96840 2012-09-14 16:48:17 -0700 nrwt: --additional-platform-dir is broken on chromium ports 2012-09-14 17:42:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dpranke dpranke ojan rniwa tony webkit.review.bot oldest_to_newest 721246 0 dpranke 2012-09-14 16:48:17 -0700 nrwt: --additional-platform-dir is broken on chromium ports 721249 1 164248 dpranke 2012-09-14 16:49:17 -0700 Created attachment 164248 Patch 721274 2 164248 webkit.review.bot 2012-09-14 17:42:45 -0700 Comment on attachment 164248 Patch Clearing flags on attachment: 164248 Committed r128675: <http://trac.webkit.org/changeset/128675> 721275 3 webkit.review.bot 2012-09-14 17:42:47 -0700 All reviewed patches have been landed. Closing bug. 164248 2012-09-14 16:49:17 -0700 2012-09-14 17:42:44 -0700 Patch bug-96840-20120914164849.patch text/plain 6096 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NTI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTVmMDc1NTE5MGQ2YjYwYjZlYTNjODlhYmEzY2QyYWNm ODk4ZDg2ZS4uMDcwNzFmOTZhMzQ2NmE5NzcwYTU0NzhkY2RhNTViNzFhOWE1MDQ4MCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3 IEBACisyMDEyLTA5LTE0ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIG5yd3Q6IC0tYWRkaXRpb25hbC1wbGF0Zm9ybS1kaXIgaXMgYnJva2VuIG9uIGNocm9t aXVtIHBvcnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05Njg0MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IExvb2tzIGxpa2UgSSBicm9rZSB0aGlzIHdoZW4gY2xlYW5pbmcgdGhpbmdzIHVwIGFzIHBhcnQg b2YKKyAgICAgICAgYWRkaW5nIE1MIHN1cHBvcnQuIEZpeGluZyBhbmQgYWRkaW5nIGEgdGVzdC4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0u cHk6CisgICAgICAgIChDaHJvbWl1bVBvcnQuZGVmYXVsdF9iYXNlbGluZV9zZWFyY2hfcGF0aCk6 CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9h bmRyb2lkLnB5OgorICAgICAgICAoQ2hyb21pdW1BbmRyb2lkUG9ydC5kZWZhdWx0X2Jhc2VsaW5l X3NlYXJjaF9wYXRoKToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9w b3J0L2Nocm9taXVtX2xpbnV4LnB5OgorICAgICAgICAoQ2hyb21pdW1MaW51eFBvcnQuZGVmYXVs dF9iYXNlbGluZV9zZWFyY2hfcGF0aCk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHk6CisgICAgICAgIChDaHJvbWl1bU1hY1BvcnQu X19pbml0X18pOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQv Y2hyb21pdW1fd2luLnB5OgorICAgICAgICAoQ2hyb21pdW1XaW5Qb3J0LnNldHVwX2Vudmlyb25f Zm9yX3NlcnZlcik6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9y dC9wb3J0X3Rlc3RjYXNlLnB5OgorICAgICAgICAodGVzdF9jaGVja19idWlsZCk6CisgICAgICAg ICh0ZXN0X2FkZGl0aW9uYWxfcGxhdGZvcm1fZGlyZWN0b3J5KToKKwogMjAxMi0wOS0xMyAgTWFy ayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gQWRkaW5n IG15c2VsZiB0byB0aGUgY29tbWl0dGVycyBsaXN0LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bS5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW0ucHkKaW5kZXggZmVlY2ZiZGZmNmNi NTBlMDVmMzc5ZmEyNzA3ZDA0MjE5ZDI4MDg0Zi4uMDA5MWJlNTY5MTgwOGY3OTkwY2U1MTY5MTRi NjA5NzdjOWEyNTExZiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtLnB5CkBAIC0xMTQsNiArMTE0LDkgQEAgY2xhc3MgQ2hyb21p dW1Qb3J0KFBvcnQpOgogICAgIGRlZiBkZWZhdWx0X3BpeGVsX3Rlc3RzKHNlbGYpOgogICAgICAg ICByZXR1cm4gVHJ1ZQogCisgICAgZGVmIGRlZmF1bHRfYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2Vs Zik6CisgICAgICAgIHJldHVybiBtYXAoc2VsZi5fd2Via2l0X2Jhc2VsaW5lX3BhdGgsIHNlbGYu RkFMTEJBQ0tfUEFUSFNbc2VsZi52ZXJzaW9uKCldKQorCiAgICAgZGVmIGRlZmF1bHRfdGltZW91 dF9tcyhzZWxmKToKICAgICAgICAgaWYgc2VsZi5nZXRfb3B0aW9uKCdjb25maWd1cmF0aW9uJykg PT0gJ0RlYnVnJzoKICAgICAgICAgICAgIHJldHVybiAxMiAqIDEwMDAKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5kcm9pZC5w eSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fYW5k cm9pZC5weQppbmRleCA0Y2UxOGVmZGRjYjE4NDgyYWI2MmZmOWJkZTg2ZDY5MTdjOGM2Yjg2Li5m Y2NjZWMxNWExMzU4OTJiMTE0ZmUzN2VlNzU0YWViYWRhYzVlMDlhIDEwMDY0NAotLS0gYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVtX2FuZHJvaWQucHkK KysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9h bmRyb2lkLnB5CkBAIC0xODcsNyArMTg3LDcgQEAgY2xhc3MgQ2hyb21pdW1BbmRyb2lkUG9ydChj aHJvbWl1bS5DaHJvbWl1bVBvcnQpOgogICAgIGRlZiBkZWZhdWx0X2NoaWxkX3Byb2Nlc3Nlcyhz ZWxmKToKICAgICAgICAgcmV0dXJuIGxlbihzZWxmLl9nZXRfZGV2aWNlcygpKQogCi0gICAgZGVm IGJhc2VsaW5lX3NlYXJjaF9wYXRoKHNlbGYpOgorICAgIGRlZiBkZWZhdWx0X2Jhc2VsaW5lX3Nl YXJjaF9wYXRoKHNlbGYpOgogICAgICAgICByZXR1cm4gbWFwKHNlbGYuX3dlYmtpdF9iYXNlbGlu ZV9wYXRoLCBzZWxmLkZBTExCQUNLX1BBVEhTKQogCiAgICAgZGVmIGNoZWNrX3dkaWZmKHNlbGYs IGxvZ2dpbmc9VHJ1ZSk6CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtX2xpbnV4LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcG9ydC9jaHJvbWl1bV9saW51eC5weQppbmRleCBkNWMyMjM1YmYzMjhjYjcy ODg0ZWZjNDc4YjFiN2VkODgyZDM3MDBhLi5mYThjMjc0ZWE0MzU4NTEwMDIxYzllODkyYTU5NTcw ZGQyNzA3ZmYxIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtX2xpbnV4LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5 b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fbGludXgucHkKQEAgLTEwNiw3ICsxMDYsNyBAQCBjbGFz cyBDaHJvbWl1bUxpbnV4UG9ydChjaHJvbWl1bS5DaHJvbWl1bVBvcnQpOgogICAgICAgICBzZWxm Ll92ZXJzaW9uID0gJ2x1Y2lkJyAgIyBXZSBvbmx5IHN1cHBvcnQgbHVjaWQgcmlnaHQgbm93Lgog ICAgICAgICBzZWxmLl9hcmNoaXRlY3R1cmUgPSBhcmNoCiAKLSAgICBkZWYgYmFzZWxpbmVfc2Vh cmNoX3BhdGgoc2VsZik6CisgICAgZGVmIGRlZmF1bHRfYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2Vs Zik6CiAgICAgICAgIHBvcnRfbmFtZXMgPSBzZWxmLkZBTExCQUNLX1BBVEhTW3NlbGYuX2FyY2hp dGVjdHVyZV0KICAgICAgICAgcmV0dXJuIG1hcChzZWxmLl93ZWJraXRfYmFzZWxpbmVfcGF0aCwg cG9ydF9uYW1lcykKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvcG9ydC9jaHJvbWl1bV9tYWMucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9wb3J0L2Nocm9taXVtX21hYy5weQppbmRleCA1NTRmZWNhMjMwNmYxMTU2ODBiMDg2 MTljNmE3OWNkZjNhMDk4MTFlLi5kYjgyZDVjNzkzNDYxNDZiZTgwZTg0YTM3ZDFkNDA0ZThiODAy YzYzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0 L2Nocm9taXVtX21hYy5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9wb3J0L2Nocm9taXVtX21hYy5weQpAQCAtNzksMTAgKzc5LDYgQEAgY2xhc3MgQ2hyb21pdW1N YWNQb3J0KGNocm9taXVtLkNocm9taXVtUG9ydCk6CiAgICAgICAgIHNlbGYuX3ZlcnNpb24gPSBw b3J0X25hbWVbcG9ydF9uYW1lLmluZGV4KCdjaHJvbWl1bS1tYWMtJykgKyBsZW4oJ2Nocm9taXVt LW1hYy0nKTpdCiAgICAgICAgIGFzc2VydCBzZWxmLl92ZXJzaW9uIGluIHNlbGYuU1VQUE9SVEVE X09TX1ZFUlNJT05TCiAKLSAgICBkZWYgYmFzZWxpbmVfc2VhcmNoX3BhdGgoc2VsZik6Ci0gICAg ICAgIGZhbGxiYWNrX3BhdGhzID0gc2VsZi5GQUxMQkFDS19QQVRIUwotICAgICAgICByZXR1cm4g bWFwKHNlbGYuX3dlYmtpdF9iYXNlbGluZV9wYXRoLCBmYWxsYmFja19wYXRoc1tzZWxmLl92ZXJz aW9uXSkKLQogICAgIGRlZiBfbW9kdWxlc190b19zZWFyY2hfZm9yX3N5bWJvbHMoc2VsZik6CiAg ICAgICAgIHJldHVybiBbc2VsZi5fYnVpbGRfcGF0aCgnZmZtcGVnc3Vtby5zbycpXQogCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2Nocm9taXVt X3dpbi5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21p dW1fd2luLnB5CmluZGV4IDdkMDMzN2FjYzRmOTRhMGVhMTA1MGM2ZjZiZjZhMDkxZGZlNThkZjIu LjExNjhlNDA3Yzc0OTA3NThjODZmZDI3MjdjMDhmNWI1NDU4MjM4M2IgMTAwNzU1Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2luLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvY2hyb21pdW1fd2lu LnB5CkBAIC05OSwxMCArOTksNiBAQCBjbGFzcyBDaHJvbWl1bVdpblBvcnQoY2hyb21pdW0uQ2hy b21pdW1Qb3J0KToKICAgICAgICAgICAgIHNlbGYuX2V4ZWN1dGl2ZS5ydW5fY29tbWFuZChbc2V0 dXBfbW91bnRdKSAgIyBQYXRocyBhcmUgYWxsIGFic29sdXRlLCBzbyB0aGlzIGRvZXMgbm90IHJl cXVpcmUgYSBjd2QuCiAgICAgICAgIHJldHVybiBlbnYKIAotICAgIGRlZiBiYXNlbGluZV9zZWFy Y2hfcGF0aChzZWxmKToKLSAgICAgICAgcG9ydF9uYW1lcyA9IHNlbGYuRkFMTEJBQ0tfUEFUSFNb c2VsZi52ZXJzaW9uKCldCi0gICAgICAgIHJldHVybiBtYXAoc2VsZi5fd2Via2l0X2Jhc2VsaW5l X3BhdGgsIHBvcnRfbmFtZXMpCi0KICAgICBkZWYgX21vZHVsZXNfdG9fc2VhcmNoX2Zvcl9zeW1i b2xzKHNlbGYpOgogICAgICAgICAjIEZJWE1FOiB3ZSBzaG91bGQgcmV0dXJuIHRoZSBwYXRoIHRv IHRoZSBmZm1wZWcgZXF1aXZhbGVudHMgdG8gZGV0ZWN0IGlmIHdlIGhhdmUgdGhlIG1wMyBhbmQg YWFjIGNvZGVjcyBpbnN0YWxsZWQuCiAgICAgICAgICMgU2VlIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD04OTcwNi4KZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weSBiL1Rvb2xzL1NjcmlwdHMv d2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvcG9ydF90ZXN0Y2FzZS5weQppbmRleCBlMTJiNjg3 NzNjMmEwZWM0NGMxMDY4YjY0NWNhYTMzMWI0YWY3MGQ0Li4xZjc1Yzc5OWFkNWMwMTJiYTcxZDM0 Y2E5M2EwZDEyOGZlZmEzNWRiIDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy9wb3J0L3BvcnRfdGVzdGNhc2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvcG9ydC9wb3J0X3Rlc3RjYXNlLnB5CkBAIC02MDksMyArNjA5LDcg QEAgY2xhc3MgUG9ydFRlc3RDYXNlKHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAgcG9ydC5f YnVpbGRfZHJpdmVyID0gYnVpbGRfZHJpdmVyX2NhbGxlZAogICAgICAgICBwb3J0LmNoZWNrX2J1 aWxkKEZhbHNlKQogICAgICAgICBzZWxmLmFzc2VydEZhbHNlKHNlbGYuYnVpbGRfY2FsbGVkLCBO b25lKQorCisgICAgZGVmIHRlc3RfYWRkaXRpb25hbF9wbGF0Zm9ybV9kaXJlY3Rvcnkoc2VsZik6 CisgICAgICAgIHBvcnQgPSBzZWxmLm1ha2VfcG9ydChvcHRpb25zPU1vY2tPcHRpb25zKGFkZGl0 aW9uYWxfcGxhdGZvcm1fZGlyZWN0b3J5PVsnL3RtcC9mb28nXSkpCisgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWxzKHBvcnQuYmFzZWxpbmVfc2VhcmNoX3BhdGgoKVswXSwgJy90bXAvZm9vJykK