9684 2006-07-01 22:21:10 -0700 [GDK] multiple little fixes and a few new things for Templinkstubs 2006-07-02 04:54:08 -0700 1 1 1 Unclassified WebKit WebCore Misc. 420+ PC Linux RESOLVED FIXED P2 Major --- 1 kb1ibt webkit-unassigned oldest_to_newest 47944 0 kb1ibt 2006-07-01 22:21:10 -0700 there multiple little spelling errors and minor glitches that were causing GDK to not build i'll attach a patch file 47945 1 9132 kb1ibt 2006-07-01 22:24:54 -0700 Created attachment 9132 basic patch 47946 2 kb1ibt 2006-07-01 22:25:57 -0700 there are still problems with the finished product of the build, however ../../WebCore/Projects/gdk/libwebcore-gdk.so: undefined reference to `WebCore::SiteIcon::getImage(WebCore::IntSize const&)' ../../WebCore/Projects/gdk/libwebcore-gdk.so: undefined reference to `WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument(WebCore::DOMImplementation*, WebCore::FrameView*)' ../../WebCore/Projects/gdk/libwebcore-gdk.so: undefined reference to `WebCore::HTMLViewSourceDocument::addViewSourceToken(WebCore::Token*)' ../../WebCore/Projects/gdk/libwebcore-gdk.so: undefined reference to `WebCore::SiteIcon::SiteIcon(WebCore::String const&)' ../../WebCore/Projects/gdk/libwebcore-gdk.so: undefined reference to `WebCore::IndentOutdentCommand::IndentOutdentCommand(WebCore::Document*, WebCore::IndentOutdentCommand::EIndentType, int)' 47947 3 9132 timothy 2006-07-01 22:35:28 -0700 Comment on attachment 9132 basic patch r=me 47951 4 timothy 2006-07-01 22:38:38 -0700 You might need to make those symbols in the TemporaryLinkStubs.cpp file. 47968 5 mrowe 2006-07-02 01:41:22 -0700 It seems to me that new files added to SVN are responsible for the undefined symbol errors. In particular, WebCore/icon/SiteIcon.cpp, WebCore/editing/IndentOutdentCommand.cpp and WebCore/html/HTMLViewSourceDocument.cpp account for the undefined symbols mentioned. Adding these files to the relevant places in the Bakefile should resolve the link errors. 47985 6 9132 ddkilzer 2006-07-02 04:51:26 -0700 Comment on attachment 9132 basic patch Shawn, if you're going to hand-edit patches, please make sure they apply when you're done.  :)  The first two patches had extra whitespace at the end of the changed lines, the second patch had an invalid segment (@@) with no changes, and the third patch had a line-count off by one (7 instead of 6 for both - and +). Also, please use WebKitTools/Scripts/prepare-ChangeLog to create a ChangeLog entry for your patch in the future.  Thanks! 47986 7 ddkilzer 2006-07-02 04:54:08 -0700 Committed revision 15135. Please file a new bug for the bakefile changes per Comment #5. 9132 2006-07-01 22:24:54 -0700 2006-07-01 22:36:03 -0700 basic patch patch text/plain 2181 kb1ibt SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ2RrL1Njcm9sbFZpZXdHZGsuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNjcm9sbFZpZXdHZGsuY3BwICAgIChyZXZpc2lvbiAxNTEzMykgCisrKyBTY3JvbGxWaWV3 R2RrLmNwcCAgICAod29ya2luZyBjb3B5KSAKQEAgLTI1Niw3ICsyNTYsNyBAQAogICAgIGdpbnQg eCwgeSwgd2lkdGgsIGhlaWdodCwgZGVwdGg7CiAgICAgZ2RrX3dpbmRvd19nZXRfZ2VvbWV0cnko ZnJhbWUsICZ4LCAmeSwgJndpZHRoLCAmaGVpZ2h0LCAmZGVwdGgpOwogICAgIG1fZGF0YS0+c2Ny b2xsVmlld0FyZWEgPSBJbnRSZWN0KDAsIDAsIHdpZHRoLCBoZWlnaHQpOwotICAgIG1fZGF0YS0+ dmlld3BvcnRBcmVhID0gSW50UmVjdCgwLCAwLCB3aWR0aCAtIFNDUk9MTEJBUl9TSVpFLCBoZWln aHQgLSBTQ1JPTExCQVJfU0laRSk7IAorICAgIG1fZGF0YS0+dmlld3BvcnRBcmVhID0gSW50UmVj dCgwLCAwLCB3aWR0aCAtIHNjcm9sbGJhclNpemUsIGhlaWdodCAtIHNjcm9sbGJhclNpemUpOyAK IH0KIAogfQpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9nZGsvVGVtcG9yYXJ5TGlua1N0dWJzLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUZW1wb3JhcnlMaW5rU3R1YnMuY3BwICAgIChyZXZpc2lvbiAxNTEz MykgCisrKyBUZW1wb3JhcnlMaW5rU3R1YnMuY3BwICAgICh3b3JraW5nIGNvcHkpIApAQCAtMzYw LDcgKzM2MCw3IEBACiAKIHZvaWQgRnJhbWU6OnNldE5lZWRzUmVhcHBseVN0eWxlcygpIHsgfQog Ci12b2lkIEltYWdlOjpkcmF3VGlsZWQoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgRmxvYXRSZWN0 JiwgY29uc3QgRmxvYXRSZWN0JiwgVGlsZVJ1bGUsIFRpbGVSdWxlKSB7IH0gCit2b2lkIEltYWdl OjpkcmF3VGlsZWQoR3JhcGhpY3NDb250ZXh0KiwgY29uc3QgRmxvYXRSZWN0JiwgY29uc3QgRmxv YXRSZWN0JiwgVGlsZVJ1bGUsIFRpbGVSdWxlLCBDb21wb3NpdGVPcGVyYXRvcikgeyB9IAogCiB2 b2lkIFJlbmRlclRoZW1lR2RrOjpzZXRDaGVja2JveFNpemUoUmVuZGVyU3R5bGUqKSBjb25zdCB7 IH0KIGJvb2wgUmVuZGVyVGhlbWVHZGs6OnBhaW50QnV0dG9uKFJlbmRlck9iamVjdCosIGNvbnN0 IFJlbmRlck9iamVjdDo6UGFpbnRJbmZvJiwgY29uc3QgSW50UmVjdCYpIHsgcmV0dXJuIGZhbHNl OyB9CkBAIC0zNzIsMyArMzcyLDQgQEAKIHZvaWQgRm9udDo6ZHJhd0NvbXBsZXhUZXh0KEdyYXBo aWNzQ29udGV4dCosIGNvbnN0IFRleHRSdW4mLCBjb25zdCBUZXh0U3R5bGUmLCBjb25zdCBGbG9h dFBvaW50JikgY29uc3QgeyBub3RJbXBsZW1lbnRlZCgpOyB9CiBmbG9hdCBGb250OjpmbG9hdFdp ZHRoRm9yQ29tcGxleFRleHQoY29uc3QgVGV4dFJ1biYsIGNvbnN0IFRleHRTdHlsZSYpIGNvbnN0 IHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIDA7IH0KIGludCBGb250OjpvZmZzZXRGb3JQb3Np dGlvbkZvckNvbXBsZXhUZXh0KGNvbnN0IFRleHRSdW4mLCBjb25zdCBUZXh0U3R5bGUmLCBpbnQs IGJvb2wpIGNvbnN0IHsgbm90SW1wbGVtZW50ZWQoKTsgcmV0dXJuIDA7IH0KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vZ2RrL1RyYW5zZmVySm9iTWFuYWdlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVHJh bnNmZXJKb2JNYW5hZ2VyLmNwcCAgICAocmV2aXNpb24gMTUxMzMpIAorKysgVHJhbnNmZXJKb2JN YW5hZ2VyLmNwcCAgICAod29ya2luZyBjb3B5KSAKQEAgLTYzLDcgKzYzLDcgQEAKICAgICBUcmFu c2ZlckpvYiogam9iID0gc3RhdGljX2Nhc3Q8VHJhbnNmZXJKb2IqPihvYmopOwogICAgIFRyYW5z ZmVySm9iSW50ZXJuYWwqIGQgPSBqb2ItPmdldEludGVybmFsKCk7CiAgICAgaW50IHRvdGFsU2l6 ZSA9IHNpemUgKiBubWVtYjsKLSAgICBkLT5jbGllbnQtPnJlY2VpdmVkRGF0YShqb2IsIHN0YXRp Y19jYXN0PGNoYXIqPnB0ciwgdG90YWxTaXplKTsgCisgICAgZC0+Y2xpZW50LT5yZWNlaXZlZERh dGEoam9iLCBzdGF0aWNfY2FzdDxjaGFyKj4ocHRyKSwgdG90YWxTaXplKTsgCiAgICAgcmV0dXJu IHRvdGFsU2l6ZTsKIH0K