96832 2012-09-14 15:27:08 -0700 new fast/loader tests from r128645 fail on Mac-wk2 2012-09-14 18:21:46 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, MakingBotsRed P2 Normal --- 1 slewis boliu abarth boliu slewis webkit-bug-importer webkit.review.bot oldest_to_newest 721188 0 slewis 2012-09-14 15:27:08 -0700 * fast/loader/display-image-unset-can-block-image-and-can-reload-in-place,html * fast/loader/images-enabled-unset-can-block-image-and-can-reload-in-place.html Introduce in changeset http://trac.webkit.org/changeset/128645. http://build.webkit.org/results/Apple%20Lion%20Release%20WK2%20(Tests)/r128650%20(3293)/results.html I don't believe WKTR has queueReload. --- /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-expected.txt +++ /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/fast/loader/display-image-unset-can-block-image-and-can-reload-in-place-actual.txt @@ -1,3 +1,4 @@ +CONSOLE MESSAGE: line 13: TypeError: 'undefined' is not a function (evaluating 'testRunner.queueReload()') Test that DisplayImages disabled can block http image and can be reloaded in-place when toggled. -SUCCESS +FAILURE: Image should not be loaded when DisplayImage is unset 721189 1 webkit-bug-importer 2012-09-14 15:27:17 -0700 <rdar://problem/12304462> 721198 2 boliu 2012-09-14 15:35:04 -0700 Is the correct fix to implement queueReload since it is used in other tests as well? eg: LayoutTests/fast/loader/reload-policy-delegate.html 721203 3 slewis 2012-09-14 15:42:11 -0700 most likely 721208 4 boliu 2012-09-14 15:48:44 -0700 Sorry, 128645 was my first webkit patch, so I'm still getting familiar with things and will probably take awhile to implement queueReload correctly. Can I get a sense of how urgent this is? Is there a way to temporarily mark these tests as expect crash just for mac webkit2? How are the other tests relying on queueReload handled in mac webkit2? 721211 5 abarth 2012-09-14 15:50:25 -0700 Typically we just skip tests for a given port if they haven't implemented all the necessary TestRuner features. 721213 6 slewis 2012-09-14 15:51:46 -0700 Updated TestExpectations in http://trac.webkit.org/projects/webkit/changeset/128664. Not incredibly urgent :). I believe the other tests are skipped. 721221 7 164245 boliu 2012-09-14 16:01:17 -0700 Created attachment 164245 Patch 721286 8 boliu 2012-09-14 17:59:12 -0700 (In reply to comment #7) > Created an attachment (id=164245) [details] > Patch Ping! (Not sure if webkit-patch upload sends out email to reviewers) 721287 9 abarth 2012-09-14 18:01:37 -0700 > Ping! (Not sure if webkit-patch upload sends out email to reviewers) It does (or rather bugzilla does). 721295 10 164245 webkit.review.bot 2012-09-14 18:21:43 -0700 Comment on attachment 164245 Patch Clearing flags on attachment: 164245 Committed r128676: <http://trac.webkit.org/changeset/128676> 721296 11 webkit.review.bot 2012-09-14 18:21:46 -0700 All reviewed patches have been landed. Closing bug. 164245 2012-09-14 16:01:17 -0700 2012-09-14 18:21:43 -0700 Patch bug-96832-20120914160048.patch text/plain 1334 boliu U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NjU4CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMmEyZjQ5Nzg1NTJmYjFlMjExZTY1 ZmMyOWJjMzlhZTYzZWUwOWQ4YS4uYTlhNWY2MmZiMDg2ZTM0Mzg2NGQwZDI1ZmQyZWM1ODZhMDNl YTAyZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA5LTE0ICBCbyBMaXUgIDxib2xpdUBj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgU2tpcCBpbWFnZSBsb2FkIHRlc3RzIHRoYXQgcmVxdWly ZXMgcXVldWVSZWxvYWQgaW4gV2ViS2l0MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTY4MzIKKworICAgICAgICBUZXN0cyBhZGRlZCBpbiByZWl2aXNv biAxMjg2NDUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS93azIvU2tpcHBlZDoKKwogMjAxMi0wOS0xNCAgQWRhbSBCYXJ0aCAgPGFi YXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJlbW92ZSB3ZWJraXRQb3N0TWVzc2FnZQpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS93azIvU2tpcHBlZAppbmRleCAxOTE3YjZjZWZiMzc5OWViZGFkM2U5ODBmMzU3Njgx NmQ4NGQwMzExLi43YzFkZTIwMWU4ZTVjMDhjMjNiY2Q3ODY3NGRlOTNmMmMwNzUzNGNiIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93azIvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS93azIvU2tpcHBlZApAQCAtMzM5LDYgKzMzOSw4IEBAIHN2Zy9jdXN0b20vc3Zn LWFsbG93ZWQtaW4tZGFzaGJvYXJkLW9iamVjdC5odG1sCiAjIDxodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDI2NzI+CiBmYXN0L2Nzcy9jb21wYXJlLWNvbnRlbnQtc3R5 bGUuaHRtbAogZmFzdC9mcmFtZXMvZnJhbWUtZGlzcGxheS1ub25lLWZvY3VzLmh0bWwKK2Zhc3Qv bG9hZGVyL2Rpc3BsYXktaW1hZ2UtdW5zZXQtY2FuLWJsb2NrLWltYWdlLWFuZC1jYW4tcmVsb2Fk LWluLXBsYWNlLmh0bWwKK2Zhc3QvbG9hZGVyL2ltYWdlcy1lbmFibGVkLXVuc2V0LWNhbi1ibG9j ay1pbWFnZS1hbmQtY2FuLXJlbG9hZC1pbi1wbGFjZS5odG1sCiBmYXN0L2xvYWRlci9yZWxvYWQt cG9saWN5LWRlbGVnYXRlLmh0bWwKIAogIyBXZWJLaXRUZXN0UnVubmVyIG5lZWRzIGxheW91dFRl c3RDb250cm9sbGVyLnF1ZXVlTG9hZAo=