96823 2012-09-14 13:27:02 -0700 Add 8 bit handling to SpaceSplitString 2022-02-27 23:19:19 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff oldest_to_newest 721083 0 msaboff 2012-09-14 13:27:02 -0700 SpaceSplitStringData needs to updated to handle 8 bit strings. 721089 1 164217 msaboff 2012-09-14 13:34:55 -0700 Created attachment 164217 Patch 721451 2 164217 sam 2012-09-15 09:35:35 -0700 Comment on attachment 164217 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164217&action=review > Source/WebCore/dom/SpaceSplitString.cpp:44 > + return hasUpper || (ored & ~0x7F); Trailing whitespace. 721500 3 msaboff 2012-09-15 15:48:09 -0700 Committed r128694: <http://trac.webkit.org/changeset/128694> 164217 2012-09-14 13:34:55 -0700 2022-02-27 23:19:19 -0800 Patch 96823.patch text/plain 3390 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODYyMCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTEzICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCA4IGJpdCBoYW5kbGlu ZyB0byBTcGFjZVNwbGl0U3RyaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05NjgyMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZGVkIHRlbXBsYXRlZCBmdW5jdGlvbnMgYmFzZWQgb24gY2hhcmFjdGVy IHR5cGUgdG8gaGFuZGxlIDggYW5kIDE2IGJpdCBzdHJpbmcgZGF0YS4KKworICAgICAgICAqIGRv bS9TcGFjZVNwbGl0U3RyaW5nLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Omhhc05vbkFTQ0lJT3JV cHBlcik6CisgICAgICAgIChXZWJDb3JlOjpTcGFjZVNwbGl0U3RyaW5nRGF0YTo6Y3JlYXRlVmVj dG9yKToKKyAgICAgICAgKiBkb20vU3BhY2VTcGxpdFN0cmluZy5oOgorICAgICAgICAoU3BhY2VT cGxpdFN0cmluZ0RhdGEpOgorCiAyMDEyLTA5LTE0ICBUb3IgQXJuZSBWZXN0YsO4ICA8dG9yLmFy bmUudmVzdGJvQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIFJlbW92ZSBvbGQgY3J1ZnQgZnJv bSB0aGUgcW1ha2UgYnVpbGQgc3lzdGVtCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vU3BhY2VT cGxpdFN0cmluZy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvZG9tL1NwYWNlU3Bs aXRTdHJpbmcuY3BwCShyZXZpc2lvbiAxMjg2MjApCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vU3Bh Y2VTcGxpdFN0cmluZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMxLDI0ICszMSwzMSBAQCB1c2lu ZyBuYW1lc3BhY2UgV1RGOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXN0YXRpYyBib29sIGhh c05vbkFTQ0lJT3JVcHBlcihjb25zdCBTdHJpbmcmIHN0cmluZykKK3RlbXBsYXRlIDx0eXBlbmFt ZSBDaGFyYWN0ZXJUeXBlPgorc3RhdGljIGlubGluZSBib29sIGhhc05vbkFTQ0lJT3JVcHBlcihj b25zdCBDaGFyYWN0ZXJUeXBlKiBjaGFyYWN0ZXJzLCB1bnNpZ25lZCBsZW5ndGgpCiB7Ci0gICAg Y29uc3QgVUNoYXIqIGNoYXJhY3RlcnMgPSBzdHJpbmcuY2hhcmFjdGVycygpOwotICAgIHVuc2ln bmVkIGxlbmd0aCA9IHN0cmluZy5sZW5ndGgoKTsKICAgICBib29sIGhhc1VwcGVyID0gZmFsc2U7 Ci0gICAgVUNoYXIgb3JlZCA9IDA7CisgICAgQ2hhcmFjdGVyVHlwZSBvcmVkID0gMDsKICAgICBm b3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbGVuZ3RoOyBpKyspIHsKLSAgICAgICAgVUNoYXIgYyA9 IGNoYXJhY3RlcnNbaV07CisgICAgICAgIENoYXJhY3RlclR5cGUgYyA9IGNoYXJhY3RlcnNbaV07 CiAgICAgICAgIGhhc1VwcGVyIHw9IGlzQVNDSUlVcHBlcihjKTsKICAgICAgICAgb3JlZCB8PSBj OwogICAgIH0KLSAgICByZXR1cm4gaGFzVXBwZXIgfHwgKG9yZWQgJiB+MHg3Rik7CisgICAgcmV0 dXJuIGhhc1VwcGVyIHx8IChvcmVkICYgfjB4N0YpOyAgICAKIH0KIAotdm9pZCBTcGFjZVNwbGl0 U3RyaW5nRGF0YTo6Y3JlYXRlVmVjdG9yKGNvbnN0IFN0cmluZyYgc3RyaW5nKQorc3RhdGljIGlu bGluZSBib29sIGhhc05vbkFTQ0lJT3JVcHBlcihjb25zdCBTdHJpbmcmIHN0cmluZykKIHsKLSAg ICBjb25zdCBVQ2hhciogY2hhcmFjdGVycyA9IHN0cmluZy5jaGFyYWN0ZXJzKCk7CiAgICAgdW5z aWduZWQgbGVuZ3RoID0gc3RyaW5nLmxlbmd0aCgpOworCisgICAgaWYgKHN0cmluZy5pczhCaXQo KSkKKyAgICAgICAgcmV0dXJuIGhhc05vbkFTQ0lJT3JVcHBlcihzdHJpbmcuY2hhcmFjdGVyczgo KSwgbGVuZ3RoKTsKKyAgICByZXR1cm4gaGFzTm9uQVNDSUlPclVwcGVyKHN0cmluZy5jaGFyYWN0 ZXJzMTYoKSwgbGVuZ3RoKTsKK30KKwordGVtcGxhdGUgPHR5cGVuYW1lIENoYXJhY3RlclR5cGU+ CitpbmxpbmUgdm9pZCBTcGFjZVNwbGl0U3RyaW5nRGF0YTo6Y3JlYXRlVmVjdG9yKGNvbnN0IENo YXJhY3RlclR5cGUqIGNoYXJhY3RlcnMsIHVuc2lnbmVkIGxlbmd0aCkKK3sKICAgICB1bnNpZ25l ZCBzdGFydCA9IDA7CiAgICAgd2hpbGUgKHRydWUpIHsKICAgICAgICAgd2hpbGUgKHN0YXJ0IDwg bGVuZ3RoICYmIGlzSFRNTFNwYWNlKGNoYXJhY3RlcnNbc3RhcnRdKSkKQEAgLTY1LDYgKzcyLDE4 IEBAIHZvaWQgU3BhY2VTcGxpdFN0cmluZ0RhdGE6OmNyZWF0ZVZlY3RvcigKICAgICB9CiB9CiAK K3ZvaWQgU3BhY2VTcGxpdFN0cmluZ0RhdGE6OmNyZWF0ZVZlY3Rvcihjb25zdCBTdHJpbmcmIHN0 cmluZykKK3sKKyAgICB1bnNpZ25lZCBsZW5ndGggPSBzdHJpbmcubGVuZ3RoKCk7CisKKyAgICBp ZiAoc3RyaW5nLmlzOEJpdCgpKSB7CisgICAgICAgIGNyZWF0ZVZlY3RvcihzdHJpbmcuY2hhcmFj dGVyczgoKSwgbGVuZ3RoKTsKKyAgICAgICAgcmV0dXJuOworICAgIH0KKworICAgIGNyZWF0ZVZl Y3RvcihzdHJpbmcuY2hhcmFjdGVyczE2KCksIGxlbmd0aCk7Cit9CisKIGJvb2wgU3BhY2VTcGxp dFN0cmluZ0RhdGE6OmNvbnRhaW5zQWxsKFNwYWNlU3BsaXRTdHJpbmdEYXRhJiBvdGhlcikKIHsK ICAgICBpZiAodGhpcyA9PSAmb3RoZXIpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9kb20vU3BhY2VT cGxpdFN0cmluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2RvbS9TcGFjZVNwbGl0 U3RyaW5nLmgJKHJldmlzaW9uIDEyODYyMCkKKysrIFNvdXJjZS9XZWJDb3JlL2RvbS9TcGFjZVNw bGl0U3RyaW5nLmgJKHdvcmtpbmcgY29weSkKQEAgLTU4LDYgKzU4LDggQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogICAgICAgICBleHBsaWNpdCBTcGFjZVNwbGl0U3RyaW5nRGF0YShjb25zdCBTcGFj ZVNwbGl0U3RyaW5nRGF0YSYpOwogCiAgICAgICAgIHZvaWQgY3JlYXRlVmVjdG9yKGNvbnN0IFN0 cmluZyYpOworICAgICAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4KKyAgICAg ICAgaW5saW5lIHZvaWQgY3JlYXRlVmVjdG9yKGNvbnN0IENoYXJhY3RlclR5cGUqLCB1bnNpZ25l ZCk7CiAKICAgICAgICAgQXRvbWljU3RyaW5nIG1fa2V5U3RyaW5nOwogICAgICAgICBWZWN0b3I8 QXRvbWljU3RyaW5nLCA0PiBtX3ZlY3RvcjsK