96822 2012-09-14 13:14:12 -0700 [Qt] Cleanup/refactor the user agent detection code 2012-09-17 10:54:36 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 lauro.neto lauro.neto hausmann webkit.review.bot oldest_to_newest 721075 0 lauro.neto 2012-09-14 13:14:12 -0700 Followup bug after suggestions made to the original useragent patch in https://bugs.webkit.org/show_bug.cgi?id=73917 721162 1 164231 lauro.neto 2012-09-14 14:56:11 -0700 Created attachment 164231 Patch Replaced Q_WS/Q_OS checks with WTF OS()/CPU(). Instead of Q_WS_X11, now checking QGuiApplication::platformName(). 721176 2 164231 hausmann 2012-09-14 15:17:03 -0700 Comment on attachment 164231 Patch r=me. Might want to double check with the EWS before landing. 722002 3 164231 webkit.review.bot 2012-09-17 09:35:27 -0700 Comment on attachment 164231 Patch Clearing flags on attachment: 164231 Committed r128770: <http://trac.webkit.org/changeset/128770> 722003 4 webkit.review.bot 2012-09-17 09:35:29 -0700 All reviewed patches have been landed. Closing bug. 722025 5 lauro.neto 2012-09-17 10:19:46 -0700 Reopen as it broke the windows bot. 722028 6 164413 lauro.neto 2012-09-17 10:31:17 -0700 Created attachment 164413 Patch 722054 7 164413 webkit.review.bot 2012-09-17 10:54:33 -0700 Comment on attachment 164413 Patch Clearing flags on attachment: 164413 Committed r128775: <http://trac.webkit.org/changeset/128775> 722055 8 webkit.review.bot 2012-09-17 10:54:36 -0700 All reviewed patches have been landed. Closing bug. 164231 2012-09-14 14:56:11 -0700 2012-09-17 09:35:26 -0700 Patch bug-96822-20120914185548.patch text/plain 4743 lauro.neto U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ3NDAyNmQyODgwZDFm MjRlMGVkOTM2ZDIzMWY0NjJjYjk3ZmFjNy4uMWJiZGQ1N2I4OWM1NWMyMDM3ZDYxMWM3NzhmMWEw NmI0YjhmOGFiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTE0ICBMYXVy byBOZXRvICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFVwZGF0ZXMgdG8g dGhlIHVzZXJhZ2VudCBwYXRjaAorCisgICAgICAgIFtRdF0gQ2xlYW51cC9yZWZhY3RvciB0aGUg dXNlciBhZ2VudCBkZXRlY3Rpb24gY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9OTY4MjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZXBsYWNlZCBRX1dTXyovUV9PU18qIHdpdGggV1RGIE9TL0NQVSBk ZXRlY3Rpb24gbWFjcm9zLgorICAgICAgICBDbGVhbnVwIHRoZSBjaGVjayBmb3IgdW5zdXBwb3J0 ZWQgT1MuCisgICAgICAgIFJlcGxhY2VkIFFTdHJpbmcuYXJnKCkgdXNhZ2Ugd2l0aCBzaW1wbGUg c3RyaW5nIGNvbmNhdGVuYXRpb24uCisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Vc2VyQWdlbnRR dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpVc2VyQWdlbnRRdDo6c3RhbmRhcmRVc2VyQWdlbnQp OgorCiAyMDEyLTA5LTEzICBZb25nIExpICA8eW9saUByaW0uY29tPgogCiAgICAgICAgIFtCbGFj a0JlcnJ5XSBSZXNvdXJjZVJlcXVlc3Qgc3RyaW5nIG9wdGltaXphdGlvbnMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3F0L1VzZXJBZ2VudFF0LmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL3F0L1VzZXJBZ2VudFF0LmNwcAppbmRleCA3MzI5YTgzMTQ3MmM2YjUyMDNj NWVkNTNkNjczZDg2ZjdmNTM2NzdiLi5jMTY0MGZiZTc5Yzc3MzM0MGY5N2E0MGNjNTg1ZmVkMjky NjY0MGY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Vc2VyQWdlbnRR dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vcXQvVXNlckFnZW50UXQuY3BwCkBA IC0yMiwxMyArMjIsMTMgQEAKIAogI2luY2x1ZGUgIlVzZXJBZ2VudFF0LmgiCiAKLSNpbmNsdWRl IDxRQ29yZUFwcGxpY2F0aW9uPgorI2luY2x1ZGUgPFFHdWlBcHBsaWNhdGlvbj4KIAogI2luY2x1 ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KICNpbmNsdWRlIDx3dGYvdGV4dC9XVEZTdHJpbmcuaD4K LSNpZiBkZWZpbmVkIFFfT1NfV0lOMzIKKyNpZiBPUyhXSU5ET1dTKQogI2luY2x1ZGUgPFN5c3Rl bUluZm8uaD4KLSNlbmRpZiAvLyBRX09TX1dJTjMyCisjZW5kaWYgLy8gT1MoV0lORE9XUykKIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCkBAIC02MiwxOSArNjIsMTYgQEAgU3RyaW5nIFVzZXJBZ2Vu dFF0OjpzdGFuZGFyZFVzZXJBZ2VudChjb25zdCBTdHJpbmcgJmFwcGxpY2F0aW9uTmFtZUZvclVz ZXJBZ2VudCwKIAogICAgICAgICAvLyBQbGF0Zm9ybS4KICAgICAgICAgdWEgPSB1YS5hcmcoUUxh dGluMVN0cmluZygKLSNpZmRlZiBRX1dTX01BQworI2lmIE9TKE1BQ19PU19YKQogICAgICAgICAg ICAgIk1hY2ludG9zaDsgIgotI2VsaWYgZGVmaW5lZCBRX1dTX1FXUwotICAgICAgICAgICAgIlF0 RW1iZWRkZWQ7ICIKLSNlbGlmIGRlZmluZWQgUV9XU19XSU4KKyNlbGlmIE9TKFdJTkRPV1MpCiAg ICAgICAgICAgICAvLyBOb3RoaW5nLgotI2VsaWYgZGVmaW5lZCBRX1dTX1gxMQotICAgICAgICAg ICAgIlgxMTsgIgogI2Vsc2UKLSAgICAgICAgICAgICJVbmtub3duOyAiCisgICAgICAgICAgICAo UUd1aUFwcGxpY2F0aW9uOjpwbGF0Zm9ybU5hbWUoKSA9PSBRTGF0aW4xU3RyaW5nKCJ4Y2IiKSkg PyAiWDExOyAiIDogIlVua25vd247ICIKICNlbmRpZgogICAgICAgICApKTsKIAorCiAgICAgICAg IC8vIFNlY3VyaXR5IHN0cmVuZ3RoLgogICAgICAgICBRU3RyaW5nIHNlY3VyaXR5U3RyZW5ndGg7 CiAjaWYgZGVmaW5lZChRVF9OT19PUEVOU1NMKQpAQCAtODQsODIgKzgxLDQ4IEBAIFN0cmluZyBV c2VyQWdlbnRRdDo6c3RhbmRhcmRVc2VyQWdlbnQoY29uc3QgU3RyaW5nICZhcHBsaWNhdGlvbk5h bWVGb3JVc2VyQWdlbnQsCiAKICAgICAgICAgLy8gT3BlcmF0aW5nIHN5c3RlbS4KICAgICAgICAg dWEgPSB1YS5hcmcoUUxhdGluMVN0cmluZygKLSNpZmRlZiBRX09TX0FJWAorI2lmIE9TKEFJWCkK ICAgICAgICAgICAgICJBSVgiCi0jZWxpZiBkZWZpbmVkIFFfT1NfV0lOMzIKKyNlbGlmIE9TKFdJ TkRPV1MpCiAgICAgICAgICAgICB3aW5kb3dzVmVyc2lvbkZvclVBU3RyaW5nKCkubGF0aW4xKCku ZGF0YSgpCi0jZWxpZiBkZWZpbmVkIFFfT1NfREFSV0lOCi0jaWZkZWYgX19pMzg2X18gfHwgX194 ODZfNjRfXworI2VsaWYgT1MoTUFDX09TX1gpCisjaWZkZWYgQ1BVKFg4NikgfHwgQ1BVKFg4Nl82 NCkKICAgICAgICAgICAgICJJbnRlbCBNYWMgT1MgWCIKICNlbHNlCiAgICAgICAgICAgICAiUFBD IE1hYyBPUyBYIgogI2VuZGlmCiAKLSNlbGlmIGRlZmluZWQgUV9PU19CU0RJCi0gICAgICAgICAg ICAiQlNEIgotI2VsaWYgZGVmaW5lZCBRX09TX0JTRDQKLSAgICAgICAgICAgICJCU0QgRm91ciIK LSNlbGlmIGRlZmluZWQgUV9PU19DWUdXSU4KLSAgICAgICAgICAgICJDeWd3aW4iCi0jZWxpZiBk ZWZpbmVkIFFfT1NfREdVWAotICAgICAgICAgICAgIkRHL1VYIgotI2VsaWYgZGVmaW5lZCBRX09T X0RZTklYCi0gICAgICAgICAgICAiRFlOSVgvcHR4IgotI2VsaWYgZGVmaW5lZCBRX09TX0ZSRUVC U0QKKyNlbGlmIE9TKEZSRUVCU0QpCiAgICAgICAgICAgICAiRnJlZUJTRCIKLSNlbGlmIGRlZmlu ZWQgUV9PU19IUFVYCi0gICAgICAgICAgICAiSFAtVVgiCi0jZWxpZiBkZWZpbmVkIFFfT1NfSFVS RAorI2VsaWYgT1MoSFVSRCkKICAgICAgICAgICAgICJHTlUgSHVyZCIKLSNlbGlmIGRlZmluZWQg UV9PU19JUklYCi0gICAgICAgICAgICAiU0dJIElyaXgiCi0jZWxpZiBkZWZpbmVkIFFfT1NfTElO VVgKKyNlbGlmIE9TKExJTlVYKQogCi0jaWYgZGVmaW5lZChfX3g4Nl82NF9fKQorI2lmIENQVShY ODZfNjQpCiAgICAgICAgICAgICAiTGludXggeDg2XzY0IgotI2VsaWYgZGVmaW5lZChfX2kzODZf XykKKyNlbGlmIENQVShYODYpCiAgICAgICAgICAgICAiTGludXggaTY4NiIKICNlbHNlCiAgICAg ICAgICAgICAiTGludXgiCiAjZW5kaWYKIAotI2VsaWYgZGVmaW5lZCBRX09TX0xZTlgKLSAgICAg ICAgICAgICJMeW54T1MiCi0jZWxpZiBkZWZpbmVkIFFfT1NfTkVUQlNECisjZWxpZiBPUyhORVRC U0QpCiAgICAgICAgICAgICAiTmV0QlNEIgotI2VsaWYgZGVmaW5lZCBRX09TX09TMgotICAgICAg ICAgICAgIk9TLzIiCi0jZWxpZiBkZWZpbmVkIFFfT1NfT1BFTkJTRAorI2VsaWYgT1MoT1BFTkJT RCkKICAgICAgICAgICAgICJPcGVuQlNEIgotI2VsaWYgZGVmaW5lZCBRX09TX09TMkVNWAotICAg ICAgICAgICAgIk9TLzIiCi0jZWxpZiBkZWZpbmVkIFFfT1NfT1NGCi0gICAgICAgICAgICAiSFAg VHJ1NjQgVU5JWCIKLSNlbGlmIGRlZmluZWQgUV9PU19RTlg2Ci0gICAgICAgICAgICAiUU5YIFJU UCBTaXgiCi0jZWxpZiBkZWZpbmVkIFFfT1NfUU5YCisjZWxpZiBPUyhRTlgpCiAgICAgICAgICAg ICAiUU5YIgotI2VsaWYgZGVmaW5lZCBRX09TX1JFTElBTlQKLSAgICAgICAgICAgICJSZWxpYW50 IFVOSVgiCi0jZWxpZiBkZWZpbmVkIFFfT1NfU0NPCi0gICAgICAgICAgICAiU0NPIE9wZW5TZXJ2 ZXIiCi0jZWxpZiBkZWZpbmVkIFFfT1NfU09MQVJJUworI2VsaWYgT1MoU09MQVJJUykKICAgICAg ICAgICAgICJTdW4gU29sYXJpcyIKLSNlbGlmIGRlZmluZWQgUV9PU19VTFRSSVgKLSAgICAgICAg ICAgICJERUMgVWx0cml4IgotI2VsaWYgZGVmaW5lZCBRX09TX1VOSVgKKyNlbGlmIE9TKFVOSVgp IC8vIEZJWE1FIExvb2tzIGxpa2UgYWxsIHVuaXggdmFyaWFudHMgYWJvdmUgYXJlIHRoZSBvbmx5 IGNhc2VzIHdoZXJlIE9TX1VOSVggaXMgc2V0LgogICAgICAgICAgICAgIlVOSVggQlNEL1NZU1Yg c3lzdGVtIgotI2VsaWYgZGVmaW5lZCBRX09TX1VOSVhXQVJFCi0gICAgICAgICAgICAiVW5peFdh cmUgU2V2ZW4sIE9wZW4gVU5JWCBFaWdodCIKICNlbHNlCiAgICAgICAgICAgICAiVW5rbm93biIK ICNlbmRpZgogICAgICAgICApKTsKIAogICAgICAgICAvLyBXZWJLaXQgdmVyc2lvbi4KLSAgICAg ICAgLy8gRklYTUUgIisiIGluIHRoZSB2ZXJzaW9uIHN0cmluZz8KLSAgICAgICAgUVN0cmluZyB2 ZXJzaW9uID0gUVN0cmluZyhRTGF0aW4xU3RyaW5nKCIlMS4lMiIpKS5hcmcoUVN0cmluZzo6bnVt YmVyKHdlYmtpdE1ham9yVmVyc2lvbiksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBRU3RyaW5nOjpudW1iZXIod2Via2l0TWlu b3JWZXJzaW9uKSk7CisgICAgICAgIFFTdHJpbmcgdmVyc2lvbiA9IFFTdHJpbmc6Om51bWJlcih3 ZWJraXRNYWpvclZlcnNpb24pICsgUUxhdGluMUNoYXIoJy4nKSArIFFTdHJpbmc6Om51bWJlcih3 ZWJraXRNaW5vclZlcnNpb24pOwogICAgICAgICB1YSA9IHVhLmFyZyh2ZXJzaW9uLCB2ZXJzaW9u KTsKICAgICB9CiAK 164413 2012-09-17 10:31:17 -0700 2012-09-17 10:54:33 -0700 Patch bug-96822-20120917143053.patch text/plain 1798 lauro.neto U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDY1ZTI3NDA0YWU1ODg0 ODg3ZjhhMjUzZDBlNzM5NDUxZjUzYjZiZi4uOWM0ODdkNzljMDdjN2NlN2U2NmFhZjgxZWQxMzQz ZDMzYTM4MTZkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA5LTE3ICBMYXVy byBOZXRvICA8bGF1cm8ubmV0b0BvcGVuYm9zc2Eub3JnPgogCisgICAgICAgIFtRdF0gQ2xlYW51 cC9yZWZhY3RvciB0aGUgdXNlciBhZ2VudCBkZXRlY3Rpb24gY29kZQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY4MjIKKworICAgICAgICBVbnJldmll d2VkIGJ1aWxkIGZpeC4KKworICAgICAgICBCdWlsZCBmaXhlcyBmb3IgV2luZG93cyBhbmQgTWFj IE9TIGJ1aWxkcy4KKworICAgICAgICAqIHBsYXRmb3JtL3F0L1VzZXJBZ2VudFF0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlVzZXJBZ2VudFF0OjpzdGFuZGFyZFVzZXJBZ2VudCk6CisKKyAgICAg ICAgICAgIFFMYXRpbjFTdHJpbmcgZG9lc24ndCBoYXZlIGEgZGVmYXVsdCBjb250cnVjdG9yLiBS ZXBsYWNlZCAjaWZkZWYgd2l0aCAjaWYuCisKKzIwMTItMDktMTcgIExhdXJvIE5ldG8gIDxsYXVy by5uZXRvQG9wZW5ib3NzYS5vcmc+CisKICAgICAgICAgVXBkYXRlcyB0byB0aGUgdXNlcmFnZW50 IHBhdGNoCiAKICAgICAgICAgW1F0XSBDbGVhbnVwL3JlZmFjdG9yIHRoZSB1c2VyIGFnZW50IGRl dGVjdGlvbiBjb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Vc2Vy QWdlbnRRdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9xdC9Vc2VyQWdlbnRRdC5jcHAK aW5kZXggYzE2NDBmYmU3OWM3NzMzNDBmOTdhNDBjYzU4NWZlZDI5MjY2NDBmNC4uM2RjZjg3OWIy MTE4MmU3ODQ4OTZhMWYwODlkMmFkMTRlNWVlZjAwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vcXQvVXNlckFnZW50UXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3F0L1VzZXJBZ2VudFF0LmNwcApAQCAtNjUsNyArNjUsNyBAQCBTdHJpbmcgVXNlckFnZW50 UXQ6OnN0YW5kYXJkVXNlckFnZW50KGNvbnN0IFN0cmluZyAmYXBwbGljYXRpb25OYW1lRm9yVXNl ckFnZW50LAogI2lmIE9TKE1BQ19PU19YKQogICAgICAgICAgICAgIk1hY2ludG9zaDsgIgogI2Vs aWYgT1MoV0lORE9XUykKLSAgICAgICAgICAgIC8vIE5vdGhpbmcuCisgICAgICAgICAgICAiIgog I2Vsc2UKICAgICAgICAgICAgIChRR3VpQXBwbGljYXRpb246OnBsYXRmb3JtTmFtZSgpID09IFFM YXRpbjFTdHJpbmcoInhjYiIpKSA/ICJYMTE7ICIgOiAiVW5rbm93bjsgIgogI2VuZGlmCkBAIC04 Niw3ICs4Niw3IEBAIFN0cmluZyBVc2VyQWdlbnRRdDo6c3RhbmRhcmRVc2VyQWdlbnQoY29uc3Qg U3RyaW5nICZhcHBsaWNhdGlvbk5hbWVGb3JVc2VyQWdlbnQsCiAjZWxpZiBPUyhXSU5ET1dTKQog ICAgICAgICAgICAgd2luZG93c1ZlcnNpb25Gb3JVQVN0cmluZygpLmxhdGluMSgpLmRhdGEoKQog I2VsaWYgT1MoTUFDX09TX1gpCi0jaWZkZWYgQ1BVKFg4NikgfHwgQ1BVKFg4Nl82NCkKKyNpZiBD UFUoWDg2KSB8fCBDUFUoWDg2XzY0KQogICAgICAgICAgICAgIkludGVsIE1hYyBPUyBYIgogI2Vs c2UKICAgICAgICAgICAgICJQUEMgTWFjIE9TIFgiCg==