96816 2012-09-14 11:58:27 -0700 <use> not working when the SVG doc is embedded in <object> data 2012-09-15 22:03:25 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fmalita fmalita krit pdr schenney webkit.review.bot zimmermann oldest_to_newest 721002 0 164201 fmalita 2012-09-14 11:58:27 -0700 Created attachment 164201 SVG use fail for <object> data Chromium issue: http://code.google.com/p/chromium/issues/detail?id=148786 When the SVG document is embedded as inline <object> data, the use element doesn't seem work. Same document embedded as inline <img> data works fine (see attached test). 721070 1 fmalita 2012-09-14 13:08:43 -0700 The problem seems to be that href's are always considered external when embedding via <object> data. SVGURIReference::isExternalURIReference(): // If the URI matches our documents URL, early exit, we're dealing with a local reference. ASSERT(document); KURL url = document->completeURL(uri); if (equalIgnoringFragmentIdentifier(url, document->url())) return false; // If the URI doesn't contain a base string, just see if it starts with a fragment-identifier. return uri.find('#') != notFound; For <object> data-embedded SVGs, the document URL is set to the actual 'data' attribute value (unlike <img>'s). So the test above falls through and hits the last return.... which is odd as it doesn't seem to do what the comment says at all: shouldn't we just check if the first character matches '#'? I'll post a patch shortly. 721085 2 164214 fmalita 2012-09-14 13:29:46 -0700 Created attachment 164214 Patch 721542 3 164214 webkit.review.bot 2012-09-15 22:03:21 -0700 Comment on attachment 164214 Patch Clearing flags on attachment: 164214 Committed r128702: <http://trac.webkit.org/changeset/128702> 721543 4 webkit.review.bot 2012-09-15 22:03:25 -0700 All reviewed patches have been landed. Closing bug. 164201 2012-09-14 11:58:27 -0700 2012-09-14 11:58:27 -0700 SVG use fail for <object> data object_inline.html text/html 907 fmalita PGh0bWw+Cjxib2R5Pgo8cD5TVkcgZW1iZWRkZWQgdmlhICZsdDtpbWcmZ3Q7IC0gdXNlIG9uIHRo ZSBncmVlbiByZWN0IHdvcmtzPC9wPgo8aW1nIHdpZHRoPSIyMDAiIGhlaWdodD0iMjAwIiBzcmM9 ImRhdGE6aW1hZ2Uvc3ZnK3htbCwKICAgIDxzdmcgdmlld2JveD0nMCAwIDYwMCAzMDAnIHhtbG5z PSdodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZycgeG1sbnM6eGxpbms9J2h0dHA6Ly93d3cudzMu b3JnLzE5OTkveGxpbmsnPgogICAgICA8ZGVmcz4KICAgICAgICA8cmVjdCBpZD0ncmVjdCcgd2lk dGg9JzEwMCcgaGVpZ2h0PScxMDAnIGZpbGw9J2dyZWVuJy8+CiAgICAgIDwvZGVmcz4KICAgICAg PHJlY3QgeD0nMTAwJyB3aWR0aD0nMTAwJyBoZWlnaHQ9JzEwMCcgZmlsbD0neWVsbG93Jy8+CiAg ICAgIDx1c2UgeGxpbms6aHJlZj0nI3JlY3QnLz4KICAgIDwvc3ZnPgoiPgo8cD5TVkcgZW1iZWRk ZWQgdmlhICZsdDtvYmplY3QmZ3Q7IC0gdXNlIG9uIHRoZSBncmVlbiByZWN0IGRvZXNuJ3Qgd29y azwvcD4KPG9iamVjdCB3aWR0aD0iMjAwIiBoZWlnaHQ9IjIwMCIgZGF0YT0iZGF0YTppbWFnZS9z dmcreG1sLAogICAgPHN2ZyB2aWV3Ym94PScwIDAgNjAwIDMwMCcgeG1sbnM9J2h0dHA6Ly93d3cu dzMub3JnLzIwMDAvc3ZnJyB4bWxuczp4bGluaz0naHR0cDovL3d3dy53My5vcmcvMTk5OS94bGlu ayc+CiAgICAgIDxkZWZzPgoJPHJlY3QgaWQ9J3JlY3QnIHdpZHRoPScxMDAnIGhlaWdodD0nMTAw JyBmaWxsPSdncmVlbicvPgogICAgICA8L2RlZnM+CiAgICAgIDxyZWN0IHg9JzEwMCcgd2lkdGg9 JzEwMCcgaGVpZ2h0PScxMDAnIGZpbGw9J3llbGxvdycvPgogICAgICA8dXNlIHhsaW5rOmhyZWY9 JyNyZWN0Jy8+CiAgICA8L3N2Zz4KIj5waWM8L29iamVjdD4KPC9ib2R5Pgo8L2h0bWw+Cg== 164214 2012-09-14 13:29:46 -0700 2012-09-15 22:03:21 -0700 Patch bug-96816-20120914162917.patch text/plain 4207 fmalita U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWIyMjQxNGIzYWJmZmI2 YmM4ZDNkN2NhM2I1YTQzNTkyYmFlMzBhYi4uYzdlZjNlZmZhNGUwYjAzMDNhYmQyMjcyYTRmZjFk ZTc4MDU1ZTQ5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTE0ICBGbG9y aW4gTWFsaXRhICA8Zm1hbGl0YUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgPHVzZT4gbm90IHdv cmtpbmcgd2hlbiB0aGUgU1ZHIGRvYyBpcyBlbWJlZGRlZCBhcyA8b2JqZWN0PiBkYXRhCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjgxNgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZWQgU1ZHVVJJ UmVmZXJlbmNlOjppc0V4dGVybmFsVVJJUmVmZXJlbmNlKCkgdG8gY29ycmVjdGx5IGNsYXNzaWZ5 IGZyYWdtZW50LW9ubHkgVVJJcy4KKyAgICAgICAgQWxzbywgc2luY2UgdGhlIGZyYWdtZW50LW9u bHkgdGVzdCBpcyBjaGVhcCwgaXQgc2hvdWxkIGJlIHRoZSBmaXJzdCB0aGluZyB0byB0cnkuCisK KyAgICAgICAgVGVzdDogc3ZnL2N1c3RvbS9vYmplY3QtZGF0YS1ocmVmLmh0bWwKKworICAgICAg ICAqIHN2Zy9TVkdVUklSZWZlcmVuY2UuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1VSSVJlZmVy ZW5jZTo6aXNFeHRlcm5hbFVSSVJlZmVyZW5jZSk6CisKIDIwMTItMDktMTQgIFNoZXJpZmYgQm90 ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIxMjg1NjYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVVJJ UmVmZXJlbmNlLmggYi9Tb3VyY2UvV2ViQ29yZS9zdmcvU1ZHVVJJUmVmZXJlbmNlLmgKaW5kZXgg Yzg3YTE3NDJhYTI5NjQ2YWFlYjk4ODkzZjgzYzA4Mzk2NTRiNDM4Yy4uMWI2ZThlOWVjZjQ5ODJk NDhhOTE5Mjk3OGE2NmQzMzFlZWYzYjVjOSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvc3Zn L1NWR1VSSVJlZmVyZW5jZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9TVkdVUklSZWZlcmVu Y2UuaApAQCAtNDMsMTQgKzQzLDE0IEBAIHB1YmxpYzoKIAogICAgIHN0YXRpYyBpbmxpbmUgYm9v bCBpc0V4dGVybmFsVVJJUmVmZXJlbmNlKGNvbnN0IFN0cmluZyYgdXJpLCBEb2N1bWVudCogZG9j dW1lbnQpCiAgICAgewotICAgICAgICAvLyBJZiB0aGUgVVJJIG1hdGNoZXMgb3VyIGRvY3VtZW50 cyBVUkwsIGVhcmx5IGV4aXQsIHdlJ3JlIGRlYWxpbmcgd2l0aCBhIGxvY2FsIHJlZmVyZW5jZS4K LSAgICAgICAgQVNTRVJUKGRvY3VtZW50KTsKLSAgICAgICAgS1VSTCB1cmwgPSBkb2N1bWVudC0+ Y29tcGxldGVVUkwodXJpKTsKLSAgICAgICAgaWYgKGVxdWFsSWdub3JpbmdGcmFnbWVudElkZW50 aWZpZXIodXJsLCBkb2N1bWVudC0+dXJsKCkpKQorICAgICAgICAvLyBGcmFnbWVudC1vbmx5IFVS SXMgYXJlIGFsd2F5cyBpbnRlcm5hbAorICAgICAgICBpZiAodXJpLnN0YXJ0c1dpdGgoJyMnKSkK ICAgICAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgICAgICAvLyBJZiB0aGUgVVJJIGRvZXNu J3QgY29udGFpbiBhIGJhc2Ugc3RyaW5nLCBqdXN0IHNlZSBpZiBpdCBzdGFydHMgd2l0aCBhIGZy YWdtZW50LWlkZW50aWZpZXIuCi0gICAgICAgIHJldHVybiB1cmkuZmluZCgnIycpICE9IG5vdEZv dW5kOworICAgICAgICAvLyBJZiB0aGUgVVJJIG1hdGNoZXMgb3VyIGRvY3VtZW50cyBVUkwsIHdl J3JlIGRlYWxpbmcgd2l0aCBhIGxvY2FsIHJlZmVyZW5jZS4KKyAgICAgICAgQVNTRVJUKGRvY3Vt ZW50KTsKKyAgICAgICAgS1VSTCB1cmwgPSBkb2N1bWVudC0+Y29tcGxldGVVUkwodXJpKTsKKyAg ICAgICAgcmV0dXJuICFlcXVhbElnbm9yaW5nRnJhZ21lbnRJZGVudGlmaWVyKHVybCwgZG9jdW1l bnQtPnVybCgpKTsKICAgICB9CiAKIHByb3RlY3RlZDoKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA0NTYwODU1ZDMzY2VmMjA5 MWI1ZmU0MzM2ZjFhYzE3NjhlMmE1ZDliLi4wNmJiMTczMTEwMTdiNmNiNjFjNWQ5OTRjZmI4OTU2 ZDhjYzdiNWIwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMDktMTQgIEZsb3JpbiBNYWxp dGEgIDxmbWFsaXRhQGNocm9taXVtLm9yZz4KKworICAgICAgICA8dXNlPiBub3Qgd29ya2luZyB3 aGVuIHRoZSBTVkcgZG9jIGlzIGVtYmVkZGVkIGFzIDxvYmplY3Q+IGRhdGEKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2ODE2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdmcvY3VzdG9tL29iamVjdC1k YXRhLWhyZWYtZXhwZWN0ZWQuaHRtbDogQWRkZWQuCisgICAgICAgICogc3ZnL2N1c3RvbS9vYmpl Y3QtZGF0YS1ocmVmLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA5LTE0ICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTI4NTc1KTogZmFz dC9mb3Jtcy90aW1lLW11bHRpcGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1wcmVzZXJ2 ZS12YWx1ZS1hZnRlci1oaXN0b3J5LWJhY2suaHRtbCBpcyBmYWlsZWQgb24gQ2hyb21pdW0tV2lu CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL29iamVjdC1kYXRhLWhyZWYtZXhw ZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vb2JqZWN0LWRhdGEtaHJlZi1leHBl Y3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZhOWIzZmZjYmVhMDc5YWIzM2VlZjBmOGExNzY1ZTM1MTRh ZTMyNzcKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9zdmcvY3VzdG9tL29iamVjdC1k YXRhLWhyZWYtZXhwZWN0ZWQuaHRtbApAQCAtMCwwICsxLDEwIEBACis8IURPQ1RZUEUgaHRtbD4K KzxodG1sPgorPGJvZHkgc3R5bGU9Im1hcmdpbjogMHB4OyBwYWRkaW5nOiAwcHg7Ij4KKyAgPG9i amVjdCBkYXRhPSJkYXRhOmltYWdlL3N2Zyt4bWwsCisgICAgPHN2ZyB4bWxucz0naHR0cDovL3d3 dy53My5vcmcvMjAwMC9zdmcnIHhtbG5zOnhsaW5rPSdodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hs aW5rJz4KKyAgICAgIDxyZWN0IGlkPSdyZWN0JyB3aWR0aD0nMTAwJyBoZWlnaHQ9JzEwMCcgZmls bD0nZ3JlZW4nLz4KKyAgICA8L3N2Zz4KKyAgIj48L29iamVjdD4KKzwvYm9keT4KKzwvaHRtbD4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vb2JqZWN0LWRhdGEtaHJlZi5odG1s IGIvTGF5b3V0VGVzdHMvc3ZnL2N1c3RvbS9vYmplY3QtZGF0YS1ocmVmLmh0bWwKbmV3IGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MC4uNzc5ZGFkYzc3YmY4NDE0ZTY5MTAwMjliZTA4MWQ4MzAxYmYyYmMyMwotLS0gL2Rldi9udWxs CisrKyBiL0xheW91dFRlc3RzL3N2Zy9jdXN0b20vb2JqZWN0LWRhdGEtaHJlZi5odG1sCkBAIC0w LDAgKzEsMTQgQEAKKzwhRE9DVFlQRSBodG1sPgorPGh0bWw+Cis8Ym9keSBzdHlsZT0ibWFyZ2lu OiAwcHg7IHBhZGRpbmc6IDBweDsiPgorICA8IS0tIFRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjgxNiAtLT4KKyAgPG9iamVjdCBkYXRhPSJkYXRhOmlt YWdlL3N2Zyt4bWwsCisgICAgPHN2ZyB4bWxucz0naHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmcn IHhtbG5zOnhsaW5rPSdodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5rJz4KKyAgICAgIDxkZWZz PgorICAgICAgICA8cmVjdCBpZD0ncmVjdCcgd2lkdGg9JzEwMCcgaGVpZ2h0PScxMDAnIGZpbGw9 J2dyZWVuJy8+CisgICAgICA8L2RlZnM+CisgICAgICA8dXNlIHhsaW5rOmhyZWY9JyNyZWN0Jy8+ CisgICAgPC9zdmc+CisgICI+PC9vYmplY3Q+Cis8L2JvZHk+Cis8L2h0bWw+Cg==