96804 2012-09-14 10:17:33 -0700 Make computeLogicalHeight virtual and updateLogicalHeight non-virtual. 2022-09-16 11:59:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 97049 97263 97475 97486 98677 99348 1 tony rbuis changseok donggwan.kim esprehn+autocc ews-watchlist glenn hyatt kondapallykalyan leviw mstensho ntim pdr rbuis webkit-bug-importer oldest_to_newest 720894 0 tony 2012-09-14 10:17:33 -0700 In bug 94982, the code for computeLogicalHeight was made const and put int a non-virtual function. This got rid of some hacks where we would store the old height, call computeLogicalHeight, then restore the old height. However, in the new code, it's hard to use computeLogicalHeight because it's not virtual so if you call it on a pointer and your pointer overrides updateLogicalHeight (e.g., it's an iframe), it'll do the wrong thing. See RenderBlock::computeBlockPreferredLogicalWidths for an example of where we would like to use childBox->computeLogicalHeight(..), but it crashes because sometimes childBox is a RenderView, which overrides updateLogicalHeight(). I think long term, we want to make computeLogicalHeight virtual and move code from the subclass updateLogicalHeight into it and then make updateLogicalHeight non-virtual. 742388 1 tony 2012-10-15 13:57:28 -0700 computeLogicalHeight is now virtual, however, I can't make updateLogicalHeight virtual because of RenderMultiColumnSet, which sets a member variable during updateLogicalHeight. It looks like that variable is the same as logicalHeight right now, but the comments suggest that there is a future use for it. I'd like to remove RenderMultiColumnSet::m_computedColumnHeight. 785202 2 hyatt 2012-12-06 13:37:25 -0800 Yeah, you're not going to be able to remove this. It's going to be needed. 892175 3 mstensho 2013-05-22 01:39:28 -0700 FYI: the RenderMultiColumnSet::updateLogicalHeight() override is going away with the fix for https://bugs.webkit.org/show_bug.cgi?id=116033 , but in the meantime (after this bug was reported) RenderRegion::updateLogicalHeight() has appeared. 1898697 4 462358 rbuis 2022-09-15 07:31:00 -0700 Created attachment 462358 Patch 1899018 5 ntim 2022-09-16 10:51:34 -0700 r=me 1899042 6 ews-feeder 2022-09-16 11:58:03 -0700 Committed 254564@main (c096c71bf576): <https://commits.webkit.org/254564@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 462358. 1899043 7 webkit-bug-importer 2022-09-16 11:59:19 -0700 <rdar://problem/100036927> 462358 2022-09-15 07:31:00 -0700 2022-09-16 11:58:04 -0700 Patch bug-96804-20220915153058.patch text/plain 1107 rbuis RnJvbSA5NWNjNWVkMGZiNTk2MzMwOTEzMjg4NzAyMTEyYTdkZmFiYjE3MmUzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSb2IgQnVpcyA8cmJ1aXNAaWdhbGlhLmNvbT4KRGF0ZTogVGh1 LCAxNSBTZXAgMjAyMiAxNToyOTowMiArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIE1ha2UgY29tcHV0 ZUxvZ2ljYWxIZWlnaHQgdmlydHVhbCBhbmQgdXBkYXRlTG9naWNhbEhlaWdodAogbm9uLXZpcnR1 YWwuIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjgwNAoKUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpNYWtlIHVwZGF0ZUxvZ2ljYWxIZWlnaHQgbm9uLXZpcnR1 YWwuCgoqIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaDoKLS0tCiBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmggfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyQm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94 LmgKaW5kZXggNDMxNzllMDlmZWU3Li4xN2IzZmU5MTk4YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQm94LmgKQEAgLTQyMyw3ICs0MjMsNyBAQCBvdmVycmlkZTsKICAgICBMYXlvdXRV bml0IHBlcnBlbmRpY3VsYXJDb250YWluaW5nQmxvY2tMb2dpY2FsSGVpZ2h0KCkgY29uc3Q7CiAK ICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlTG9naWNhbFdpZHRoKCk7Ci0gICAgdmlydHVhbCB2b2lk IHVwZGF0ZUxvZ2ljYWxIZWlnaHQoKTsKKyAgICB2b2lkIHVwZGF0ZUxvZ2ljYWxIZWlnaHQoKTsK ICAgICB2aXJ0dWFsIExvZ2ljYWxFeHRlbnRDb21wdXRlZFZhbHVlcyBjb21wdXRlTG9naWNhbEhl aWdodChMYXlvdXRVbml0IGxvZ2ljYWxIZWlnaHQsIExheW91dFVuaXQgbG9naWNhbFRvcCkgY29u c3Q7CiAKICAgICB2b2lkIGNhY2hlSW50cmluc2ljQ29udGVudExvZ2ljYWxIZWlnaHRGb3JGbGV4 SXRlbShMYXlvdXRVbml0KSBjb25zdDsK