96802 2012-09-14 10:07:32 -0700 [Chromium] IndexedDB: Remove legacy two-phase open() API members 2012-09-17 10:13:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell abarth alecflett dglazkov dgrogan fishd jamesr peter+ews tkent+wkapi tony webkit.review.bot oldest_to_newest 720873 0 jsbell 2012-09-14 10:07:32 -0700 [Chromium] IndexedDB: Remove legacy two-phase open() API members 720881 1 164177 jsbell 2012-09-14 10:09:47 -0700 Created attachment 164177 Patch 720887 2 jsbell 2012-09-14 10:12:04 -0700 https://codereview.chromium.org/10916318 needs to land first. 721245 3 jsbell 2012-09-14 16:47:48 -0700 Chromium side has landed, this is ready for review. dgrogan@ - can you take a look? 721247 4 webkit.review.bot 2012-09-14 16:48:32 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 721248 5 164177 dgrogan 2012-09-14 16:48:36 -0700 Comment on attachment 164177 Patch LGTM 721261 6 164177 webkit.review.bot 2012-09-14 17:07:27 -0700 Comment on attachment 164177 Patch Attachment 164177 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13851698 721294 7 164177 peter+ews 2012-09-14 18:21:33 -0700 Comment on attachment 164177 Patch Attachment 164177 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13852617 721984 8 jsbell 2012-09-17 09:17:39 -0700 I think chromium DEPS just needed to roll. Retrying the CQ. 722020 9 164177 webkit.review.bot 2012-09-17 10:13:22 -0700 Comment on attachment 164177 Patch Clearing flags on attachment: 164177 Committed r128773: <http://trac.webkit.org/changeset/128773> 722021 10 webkit.review.bot 2012-09-17 10:13:26 -0700 All reviewed patches have been landed. Closing bug. 164177 2012-09-14 10:09:47 -0700 2012-09-17 10:13:22 -0700 Patch bug-96802-20120914100918.patch text/plain 5133 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NjAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGRmNjA1MWZiMzhlYTE2MmY4ZmExZDZkYTA4YjUzZmJjMTFjNDU4NzYuLjFmYzA0MzdkYmEyNmQz NzUwNDhhZTBmNjYyNmJhNjkxM2E3ZDhmNmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjIgQEAKKzIwMTItMDktMTQgIEpvc2h1YSBCZWxsICA8anNiZWxsQGNocm9taXVt Lm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEluZGV4ZWREQjogUmVtb3ZlIGxlZ2FjeSB0d28t cGhhc2Ugb3BlbigpIEFQSSBtZW1iZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05NjgwMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZvbGxvd2luZyBodHRwOi8vd2Via2l0Lm9yZy9iLzkwNDExIGFuZCBz dWJzZXF1ZW50IGNsZWFudXAgb24gdGhlIENocm9taXVtIHNpZGUsCisgICAgICAgIHRoZXNlIGVu dHJ5IHBvaW50cyBhcmUgbm8gbG9uZ2VyIG5lZWRlZC4KKworICAgICAgICAqIHB1YmxpYy9XZWJJ REJEYXRhYmFzZS5oOiBEZWxldGUgb2xkIHNlY29uZC1waGFzZSBvcGVuKGRiLWNhbGxiYWNrcykK KyAgICAgICAgKiBwdWJsaWMvV2ViSURCRmFjdG9yeS5oOiBEZWxldGUgb2xkIGZpcnN0LXBoYXNl IG9wZW4oKSB3L28gZGItY2FsbGJhY2tzCisgICAgICAgICogc3JjL1dlYklEQkRhdGFiYXNlSW1w bC5jcHA6IE5vIGxvbmdlciBuZWVkIHRvIGFjY291bnQgZm9yIGEgY2xvc2UgYmV0d2VlbiBwaGFz ZXMuCisgICAgICAgIChXZWJLaXQ6OldlYklEQkRhdGFiYXNlSW1wbDo6V2ViSURCRGF0YWJhc2VJ bXBsKToKKyAgICAgICAgKFdlYktpdDo6V2ViSURCRGF0YWJhc2VJbXBsOjpjbG9zZSk6CisgICAg ICAgIChXZWJLaXQ6OldlYklEQkRhdGFiYXNlSW1wbDo6Zm9yY2VDbG9zZSk6CisgICAgICAgICog c3JjL1dlYklEQkRhdGFiYXNlSW1wbC5oOgorICAgICAgICAoV2ViSURCRGF0YWJhc2VJbXBsKToK KwogMjAxMi0wOS0xNCAgS2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAg ICAgICBNYWtlIHRpbWUgaW5wdXQgbGFuZyBhdHRyaWJ1dGUgYXdhcmUgZm9yIHRlc3RpbmcKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkRhdGFiYXNlLmgg Yi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJREJEYXRhYmFzZS5oCmluZGV4IDU5 MmExMGUzZTE5NzAxZmU0MDg4ZjMyOWQxMmVjOTgwMGY5NGQyOTUuLjgzYjlhNDI1Zjg0N2ZhOWQ4 ODE3MzdjMzA5ZWE4YTI4MmFiNGVmMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYklEQkRhdGFiYXNlLmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViSURCRGF0YWJhc2UuaApAQCAtNjYsOSArNjYsNiBAQCBwdWJsaWM6CiAgICAgdmly dHVhbCB2b2lkIGNsb3NlKCkgeyBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KICAgICB2 aXJ0dWFsIHZvaWQgZm9yY2VDbG9zZSgpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9 CiAKLSAgICAvLyBGSVhNRTogUmVtb3ZlIHRoaXMgbWV0aG9kIGFmdGVyIFdLOTA0MTEgY2xlYW51 cCBpcyBjb21wbGV0ZSBvbiB0aGUgQ2hyb21pdW0gc2lkZS4KLSAgICB2aXJ0dWFsIHZvaWQgb3Bl bihXZWJJREJEYXRhYmFzZUNhbGxiYWNrcyopIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgp OyB9Ci0KIHByb3RlY3RlZDoKICAgICBXZWJJREJEYXRhYmFzZSgpIHsgfQogfTsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkZhY3RvcnkuaCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklEQkZhY3RvcnkuaAppbmRleCA2OWE0NTNhYmNk OTQ0ZTM3MjZhYjVhYmFlODZlNDdjN2Q5YTVjNDM4Li4xMmVjZjA3YzcyNzcyMDViYmI2ZDY5N2E4 YjhjYjIzMzFjZTEzNWFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJJREJGYWN0b3J5LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi SURCRmFjdG9yeS5oCkBAIC01NSwxMCArNTUsNiBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIHZv aWQgZ2V0RGF0YWJhc2VOYW1lcyhXZWJJREJDYWxsYmFja3MqIGNhbGxiYWNrcywgY29uc3QgV2Vi U2VjdXJpdHlPcmlnaW4mIG9yaWdpbiwgV2ViRnJhbWUqIGZyYW1lLCBjb25zdCBXZWJTdHJpbmcm IGRhdGFEaXIpIHsgV0VCS0lUX0FTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CiAKLSAgICAvLyBGSVhN RTogUmVtb3ZlIHRoaXMgb3ZlcmxvYWQgYWZ0ZXIgV0s5MDQxMSBjbGVhbnVwIGlzIGNvbXBsZXRl IG9uIHRoZSBDaHJvbWl1bSBzaWRlLgotICAgIC8vIFRoZSBXZWJLaXQgaW1wbGVtZW50YXRpb24g b2Ygb3BlbiBpZ25vcmVzIHRoZSBXZWJGcmFtZSogcGFyYW1ldGVyLgotICAgIHZpcnR1YWwgdm9p ZCBvcGVuKGNvbnN0IFdlYlN0cmluZyYgbmFtZSwgbG9uZyBsb25nIHZlcnNpb24sIFdlYklEQkNh bGxiYWNrcyogY2FsbGJhY2tzLCBjb25zdCBXZWJTZWN1cml0eU9yaWdpbiYgb3JpZ2luLCBXZWJG cmFtZSogZnJhbWUsIGNvbnN0IFdlYlN0cmluZyYgZGF0YURpcikgeyBXRUJLSVRfQVNTRVJUX05P VF9SRUFDSEVEKCk7IH0KLQogICAgIC8vIFRoZSBXZWJLaXQgaW1wbGVtZW50YXRpb24gb2Ygb3Bl biBpZ25vcmVzIHRoZSBXZWJGcmFtZSogcGFyYW1ldGVyLgogICAgIHZpcnR1YWwgdm9pZCBvcGVu KGNvbnN0IFdlYlN0cmluZyYgbmFtZSwgbG9uZyBsb25nIHZlcnNpb24sIFdlYklEQkNhbGxiYWNr cyogY2FsbGJhY2tzLCBXZWJJREJEYXRhYmFzZUNhbGxiYWNrcyogZGF0YWJhc2VDYWxsYmFja3Ms IGNvbnN0IFdlYlNlY3VyaXR5T3JpZ2luJiBvcmlnaW4sIFdlYkZyYW1lKiBmcmFtZSwgY29uc3Qg V2ViU3RyaW5nJiBkYXRhRGlyKSB7IFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsgfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJEYXRhYmFzZUltcGwu Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSURCRGF0YWJhc2VJbXBsLmNwcApp bmRleCA1Mjg3OWE5YTdmM2I3MzgwYWJhMzA2ZWQ2NzNkMGM0MmExMjhmYzQ2Li5iNThjZDUxMTE3 NzY4ODRmOTU2MDFlOWVlNzllMGQ4Mjg5M2M2MmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJJREJEYXRhYmFzZUltcGwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYklEQkRhdGFiYXNlSW1wbC5jcHAKQEAgLTQ4LDcgKzQ4LDYgQEAgbmFt ZXNwYWNlIFdlYktpdCB7CiBXZWJJREJEYXRhYmFzZUltcGw6OldlYklEQkRhdGFiYXNlSW1wbChQ YXNzUmVmUHRyPElEQkRhdGFiYXNlQmFja2VuZEludGVyZmFjZT4gZGF0YWJhc2VCYWNrZW5kLCBX VEY6OlBhc3NSZWZQdHI8SURCRGF0YWJhc2VDYWxsYmFja3NQcm94eT4gZGF0YWJhc2VDYWxsYmFj a3MpCiAgICAgOiBtX2RhdGFiYXNlQmFja2VuZChkYXRhYmFzZUJhY2tlbmQpCiAgICAgLCBtX2Rh dGFiYXNlQ2FsbGJhY2tzKGRhdGFiYXNlQ2FsbGJhY2tzKQotICAgICwgbV9jbG9zZVBlbmRpbmco ZmFsc2UpCiB7CiB9CiAKQEAgLTk2LDE5ICs5NSwxNSBAQCB2b2lkIFdlYklEQkRhdGFiYXNlSW1w bDo6Y2xvc2UoKQogewogICAgIC8vIFVzZSB0aGUgY2FsbGJhY2tzIHBhc3NlZCBpbiB0byB0aGUg Y29uc3RydWN0b3Igc28gdGhhdCB0aGUgYmFja2VuZCBpbgogICAgIC8vIG11bHRpLXByb2Nlc3Mg Y2hyb21pdW0ga25vd3Mgd2hpY2ggZGF0YWJhc2UgY29ubmVjdGlvbiBpcyBjbG9zaW5nLgotICAg IGlmICghbV9kYXRhYmFzZUNhbGxiYWNrcykgewotICAgICAgICBtX2Nsb3NlUGVuZGluZyA9IHRy dWU7CisgICAgaWYgKCFtX2RhdGFiYXNlQ2FsbGJhY2tzKQogICAgICAgICByZXR1cm47Ci0gICAg fQogICAgIG1fZGF0YWJhc2VCYWNrZW5kLT5jbG9zZShtX2RhdGFiYXNlQ2FsbGJhY2tzLnJlbGVh c2UoKSk7CiB9CiAKIHZvaWQgV2ViSURCRGF0YWJhc2VJbXBsOjpmb3JjZUNsb3NlKCkKIHsKLSAg ICBpZiAoIW1fZGF0YWJhc2VDYWxsYmFja3MpIHsKLSAgICAgICAgbV9jbG9zZVBlbmRpbmcgPSB0 cnVlOworICAgIGlmICghbV9kYXRhYmFzZUNhbGxiYWNrcykKICAgICAgICAgcmV0dXJuOwotICAg IH0KICAgICBSZWZQdHI8SURCRGF0YWJhc2VDYWxsYmFja3NQcm94eT4gY2FsbGJhY2tzID0gbV9k YXRhYmFzZUNhbGxiYWNrcy5yZWxlYXNlKCk7CiAgICAgbV9kYXRhYmFzZUJhY2tlbmQtPmNsb3Nl KGNhbGxiYWNrcyk7CiAgICAgY2FsbGJhY2tzLT5vbkZvcmNlZENsb3NlKCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJREJEYXRhYmFzZUltcGwuaCBiL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQkRhdGFiYXNlSW1wbC5oCmluZGV4IDljZDFjYWY1 OTIwNjliNTRkZmI5NmNjODc4NDRjMzc5NmRiM2EzMDcuLjUxOGZmY2RiOTc5ODAwNWU0Yzg4YzA3 ODhlMDRlYWU1M2Y3NmM4YzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYklEQkRhdGFiYXNlSW1wbC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YklEQkRhdGFiYXNlSW1wbC5oCkBAIC02Miw5ICs2Miw2IEBAIHB1YmxpYzoKIHByaXZhdGU6CiAg ICAgV1RGOjpSZWZQdHI8V2ViQ29yZTo6SURCRGF0YWJhc2VCYWNrZW5kSW50ZXJmYWNlPiBtX2Rh dGFiYXNlQmFja2VuZDsKICAgICBXVEY6OlJlZlB0cjxJREJEYXRhYmFzZUNhbGxiYWNrc1Byb3h5 PiBtX2RhdGFiYXNlQ2FsbGJhY2tzOwotICAgIC8vIEZJWE1FOiBSZW1vdmUgdGhpcyBmbGFnIHdo ZW4gd2UgY29uc29saWRhdGUgdHdvLXBoYXNlIG9wZW4uCi0gICAgLy8gaHR0cDovL3drYi51Zy85 MDQxMQotICAgIGJvb2wgbV9jbG9zZVBlbmRpbmc7CiB9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJL aXQK