96788 2012-09-14 07:48:09 -0700 Gesture events sent to wrong node when page is scrolled 2012-09-14 08:54:49 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 96060 1 rbyers rbyers abarth allan.jensen sadrul tonikitoo webkit.review.bot oldest_to_newest 720766 0 rbyers 2012-09-14 07:48:09 -0700 In bug 92281, gesture events started being propagated to the DOM, just for the sake of chromium plugins. However the hit test that occurs here is happening on the wrong co-ordinate space, so if the page is scrolled, the wrong DOM element will be targeted. 720770 1 rbyers 2012-09-14 08:00:21 -0700 In the new layout test I'm about to upload, we currently get the following output (only the unexpected GestureTapDown, and the synthetic mouse events are received): Plugin received event: GestureTapDown Plugin received event: MouseEnter Plugin received event: MouseMove Plugin received event: MouseDown Plugin received event: MouseUp Plugin received event: MouseWheel With the fix, we get this as expected: Plugin received event: GestureTap Plugin received event: MouseEnter Plugin received event: MouseMove Plugin received event: MouseDown Plugin received event: MouseUp Plugin received event: GestureScrollBegin Plugin received event: GestureScrollUpdate Plugin received event: MouseWheel Plugin received event: GestureScrollEnd 720776 2 164155 rbyers 2012-09-14 08:13:54 -0700 Created attachment 164155 Patch 720779 3 rbyers 2012-09-14 08:15:06 -0700 abarth@, since you reviewed the original change in bug 92281, do you want to review this one two? 720813 4 164155 webkit.review.bot 2012-09-14 08:54:46 -0700 Comment on attachment 164155 Patch Clearing flags on attachment: 164155 Committed r128615: <http://trac.webkit.org/changeset/128615> 720814 5 webkit.review.bot 2012-09-14 08:54:49 -0700 All reviewed patches have been landed. Closing bug. 164155 2012-09-14 08:13:54 -0700 2012-09-14 08:54:46 -0700 Patch bug-96788-20120914111325.patch text/plain 4903 rbyers U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ3NDAyNmQyODgwZDFm MjRlMGVkOTM2ZDIzMWY0NjJjYjk3ZmFjNy4uMDZiNzRjM2Y1NjFhNDFmMzVjYTllZDliMzQ4N2Nh YzI4OGUzNGUwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTE0ICBSaWNr IEJ5ZXJzICA8cmJ5ZXJzQGNocm9taXVtLm9yZz4KKworICAgICAgICBHZXN0dXJlIGV2ZW50cyBz ZW50IHRvIHdyb25nIG5vZGUgd2hlbiBwYWdlIGlzIHNjcm9sbGVkCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njc4OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkanVzdCB0aGUgY28tb3JkaW5hdGUgc3Bh Y2UgY29ycmVjdGx5IHdoZW4gZG9pbmcgaGl0IHRlc3RpbmcgZm9yCisgICAgICAgIGdlc3R1cmUg ZXZlbnRzIChhcyBmb3IgYWxsIG90aGVyIGV2ZW50IGhhbmRsaW5nIGNvZGUgaGVyZSkuCisKKyAg ICAgICAgVGVzdDogcGxhdGZvcm0vY2hyb21pdW0vcGx1Z2lucy9nZXN0dXJlLWV2ZW50cy1zY3Jv bGxlZC5odG1sCisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpFdmVudEhhbmRsZXI6OmhhbmRsZUdlc3R1cmVFdmVudCk6CisKIDIwMTItMDktMTMg IFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIFJlc291cmNl UmVxdWVzdCBzdHJpbmcgb3B0aW1pemF0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv cGFnZS9FdmVudEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIu Y3BwCmluZGV4IGYxMDJlODU2ZGMyOTU0MmU0MzQ4YWNiYzc3MWExNDAxZGJmZTYzZTMuLjQ4ZDA3 OWUyMmI3MWM0MWE1ZDkzMDRkOGJlMjFiYTI2YjhiMzg5MjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0V2 ZW50SGFuZGxlci5jcHAKQEAgLTIzODEsNyArMjM4MSw4IEBAIGJvb2wgRXZlbnRIYW5kbGVyOjpo YW5kbGVHZXN0dXJlRXZlbnQoY29uc3QgUGxhdGZvcm1HZXN0dXJlRXZlbnQmIGdlc3R1cmVFdmVu dCkKICAgICAgICAgZXZlbnRUYXJnZXQgPSBtX3Njcm9sbEdlc3R1cmVIYW5kbGluZ05vZGUuZ2V0 KCk7CiAKICAgICBpZiAoIWV2ZW50VGFyZ2V0KSB7Ci0gICAgICAgIEhpdFRlc3RSZXN1bHQgcmVz dWx0ID0gaGl0VGVzdFJlc3VsdEF0UG9pbnQoZ2VzdHVyZUV2ZW50LnBvc2l0aW9uKCksIGZhbHNl LCBmYWxzZSwgRG9udEhpdFRlc3RTY3JvbGxiYXJzLCBIaXRUZXN0UmVxdWVzdDo6UmVhZE9ubHkg fCBIaXRUZXN0UmVxdWVzdDo6QWN0aXZlKTsKKyAgICAgICAgSW50UG9pbnQgaGl0VGVzdFBvaW50 ID0gbV9mcmFtZS0+dmlldygpLT53aW5kb3dUb0NvbnRlbnRzKGdlc3R1cmVFdmVudC5wb3NpdGlv bigpKTsKKyAgICAgICAgSGl0VGVzdFJlc3VsdCByZXN1bHQgPSBoaXRUZXN0UmVzdWx0QXRQb2lu dChoaXRUZXN0UG9pbnQsIGZhbHNlLCBmYWxzZSwgRG9udEhpdFRlc3RTY3JvbGxiYXJzLCBIaXRU ZXN0UmVxdWVzdDo6UmVhZE9ubHkgfCBIaXRUZXN0UmVxdWVzdDo6QWN0aXZlKTsKICAgICAgICAg ZXZlbnRUYXJnZXQgPSByZXN1bHQudGFyZ2V0Tm9kZSgpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDkxM2Rh YmY1NzJlMzA0NWFmYjY0M2QzNTFlMDYxNjZkYTRlNmJlNmIuLjJkMTkzYjcyOGUyNzFiZTY3ZDlk OTZlNDU0ZWRlYTk1MzAxNzk5OTIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZwor KysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOS0xNCAg UmljayBCeWVycyAgPHJieWVyc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgR2VzdHVyZSBldmVu dHMgc2VudCB0byB3cm9uZyBub2RlIHdoZW4gcGFnZSBpcyBzY3JvbGxlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY3ODgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbGF5b3V0IHRlc3QgYmFzZWQg b24gZ2VzdHVyZS1ldmVudHMuaHRtbCB3aGljaCB0ZXN0cyB0aGUgY2FzZSB3aGVuCisgICAgICAg IHRoZSBkb2N1bWVudCBpcyBzY3JvbGxlZCAoc28gdGhhdCBjbGllbnQgY28tb3JkaW5hdGVzIGRv bid0IGVxdWFsIHBhZ2UKKyAgICAgICAgY28tb3JkaW5hdGVzKS4KKyAgICAgICAgKiBwbGF0Zm9y bS9jaHJvbWl1bS9wbHVnaW5zL2dlc3R1cmUtZXZlbnRzLXNjcm9sbGVkLWV4cGVjdGVkLnR4dDog QWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vcGx1Z2lucy9nZXN0dXJlLWV2ZW50 cy1zY3JvbGxlZC5odG1sOiBBZGRlZC4KKwogMjAxMi0wOS0xMyAgSm9obiBNZWxsb3IgIDxqb2hu bWVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFRleHQgQXV0b3NpemluZzogQWRkIGV4cGxhbmF0 aW9ucyB0byB0ZXN0cy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVt L3BsdWdpbnMvZ2VzdHVyZS1ldmVudHMtc2Nyb2xsZWQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vY2hyb21pdW0vcGx1Z2lucy9nZXN0dXJlLWV2ZW50cy1zY3JvbGxlZC1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uMmZkYTQyNmIxOGNiN2Q3NzM4NzE2MzllN2MwMDQ0YWY2Njdl MWRjMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Bs dWdpbnMvZ2VzdHVyZS1ldmVudHMtc2Nyb2xsZWQtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMTAg QEAKK1BsdWdpbiByZWNlaXZlZCBldmVudDogR2VzdHVyZVRhcAorUGx1Z2luIHJlY2VpdmVkIGV2 ZW50OiBNb3VzZUVudGVyCitQbHVnaW4gcmVjZWl2ZWQgZXZlbnQ6IE1vdXNlTW92ZQorUGx1Z2lu IHJlY2VpdmVkIGV2ZW50OiBNb3VzZURvd24KK1BsdWdpbiByZWNlaXZlZCBldmVudDogTW91c2VV cAorUGx1Z2luIHJlY2VpdmVkIGV2ZW50OiBHZXN0dXJlU2Nyb2xsQmVnaW4KK1BsdWdpbiByZWNl aXZlZCBldmVudDogR2VzdHVyZVNjcm9sbFVwZGF0ZQorUGx1Z2luIHJlY2VpdmVkIGV2ZW50OiBN b3VzZVdoZWVsCitQbHVnaW4gcmVjZWl2ZWQgZXZlbnQ6IEdlc3R1cmVTY3JvbGxFbmQKKwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vcGx1Z2lucy9nZXN0dXJlLWV2 ZW50cy1zY3JvbGxlZC5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vcGx1Z2lu cy9nZXN0dXJlLWV2ZW50cy1zY3JvbGxlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmM4ZDE5NzFmYzNmMGJh ZDg5MzI3NjA2OWRmMTJmOTNjODEzZGY2ODEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9jaHJvbWl1bS9wbHVnaW5zL2dlc3R1cmUtZXZlbnRzLXNjcm9sbGVkLmh0bWwK QEAgLTAsMCArMSw0MyBAQAorPGh0bWw+Cis8aGVhZD4KKzxzdHlsZT4KKyAgYm9keSB7CisgICAg aGVpZ2h0OiAyMDAwcHg7CisgIH0KKyAgI3BsdWdpbiB7CisgICAgcG9zaXRpb246IGFic29sdXRl OworICAgIHRvcDogNTAwcHg7CisgICAgd2lkdGg6IDE1MHB4OworICAgIGhlaWdodDogMTUwcHg7 CisgIH0KKzwvc3R5bGU+Cis8L2hlYWQ+CisKKzxib2R5PgorPGVtYmVkIGlkPSJwbHVnaW4iIHR5 cGU9ImFwcGxpY2F0aW9uL3gtd2Via2l0LXRlc3Qtd2VicGx1Z2luIiBwcmltaXRpdmU9InRyaWFu Z2xlIiBiYWNrZ3JvdW5kLWNvbG9yPSJncmVlbiIgcHJpbWl0aXZlLWNvbG9yPSJibHVlIj48L2Vt YmVkPgorPHNjcmlwdD4KKworICAgIGlmICghd2luZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAg ZG9jdW1lbnQud3JpdGUoIlRoaXMgdGVzdCBkb2VzIG5vdCB3b3JrIGluIG1hbnVhbCBtb2RlLiIp OworICAgIH0gZWxzZSB7CisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworCisgICAg ICAgIC8vIFNjcm9sbCBzbyB0aGUgcGx1Z2luIGlzIDEwMHB4IGRvd24gdGhlIHBhZ2UKKyAgICAg ICAgd2luZG93LnNjcm9sbCgwLCA0MDApOworCisgICAgICAgIC8vIFRoZXNlIGV2ZW50cyBzaG91 bGQgbm90IHJlYWNoIHRoZSBwbHVnaW4gc2luY2UgaXQncyBmdXRoZXIgZG93biBvbiB0aGUgcGFn ZS4KKyAgICAgICAgZXZlbnRTZW5kZXIuZ2VzdHVyZVRhcERvd24oMzAsIDMwKTsKKyAgICAgICAg ZXZlbnRTZW5kZXIuZ2VzdHVyZVRhcERvd24oMzAsIDUzMCk7CisKKyAgICAgICAgLy8gU2VuZCBz b21lIGdlc3R1cmUgZXZlbnRzIHRvIHRoZSBwbHVnaW4uCisgICAgICAgIHZhciBwb3NpdGlvblgg PSAzMDsKKyAgICAgICAgdmFyIHBvc2l0aW9uWSA9IDExMDsKKyAgICAgICAgZXZlbnRTZW5kZXIu Z2VzdHVyZVRhcChwb3NpdGlvblgsIHBvc2l0aW9uWSk7CisgICAgICAgIGV2ZW50U2VuZGVyLmdl c3R1cmVTY3JvbGxCZWdpbihwb3NpdGlvblgsIHBvc2l0aW9uWSk7CisgICAgICAgIGV2ZW50U2Vu ZGVyLmdlc3R1cmVTY3JvbGxVcGRhdGUoMzAsIDApOworICAgICAgICBldmVudFNlbmRlci5nZXN0 dXJlU2Nyb2xsRW5kKDAsIDApOworICAgIH0KKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ Cg==