96782 2012-09-14 07:24:39 -0700 [GTK] Don't use the C API internally in WebKitURIResponse 2012-10-18 05:31:23 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 96781 96766 96783 99705 1 cgarcia webkit-unassigned gustavo mario mrobinson webkit.review.bot oldest_to_newest 720742 0 cgarcia 2012-09-14 07:24:39 -0700 Use the C++ classes instead. 720743 1 164145 cgarcia 2012-09-14 07:26:14 -0700 Created attachment 164145 Patch 720746 2 webkit.review.bot 2012-09-14 07:27:35 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 733449 3 164145 mario 2012-10-03 01:47:07 -0700 Comment on attachment 164145 Patch Looks good to me 745171 4 164145 xan.lopez 2012-10-18 05:12:43 -0700 Comment on attachment 164145 Patch Looks good. 745181 5 cgarcia 2012-10-18 05:31:23 -0700 Committed r131732: <http://trac.webkit.org/changeset/131732> 164145 2012-09-14 07:26:14 -0700 2012-10-18 05:12:43 -0700 Patch wk2-no-c-api-uri-response.diff text/plain 3831 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmZjY2M2ZiLi42YTZhYzE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDktMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIERvbid0IHVzZSB0aGUgQyBBUEkgaW50ZXJuYWxseSBpbiBXZWJL aXRVUklSZXNwb25zZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTY3ODIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBVc2luZyB0aGUgQysrIGNsYXNzZXMgZGlyZWN0bHkgaW5zdGVhZCBvZiB0aGUgQyBBUEkg d3JhcHBlcnMgd2UKKyAgICAgICAgYXZvaWQgYSBsb3Qgb2YgdG9JbXBsL3RvQVBJIGNhc3RzLCBz dHJpbmcgY29udmVyc2lvbnMgYW5kCisgICAgICAgIGFsbG9jYXRpb25zLiBUaGUgY29kZSBpcyBh bHNvIGEgbG90IHNpbXBsZXIgYW5kIGVhc2llciB0byByZWFkLgorCisgICAgICAgICogVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0VVJJUmVzcG9uc2UuY3BwOgorICAgICAgICAod2Via2l0VVJJUmVz cG9uc2VTZXRDZXJ0aWZpY2F0ZUluZm8pOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFVSSVJlc3BvbnNlUHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dl YktpdFdlYlZpZXcuY3BwOgorICAgICAgICAoc2V0Q2VydGlmaWNhdGVUb01haW5SZXNvdXJjZSk6 CisKIDIwMTItMDktMTIgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29t PgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjc4NzYuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRVUklSZXNwb25zZS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRVUklSZXNwb25zZS5jcHAK aW5kZXggMjk4MTFmYy4uZTU0ZDE4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0VVJJUmVzcG9uc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVSSVJlc3BvbnNlLmNwcApAQCAtMzcsNyArMzcsNiBAQCBl bnVtIHsKICAgICBQUk9QX1NVR0dFU1RFRF9GSUxFTkFNRQogfTsKIAotdXNpbmcgbmFtZXNwYWNl IFdlYktpdDsKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBHX0RFRklORV9UWVBFKFdlYktp dFVSSVJlc3BvbnNlLCB3ZWJraXRfdXJpX3Jlc3BvbnNlLCBHX1RZUEVfT0JKRUNUKQpAQCAtMjgy LDkgKzI4MSw5IEBAIGNvbnN0IFdlYkNvcmU6OlJlc291cmNlUmVzcG9uc2UmIHdlYmtpdFVSSVJl c3BvbnNlR2V0UmVzb3VyY2VSZXNwb25zZShXZWJLaXRVUklSCiAgICAgcmV0dXJuIHVyaVJlc3Bv bnNlLT5wcml2LT5yZXNvdXJjZVJlc3BvbnNlOwogfQogCi12b2lkIHdlYmtpdFVSSVJlc3BvbnNl U2V0Q2VydGlmaWNhdGVJbmZvKFdlYktpdFVSSVJlc3BvbnNlKiByZXNwb25zZSwgV0tDZXJ0aWZp Y2F0ZUluZm9SZWYgd2tDZXJ0aWZpY2F0ZSkKK3ZvaWQgd2Via2l0VVJJUmVzcG9uc2VTZXRDZXJ0 aWZpY2F0ZUluZm8oV2ViS2l0VVJJUmVzcG9uc2UqIHJlc3BvbnNlLCBXZWJDZXJ0aWZpY2F0ZUlu Zm8qIGNlcnRpZmljYXRlKQogewotICAgIGNvbnN0IFBsYXRmb3JtQ2VydGlmaWNhdGVJbmZvJiBj ZXJ0aWZpY2F0ZUluZm8gPSB0b0ltcGwod2tDZXJ0aWZpY2F0ZSktPnBsYXRmb3JtQ2VydGlmaWNh dGVJbmZvKCk7CisgICAgY29uc3QgUGxhdGZvcm1DZXJ0aWZpY2F0ZUluZm8mIGNlcnRpZmljYXRl SW5mbyA9IGNlcnRpZmljYXRlLT5wbGF0Zm9ybUNlcnRpZmljYXRlSW5mbygpOwogICAgIHJlc3Bv bnNlLT5wcml2LT5yZXNvdXJjZVJlc3BvbnNlLnNldFNvdXBNZXNzYWdlQ2VydGlmaWNhdGUoY2Vy dGlmaWNhdGVJbmZvLmNlcnRpZmljYXRlKCkpOwogICAgIHJlc3BvbnNlLT5wcml2LT5yZXNvdXJj ZVJlc3BvbnNlLnNldFNvdXBNZXNzYWdlVExTRXJyb3JzKGNlcnRpZmljYXRlSW5mby50bHNFcnJv cnMoKSk7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRVUklSZXNwb25zZVByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv Z3RrL1dlYktpdFVSSVJlc3BvbnNlUHJpdmF0ZS5oCmluZGV4IDk1N2M5Y2UuLjNhNTA2NGQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFVSSVJlc3Bv bnNlUHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktp dFVSSVJlc3BvbnNlUHJpdmF0ZS5oCkBAIC0yOSw4ICsyOSwxMCBAQAogI2luY2x1ZGUgIldlYktp dFVSSVJlc3BvbnNlLmgiCiAjaW5jbHVkZSA8V2ViQ29yZS9SZXNvdXJjZVJlc3BvbnNlLmg+CiAK K3VzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CisKIFdlYktpdFVSSVJlc3BvbnNlKiB3ZWJraXRVUklS ZXNwb25zZUNyZWF0ZUZvclJlc291cmNlUmVzcG9uc2UoY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VS ZXNwb25zZSYpOwogY29uc3QgV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYgd2Via2l0VVJJUmVz cG9uc2VHZXRSZXNvdXJjZVJlc3BvbnNlKFdlYktpdFVSSVJlc3BvbnNlKik7Ci12b2lkIHdlYmtp dFVSSVJlc3BvbnNlU2V0Q2VydGlmaWNhdGVJbmZvKFdlYktpdFVSSVJlc3BvbnNlKiwgV0tDZXJ0 aWZpY2F0ZUluZm9SZWYpOwordm9pZCB3ZWJraXRVUklSZXNwb25zZVNldENlcnRpZmljYXRlSW5m byhXZWJLaXRVUklSZXNwb25zZSosIFdlYkNlcnRpZmljYXRlSW5mbyopOwogCiAjZW5kaWYgLy8g V2ViS2l0VVJJUmVzcG9uc2VQcml2YXRlX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKaW5kZXggY2I2MjhiYS4uYjBlODVmZCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5j cHAKQEAgLTExMDYsNyArMTEwNiw3IEBAIHN0YXRpYyB2b2lkIHNldENlcnRpZmljYXRlVG9NYWlu UmVzb3VyY2UoV2ViS2l0V2ViVmlldyogd2ViVmlldykKICAgICBBU1NFUlQocHJpdi0+bWFpblJl c291cmNlLmdldCgpKTsKIAogICAgIHdlYmtpdFVSSVJlc3BvbnNlU2V0Q2VydGlmaWNhdGVJbmZv KHdlYmtpdF93ZWJfcmVzb3VyY2VfZ2V0X3Jlc3BvbnNlKHByaXYtPm1haW5SZXNvdXJjZS5nZXQo KSksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgV0tGcmFtZUdldENl cnRpZmljYXRlSW5mbyh3ZWJraXRXZWJSZXNvdXJjZUdldEZyYW1lKHByaXYtPm1haW5SZXNvdXJj ZS5nZXQoKSkpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0b0lt cGwoV0tGcmFtZUdldENlcnRpZmljYXRlSW5mbyh3ZWJraXRXZWJSZXNvdXJjZUdldEZyYW1lKHBy aXYtPm1haW5SZXNvdXJjZS5nZXQoKSkpKSk7CiB9CiAKIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZp ZXdFbWl0TG9hZENoYW5nZWQoV2ViS2l0V2ViVmlldyogd2ViVmlldywgV2ViS2l0TG9hZEV2ZW50 IGxvYWRFdmVudCkK