96780 2012-09-14 07:16:10 -0700 [GTK] Don't use the C API internally in WebKitJavascriptResult 2012-09-26 09:51:03 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 96779 96766 96781 1 cgarcia webkit-unassigned gustavo mario mrobinson webkit.review.bot oldest_to_newest 720730 0 cgarcia 2012-09-14 07:16:10 -0700 Use the C++ classes instead. 720733 1 164142 cgarcia 2012-09-14 07:17:24 -0700 Created attachment 164142 Patch 720736 2 webkit.review.bot 2012-09-14 07:20:06 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 728452 3 164142 gustavo 2012-09-26 05:44:39 -0700 Comment on attachment 164142 Patch Not a big saving in this case, but consistency is good =) 728682 4 cgarcia 2012-09-26 09:51:03 -0700 Committed r129661: http://trac.webkit.org/changeset/129661 164142 2012-09-14 07:17:24 -0700 2012-09-26 05:44:39 -0700 Patch wk2-no-c-api-js-result.diff text/plain 4539 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmZjY2M2ZiLi5jNTgyYTZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDktMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIERvbid0IHVzZSB0aGUgQyBBUEkgaW50ZXJuYWxseSBpbiBXZWJL aXRKYXZhc2NyaXB0UmVzdWx0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05Njc4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVzaW5nIHRoZSBDKysgY2xhc3NlcyBkaXJlY3RseSBpbnN0ZWFkIG9mIHRoZSBD IEFQSSB3cmFwcGVycyB3ZQorICAgICAgICBhdm9pZCBhIGxvdCBvZiB0b0ltcGwvdG9BUEkgY2Fz dHMsIHN0cmluZyBjb252ZXJzaW9ucyBhbmQKKyAgICAgICAgYWxsb2NhdGlvbnMuIFRoZSBjb2Rl IGlzIGFsc28gYSBsb3Qgc2ltcGxlciBhbmQgZWFzaWVyIHRvIHJlYWQuCisKKyAgICAgICAgKiBV SVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRKYXZhc2NyaXB0UmVzdWx0LmNwcDoKKyAgICAgICAgKF9X ZWJLaXRKYXZhc2NyaXB0UmVzdWx0OjpfV2ViS2l0SmF2YXNjcmlwdFJlc3VsdCk6CisgICAgICAg ICh3ZWJraXRKYXZhc2NyaXB0UmVzdWx0Q3JlYXRlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXRKYXZhc2NyaXB0UmVzdWx0UHJpdmF0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwOgorICAgICAgICAod2Via2l0V2ViVmlld1J1bkph dmFTY3JpcHRDYWxsYmFjayk6CisKIDIwMTItMDktMTIgIFNoZXJpZmYgQm90ICA8d2Via2l0LnJl dmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIx Mjc4NzYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJL aXRKYXZhc2NyaXB0UmVzdWx0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdEphdmFzY3JpcHRSZXN1bHQuY3BwCmluZGV4IDg0YWQwNGQuLjJhMWI4ZDUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEphdmFzY3JpcHRS ZXN1bHQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEph dmFzY3JpcHRSZXN1bHQuY3BwCkBAIC0yMSwxNSArMjEsMTYgQEAKICNpbmNsdWRlICJXZWJLaXRK YXZhc2NyaXB0UmVzdWx0LmgiCiAKICNpbmNsdWRlICJXZWJLaXRKYXZhc2NyaXB0UmVzdWx0UHJp dmF0ZS5oIgorI2luY2x1ZGUgIldlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5oIgogI2luY2x1ZGUg PHd0Zi9nb2JqZWN0L0dSZWZQdHIuaD4KIAogc3RydWN0IF9XZWJLaXRKYXZhc2NyaXB0UmVzdWx0 IHsKLSAgICBfV2ViS2l0SmF2YXNjcmlwdFJlc3VsdChXZWJLaXRXZWJWaWV3KiB2aWV3LCBXS1Nl cmlhbGl6ZWRTY3JpcHRWYWx1ZVJlZiB3a1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZSkKKyAgICBfV2Vi S2l0SmF2YXNjcmlwdFJlc3VsdChXZWJLaXRXZWJWaWV3KiB2aWV3LCBXZWJTZXJpYWxpemVkU2Ny aXB0VmFsdWUqIHNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSkKICAgICAgICAgOiB3ZWJWaWV3KHZpZXcp CiAgICAgICAgICwgcmVmZXJlbmNlQ291bnQoMSkKLSAgICAgICAgewotICAgICAgICAgICAgdmFs dWUgPSBXS1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZURlc2VyaWFsaXplKHdrU2VyaWFsaXplZFNjcmlw dFZhbHVlLCB3ZWJraXRfd2ViX3ZpZXdfZ2V0X2phdmFzY3JpcHRfZ2xvYmFsX2NvbnRleHQodmll dyksIDApOwotICAgICAgICB9CisgICAgeworICAgICAgICB2YWx1ZSA9IHNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZS0+ZGVzZXJpYWxpemUod2Via2l0X3dlYl92aWV3X2dldF9qYXZhc2NyaXB0X2dsb2Jh bF9jb250ZXh0KHZpZXcpLCAwKTsKKyAgICB9CiAKICAgICBHUmVmUHRyPFdlYktpdFdlYlZpZXc+ IHdlYlZpZXc7CiAgICAgSlNWYWx1ZVJlZiB2YWx1ZTsKQEAgLTM5LDEwICs0MCwxMCBAQCBzdHJ1 Y3QgX1dlYktpdEphdmFzY3JpcHRSZXN1bHQgewogCiBHX0RFRklORV9CT1hFRF9UWVBFKFdlYktp dEphdmFzY3JpcHRSZXN1bHQsIHdlYmtpdF9qYXZhc2NyaXB0X3Jlc3VsdCwgd2Via2l0X2phdmFz Y3JpcHRfcmVzdWx0X3JlZiwgd2Via2l0X2phdmFzY3JpcHRfcmVzdWx0X3VucmVmKQogCi1XZWJL aXRKYXZhc2NyaXB0UmVzdWx0KiB3ZWJraXRKYXZhc2NyaXB0UmVzdWx0Q3JlYXRlKFdlYktpdFdl YlZpZXcqIHdlYlZpZXcsIFdLU2VyaWFsaXplZFNjcmlwdFZhbHVlUmVmIHdrU2VyaWFsaXplZFNj cmlwdFZhbHVlKQorV2ViS2l0SmF2YXNjcmlwdFJlc3VsdCogd2Via2l0SmF2YXNjcmlwdFJlc3Vs dENyZWF0ZShXZWJLaXRXZWJWaWV3KiB3ZWJWaWV3LCBXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUq IHNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSkKIHsKICAgICBXZWJLaXRKYXZhc2NyaXB0UmVzdWx0KiBy ZXN1bHQgPSBnX3NsaWNlX25ldyhXZWJLaXRKYXZhc2NyaXB0UmVzdWx0KTsKLSAgICBuZXcgKHJl c3VsdCkgV2ViS2l0SmF2YXNjcmlwdFJlc3VsdCh3ZWJWaWV3LCB3a1NlcmlhbGl6ZWRTY3JpcHRW YWx1ZSk7CisgICAgbmV3IChyZXN1bHQpIFdlYktpdEphdmFzY3JpcHRSZXN1bHQod2ViVmlldywg c2VyaWFsaXplZFNjcmlwdFZhbHVlKTsKICAgICByZXR1cm4gcmVzdWx0OwogfQogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRKYXZhc2NyaXB0UmVz dWx0UHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0SmF2 YXNjcmlwdFJlc3VsdFByaXZhdGUuaAppbmRleCA4NDBlYWQwLi5hYzc1Nzg4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRKYXZhc2NyaXB0UmVzdWx0 UHJpdmF0ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEph dmFzY3JpcHRSZXN1bHRQcml2YXRlLmgKQEAgLTI0LDYgKzI0LDggQEAKICNpbmNsdWRlICJXZWJL aXRQcml2YXRlLmgiCiAjaW5jbHVkZSAiV2ViS2l0V2ViVmlldy5oIgogCi1XZWJLaXRKYXZhc2Ny aXB0UmVzdWx0KiB3ZWJraXRKYXZhc2NyaXB0UmVzdWx0Q3JlYXRlKFdlYktpdFdlYlZpZXcqLCBX S1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZVJlZik7Cit1c2luZyBuYW1lc3BhY2UgV2ViS2l0OworCitX ZWJLaXRKYXZhc2NyaXB0UmVzdWx0KiB3ZWJraXRKYXZhc2NyaXB0UmVzdWx0Q3JlYXRlKFdlYktp dFdlYlZpZXcqLCBXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUqKTsKIAogI2VuZGlmIC8vIFdlYktp dEphdmFzY3JpcHRSZXN1bHRQcml2YXRlX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKaW5kZXggNmJmNjE3ZS4uYmRiMjc0YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5j cHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5j cHAKQEAgLTIxMjcsNyArMjEyNyw3IEBAIHN0YXRpYyB2b2lkIHdlYmtpdFdlYlZpZXdSdW5KYXZh U2NyaXB0Q2FsbGJhY2soV0tTZXJpYWxpemVkU2NyaXB0VmFsdWVSZWYgd2tTZXJpCiAgICAgICAg IGdfc2ltcGxlX2FzeW5jX3Jlc3VsdF90YWtlX2Vycm9yKHJlc3VsdC5nZXQoKSwgZXJyb3IpOwog ICAgIGVsc2UgaWYgKHdrU2VyaWFsaXplZFNjcmlwdFZhbHVlKSB7CiAgICAgICAgIEdSZWZQdHI8 V2ViS2l0V2ViVmlldz4gd2ViVmlldyA9IGFkb3B0R1JlZihXRUJLSVRfV0VCX1ZJRVcoZ19hc3lu Y19yZXN1bHRfZ2V0X3NvdXJjZV9vYmplY3QoR19BU1lOQ19SRVNVTFQocmVzdWx0LmdldCgpKSkp KTsKLSAgICAgICAgZGF0YS0+c2NyaXB0UmVzdWx0ID0gd2Via2l0SmF2YXNjcmlwdFJlc3VsdENy ZWF0ZSh3ZWJWaWV3LmdldCgpLCB3a1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZSk7CisgICAgICAgIGRh dGEtPnNjcmlwdFJlc3VsdCA9IHdlYmtpdEphdmFzY3JpcHRSZXN1bHRDcmVhdGUod2ViVmlldy5n ZXQoKSwgdG9JbXBsKHdrU2VyaWFsaXplZFNjcmlwdFZhbHVlKSk7CiAgICAgfSBlbHNlIHsKICAg ICAgICAgZ19zZXRfZXJyb3JfbGl0ZXJhbCgmZXJyb3IsIFdFQktJVF9KQVZBU0NSSVBUX0VSUk9S LCBXRUJLSVRfSkFWQVNDUklQVF9FUlJPUl9TQ1JJUFRfRkFJTEVELCBfKCJBbiBleGNlcHRpb24g d2FzIHJhaXNlZCBpbiBKYXZhU2NyaXB0IikpOwogICAgICAgICBnX3NpbXBsZV9hc3luY19yZXN1 bHRfdGFrZV9lcnJvcihyZXN1bHQuZ2V0KCksIGVycm9yKTsK