96773 2012-09-14 06:56:05 -0700 [GTK] Don't use the C API internally in WebKitDownload 2012-10-17 09:00:39 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 96772 96766 96774 1 cgarcia webkit-unassigned mario oldest_to_newest 720702 0 cgarcia 2012-09-14 06:56:05 -0700 Use the C++ classes instead. 720703 1 164133 cgarcia 2012-09-14 06:57:28 -0700 Created attachment 164133 Patch 733438 2 164133 mario 2012-10-03 01:35:38 -0700 Comment on attachment 164133 Patch Looks good to me 744288 3 cgarcia 2012-10-17 09:00:39 -0700 Committed r131608: <http://trac.webkit.org/changeset/131608> 164133 2012-09-14 06:57:28 -0700 2012-10-17 06:39:51 -0700 Patch wk2-no-c-api-download.diff text/plain 4913 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmZjY2M2ZiLi4yZmE0ZTdhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDEyLTA5LTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBEb24ndCB1c2UgdGhlIEMgQVBJIGludGVybmFsbHkgaW4gV2Vi S2l0RG93bmxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk2NzczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVXNpbmcgdGhlIEMrKyBjbGFzc2VzIGRpcmVjdGx5IGluc3RlYWQgb2YgdGhlIEMgQVBJIHdy YXBwZXJzIHdlCisgICAgICAgIGF2b2lkIGEgbG90IG9mIHRvSW1wbC90b0FQSSBjYXN0cywgc3Ry aW5nIGNvbnZlcnNpb25zIGFuZAorICAgICAgICBhbGxvY2F0aW9ucy4gVGhlIGNvZGUgaXMgYWxz byBhIGxvdCBzaW1wbGVyIGFuZCBlYXNpZXIgdG8gcmVhZC4KKworICAgICAgICAqIFVJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdERvd25sb2FkLmNwcDoKKyAgICAgICAgKF9XZWJLaXREb3dubG9hZFBy aXZhdGUpOgorICAgICAgICAod2Via2l0RG93bmxvYWRDcmVhdGUpOgorICAgICAgICAod2Via2l0 X2Rvd25sb2FkX2dldF9yZXF1ZXN0KToKKyAgICAgICAgKHdlYmtpdF9kb3dubG9hZF9jYW5jZWwp OgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdERvd25sb2FkUHJpdmF0ZS5oOgor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuY3BwOgorICAgICAg ICAod2Via2l0X3dlYl9jb250ZXh0X2Rvd25sb2FkX3VyaSk6CisgICAgICAgICh3ZWJraXRXZWJD b250ZXh0R2V0T3JDcmVhdGVEb3dubG9hZCk6CisKIDIwMTItMDktMTIgIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIxMjc4NzYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L2d0ay9XZWJLaXREb3dubG9hZC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0 ay9XZWJLaXREb3dubG9hZC5jcHAKaW5kZXggYWEyNjIzNy4uNjIwYWM5NiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93bmxvYWQuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdERvd25sb2FkLmNwcApAQCAt MzEsNyArMzEsNiBAQAogI2luY2x1ZGUgPHd0Zi9nb2JqZWN0L0dPd25QdHIuaD4KICNpbmNsdWRl IDx3dGYvZ29iamVjdC9HUmVmUHRyLmg+CiAKLXVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB1c2lu ZyBuYW1lc3BhY2UgV2ViQ29yZTsKIAogZW51bSB7CkBAIC01Myw3ICs1Miw3IEBAIGVudW0gewog fTsKIAogc3RydWN0IF9XZWJLaXREb3dubG9hZFByaXZhdGUgewotICAgIFdLUmV0YWluUHRyPFdL RG93bmxvYWRSZWY+IHdrRG93bmxvYWQ7CisgICAgUmVmUHRyPERvd25sb2FkUHJveHk+IGRvd25s b2FkOwogCiAgICAgR1JlZlB0cjxXZWJLaXRVUklSZXF1ZXN0PiByZXF1ZXN0OwogICAgIEdSZWZQ dHI8V2ViS2l0VVJJUmVzcG9uc2U+IHJlc3BvbnNlOwpAQCAtMjY0LDExICsyNjMsMTEgQEAgc3Rh dGljIHZvaWQgd2Via2l0X2Rvd25sb2FkX2NsYXNzX2luaXQoV2ViS2l0RG93bmxvYWRDbGFzcyog ZG93bmxvYWRDbGFzcykKICAgICBnX3R5cGVfY2xhc3NfYWRkX3ByaXZhdGUoZG93bmxvYWRDbGFz cywgc2l6ZW9mKFdlYktpdERvd25sb2FkUHJpdmF0ZSkpOwogfQogCi1XZWJLaXREb3dubG9hZCog d2Via2l0RG93bmxvYWRDcmVhdGUoV0tEb3dubG9hZFJlZiB3a0Rvd25sb2FkKQorV2ViS2l0RG93 bmxvYWQqIHdlYmtpdERvd25sb2FkQ3JlYXRlKERvd25sb2FkUHJveHkqIGRvd25sb2FkUHJveHkp CiB7Ci0gICAgQVNTRVJUKHdrRG93bmxvYWQpOworICAgIEFTU0VSVChkb3dubG9hZFByb3h5KTsK ICAgICBXZWJLaXREb3dubG9hZCogZG93bmxvYWQgPSBXRUJLSVRfRE9XTkxPQUQoZ19vYmplY3Rf bmV3KFdFQktJVF9UWVBFX0RPV05MT0FELCBOVUxMKSk7Ci0gICAgZG93bmxvYWQtPnByaXYtPndr RG93bmxvYWQgPSB3a0Rvd25sb2FkOworICAgIGRvd25sb2FkLT5wcml2LT5kb3dubG9hZCA9IGRv d25sb2FkUHJveHk7CiAgICAgcmV0dXJuIGRvd25sb2FkOwogfQogCkBAIC0zNzksOCArMzc4LDgg QEAgV2ViS2l0VVJJUmVxdWVzdCogd2Via2l0X2Rvd25sb2FkX2dldF9yZXF1ZXN0KFdlYktpdERv d25sb2FkKiBkb3dubG9hZCkKIAogICAgIFdlYktpdERvd25sb2FkUHJpdmF0ZSogcHJpdiA9IGRv d25sb2FkLT5wcml2OwogICAgIGlmICghcHJpdi0+cmVxdWVzdCkKLSAgICAgICAgcHJpdi0+cmVx dWVzdCA9IGFkb3B0R1JlZih3ZWJraXRVUklSZXF1ZXN0Q3JlYXRlRm9yUmVzb3VyY2VSZXF1ZXN0 KHRvSW1wbChwcml2LT53a0Rvd25sb2FkLmdldCgpKS0+cmVxdWVzdCgpKSk7Ci0gICAgcmV0dXJu IGRvd25sb2FkLT5wcml2LT5yZXF1ZXN0LmdldCgpOworICAgICAgICBwcml2LT5yZXF1ZXN0ID0g YWRvcHRHUmVmKHdlYmtpdFVSSVJlcXVlc3RDcmVhdGVGb3JSZXNvdXJjZVJlcXVlc3QocHJpdi0+ ZG93bmxvYWQtPnJlcXVlc3QoKSkpOworICAgIHJldHVybiBwcml2LT5yZXF1ZXN0LmdldCgpOwog fQogCiAvKioKQEAgLTQ2NSw3ICs0NjQsNyBAQCB2b2lkIHdlYmtpdF9kb3dubG9hZF9jYW5jZWwo V2ViS2l0RG93bmxvYWQqIGRvd25sb2FkKQogICAgIGdfcmV0dXJuX2lmX2ZhaWwoV0VCS0lUX0lT X0RPV05MT0FEKGRvd25sb2FkKSk7CiAKICAgICBkb3dubG9hZC0+cHJpdi0+aXNDYW5jZWxsZWQg PSB0cnVlOwotICAgIFdLRG93bmxvYWRDYW5jZWwoZG93bmxvYWQtPnByaXYtPndrRG93bmxvYWQu Z2V0KCkpOworICAgIGRvd25sb2FkLT5wcml2LT5kb3dubG9hZC0+Y2FuY2VsKCk7CiB9CiAKIC8q KgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0RG93 bmxvYWRQcml2YXRlLmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRE b3dubG9hZFByaXZhdGUuaAppbmRleCA2ZjRiNTM2Li5jZTQyOWQyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3dubG9hZFByaXZhdGUuaAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3dubG9hZFByaXZhdGUu aApAQCAtMjUsNyArMjUsOSBAQAogI2luY2x1ZGUgPFdlYkNvcmUvUmVzb3VyY2VFcnJvci5oPgog I2luY2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAotV2ViS2l0RG93bmxvYWQqIHdlYmtpdERv d25sb2FkQ3JlYXRlKFdLRG93bmxvYWRSZWYpOwordXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKKwor V2ViS2l0RG93bmxvYWQqIHdlYmtpdERvd25sb2FkQ3JlYXRlKERvd25sb2FkUHJveHkqKTsKIGJv b2wgd2Via2l0RG93bmxvYWRJc0NhbmNlbGxlZChXZWJLaXREb3dubG9hZCopOwogdm9pZCB3ZWJr aXREb3dubG9hZFNldFJlc3BvbnNlKFdlYktpdERvd25sb2FkKiwgV2ViS2l0VVJJUmVzcG9uc2Uq KTsKIHZvaWQgd2Via2l0RG93bmxvYWROb3RpZnlQcm9ncmVzcyhXZWJLaXREb3dubG9hZCosIGd1 aW50NjQgYnl0ZXNSZWNlaXZlZCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2d0ay9XZWJLaXRXZWJDb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRleHQuY3BwCmluZGV4IGIwMzZkZTkuLjYzZTU5ZDMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNvbnRl eHQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYkNv bnRleHQuY3BwCkBAIC0yOTMsNyArMjkzLDcgQEAgV2ViS2l0RG93bmxvYWQqIHdlYmtpdF93ZWJf Y29udGV4dF9kb3dubG9hZF91cmkoV2ViS2l0V2ViQ29udGV4dCogY29udGV4dCwgY29uc3QKICAg ICBnX3JldHVybl92YWxfaWZfZmFpbCh1cmksIDApOwogCiAgICAgRG93bmxvYWRQcm94eSogZG93 bmxvYWRQcm94eSA9IGNvbnRleHQtPnByaXYtPmNvbnRleHQtPmRvd25sb2FkKDAsIFdlYkNvcmU6 OlJlc291cmNlUmVxdWVzdChTdHJpbmc6OmZyb21VVEY4KHVyaSkpKTsKLSAgICBXZWJLaXREb3du bG9hZCogZG93bmxvYWQgPSB3ZWJraXREb3dubG9hZENyZWF0ZSh0b0FQSShkb3dubG9hZFByb3h5 KSk7CisgICAgV2ViS2l0RG93bmxvYWQqIGRvd25sb2FkID0gd2Via2l0RG93bmxvYWRDcmVhdGUo ZG93bmxvYWRQcm94eSk7CiAgICAgZG93bmxvYWRzTWFwKCkuc2V0KGRvd25sb2FkUHJveHksIGRv d25sb2FkKTsKICAgICByZXR1cm4gZG93bmxvYWQ7CiB9CkBAIC01NjcsNyArNTY3LDcgQEAgV2Vi S2l0RG93bmxvYWQqIHdlYmtpdFdlYkNvbnRleHRHZXRPckNyZWF0ZURvd25sb2FkKERvd25sb2Fk UHJveHkqIGRvd25sb2FkUHJveHkKICAgICBpZiAoZG93bmxvYWQpCiAgICAgICAgIHJldHVybiBk b3dubG9hZC5nZXQoKTsKIAotICAgIGRvd25sb2FkID0gYWRvcHRHUmVmKHdlYmtpdERvd25sb2Fk Q3JlYXRlKHRvQVBJKGRvd25sb2FkUHJveHkpKSk7CisgICAgZG93bmxvYWQgPSBhZG9wdEdSZWYo d2Via2l0RG93bmxvYWRDcmVhdGUoZG93bmxvYWRQcm94eSkpOwogICAgIGRvd25sb2Fkc01hcCgp LnNldChkb3dubG9hZFByb3h5LCBkb3dubG9hZC5nZXQoKSk7CiAgICAgcmV0dXJuIGRvd25sb2Fk LmdldCgpOwogfQo=