96771 2012-09-14 06:49:15 -0700 [BlackBerry] Use glDeleteProgram to delete OpenGL shader programs 2012-09-17 08:05:52 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 fspacek webkit-unassigned anilsson mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 720697 0 fspacek 2012-09-14 06:49:15 -0700 We need to use glDeleteProgram instead of glDeleteShader. Change the name of the variable at the same time. 720699 1 164131 fspacek 2012-09-14 06:50:59 -0700 Created attachment 164131 patch 721902 2 anilsson 2012-09-17 07:22:05 -0700 LGTM 721920 3 164131 rwlbuis 2012-09-17 07:48:44 -0700 Comment on attachment 164131 patch Looks good. 721941 4 164131 webkit.review.bot 2012-09-17 08:05:48 -0700 Comment on attachment 164131 patch Clearing flags on attachment: 164131 Committed r128760: <http://trac.webkit.org/changeset/128760> 721942 5 webkit.review.bot 2012-09-17 08:05:52 -0700 All reviewed patches have been landed. Closing bug. 164131 2012-09-14 06:50:59 -0700 2012-09-17 08:05:48 -0700 patch patch.patch text/plain 5460 fspacek Y29tbWl0IDI0OTJhYjRjNjc5NDBjZDlhYzI2ZTFiZGRiYjBlNDk3ZWIzODViMjIKQXV0aG9yOiBG aWxpcCBTcGFjZWsgPGZzcGFjZWtAcmltLmNvbT4KRGF0ZTogICBGcmkgU2VwIDE0IDA5OjEwOjUz IDIwMTIgLTA0MDAKCiAgICAyMDEyLTA5LTE0ICBGaWxpcCBTcGFjZWsgIDxmc3BhY2VrQHJpbS5j b20+CiAgICAKICAgICAgICAgICAgVXNlIGdsRGVsZXRlUHJvZ3JhbSB0byBkZWxldGUgT3BlbkdM IHNoYWRlciBwcm9ncmFtcy4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBpbnRlcm5hbGx5IGJ5IEFydmlkIE5pbHNz b24uCiAgICAKICAgICAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0VHTElt YWdlTGF5ZXJXZWJLaXRUaHJlYWQuY3BwOgogICAgICAgICAgICAoV2ViQ29yZTo6RUdMSW1hZ2VM YXllcldlYktpdFRocmVhZDo6RUdMSW1hZ2VMYXllcldlYktpdFRocmVhZCk6CiAgICAgICAgICAg IChXZWJDb3JlOjpFR0xJbWFnZUxheWVyV2ViS2l0VGhyZWFkOjp+RUdMSW1hZ2VMYXllcldlYktp dFRocmVhZCk6CiAgICAgICAgICAgIChXZWJDb3JlOjpFR0xJbWFnZUxheWVyV2ViS2l0VGhyZWFk OjpkZWxldGVGcm9udEJ1ZmZlcik6CiAgICAgICAgICAgIChXZWJDb3JlOjpFR0xJbWFnZUxheWVy V2ViS2l0VGhyZWFkOjpjcmVhdGVTaGFkZXJJZk5lZWRlZCk6CiAgICAgICAgICAgIChXZWJDb3Jl OjpFR0xJbWFnZUxheWVyV2ViS2l0VGhyZWFkOjpibGl0VG9Gcm9udEJ1ZmZlcik6CiAgICAgICAg ICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9FR0xJbWFnZUxheWVyV2ViS2l0VGhy ZWFkLmg6CiAgICAgICAgICAgIChFR0xJbWFnZUxheWVyV2ViS2l0VGhyZWFkKToKCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK aW5kZXggMTdhNjY4Zi4uZTJjYjhkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEy LTA5LTE0ICBGaWxpcCBTcGFjZWsgIDxmc3BhY2VrQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNr QmVycnldIFVzZSBnbERlbGV0ZVByb2dyYW0gdG8gZGVsZXRlIE9wZW5HTCBzaGFkZXIgcHJvZ3Jh bXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05Njc3 MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldmll d2VkIGludGVybmFsbHkgYnkgQXJ2aWQgTmlsc3Nvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2JsYWNrYmVycnkvRUdMSW1hZ2VMYXllcldlYktpdFRocmVhZC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpFR0xJbWFnZUxheWVyV2ViS2l0VGhyZWFkOjpFR0xJbWFnZUxheWVyV2ViS2l0 VGhyZWFkKToKKyAgICAgICAgKFdlYkNvcmU6OkVHTEltYWdlTGF5ZXJXZWJLaXRUaHJlYWQ6On5F R0xJbWFnZUxheWVyV2ViS2l0VGhyZWFkKToKKyAgICAgICAgKFdlYkNvcmU6OkVHTEltYWdlTGF5 ZXJXZWJLaXRUaHJlYWQ6OmRlbGV0ZUZyb250QnVmZmVyKToKKyAgICAgICAgKFdlYkNvcmU6OkVH TEltYWdlTGF5ZXJXZWJLaXRUaHJlYWQ6OmNyZWF0ZVNoYWRlcklmTmVlZGVkKToKKyAgICAgICAg KFdlYkNvcmU6OkVHTEltYWdlTGF5ZXJXZWJLaXRUaHJlYWQ6OmJsaXRUb0Zyb250QnVmZmVyKToK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0VHTEltYWdlTGF5ZXJXZWJL aXRUaHJlYWQuaDoKKyAgICAgICAgKEVHTEltYWdlTGF5ZXJXZWJLaXRUaHJlYWQpOgorCiAyMDEy LTA5LTEyICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNr QmVycnldIEFkZCBjdXN0b20gbWVzc2FnZXMgZm9yIGlucHV0IHR5cGUgdmFsaWRhdGlvbi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvRUdM SW1hZ2VMYXllcldlYktpdFRocmVhZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9ibGFja2JlcnJ5L0VHTEltYWdlTGF5ZXJXZWJLaXRUaHJlYWQuY3BwCmluZGV4IDhjNWI3 MjQuLjg5MjBlOTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2JsYWNrYmVycnkvRUdMSW1hZ2VMYXllcldlYktpdFRocmVhZC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYmxhY2tiZXJyeS9FR0xJbWFnZUxheWVyV2ViS2l0VGhy ZWFkLmNwcApAQCAtNDUsNyArNDUsNyBAQCBFR0xJbWFnZUxheWVyV2ViS2l0VGhyZWFkOjpFR0xJ bWFnZUxheWVyV2ViS2l0VGhyZWFkKExheWVyVHlwZSB0eXBlKQogICAgICwgbV9uZWVkc0Rpc3Bs YXkoZmFsc2UpCiAgICAgLCBtX2Zyb250QnVmZmVyVGV4dHVyZSgwKQogICAgICwgbV9mYm8oMCkK LSAgICAsIG1fc2hhZGVyKDApCisgICAgLCBtX3Byb2dyYW0oMCkKICAgICAsIG1faW1hZ2UoMCkK IHsKICAgICBsYXllckNvbXBvc2l0aW5nVGhyZWFkKCktPnNldENsaWVudChtX2NsaWVudC5nZXQo KSk7CkBAIC01OCw3ICs1OCw3IEBAIEVHTEltYWdlTGF5ZXJXZWJLaXRUaHJlYWQ6On5FR0xJbWFn ZUxheWVyV2ViS2l0VGhyZWFkKCkKICAgICAvLyBiZWZvcmUgd2UgZ2V0IHRoaXMgZmFyLgogICAg IEFTU0VSVCghbV9mcm9udEJ1ZmZlclRleHR1cmUpOwogICAgIEFTU0VSVCghbV9mYm8pOwotICAg IEFTU0VSVCghbV9zaGFkZXIpOworICAgIEFTU0VSVCghbV9wcm9ncmFtKTsKICAgICBBU1NFUlQo IW1faW1hZ2UpOwogfQogCkBAIC0xMjMsOCArMTIzLDggQEAgdm9pZCBFR0xJbWFnZUxheWVyV2Vi S2l0VGhyZWFkOjpkZWxldGVGcm9udEJ1ZmZlcigpCiAgICAgbV9mcm9udEJ1ZmZlclRleHR1cmUg PSAwOwogICAgIGdsRGVsZXRlRnJhbWVidWZmZXJzKDEsICZtX2Zibyk7CiAgICAgbV9mYm8gPSAw OwotICAgIGdsRGVsZXRlU2hhZGVyKG1fc2hhZGVyKTsKLSAgICBtX3NoYWRlciA9IDA7CisgICAg Z2xEZWxldGVQcm9ncmFtKG1fcHJvZ3JhbSk7CisgICAgbV9wcm9ncmFtID0gMDsKIAogICAgIC8v IFRoZSBpbWFnZSBpcyBpbiBvdXIgRUdMSW1hZ2VMYXllckNvbXBvc2l0aW5nVGhyZWFkQ2xpZW50 J3MgY3VzdG9keQogICAgIC8vIGF0IHRoaXMgcG9pbnQsIGFuZCB0aGF0IG9iamVjdCBpcyByZXNw b25zaWJsZSBmb3IgZGVsZXRpbmcgaXQuCkBAIC0yMTYsMTUgKzIxNiwxNSBAQCB2b2lkIEVHTElt YWdlTGF5ZXJXZWJLaXRUaHJlYWQ6OmNyZWF0ZVNoYWRlcklmTmVlZGVkKCkKICAgICAgICAgIiAg Z2xfRnJhZ0NvbG9yID0gdGV4dHVyZTJEKHNfdGV4dHVyZSwgdl90ZXhDb29yZCk7IFxuIgogICAg ICAgICAifSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg XG4iOwogCi0gICAgaWYgKCFtX3NoYWRlcikgewotICAgICAgICBtX3NoYWRlciA9IExheWVyUmVu ZGVyZXI6OmxvYWRTaGFkZXJQcm9ncmFtKHZlcnRleFNoYWRlclN0cmluZywgZnJhZ21lbnRTaGFk ZXJTdHJpbmdSR0JBKTsKLSAgICAgICAgaWYgKCFtX3NoYWRlcikKKyAgICBpZiAoIW1fcHJvZ3Jh bSkgeworICAgICAgICBtX3Byb2dyYW0gPSBMYXllclJlbmRlcmVyOjpsb2FkU2hhZGVyUHJvZ3Jh bSh2ZXJ0ZXhTaGFkZXJTdHJpbmcsIGZyYWdtZW50U2hhZGVyU3RyaW5nUkdCQSk7CisgICAgICAg IGlmICghbV9wcm9ncmFtKQogICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICBnbEJpbmRBdHRy aWJMb2NhdGlvbihtX3NoYWRlciwgR0xFUzJQcm9ncmFtOjpQb3NpdGlvbkF0dHJpYnV0ZUluZGV4 LCAiYV9wb3NpdGlvbiIpOwotICAgICAgICBnbEJpbmRBdHRyaWJMb2NhdGlvbihtX3NoYWRlciwg R0xFUzJQcm9ncmFtOjpUZXhDb29yZEF0dHJpYnV0ZUluZGV4LCAiYV90ZXhDb29yZCIpOwotICAg ICAgICBnbExpbmtQcm9ncmFtKG1fc2hhZGVyKTsKLSAgICAgICAgdW5zaWduZWQgc2FtcGxlckxv Y2F0aW9uID0gZ2xHZXRVbmlmb3JtTG9jYXRpb24obV9zaGFkZXIsICJzX3RleHR1cmUiKTsKLSAg ICAgICAgZ2xVc2VQcm9ncmFtKG1fc2hhZGVyKTsKKyAgICAgICAgZ2xCaW5kQXR0cmliTG9jYXRp b24obV9wcm9ncmFtLCBHTEVTMlByb2dyYW06OlBvc2l0aW9uQXR0cmlidXRlSW5kZXgsICJhX3Bv c2l0aW9uIik7CisgICAgICAgIGdsQmluZEF0dHJpYkxvY2F0aW9uKG1fcHJvZ3JhbSwgR0xFUzJQ cm9ncmFtOjpUZXhDb29yZEF0dHJpYnV0ZUluZGV4LCAiYV90ZXhDb29yZCIpOworICAgICAgICBn bExpbmtQcm9ncmFtKG1fcHJvZ3JhbSk7CisgICAgICAgIHVuc2lnbmVkIHNhbXBsZXJMb2NhdGlv biA9IGdsR2V0VW5pZm9ybUxvY2F0aW9uKG1fcHJvZ3JhbSwgInNfdGV4dHVyZSIpOworICAgICAg ICBnbFVzZVByb2dyYW0obV9wcm9ncmFtKTsKICAgICAgICAgZ2xVbmlmb3JtMWkoc2FtcGxlckxv Y2F0aW9uLCAwKTsKICAgICB9CiB9CkBAIC0yNTUsNyArMjU1LDcgQEAgdm9pZCBFR0xJbWFnZUxh eWVyV2ViS2l0VGhyZWFkOjpibGl0VG9Gcm9udEJ1ZmZlcih1bnNpZ25lZCBiYWNrQnVmZmVyVGV4 dHVyZSkKIAogICAgIGdsVmlld3BvcnQoMCwgMCwgbV9zaXplLndpZHRoKCksIG1fc2l6ZS5oZWln aHQoKSk7CiAgICAgZ2xCaW5kRnJhbWVidWZmZXIoR0xfRlJBTUVCVUZGRVIsIG1fZmJvKTsKLSAg ICBnbFVzZVByb2dyYW0obV9zaGFkZXIpOworICAgIGdsVXNlUHJvZ3JhbShtX3Byb2dyYW0pOwog ICAgIGdsQmluZFRleHR1cmUoR0xfVEVYVFVSRV8yRCwgYmFja0J1ZmZlclRleHR1cmUpOwogICAg IGdsQ29sb3JNYXNrKHRydWUsIHRydWUsIHRydWUsIHRydWUpOwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ibGFja2JlcnJ5L0VHTEltYWdlTGF5ZXJXZWJL aXRUaHJlYWQuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkv RUdMSW1hZ2VMYXllcldlYktpdFRocmVhZC5oCmluZGV4IGYyNTYxZmMuLjdmODQyZTkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2JsYWNrYmVycnkvRUdMSW1h Z2VMYXllcldlYktpdFRocmVhZC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2JsYWNrYmVycnkvRUdMSW1hZ2VMYXllcldlYktpdFRocmVhZC5oCkBAIC01Niw3ICs1Niw3 IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX25lZWRzRGlzcGxheTsKICAgICB1bnNpZ25lZCBtX2Zy b250QnVmZmVyVGV4dHVyZTsKICAgICB1bnNpZ25lZCBtX2ZibzsKLSAgICB1bnNpZ25lZCBtX3No YWRlcjsKKyAgICB1bnNpZ25lZCBtX3Byb2dyYW07CiAgICAgdm9pZCogbV9pbWFnZTsKICAgICBW ZWN0b3I8dm9pZCo+IG1fZ2FyYmFnZTsKICAgICBJbnRTaXplIG1fc2l6ZTsK