96758 2012-09-14 05:09:25 -0700 Web Inspector: Get rid of setting values to innerHTML in inspector front-end. 2012-09-14 05:42:30 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 720609 0 vsevik 2012-09-14 05:09:25 -0700 existing occurrences: Source/WebCore/inspector/front-end/RequestHTMLView.js: iframe.contentDocument.body.innerHTML = this.request.content; This one is valid - this iframe is sandboxed. Source/WebCore/inspector/front-end/WebGLProfileView.js: this._traceLogElement.innerHTML = ""; Source/WebCore/inspector/front-end/cm/codemirror.js: // Check for problem with IE innerHTML not working when we have a Source/WebCore/inspector/front-end/cm/codemirror.js: e = new Error("A CodeMirror inside a P-style element does not work in Internet Explorer. (innerHTML bug)"); Source/WebCore/inspector/front-end/cm/codemirror.js: markerElement.innerHTML = text; Source/WebCore/inspector/front-end/cm/codemirror.js: e.innerHTML = ""; Source/WebCore/inspector/front-end/cm/codemirror.js: e.innerHTML = ""; Patch to follow 720610 1 164111 vsevik 2012-09-14 05:10:35 -0700 Created attachment 164111 Patch 720639 2 164111 webkit.review.bot 2012-09-14 05:42:27 -0700 Comment on attachment 164111 Patch Clearing flags on attachment: 164111 Committed r128595: <http://trac.webkit.org/changeset/128595> 720640 3 webkit.review.bot 2012-09-14 05:42:30 -0700 All reviewed patches have been landed. Closing bug. 164111 2012-09-14 05:10:35 -0700 2012-09-14 05:42:27 -0700 Patch bug-96758-20120914161006.patch text/plain 1525 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NTg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjE1MmI5NWQ0ZmJjMDU2 NmQ5OTgwZDA5NDljYWY3M2I0YzgzNGVmZC4uMWNkMDVjNGIxMzhjNGI1YzdmOTMxMmU0YmZkNTk0 NDkyMGIyYTZmNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDEyLTA5LTE0ICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEdldCByaWQgb2Ygc2V0dGluZyB2YWx1ZXMgdG8gaW5uZXJIVE1MIGluIGluc3BlY3RvciBm cm9udC1lbmQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05Njc1OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlbW92ZWQgaW5uZXJIVE1MIGZyb20gV2ViR0xQcm9maWxlVmlldy4KKworICAgICAgICAqIGlu c3BlY3Rvci9mcm9udC1lbmQvV2ViR0xQcm9maWxlVmlldy5qczoKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5XZWJHTFByb2ZpbGVWaWV3LnByb3RvdHlwZS5fc2hvd1RyYWNlTG9nKToKKworMjAxMi0w OS0xNCAgVnNldm9sb2QgVmxhc292ICA8dnNldmlrQGNocm9taXVtLm9yZz4KKwogICAgICAgICBV bnJldmlld2VkIHIxMjg1ODAgZm9sbG93IHVwOiBmaXhlZCBxdCBtaW5pbWFsIGNvbXBpbGF0aW9u LgogCiAgICAgICAgICogbG9hZGVyL0RvY3VtZW50VGhyZWFkYWJsZUxvYWRlci5jcHA6CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1dlYkdMUHJvZmlsZVZp ZXcuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1dlYkdMUHJvZmlsZVZp ZXcuanMKaW5kZXggYTUwNGY2M2VlZTZjMDVkZGFjZTY1MTA0ZTAxYmQ5YjFkNDdmMWRhZi4uNjAy ODUzNmM4ODIxMTQzMGViYTg5NzlhZGM2Y2EzNThmYzYwMDIwYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9XZWJHTFByb2ZpbGVWaWV3LmpzCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvV2ViR0xQcm9maWxlVmlldy5qcwpAQCAt OTksNyArOTksNyBAQCBXZWJJbnNwZWN0b3IuV2ViR0xQcm9maWxlVmlldy5wcm90b3R5cGUgPSB7 CiAgICAgewogICAgICAgICBmdW5jdGlvbiBkaWRSZWNlaXZlVHJhY2VMb2coZXJyb3IsIHRyYWNl TG9nKQogICAgICAgICB7Ci0gICAgICAgICAgICB0aGlzLl90cmFjZUxvZ0VsZW1lbnQuaW5uZXJI VE1MID0gIiI7CisgICAgICAgICAgICB0aGlzLl90cmFjZUxvZ0VsZW1lbnQudGV4dENvbnRlbnQg PSAiIjsKICAgICAgICAgICAgIGlmICghdHJhY2VMb2cpCiAgICAgICAgICAgICAgICAgcmV0dXJu OwogICAgICAgICAgICAgdmFyIGNhbGxzID0gdHJhY2VMb2cuY2FsbHM7Cg==