96750 2012-09-14 04:02:28 -0700 [BlackBerry] Prevent scroll adjustment of input fields when region of interest mechanism active 2012-09-18 01:17:01 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson anilsson mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 720551 0 anilsson 2012-09-14 04:02:28 -0700 The region of interest mechanism replaces the scrolling/zooming functionality in BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible(CaretScrollType scrollType). We accomplish this by introducing a new fine-grained setting for the various adjustment modes. Whoever enables ROI needs to disable all scroll types using the new setting. PR 208387 721267 1 164252 anilsson 2012-09-14 17:11:22 -0700 Created attachment 164252 Patch 721894 2 164252 tonikitoo 2012-09-17 07:04:55 -0700 Comment on attachment 164252 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164252&action=review > Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1055 > - if (!Platform::Settings::instance()->allowCenterScrollAdjustmentForInputFields() && scrollType != EdgeIfNeeded) > + if (!(Platform::Settings::instance()->allowedScrollAdjustmentForInputFields() & scrollType)) I would name it scrollAdjustmentForInputFieldsPolicy, but this this also ok. > Source/WebKit/blackberry/WebKitSupport/InputHandler.h:71 > + enum CaretScrollType { CenterAlways = BlackBerry::Platform::Settings::ScrollAdjustmentCenterAlways, > + CenterIfNeeded = BlackBerry::Platform::Settings::ScrollAdjustmentCenterIfNeeded, > + EdgeIfNeeded = BlackBerry::Platform::Settings::ScrollAdjustmentEdgeIfNeeded }; there are compile asserts we can add to ensure these values match. 722581 3 164252 webkit.review.bot 2012-09-18 01:16:58 -0700 Comment on attachment 164252 Patch Clearing flags on attachment: 164252 Committed r128858: <http://trac.webkit.org/changeset/128858> 722582 4 webkit.review.bot 2012-09-18 01:17:01 -0700 All reviewed patches have been landed. Closing bug. 164252 2012-09-14 17:11:22 -0700 2012-09-18 01:16:58 -0700 Patch bug-96750-20120915021052.patch text/plain 4553 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0MWNmYTE2YjBlNzFlMDcwOTJiNThjNjU3YTFmMDkyMzMyOGU5YTIyLi4zMmMwZDBhNGRl MmNkMjM3MjlmZTdkZjU4ODhmMDg2ZWNlMmRlM2JkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMi0wOS0xNCAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFByZXZlbnQgc2Nyb2xsIGFkanVz dG1lbnQgb2YgaW5wdXQgZmllbGRzIHdoZW4gcmVnaW9uIG9mIGludGVyZXN0IG1lY2hhbmlzbSBh Y3RpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2 NzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IHJlZ2lvbiBvZiBpbnRlcmVzdCBtZWNoYW5pc20gcmVwbGFjZXMgdGhlIHNjcm9sbGluZy96b29t aW5nCisgICAgICAgIGZ1bmN0aW9uYWxpdHkgaW4gSW5wdXRIYW5kbGVyOjplbnN1cmVGb2N1c1Rl eHRFbGVtZW50VmlzaWJsZSgpLgorCisgICAgICAgIFdlIGludHJvZHVjZSBhIG5ldyBmaW5lLWdy YWluZWQgc2V0dGluZyBmb3IgdGhlIHZhcmlvdXMgYWRqdXN0bWVudAorICAgICAgICBtb2Rlcy4g VGhlIFdlYktpdCBlbWJlZGRlciBjYW4gZGlzYWJsZSBhbGwgc2Nyb2xsIHR5cGVzIGluIGZhdm9y IG9mIHRoZQorICAgICAgICByZWdpb24gb2YgaW50ZXJlc3QgbWVjaGFuaXNtIGJ5IHVzaW5nIHRo ZSBuZXcgc2V0dGluZy4KKworICAgICAgICBQUiAjMjA4Mzg3CisKKyAgICAgICAgUmV2aWV3ZWQg aW50ZXJuYWxseSBieSBNaWtlIEZlbnRvbi4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvQWJv dXREYXRhLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6Y29uZmlnUGFnZSk6Cisg ICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAoQmxhY2tC ZXJyeTo6V2ViS2l0OjpJbnB1dEhhbmRsZXI6OmVuc3VyZUZvY3VzVGV4dEVsZW1lbnRWaXNpYmxl KToKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5oOgorCiAyMDEyLTA5LTEz ICBBcnZpZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJy eV0gQWRkIHJlbmRlclRyZWVBc1RleHQgQVBJIHRvIFdlYlBhZ2UKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0Fib3V0RGF0YS5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9BYm91dERhdGEuY3BwCmluZGV4IDExYmUw MjZiZTg5NTI0OTJjNzFhOTFhNjkxMjBkMTU5NWEwMmQxZTguLjE1YmYzMDJiNDFlMDk5ODc1MjEz MzRlYjRlMjE4NDc0ODAwNzBkZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJLaXRTdXBwb3J0L0Fib3V0RGF0YS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvQWJvdXREYXRhLmNwcApAQCAtMTM4LDcgKzEzOCw3IEBAIHN0YXRp YyBTdHJpbmcgY29uZmlnUGFnZSgpCiAgICAgcGFnZSArPSBudW1iZXJUb0hUTUxUcigic2VsZWN0 aW9uRW5hYmxlZCIsIHNldHRpbmdzLT5zZWxlY3Rpb25FbmFibGVkKCkpOwogICAgIHBhZ2UgKz0g bnVtYmVyVG9IVE1MVHIoImZpbmVDdXJzb3JDb250cm9sRW5hYmxlZCIsIHNldHRpbmdzLT5maW5l Q3Vyc29yQ29udHJvbEVuYWJsZWQoKSk7CiAgICAgcGFnZSArPSBudW1iZXJUb0hUTUxUcigiYWx3 YXlzU2hvd0tleWJvYXJkT25Gb2N1cyIsIHNldHRpbmdzLT5hbHdheXNTaG93S2V5Ym9hcmRPbkZv Y3VzKCkpOwotICAgIHBhZ2UgKz0gbnVtYmVyVG9IVE1MVHIoImFsbG93Q2VudGVyU2Nyb2xsQWRq dXN0bWVudEZvcklucHV0RmllbGRzIiwgc2V0dGluZ3MtPmFsbG93Q2VudGVyU2Nyb2xsQWRqdXN0 bWVudEZvcklucHV0RmllbGRzKCkpOworICAgIHBhZ2UgKz0gbnVtYmVyVG9IVE1MVHIoImFsbG93 ZWRTY3JvbGxBZGp1c3RtZW50Rm9ySW5wdXRGaWVsZHMiLCBzZXR0aW5ncy0+YWxsb3dlZFNjcm9s bEFkanVzdG1lbnRGb3JJbnB1dEZpZWxkcygpKTsKICAgICBwYWdlICs9IG51bWJlclRvSFRNTFRy KCJ1bnJlc3RyaWN0ZWRSZXNpemVFdmVudHMiLCBzZXR0aW5ncy0+dW5yZXN0cmljdGVkUmVzaXpl RXZlbnRzKCkpOwogICAgIHBhZ2UgKz0gbnVtYmVyVG9IVE1MVHIoImlzQnJpZGdlQnJvd3NlciIs IHNldHRpbmdzLT5pc0JyaWRnZUJyb3dzZXIoKSk7CiAgICAgcGFnZSArPSBudW1iZXJUb0hUTUxU cigic2hvd0ltYWdlTG9jYXRpb25PcHRpb25zSW5HQ00iLCBzZXR0aW5ncy0+c2hvd0ltYWdlTG9j YXRpb25PcHRpb25zSW5HQ00oKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVy cnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2Jl cnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCAyZDc2MjkxMjg2ODI4ZTQ2 ZGI3MDAwZmY0Y2VmNjA4YzRiMzc3ODZiLi41YTFiNGZiMWI4YzlhMWFlYWUzYTBkOWM1NTA4YTVj ZmMyYWI3ODYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3Vw cG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTEwNTIsNyArMTA1Miw3IEBAIHZvaWQgSW5w dXRIYW5kbGVyOjplbnN1cmVGb2N1c1RleHRFbGVtZW50VmlzaWJsZShDYXJldFNjcm9sbFR5cGUg c2Nyb2xsVHlwZSkKICAgICBpZiAoIWlzQWN0aXZlVGV4dEVkaXQoKSB8fCAhaXNJbnB1dE1vZGVF bmFibGVkKCkgfHwgIW1fY3VycmVudEZvY3VzRWxlbWVudC0+ZG9jdW1lbnQoKSkKICAgICAgICAg cmV0dXJuOwogCi0gICAgaWYgKCFQbGF0Zm9ybTo6U2V0dGluZ3M6Omluc3RhbmNlKCktPmFsbG93 Q2VudGVyU2Nyb2xsQWRqdXN0bWVudEZvcklucHV0RmllbGRzKCkgJiYgc2Nyb2xsVHlwZSAhPSBF ZGdlSWZOZWVkZWQpCisgICAgaWYgKCEoUGxhdGZvcm06OlNldHRpbmdzOjppbnN0YW5jZSgpLT5h bGxvd2VkU2Nyb2xsQWRqdXN0bWVudEZvcklucHV0RmllbGRzKCkgJiBzY3JvbGxUeXBlKSkKICAg ICAgICAgcmV0dXJuOwogCiAgICAgRnJhbWUqIGVsZW1lbnRGcmFtZSA9IG1fY3VycmVudEZvY3Vz RWxlbWVudC0+ZG9jdW1lbnQoKS0+ZnJhbWUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5oIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmgKaW5kZXggZTZkMzI5N2Y3MGU5 NTdmZjI3MzY0YTY1OTkwNTZlZDA5YTdkYWNmYy4uYzY1Yjk5MTZiMTIyOTdmMjE0ODJkYjY4Y2Ey N2U5OTk3ZGNhOWU5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvSW5wdXRIYW5kbGVyLmgKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dl YktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmgKQEAgLTIyLDYgKzIyLDcgQEAKICNpbmNsdWRlICJU ZXh0Q2hlY2tpbmcuaCIKIAogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUlucHV0RXZlbnRz Lmg+CisjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtU2V0dGluZ3MuaD4KIAogI2luY2x1ZGUg PGltZi9ldmVudHMuaD4KICNpbmNsdWRlIDxpbWYvaW5wdXRfZGF0YS5oPgpAQCAtNjUsNyArNjYs OSBAQCBwdWJsaWM6CiAgICAgfklucHV0SGFuZGxlcigpOwogCiAgICAgZW51bSBGb2N1c0VsZW1l bnRUeXBlIHsgVGV4dEVkaXQsIFRleHRQb3B1cCAvKiBEYXRlL1RpbWUgJiBDb2xvciAqLywgU2Vs ZWN0UG9wdXAsIFBsdWdpbiB9OwotICAgIGVudW0gQ2FyZXRTY3JvbGxUeXBlIHsgQ2VudGVyQWx3 YXlzLCBDZW50ZXJJZk5lZWRlZCwgRWRnZUlmTmVlZGVkIH07CisgICAgZW51bSBDYXJldFNjcm9s bFR5cGUgeyBDZW50ZXJBbHdheXMgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U2V0dGluZ3M6OlNj cm9sbEFkanVzdG1lbnRDZW50ZXJBbHdheXMsCisgICAgICAgICAgICAgICAgICAgICAgICAgICBD ZW50ZXJJZk5lZWRlZCA9IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTZXR0aW5nczo6U2Nyb2xsQWRq dXN0bWVudENlbnRlcklmTmVlZGVkLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgRWRnZUlm TmVlZGVkID0gQmxhY2tCZXJyeTo6UGxhdGZvcm06OlNldHRpbmdzOjpTY3JvbGxBZGp1c3RtZW50 RWRnZUlmTmVlZGVkIH07CiAKICAgICBib29sIGlzSW5wdXRNb2RlRW5hYmxlZCgpIGNvbnN0Owog ICAgIHZvaWQgc2V0SW5wdXRNb2RlRW5hYmxlZChib29sIGFjdGl2ZSA9IHRydWUpOwo=