96737 2012-09-14 02:20:55 -0700 Web Inspector: NMI: remove current traits helper class because it is customizing the instrumentation at a wrong place and is not necessary at the moment. 2012-09-14 03:09:59 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 loislo loislo alph apavlov benjamin bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 720461 0 loislo 2012-09-14 02:20:55 -0700 EOM 720463 1 164075 loislo 2012-09-14 02:23:34 -0700 Created attachment 164075 Patch 720497 2 164075 webkit.review.bot 2012-09-14 03:09:56 -0700 Comment on attachment 164075 Patch Clearing flags on attachment: 164075 Committed r128576: <http://trac.webkit.org/changeset/128576> 720498 3 webkit.review.bot 2012-09-14 03:09:59 -0700 All reviewed patches have been landed. Closing bug. 164075 2012-09-14 02:23:34 -0700 2012-09-14 03:09:56 -0700 Patch bug-96737-20120914132305.patch text/plain 4415 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NTY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDc4NGU5OWVhMDU2YjgxZGE1NTk2Mjk1 YzdiMWIwNmU3NDdiMjBlYjUuLmQ5YmZhNjU2Yjg0ODg3ODc1ZTNjOTI5ZWZjYzI1ZjMwNzVkYWFi ZDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDktMTQgIElseWEgVGlraG9ub3Zza3kgIDxs b2lzbG9AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IE5NSTogcmVtb3Zl IGN1cnJlbnQgdHJhaXRzIGhlbHBlciBjbGFzcyBiZWNhdXNlIGl0IGlzIGN1c3RvbWl6aW5nIHRo ZSBpbnN0cnVtZW50YXRpb24gYXQgYSB3cm9uZyBwbGFjZSBhbmQgaXMgbm90IG5lY2Vzc2FyeSBh dCB0aGUgbW9tZW50LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTY3MzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHd0Zi9NZW1vcnlJbnN0cnVtZW50YXRpb24uaDoKKyAgICAgICAgKE1lbW9yeUluc3Ry dW1lbnRhdGlvbik6CisgICAgICAgIFdURjo6TWVtb3J5SW5zdHJ1bWVudGF0aW9uVHJhaXRzKTog cmVtb3ZlZAorICAgICAgICAoV1RGOjpNZW1vcnlJbnN0cnVtZW50YXRpb246Ok93bmluZ1RyYWl0 czo6YWRkSW5zdHJ1bWVudGVkT2JqZWN0KTogZGlyZWN0IGNhbGwgaW5zZXJ0ZWQKKyAgICAgICAg KFdURjo6TWVtb3J5SW5zdHJ1bWVudGF0aW9uOjpPd25pbmdUcmFpdHM6OmFkZE9iamVjdCk6ZGly ZWN0IGNhbGwgaW5zZXJ0ZWQKKwogMjAxMi0wOS0xNCAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcu a2ltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjg1 MDcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9NZW1vcnlJbnN0cnVtZW50YXRpb24uaCBi L1NvdXJjZS9XVEYvd3RmL01lbW9yeUluc3RydW1lbnRhdGlvbi5oCmluZGV4IDgxZjc5ZThiZjQx NmQyMDFlYTUwOTcwMWY5OWRjMmFjZDc5ZjJmYjAuLjA0Y2E4ZDIwZTA2ZGNmNmMwOWVhZTNjZDY4 Mzk3MTdiMmY4ODg3MDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01lbW9yeUluc3RydW1l bnRhdGlvbi5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01lbW9yeUluc3RydW1lbnRhdGlvbi5oCkBA IC00OCwxMiArNDgsNiBAQCBlbnVtIE1lbW9yeU93bmluZ1R5cGUgewogICAgIGJ5UmVmZXJlbmNl CiB9OwogCi1jbGFzcyBNZW1vcnlJbnN0cnVtZW50YXRpb25UcmFpdHMgewotcHVibGljOgotICAg IHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHN0YXRpYyB2b2lkIGFkZEluc3RydW1lbnRlZE9iamVjdChN ZW1vcnlJbnN0cnVtZW50YXRpb24qLCBjb25zdCBUKiBjb25zdCYsIE1lbW9yeU9iamVjdFR5cGUs IE1lbW9yeU93bmluZ1R5cGUpOwotICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IHN0YXRpYyB2b2lk IGFkZE9iamVjdChNZW1vcnlJbnN0cnVtZW50YXRpb24qLCBjb25zdCBUKiBjb25zdCYsIE1lbW9y eU9iamVjdFR5cGUsIE1lbW9yeU93bmluZ1R5cGUpOwotfTsKLQogY2xhc3MgTWVtb3J5SW5zdHJ1 bWVudGF0aW9uIHsKIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5NZW1vcnlJbnN0cnVtZW50YXRpb24o KSB7IH0KQEAgLTgwLDcgKzc0LDYgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgcHJvY2Vz c0RlZmVycmVkSW5zdHJ1bWVudGVkUG9pbnRlcnMoKSA9IDA7CiAKICAgICBmcmllbmQgY2xhc3Mg TWVtb3J5Q2xhc3NJbmZvOwotICAgIGZyaWVuZCBjbGFzcyBNZW1vcnlJbnN0cnVtZW50YXRpb25U cmFpdHM7CiAKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiBjbGFzcyBJbnN0cnVtZW50ZWRQb2lu dGVyIDogcHVibGljIEluc3RydW1lbnRlZFBvaW50ZXJCYXNlIHsKICAgICBwdWJsaWM6CkBAIC0x MTYsMTEgKzEwOSwxMSBAQCBwcml2YXRlOgogICAgIHN0cnVjdCBPd25pbmdUcmFpdHMgeyAvLyBE ZWZhdWx0IGJ5UmVmZXJlbmNlIGltcGxlbWVudGF0aW9uLgogICAgICAgICBzdGF0aWMgdm9pZCBh ZGRJbnN0cnVtZW50ZWRPYmplY3QoTWVtb3J5SW5zdHJ1bWVudGF0aW9uKiBpbnN0cnVtZW50YXRp b24sIGNvbnN0IFQmIHQsIE1lbW9yeU9iamVjdFR5cGUgb3duZXJPYmplY3RUeXBlKQogICAgICAg ICB7Ci0gICAgICAgICAgICBNZW1vcnlJbnN0cnVtZW50YXRpb25UcmFpdHM6OmFkZEluc3RydW1l bnRlZE9iamVjdDxUPihpbnN0cnVtZW50YXRpb24sICZ0LCBvd25lck9iamVjdFR5cGUsIGJ5UmVm ZXJlbmNlKTsKKyAgICAgICAgICAgIGluc3RydW1lbnRhdGlvbi0+YWRkSW5zdHJ1bWVudGVkT2Jq ZWN0SW1wbCgmdCwgb3duZXJPYmplY3RUeXBlLCBieVJlZmVyZW5jZSk7CiAgICAgICAgIH0KICAg ICAgICAgc3RhdGljIHZvaWQgYWRkT2JqZWN0KE1lbW9yeUluc3RydW1lbnRhdGlvbiogaW5zdHJ1 bWVudGF0aW9uLCBjb25zdCBUJiB0LCBNZW1vcnlPYmplY3RUeXBlIG93bmVyT2JqZWN0VHlwZSkK ICAgICAgICAgewotICAgICAgICAgICAgTWVtb3J5SW5zdHJ1bWVudGF0aW9uVHJhaXRzOjphZGRP YmplY3Q8VD4oaW5zdHJ1bWVudGF0aW9uLCAmdCwgb3duZXJPYmplY3RUeXBlLCBieVJlZmVyZW5j ZSk7CisgICAgICAgICAgICBpbnN0cnVtZW50YXRpb24tPmFkZE9iamVjdEltcGwoJnQsIG93bmVy T2JqZWN0VHlwZSwgYnlSZWZlcmVuY2UpOwogICAgICAgICB9CiAgICAgfTsKIApAQCAtMTI4LDEx ICsxMjEsMTEgQEAgcHJpdmF0ZToKICAgICBzdHJ1Y3QgT3duaW5nVHJhaXRzPFQqPiB7IC8vIEN1 c3RvbSBieVBvaW50ZXIgaW1wbGVtZW50YXRpb24uCiAgICAgICAgIHN0YXRpYyB2b2lkIGFkZElu c3RydW1lbnRlZE9iamVjdChNZW1vcnlJbnN0cnVtZW50YXRpb24qIGluc3RydW1lbnRhdGlvbiwg Y29uc3QgVCogY29uc3QmIHQsIE1lbW9yeU9iamVjdFR5cGUgb3duZXJPYmplY3RUeXBlKQogICAg ICAgICB7Ci0gICAgICAgICAgICBNZW1vcnlJbnN0cnVtZW50YXRpb25UcmFpdHM6OmFkZEluc3Ry dW1lbnRlZE9iamVjdDxUPihpbnN0cnVtZW50YXRpb24sIHQsIG93bmVyT2JqZWN0VHlwZSwgYnlQ b2ludGVyKTsKKyAgICAgICAgICAgIGluc3RydW1lbnRhdGlvbi0+YWRkSW5zdHJ1bWVudGVkT2Jq ZWN0SW1wbCh0LCBvd25lck9iamVjdFR5cGUsIGJ5UG9pbnRlcik7CiAgICAgICAgIH0KICAgICAg ICAgc3RhdGljIHZvaWQgYWRkT2JqZWN0KE1lbW9yeUluc3RydW1lbnRhdGlvbiogaW5zdHJ1bWVu dGF0aW9uLCBjb25zdCBUKiBjb25zdCYgdCwgTWVtb3J5T2JqZWN0VHlwZSBvd25lck9iamVjdFR5 cGUpCiAgICAgICAgIHsKLSAgICAgICAgICAgIE1lbW9yeUluc3RydW1lbnRhdGlvblRyYWl0czo6 YWRkT2JqZWN0PFQ+KGluc3RydW1lbnRhdGlvbiwgdCwgb3duZXJPYmplY3RUeXBlLCBieVBvaW50 ZXIpOworICAgICAgICAgICAgaW5zdHJ1bWVudGF0aW9uLT5hZGRPYmplY3RJbXBsKHQsIG93bmVy T2JqZWN0VHlwZSwgYnlQb2ludGVyKTsKICAgICAgICAgfQogICAgIH07CiAKQEAgLTE0NSwxOCAr MTM4LDYgQEAgcHJpdmF0ZToKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBUPiB2b2lkIGFkZE9iamVj dEltcGwoY29uc3QgUmVmUHRyPFQ+KiBjb25zdCYsIE1lbW9yeU9iamVjdFR5cGUsIE1lbW9yeU93 bmluZ1R5cGUpOwogfTsKIAotdGVtcGxhdGU8dHlwZW5hbWUgVD4KLXZvaWQgTWVtb3J5SW5zdHJ1 bWVudGF0aW9uVHJhaXRzOjphZGRJbnN0cnVtZW50ZWRPYmplY3QoTWVtb3J5SW5zdHJ1bWVudGF0 aW9uKiBpbnN0cnVtZW50YXRpb24sIGNvbnN0IFQqIGNvbnN0JiB0LCBNZW1vcnlPYmplY3RUeXBl IG93bmVyT2JqZWN0VHlwZSwgTWVtb3J5T3duaW5nVHlwZSBvd25pbmdUeXBlKQotewotICAgIGlu c3RydW1lbnRhdGlvbi0+YWRkSW5zdHJ1bWVudGVkT2JqZWN0SW1wbCh0LCBvd25lck9iamVjdFR5 cGUsIG93bmluZ1R5cGUpOwotfQotCi10ZW1wbGF0ZTx0eXBlbmFtZSBUPgotdm9pZCBNZW1vcnlJ bnN0cnVtZW50YXRpb25UcmFpdHM6OmFkZE9iamVjdChNZW1vcnlJbnN0cnVtZW50YXRpb24qIGlu c3RydW1lbnRhdGlvbiwgY29uc3QgVCogY29uc3QmIHQsIE1lbW9yeU9iamVjdFR5cGUgb3duZXJP YmplY3RUeXBlLCBNZW1vcnlPd25pbmdUeXBlIG93bmluZ1R5cGUpCi17Ci0gICAgaW5zdHJ1bWVu dGF0aW9uLT5hZGRPYmplY3RJbXBsKHQsIG93bmVyT2JqZWN0VHlwZSwgb3duaW5nVHlwZSk7Ci19 Ci0KIGNsYXNzIE1lbW9yeU9iamVjdEluZm8gewogcHVibGljOgogICAgIE1lbW9yeU9iamVjdElu Zm8oTWVtb3J5SW5zdHJ1bWVudGF0aW9uKiBtZW1vcnlJbnN0cnVtZW50YXRpb24sIE1lbW9yeU9i amVjdFR5cGUgb3duZXJPYmplY3RUeXBlKQo=