96734 2012-09-14 01:27:48 -0700 Cannot select text within a label element that is linked to an input field 2024-12-25 00:27:21 -0800 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified OS X 10.6 REOPENED https://bugs.webkit.org/show_bug.cgi?id=259557 http://jsfiddle.net/FpcTz/ BlinkMergeCandidate, BrowserCompat, InRadar P2 Normal --- 259558 1 ben webkit-unassigned ahmad.saleem792 akeerthi commit-queue forms-bugs rniwa webkit-bug-importer oldest_to_newest 720430 0 ben 2012-09-14 01:27:48 -0700 1. Go to: http://jsfiddle.net/FpcTz/ 2. Try and select the label text either by double clicking or dragging over some of it. The selection is lost and focus jumps to the field next to it. This happens for text within label tags that is linked to an input via the 'for' attribute. 1907526 1 ahmad.saleem792 2022-10-22 04:57:43 -0700 This to merge following Blink Commit - https://src.chromium.org/viewvc/blink?view=revision&revision=174296 In Webkit GitHub source here: https://github.com/WebKit/WebKit/blob/51974bdf186d0771e79b230316ed0cddc5293f88/Source/WebCore/html/HTMLLabelElement.cpp#L136 ___ It fails following test - https://jsfiddle.net/9pznh8ak/show 1909183 2 ahmad.saleem792 2022-10-29 17:43:39 -0700 (In reply to Ahmad Saleem from comment #1) > This to merge following Blink Commit - > > https://src.chromium.org/viewvc/blink?view=revision&revision=174296 > > In Webkit GitHub source here: > > https://github.com/WebKit/WebKit/blob/ > 51974bdf186d0771e79b230316ed0cddc5293f88/Source/WebCore/html/ > HTMLLabelElement.cpp#L136 > > ___ > > It fails following test - https://jsfiddle.net/9pznh8ak/show I tried to merge this: https://github.com/WebKit/WebKit/pull/5676 and the issue is: ``` auto control = this->control(); ``` If I try to change it to RefPtr then it leads to build failures. If I don't then it compiles but crashes on following test: imported/blink/fast/forms/label/detached-document.html 1916377 3 ahmad.saleem792 2022-12-02 16:08:25 -0800 (In reply to Ahmad Saleem from comment #2) > (In reply to Ahmad Saleem from comment #1) > > This to merge following Blink Commit - > > > > https://src.chromium.org/viewvc/blink?view=revision&revision=174296 > > > > In Webkit GitHub source here: > > > > https://github.com/WebKit/WebKit/blob/ > > 51974bdf186d0771e79b230316ed0cddc5293f88/Source/WebCore/html/ > > HTMLLabelElement.cpp#L136 > > > > ___ > > > > It fails following test - https://jsfiddle.net/9pznh8ak/show > > I tried to merge this: > > https://github.com/WebKit/WebKit/pull/5676 > > and the issue is: > > ``` > auto control = this->control(); > ``` > > If I try to change it to RefPtr then it leads to build failures. If I don't > then it compiles but crashes on following test: > > imported/blink/fast/forms/label/detached-document.html While trying to find equivalent of "LocalFrame.h" header, it seems that Webkit has "Frame.h" as equivalent. I might try to add it and push it again in future but just wanted to comment so if someone else know, they can fix try it. 1951377 4 ews-feeder 2023-04-26 11:15:49 -0700 Committed 263420@main (01527bde3937): <https://commits.webkit.org/263420@main> Reviewed commits have been landed. Closing PR #12503 and removing active labels. 1951378 5 webkit-bug-importer 2023-04-26 11:16:24 -0700 <rdar://problem/108566491> 1968436 6 commit-queue 2023-07-27 06:42:01 -0700 Re-opened since this is blocked by bug 259558 1968567 7 ap 2023-07-27 20:17:13 -0700 New tracking radar: rdar://113011484 1982232 8 ahmad.saleem792 2023-10-03 14:42:46 -0700 We might need to add following as well: https://src.chromium.org/viewvc/blink?view=revision&revision=182131 and https://src.chromium.org/viewvc/blink?view=revision&revision=185576 2083854 9 ahmad.saleem792 2024-12-25 00:25:17 -0800 (In reply to Ahmad Saleem from comment #1) > This to merge following Blink Commit - > > https://src.chromium.org/viewvc/blink?view=revision&revision=174296 > > In Webkit GitHub source here: > > https://github.com/WebKit/WebKit/blob/ > 51974bdf186d0771e79b230316ed0cddc5293f88/Source/WebCore/html/ > HTMLLabelElement.cpp#L136 > > ___ > > It fails following test - https://jsfiddle.net/9pznh8ak/show SVN is gone - https://github.com/chromium/chromium/commit/56bbe7a3ca5fa03484b2852188778b03be9fd8a3 and https://github.com/chromium/chromium/commit/6dbe5851b1abf2f6157c2abdb678209d3a92eca3 and https://github.com/chromium/chromium/commit/d57ffe6d165e3a7d45d8a6f0af2a125d83ab514a and https://github.com/chromium/chromium/commit/b33fd86d989afbd66fd795690c9d4c34bb9836d5 2083855 10 ahmad.saleem792 2024-12-25 00:27:21 -0800 (In reply to Ahmad Saleem from comment #9) > (In reply to Ahmad Saleem from comment #1) > > This to merge following Blink Commit - > > > > https://src.chromium.org/viewvc/blink?view=revision&revision=174296 > > > > In Webkit GitHub source here: > > > > https://github.com/WebKit/WebKit/blob/ > > 51974bdf186d0771e79b230316ed0cddc5293f88/Source/WebCore/html/ > > HTMLLabelElement.cpp#L136 > > > > ___ > > > > It fails following test - https://jsfiddle.net/9pznh8ak/show > > SVN is gone - > https://github.com/chromium/chromium/commit/ > 56bbe7a3ca5fa03484b2852188778b03be9fd8a3 > > and > https://github.com/chromium/chromium/commit/ > 6dbe5851b1abf2f6157c2abdb678209d3a92eca3 > > and > https://github.com/chromium/chromium/commit/ > d57ffe6d165e3a7d45d8a6f0af2a125d83ab514a > > and > https://github.com/chromium/chromium/commit/ > b33fd86d989afbd66fd795690c9d4c34bb9836d5 https://github.com/chromium/chromium/commit/5db23fe6d7151affeaf8b84ac2b16cf1603c456d