96727 2012-09-13 22:31:13 -0700 EventSendingController::keyDown does not support non-array modifier arguments 2012-10-01 01:35:31 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis ap eric kenneth mrobinson tkent webkit.review.bot oldest_to_newest 720318 0 naginenis 2012-09-13 22:31:13 -0700 fast/forms/legend-access-key.html is failing since it uses "altKey" as the modifier argument. Non-array modifier arguments should be handled in EventSendingController::keyDown to solve the issue. 720581 1 164104 naginenis 2012-09-14 04:38:34 -0700 Created attachment 164104 Patch 720668 2 164104 webkit.review.bot 2012-09-14 06:19:14 -0700 Comment on attachment 164104 Patch Clearing flags on attachment: 164104 Committed r128602: <http://trac.webkit.org/changeset/128602> 720669 3 webkit.review.bot 2012-09-14 06:19:16 -0700 All reviewed patches have been landed. Closing bug. 720848 4 ap 2012-09-14 09:49:27 -0700 > Non-array modifier arguments should be handled in EventSendingController::keyDown to solve the issue. Are you saying that DumpRenderTree supports this, so WebKitTestRunner should, too? I don't see that in DumpRenderTree implementation. I'd like to roll out this patch unless there is a convincing explanation. 720940 5 naginenis 2012-09-14 10:47:58 -0700 (In reply to comment #4) > > Non-array modifier arguments should be handled in EventSendingController::keyDown to solve the issue. > > Are you saying that DumpRenderTree supports this, so WebKitTestRunner should, too? I don't see that in DumpRenderTree implementation. This support was added by different ports for DumpRenderTree in EventSender, so I thought it make sense to have it in WKTR too. http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/efl/EventSender.cpp#L256 http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/gtk/EventSender.cpp#L297 http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestRunner/EventSender.cpp#L192 722348 6 ap 2012-09-17 16:01:08 -0700 CC'ing people who were adding this code to ports over the years. This is just wrong. This was never meant to work with string arguments, and still doesn't in Mac DumpRenderTree. Was everyone just adding this code to accommodate for a typo in a single test?! How did that pass review multiple times? Please at the very least implement this on Mac too, to regain interoperability of DumpRenderTree implementations. 722353 7 eric 2012-09-17 16:04:22 -0700 Seems like a reasonable feature to me. I certainly don't mind supporting this variant. 731470 8 naginenis 2012-10-01 01:35:31 -0700 Implemented this on Mac too, in the bug #97805 164104 2012-09-14 04:38:34 -0700 2012-09-14 06:19:14 -0700 Patch 96727.patch text/plain 3633 naginenis ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjZmEwZjEwLi40ZTJlNmEyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDkt MTQgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5j b20+CisKKyAgICAgICAgRXZlbnRTZW5kaW5nQ29udHJvbGxlcjo6a2V5RG93biBkb2VzIG5vdCBz dXBwb3J0IG5vbi1hcnJheSBtb2RpZmllciBhcmd1bWVudHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NzI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVW5za2lwIHBhc3NpbmcgdGVzdCBmYXN0L2Zvcm1z L2xlZ2VuZC1hY2Nlc3Mta2V5Lmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2VmbC13azIvVGVz dEV4cGVjdGF0aW9uczoKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGstd2syL1NraXBwZWQ6CisKIDIw MTItMDktMTQgIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgV2ViIEluc3BlY3RvcjogQWRkIGFiaWxpdHkgdG8gcmVwbGF5IFhIUiBpbiBuZXR3b3JrIHBh bmVsLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0 YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zCmlu ZGV4IDA5NDJiNGUuLmNlNWM2ZTggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Vm bC13azIvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2sy L1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTE5Nyw3ICsxOTcsNiBAQCBCVUdXS0VGTCA6IHN0b3JhZ2Uv ZG9tc3RvcmFnZS9zdG9yYWdlLWNsb3NlLWRhdGFiYXNlLW9uLWlkbGUuaHRtbCA9IFRFWFQKIEJV R1dLRUZMIDogZWRpdGluZy9pbnB1dC9lbWFjcy1jdHJsLW8uaHRtbCA9IFRFWFQKIEJVR1dLRUZM IDogZmFzdC9ibG9jay9mbG9hdC9mbG9hdC1pbi1mbG9hdC1oaXQtdGVzdGluZy5odG1sID0gVEVY VAogQlVHV0tFRkwgOiBmYXN0L2RvbS9XaW5kb3cvbW96aWxsYS1mb2N1cy1ibHVyLmh0bWwgPSBU RVhUCi1CVUdXS0VGTCA6IGZhc3QvZm9ybXMvbGVnZW5kLWFjY2Vzcy1rZXkuaHRtbCA9IFRFWFQK IEJVR1dLRUZMIDogZmFzdC9mb3Jtcy9zZWxlY3Qtd3JpdGluZy1kaXJlY3Rpb24tbmF0dXJhbC5o dG1sID0gVEVYVAogQlVHV0tFRkwgOiBmYXN0L2ZyYW1lcy9mbGF0dGVuaW5nL2lmcmFtZS10aW55 Lmh0bWwgPSBURVhUCiBCVUdXS0VGTCA6IGZhc3QvcmVwbGFjZWQvbm8tZm9jdXMtcmluZy1lbWJl ZC5odG1sID0gVEVYVApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrLXdrMi9T a2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrLXdrMi9Ta2lwcGVkCmluZGV4IGI5MzMy ZTIuLjA5NjQ0MmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay13azIvU2tp cHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGstd2syL1NraXBwZWQKQEAgLTgzLDcg KzgzLDYgQEAgZmFzdC9mb3Jtcy9pbXBsaWNpdC1zdWJtaXNzaW9uLmh0bWwKIGZhc3QvZm9ybXMv c2VsZWN0LXR5cGUtYWhlYWQtbm9uLWxhdGluLmh0bWwKIGZhc3QvZm9ybXMvbGlzdGJveC10eXBl YWhlYWQtY3lyaWxsaWMuaHRtbAogZmFzdC9mb3Jtcy9saXN0Ym94LXR5cGVhaGVhZC1ncmVlay5o dG1sCi1mYXN0L2Zvcm1zL2xlZ2VuZC1hY2Nlc3Mta2V5Lmh0bWwKIGh0dHAvdGVzdHMveG1saHR0 cHJlcXVlc3Qvd29ya2Vycy9hYm9ydC1leGNlcHRpb24tYXNzZXJ0Lmh0bWwKIHBsYXRmb3JtL2d0 ay9mYXN0L2Zvcm1zL21lbnVsaXN0LXR5cGVhaGVhZC1maW5kLmh0bWwKIHBsdWdpbnMvZG9jdW1l bnQtb3Blbi5odG1sCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggYWNhNDRjMy4uMzY1YzhjNiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisr KyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTE0ICBTdWRhcnNh bmEgTmFnaW5lbmkgIDxzdWRhcnNhbmEubmFnaW5lbmlAbGludXguaW50ZWwuY29tPgorCisgICAg ICAgIEV2ZW50U2VuZGluZ0NvbnRyb2xsZXI6OmtleURvd24gZG9lcyBub3Qgc3VwcG9ydCBub24t YXJyYXkgbW9kaWZpZXIgYXJndW1lbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05NjcyNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBoYW5kbGluZyBhIHN0cmluZyBhcyBtb2Rp ZmllciBhcmd1bWVudCB0bworICAgICAgICBFdmVudFNlbmRpbmdDb250cm9sbGVyOjprZXlEb3du LgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9FdmVudFNlbmRp bmdDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdUUjo6cGFyc2VNb2RpZmllckFycmF5KToKKwog MjAxMi0wOS0xNCAgUGV0ZXIgQmV2ZXJsb28gIDxwZXRlckBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgVGhlIHJ1bnRpbWUvdW5zaWduZWQgY2F0ZWdvcnkgc2hvdWxkIGJlIHZhbGlkIGluIHRoZSBj cHAgc3R5bGUtY2hlY2tlci4KZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5q ZWN0ZWRCdW5kbGUvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5jcHAgYi9Ub29scy9XZWJLaXRUZXN0 UnVubmVyL0luamVjdGVkQnVuZGxlL0V2ZW50U2VuZGluZ0NvbnRyb2xsZXIuY3BwCmluZGV4IGVj ZmE2YjMuLmI3ZTIwM2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0 ZWRCdW5kbGUvRXZlbnRTZW5kaW5nQ29udHJvbGxlci5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9FdmVudFNlbmRpbmdDb250cm9sbGVyLmNwcApAQCAtNzQs NiArNzQsMTMgQEAgc3RhdGljIFdLRXZlbnRNb2RpZmllcnMgcGFyc2VNb2RpZmllckFycmF5KEpT Q29udGV4dFJlZiBjb250ZXh0LCBKU1ZhbHVlUmVmIGFycmEKIHsKICAgICBpZiAoIWFycmF5VmFs dWUpCiAgICAgICAgIHJldHVybiAwOworCisgICAgLy8gVGhlIHZhbHVlIG1heSBlaXRoZXIgYmUg YSBzdHJpbmcgd2l0aCBhIHNpbmdsZSBtb2RpZmllciBvciBhbiBhcnJheSBvZiBtb2RpZmllcnMu CisgICAgaWYgKEpTVmFsdWVJc1N0cmluZyhjb250ZXh0LCBhcnJheVZhbHVlKSkgeworICAgICAg ICBKU1JldGFpblB0cjxKU1N0cmluZ1JlZj4gc3RyaW5nKEFkb3B0LCBKU1ZhbHVlVG9TdHJpbmdD b3B5KGNvbnRleHQsIGFycmF5VmFsdWUsIDApKTsKKyAgICAgICAgcmV0dXJuIHBhcnNlTW9kaWZp ZXIoc3RyaW5nLmdldCgpKTsKKyAgICB9CisKICAgICBpZiAoIUpTVmFsdWVJc09iamVjdChjb250 ZXh0LCBhcnJheVZhbHVlKSkKICAgICAgICAgcmV0dXJuIDA7CiAgICAgSlNPYmplY3RSZWYgYXJy YXkgPSBjb25zdF9jYXN0PEpTT2JqZWN0UmVmPihhcnJheVZhbHVlKTsK