<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>96718</bug_id>
          
          <creation_ts>2012-09-13 19:11:59 -0700</creation_ts>
          <short_desc>mac-future ignores fallback test expectations</short_desc>
          <delta_ts>2012-09-14 15:52:43 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Stephanie Lewis">slewis</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>dpranke</cc>
    
    <cc>mrowe</cc>
    
    <cc>ojan</cc>
    
    <cc>slewis</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>720223</commentid>
    <comment_count>0</comment_count>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2012-09-13 19:11:59 -0700</bug_when>
    <thetext>When running tests on mac-future TestExpectation files from mac are ignored.

The configuration matching is using a fallback array that doesn&apos;t contain mac-future so no expectation configurations match

patch coming.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720225</commentid>
    <comment_count>1</comment_count>
      <attachid>164028</attachid>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2012-09-13 19:16:01 -0700</bug_when>
    <thetext>Created attachment 164028
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720250</commentid>
    <comment_count>2</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-13 20:05:37 -0700</bug_when>
    <thetext>1) I think there&apos;s something wrong with your patch (wrong mime type?)

2) mac-future isn&apos;t supposed to be a real test configuration, so I&apos;m a bit nervous with this change. What are you running that&apos;s giving you the error?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720251</commentid>
    <comment_count>3</comment_count>
      <attachid>164034</attachid>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2012-09-13 20:07:43 -0700</bug_when>
    <thetext>Created attachment 164034
patch.txt?

weird, it was just the output from git format-patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720258</commentid>
    <comment_count>4</comment_count>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2012-09-13 20:19:14 -0700</bug_when>
    <thetext>There were comments in the code that suggested we need to refactor the approach as well.  I&apos;m open to that, but if this is going to be a large refactoring I&apos;d like to get my tests running first.

My understanding was that mac-future was added as a placeholder for platforms still in development.  Running the layout tests against changes to mac os early on helps us find regressions in underlying code.

We use 

--additional-platform-directory=ADDITIONAL_PLATFORM_DIRECTORY
                        Additional directory where to look for test baselines
                        (will take precendence over platform baselines).
                        Specify multiple times to add multiple search path
                        entries.
--additional-expectations=ADDITIONAL_EXPECTATIONS
                        Path to a test_expectations file that will override
                        previous expectations. Specify multiple times for
                        multiple sets of overrides.

to specify the location of those results and the TestExpectations file.

The bug is that since there is no match for the platform in VERSION_FALLBACK_ORDER the expectations for older platforms don&apos;t match configurations.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720286</commentid>
    <comment_count>5</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-13 21:24:52 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; There were comments in the code that suggested we need to refactor the approach as well.  I&apos;m open to that, but if this is going to be a large refactoring I&apos;d like to get my tests running first.
&gt; 
&gt; My understanding was that mac-future was added as a placeholder for platforms still in development.  Running the layout tests against changes to mac os early on helps us find regressions in underlying code.
&gt; 

Not exactly. &quot;mac-future&quot; is a placeholder for platforms still in development, but really it&apos;s meant to always resolve to platform/mac (as opposed to something like &quot;mac-lion&quot;  which may point to platform/mac one day and platform/mac-lion the next. So, the theory was that platform/mac would always contain the results of whatever was under development and, if the currently shipping version produces different results, it would go in mac-lion or whatever (mac-mountainlion now).

I believe I worked this all out w/ Mark Rowe a while ago. That said, I&apos;m not particularly wedded to this and we can certainly change it to whatever works for you.

&gt; We use 
&gt; 
&gt; --additional-platform-directory=ADDITIONAL_PLATFORM_DIRECTORY
&gt;                         Additional directory where to look for test baselines
&gt;                         (will take precendence over platform baselines).
&gt;                         Specify multiple times to add multiple search path
&gt;                         entries.
&gt; --additional-expectations=ADDITIONAL_EXPECTATIONS
&gt;                         Path to a test_expectations file that will override
&gt;                         previous expectations. Specify multiple times for
&gt;                         multiple sets of overrides.
&gt; 
&gt; to specify the location of those results and the TestExpectations file.
&gt; 
&gt; The bug is that since there is no match for the platform in VERSION_FALLBACK_ORDER the expectations for older platforms don&apos;t match configurations.

I&apos;m having trouble parsing this sentence. Why do you need mac-future to be in VERSION_FALLBACK_ORDER if you&apos;re also using --additional-expectations and --additional-platform-directory? Does run-webkit-tests --platform mac-future --additional-platform-directory=X --additional-expectations=Y not work? I tried this quickly before I left the office tonight and --platform mac-future seemed to work ok for me, but I might&apos;ve missed something.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720322</commentid>
    <comment_count>6</comment_count>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2012-09-13 22:40:36 -0700</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; There were comments in the code that suggested we need to refactor the approach as well.  I&apos;m open to that, but if this is going to be a large refactoring I&apos;d like to get my tests running first.
&gt; &gt; 
&gt; &gt; My understanding was that mac-future was added as a placeholder for platforms still in development.  Running the layout tests against changes to mac os early on helps us find regressions in underlying code.
&gt; &gt; 
&gt; 
&gt; Not exactly. &quot;mac-future&quot; is a placeholder for platforms still in development, but really it&apos;s meant to always resolve to platform/mac (as opposed to something like &quot;mac-lion&quot;  which may point to platform/mac one day and platform/mac-lion the next. So, the theory was that platform/mac would always contain the results of whatever was under development and, if the currently shipping version produces different results, it would go in mac-lion or whatever (mac-mountainlion now).

I think our issue is that we now have two &quot;macs&quot;.  The one that webkit considers the most recent and the one that we consider the most recent.  I&apos;m confused as to how you think we should differentiate between the two.

&gt; 
&gt; I believe I worked this all out w/ Mark Rowe a while ago. That said, I&apos;m not particularly wedded to this and we can certainly change it to whatever works for you.
&gt; 
&gt; &gt; We use 
&gt; &gt; 
&gt; &gt; --additional-platform-directory=ADDITIONAL_PLATFORM_DIRECTORY
&gt; &gt;                         Additional directory where to look for test baselines
&gt; &gt;                         (will take precendence over platform baselines).
&gt; &gt;                         Specify multiple times to add multiple search path
&gt; &gt;                         entries.
&gt; &gt; --additional-expectations=ADDITIONAL_EXPECTATIONS
&gt; &gt;                         Path to a test_expectations file that will override
&gt; &gt;                         previous expectations. Specify multiple times for
&gt; &gt;                         multiple sets of overrides.
&gt; &gt; 
&gt; &gt; to specify the location of those results and the TestExpectations file.
&gt; &gt; 
&gt; &gt; The bug is that since there is no match for the platform in VERSION_FALLBACK_ORDER the expectations for older platforms don&apos;t match configurations.
&gt; 
&gt; I&apos;m having trouble parsing this sentence. Why do you need mac-future to be in VERSION_FALLBACK_ORDER if you&apos;re also using --additional-expectations and --additional-platform-directory? Does run-webkit-tests --platform mac-future --additional-platform-directory=X --additional-expectations=Y not work? I tried this quickly before I left the office tonight and --platform mac-future seemed to work ok for me, but I might&apos;ve missed something.

passing --platform doesn&apos;t resolve the TestExpectation issue.

So what I tracked down the problem to is that we create a TestExpectation for each port that we want to use the testexpectations files for.  Those are mac-future and  mac.  mac is what we are interested in here.  TestExpectation has a list of configurations that the mac testexpectation would apply to.  The function to create that list is port._generate_all_test_configurations.  The configurations end up being VERSION_FALLBACK_ORDER x BUILD_TYPES x ARCHITECTURES.  Since the platform we&apos;re running is mac-future and the VERSION_FALLBACK_ORDER doesn&apos;t contain mac-future TestExpectation decides that the mac testexpectation doesn&apos;t apply to our current platform.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720955</commentid>
    <comment_count>7</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-14 11:05:57 -0700</bug_when>
    <thetext>I&apos;m sorry, I&apos;m surely missing something here. 

First, if this discussion is blocking anything important, feel free to have someone r+ this and land it while we try to resolve my confusion; the patch looks fine but I don&apos;t want to r+ something I don&apos;t understand the need for.

I understand the desire to distinguish between the version that is currently shipping and some internal unreleased version. I believe that in order to run run-webkit-tests with some new set of tests, baselines, and expectations, running with --platform mac-future --additional-platform-dir=X --additional-expectations=Y is all you should need. That will pick up the TestExpectations in platform/mac in addition to the file you&apos;ve specified on the command line. You can verify this by, e.g., running with --details and checking the expectation for some test listed in mac/TestExpectations, like fast/dom/shadow/content-element-api.html.

The point I&apos;m confused about is your need to modify _generate_all_test_configurations(); while that function is called during run-webkit-tests, it isn&apos;t (I don&apos;t think) really used for anything, and I don&apos;t think adding mac-future to that will have any effect on how run-webkit-tests runs. 

The list of configurations is used mostly (solely?) when using the &apos;REBASELINE&apos; modifier and rewriting the file when tests no longer fail. So, I could believe that mac-future needs to be in that list if you&apos;re trying to make it work with garden-o-matic or webkit-patch rebaseline-expectations. Are you trying to use one of those commands, or are you having some problem with run-webkit-tests that I&apos;m not seeing?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>721134</commentid>
    <comment_count>8</comment_count>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2012-09-14 14:32:11 -0700</bug_when>
    <thetext>_generate_all_test_configurations is called during the test to when parsing test_expectations.  Starting from the failing line I outlined how this is failing for us.


The problem line is in test_expectations.py in def _add_expectations(self, expectation_list):

if self._is_lint_mode or self._test_config in expectation_line.matching_configurations:
    self._model.add_expectation_line(expectation_line)

_log.debug(&apos;is_lint_mode=%s _test_config=%s matching_config=%s&apos; % (self._is_lint_mode, self._test_config, expectation_line.matching_configurations))

The log statement outputs this:

14:08:15.730 12586 is_lint_mode=False _test_config=&lt;future, x86_64, release&gt; matching_config=set([TestConfig(version=&apos;snowleopard&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;mountainlion&apos;, architecture=&apos;x86_64&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;lion&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;mountainlion&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;lion&apos;, architecture=&apos;x86_64&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;mountainlion&apos;, architecture=&apos;x86&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;snowleopard&apos;, architecture=&apos;x86_64&apos;, build_type=&apos;debug&apos;), TestConfig(version=&apos;lion&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;snowleopard&apos;, architecture=&apos;x86&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;lion&apos;, architecture=&apos;x86_64&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;mountainlion&apos;, architecture=&apos;x86_64&apos;, build_type=&apos;release&apos;), TestConfig(version=&apos;snowleopard&apos;, architecture=&apos;x86_64&apos;, build_type=&apos;release&apos;)])

you&apos;ll notice that the _test_config is future and the matching_configurations don&apos;t have future as an option.  So the expectation for this test is never added.

expectation_line.matching_configurations is set in test_expectations.py in_parse_modifiers(self, expectation_line):

expectation_line.matching_configurations = self._test_configuration_converter.to_config_set(parsed_specifiers, expectation_line.warnings)

the test_configurarion_converter has the list of configurations and it is created in test_expectations.py in TestExpectationParser.__init__(self, port, full_test_list, allow_rebaseline_modifier)

self._test_configuration_converter = TestConfigurationConverter(set(port.all_test_configurations()), port.configuration_specifier_macros())

port.all_test_configurations() calls _generate_all_test_configurations which uses the VERSION_FALLBACK_ORDER to come up with a list of platforms.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>721154</commentid>
    <comment_count>9</comment_count>
    <who name="Dirk Pranke">dpranke</who>
    <bug_when>2012-09-14 14:47:27 -0700</bug_when>
    <thetext>Okay, apparently I&apos;ve been misreading the logs this whole time ... sigh.

I&apos;ve reproduced your problem. Patch is fine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>721214</commentid>
    <comment_count>10</comment_count>
    <who name="Stephanie Lewis">slewis</who>
    <bug_when>2012-09-14 15:52:43 -0700</bug_when>
    <thetext>Committed http://trac.webkit.org/projects/webkit/changeset/128662</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>164028</attachid>
            <date>2012-09-13 19:16:01 -0700</date>
            <delta_ts>2012-09-13 20:07:43 -0700</delta_ts>
            <desc>patch</desc>
            <filename>0001-mac-future-ignores-previous-platform-TestExpectation.patch</filename>
            <type>application/octet-stream</type>
            <size>2463</size>
            <attacher name="Stephanie Lewis">slewis</attacher>
            
              <data encoding="base64">RnJvbSA3ZjNhMDZjNmVlYmRlZGZhODc5YWRmYjkxZDVmYzBiNjhiYzljZmI1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVwaGFuaWUgTGV3aXMgPHNsZXdpc0BhcHBsZS5jb20+CkRh
dGU6IFRodSwgMTMgU2VwIDIwMTIgMTk6MTQ6MDIgLTA3MDAKU3ViamVjdDogW1BBVENIXSBtYWMt
ZnV0dXJlIGlnbm9yZXMgcHJldmlvdXMgcGxhdGZvcm0gVGVzdEV4cGVjdGF0aW9ucy4KIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjcxOC4KClJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgoKVGVzdEV4cGVjdGF0aW9ucyBtYXRjaCBhbiBleHBlY3RhdGlvbidzIGNv
bmZpZ3VyYXRvbiBhZ2FpbnN0IGEgbGlzdCBvZiBjb25maWd1cmF0aW9ucyB0aGF0IGFyZQp2YWxp
ZCBmb3IgdGhhdCBwb3J0LiAgVGhhdCBsaXN0IGRvZXMgbm90IGNvbnRhaW4gbWFjLWZ1dHVyZSBz
byBub25lIG9mIHRoZSBleHBlY3RhdGlvbnMgY2FuIGJlCmFwcGxpZWQuCgoqIFNjcmlwdHMvd2Vi
a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYXBwbGUucHk6CihBcHBsZVBvcnQuX2dlbmVyYXRlX2Fs
bF90ZXN0X2NvbmZpZ3VyYXRpb25zKToKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogVG9vbHMvU2NyaXB0
cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9hcHBsZS5weSB8ICAgIDMgKystCiAyIGZpbGVz
IGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9U
b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzg3MWMxMi4uNzNhMWE5NyAx
MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE3IEBACisyMDEyLTA5LTEzICBTdGVwaGFuaWUgTGV3aXMgIDxzbGV3aXNAYXBwbGUuY29t
PgorCisgICAgICAgIG1hYy1mdXR1cmUgaWdub3JlcyBwcmV2aW91cyBwbGF0Zm9ybSBUZXN0RXhw
ZWN0YXRpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9OTY3MTguCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgVGVzdEV4cGVjdGF0aW9ucyBtYXRjaCBhbiBleHBlY3RhdGlvbidzIGNvbmZpZ3VyYXRvbiBh
Z2FpbnN0IGEgbGlzdCBvZiBjb25maWd1cmF0aW9ucyB0aGF0IGFyZSAKKyAgICAgICAgdmFsaWQg
Zm9yIHRoYXQgcG9ydC4gIFRoYXQgbGlzdCBkb2VzIG5vdCBjb250YWluIG1hYy1mdXR1cmUgc28g
bm9uZSBvZiB0aGUgZXhwZWN0YXRpb25zIGNhbiBiZQorICAgICAgICBhcHBsaWVkLgorCisgICAg
ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9hcHBsZS5weToKKyAgICAg
ICAgKEFwcGxlUG9ydC5fZ2VuZXJhdGVfYWxsX3Rlc3RfY29uZmlndXJhdGlvbnMpOgorCiAyMDEy
LTA5LTEzICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CiAKICAgICAgICAgQWRkIGdl
bmRlci1uZXV0cmFsIGZvcm0gb2Ygd2Via2l0LXBhdGNoIGxhbmQtY293Ym95CmRpZmYgLS1naXQg
YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2FwcGxlLnB5IGIvVG9v
bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9hcHBsZS5weQppbmRleCBkOGUx
NjQ5Li4wNTU0MTlhIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90
ZXN0cy9wb3J0L2FwcGxlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl
c3RzL3BvcnQvYXBwbGUucHkKQEAgLTkyLDcgKzkyLDggQEAgY2xhc3MgQXBwbGVQb3J0KFBvcnQp
OgogCiAgICAgZGVmIF9nZW5lcmF0ZV9hbGxfdGVzdF9jb25maWd1cmF0aW9ucyhzZWxmKToKICAg
ICAgICAgY29uZmlndXJhdGlvbnMgPSBbXQotICAgICAgICBmb3IgcG9ydF9uYW1lIGluIHNlbGYu
VkVSU0lPTl9GQUxMQkFDS19PUkRFUjoKKyAgICAgICAgYWxsb3dlZF9wb3J0X25hbWVzID0gc2Vs
Zi5WRVJTSU9OX0ZBTExCQUNLX09SREVSICsgW3NlbGYub3BlcmF0aW5nX3N5c3RlbSgpICsgIi1m
dXR1cmUiXQorICAgICAgICBmb3IgcG9ydF9uYW1lIGluIGFsbG93ZWRfcG9ydF9uYW1lczoKICAg
ICAgICAgICAgIGZvciBidWlsZF90eXBlIGluIHNlbGYuQUxMX0JVSUxEX1RZUEVTOgogICAgICAg
ICAgICAgICAgIGZvciBhcmNoaXRlY3R1cmUgaW4gc2VsZi5BUkNISVRFQ1RVUkVTOgogICAgICAg
ICAgICAgICAgICAgICBjb25maWd1cmF0aW9ucy5hcHBlbmQoVGVzdENvbmZpZ3VyYXRpb24odmVy
c2lvbj1zZWxmLl9zdHJpcF9wb3J0X25hbWVfcHJlZml4KHBvcnRfbmFtZSksIGFyY2hpdGVjdHVy
ZT1hcmNoaXRlY3R1cmUsIGJ1aWxkX3R5cGU9YnVpbGRfdHlwZSkpCi0tIAoxLjcuMTAuMiAoQXBw
bGUgR2l0LTMzKQoK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>164034</attachid>
            <date>2012-09-13 20:07:43 -0700</date>
            <delta_ts>2012-09-14 14:47:32 -0700</delta_ts>
            <desc>patch.txt?</desc>
            <filename>0001-mac-future-ignores-previous-platform-TestExpectation.txt</filename>
            <type>text/plain</type>
            <size>2463</size>
            <attacher name="Stephanie Lewis">slewis</attacher>
            
              <data encoding="base64">RnJvbSA3ZjNhMDZjNmVlYmRlZGZhODc5YWRmYjkxZDVmYzBiNjhiYzljZmI1IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVwaGFuaWUgTGV3aXMgPHNsZXdpc0BhcHBsZS5jb20+CkRh
dGU6IFRodSwgMTMgU2VwIDIwMTIgMTk6MTQ6MDIgLTA3MDAKU3ViamVjdDogW1BBVENIXSBtYWMt
ZnV0dXJlIGlnbm9yZXMgcHJldmlvdXMgcGxhdGZvcm0gVGVzdEV4cGVjdGF0aW9ucy4KIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjcxOC4KClJldmlld2VkIGJ5IE5P
Qk9EWSAoT09QUyEpLgoKVGVzdEV4cGVjdGF0aW9ucyBtYXRjaCBhbiBleHBlY3RhdGlvbidzIGNv
bmZpZ3VyYXRvbiBhZ2FpbnN0IGEgbGlzdCBvZiBjb25maWd1cmF0aW9ucyB0aGF0IGFyZQp2YWxp
ZCBmb3IgdGhhdCBwb3J0LiAgVGhhdCBsaXN0IGRvZXMgbm90IGNvbnRhaW4gbWFjLWZ1dHVyZSBz
byBub25lIG9mIHRoZSBleHBlY3RhdGlvbnMgY2FuIGJlCmFwcGxpZWQuCgoqIFNjcmlwdHMvd2Vi
a2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvYXBwbGUucHk6CihBcHBsZVBvcnQuX2dlbmVyYXRlX2Fs
bF90ZXN0X2NvbmZpZ3VyYXRpb25zKToKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogVG9vbHMvU2NyaXB0
cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9hcHBsZS5weSB8ICAgIDMgKystCiAyIGZpbGVz
IGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9U
b29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzg3MWMxMi4uNzNhMWE5NyAx
MDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE3IEBACisyMDEyLTA5LTEzICBTdGVwaGFuaWUgTGV3aXMgIDxzbGV3aXNAYXBwbGUuY29t
PgorCisgICAgICAgIG1hYy1mdXR1cmUgaWdub3JlcyBwcmV2aW91cyBwbGF0Zm9ybSBUZXN0RXhw
ZWN0YXRpb25zLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/
aWQ9OTY3MTguCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg
ICAgVGVzdEV4cGVjdGF0aW9ucyBtYXRjaCBhbiBleHBlY3RhdGlvbidzIGNvbmZpZ3VyYXRvbiBh
Z2FpbnN0IGEgbGlzdCBvZiBjb25maWd1cmF0aW9ucyB0aGF0IGFyZSAKKyAgICAgICAgdmFsaWQg
Zm9yIHRoYXQgcG9ydC4gIFRoYXQgbGlzdCBkb2VzIG5vdCBjb250YWluIG1hYy1mdXR1cmUgc28g
bm9uZSBvZiB0aGUgZXhwZWN0YXRpb25zIGNhbiBiZQorICAgICAgICBhcHBsaWVkLgorCisgICAg
ICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9hcHBsZS5weToKKyAgICAg
ICAgKEFwcGxlUG9ydC5fZ2VuZXJhdGVfYWxsX3Rlc3RfY29uZmlndXJhdGlvbnMpOgorCiAyMDEy
LTA5LTEzICBQaGlsaXAgUm9nZXJzICA8cGRyQGdvb2dsZS5jb20+CiAKICAgICAgICAgQWRkIGdl
bmRlci1uZXV0cmFsIGZvcm0gb2Ygd2Via2l0LXBhdGNoIGxhbmQtY293Ym95CmRpZmYgLS1naXQg
YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2FwcGxlLnB5IGIvVG9v
bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9hcHBsZS5weQppbmRleCBkOGUx
NjQ5Li4wNTU0MTlhIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90
ZXN0cy9wb3J0L2FwcGxlLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rl
c3RzL3BvcnQvYXBwbGUucHkKQEAgLTkyLDcgKzkyLDggQEAgY2xhc3MgQXBwbGVQb3J0KFBvcnQp
OgogCiAgICAgZGVmIF9nZW5lcmF0ZV9hbGxfdGVzdF9jb25maWd1cmF0aW9ucyhzZWxmKToKICAg
ICAgICAgY29uZmlndXJhdGlvbnMgPSBbXQotICAgICAgICBmb3IgcG9ydF9uYW1lIGluIHNlbGYu
VkVSU0lPTl9GQUxMQkFDS19PUkRFUjoKKyAgICAgICAgYWxsb3dlZF9wb3J0X25hbWVzID0gc2Vs
Zi5WRVJTSU9OX0ZBTExCQUNLX09SREVSICsgW3NlbGYub3BlcmF0aW5nX3N5c3RlbSgpICsgIi1m
dXR1cmUiXQorICAgICAgICBmb3IgcG9ydF9uYW1lIGluIGFsbG93ZWRfcG9ydF9uYW1lczoKICAg
ICAgICAgICAgIGZvciBidWlsZF90eXBlIGluIHNlbGYuQUxMX0JVSUxEX1RZUEVTOgogICAgICAg
ICAgICAgICAgIGZvciBhcmNoaXRlY3R1cmUgaW4gc2VsZi5BUkNISVRFQ1RVUkVTOgogICAgICAg
ICAgICAgICAgICAgICBjb25maWd1cmF0aW9ucy5hcHBlbmQoVGVzdENvbmZpZ3VyYXRpb24odmVy
c2lvbj1zZWxmLl9zdHJpcF9wb3J0X25hbWVfcHJlZml4KHBvcnRfbmFtZSksIGFyY2hpdGVjdHVy
ZT1hcmNoaXRlY3R1cmUsIGJ1aWxkX3R5cGU9YnVpbGRfdHlwZSkpCi0tIAoxLjcuMTAuMiAoQXBw
bGUgR2l0LTMzKQoK
</data>
<flag name="review"
          id="175686"
          type_id="1"
          status="+"
          setter="dpranke"
    />
          </attachment>
      

    </bug>

</bugzilla>