96715 2012-09-13 18:11:47 -0700 Remove Blob.webkitSlice 2012-09-19 18:40:44 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 1 abarth abarth kinuko mjs ojan syoichi webkit.review.bot oldest_to_newest 720182 0 abarth 2012-09-13 18:11:47 -0700 Remove Blob.webkitSlice 720185 1 164019 abarth 2012-09-13 18:13:49 -0700 Created attachment 164019 Patch 720313 2 164019 fishd 2012-09-13 22:28:46 -0700 Comment on attachment 164019 Patch It's not totally clear to me from those metrics that we won't break some sites with this change. Let's give it a try, but it would probably be good to delay this until after the Chrome 23 branch (which is cut next Tuesday IIRC). 720392 3 abarth 2012-09-14 00:14:28 -0700 Yeah, I'm not sure how to interpret the metrics either. We'll know better after we try a few of these and see where we run into problems. 724014 4 164019 abarth 2012-09-19 17:57:58 -0700 Comment on attachment 164019 Patch Fingers crossed. 724036 5 164019 webkit.review.bot 2012-09-19 18:14:56 -0700 Comment on attachment 164019 Patch Rejecting attachment 164019 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: static-dashboards/flakiness_dashboard_unittests.js Failed to merge in the changes. Patch failed at 0001 update flakiness dashboard after cutover to new test expectations syntax When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/13944006 724054 6 164019 webkit.review.bot 2012-09-19 18:40:40 -0700 Comment on attachment 164019 Patch Clearing flags on attachment: 164019 Committed r129082: <http://trac.webkit.org/changeset/129082> 724055 7 webkit.review.bot 2012-09-19 18:40:44 -0700 All reviewed patches have been landed. Closing bug. 164019 2012-09-13 18:13:49 -0700 2012-09-19 18:40:40 -0700 Patch bug-96715-20120913181321.patch text/plain 6516 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NTEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmYzNzg3ODU0NGJiYzY1 NGM5MDEwMTIzNTE2YTc1YzM3MDA1NmQ0MS4uNDM4NjQ4NzBmZWI0NGVlNjEwMjVmYWVjNzY2MmU5 ZTY3NTg0YzhkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI5IEBACiAyMDEyLTA5LTEzICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmVtb3ZlIEJsb2Iud2Via2l0 U2xpY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2 NzE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQmFz ZWQgb24gdGhlc2UgdXNhZ2UgbWV0cmljcywgaXQgYXBwZWFycyB0aGF0IGl0IGlzIHNhZmUgdG8g cmVtb3ZlCisgICAgICAgIEJsb2Iud2Via2l0U2xpY2UuIEZvbGtzIHRoYXQgd2VyZSBwcmV2aW91 c2x5IGNhbGxpbmcgd2Via2l0U2xpY2Ugc2hvdWxkCisgICAgICAgIGp1c3QgY2FsbCBzbGljZSBp bnN0ZWFkLiBUaGV5IGRvIHRoZSBzYW1lIHRoaW5nLgorCisgICAgICAgIFJhdGlvIG9mIEJsb2Iu d2Via2l0U2xpY2UgY2FsbHMgdG8gQmxvYi5zbGljZTogMTQuODclCisgICAgICAgIFJhdGlvIG9m IEJsb2Iud2Via2l0U2xpY2UgY2FsbHMgdG8gRG9jdW1lbnQgY3JlYXRpb246IDAuMDA1MyUKKwor ICAgICAgICAqIGZpbGVhcGkvQmxvYi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCbG9iOjpzbGlj ZSk6CisgICAgICAgICogZmlsZWFwaS9CbG9iLmg6CisgICAgICAgIChCbG9iKToKKyAgICAgICAg KiBmaWxlYXBpL0Jsb2IuaWRsOgorICAgICAgICAqIGZpbGVhcGkvRmlsZS5oOgorICAgICAgICAo RmlsZSk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9GaWxlVXRpbHMuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuQ2h1bmtlZEZpbGVSZWFkZXIucHJvdG90eXBlLl9sb2FkQ2h1bmsp OgorCisyMDEyLTA5LTEzICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAg ICAgUkVHUkVTU0lPTihyMTI1MTI2KTogSXQgbWFkZSBmYXN0L2V2ZW50cy9rZXlldmVudC1pZnJh bWUtcmVtb3ZlZC1jcmFzaC5odG1sIGFzc2VydAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTM2NTQKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv ZmlsZWFwaS9CbG9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvQmxvYi5jcHAKaW5kZXgg NDMxZjE3NjRiODA3ZjRlY2Y4ZDBiZmM1ODFjMWIwMjUzMGU1ZjJlMS4uMjkxYTIyNzI5OGE3Njdl ZWFkYWFmOWZlYTZjMDliNmNkNGVmMjFjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmls ZWFwaS9CbG9iLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0Jsb2IuY3BwCkBAIC04 OSwyMSArODksNiBAQCBCbG9iOjp+QmxvYigpCiAjaWYgRU5BQkxFKEJMT0IpCiBQYXNzUmVmUHRy PEJsb2I+IEJsb2I6OnNsaWNlKGxvbmcgbG9uZyBzdGFydCwgbG9uZyBsb25nIGVuZCwgY29uc3Qg U3RyaW5nJiBjb250ZW50VHlwZSkgY29uc3QKIHsKLSAgICBIaXN0b2dyYW1TdXBwb3J0OjpoaXN0 b2dyYW1FbnVtZXJhdGlvbigiV2ViQ29yZS5CbG9iLnNsaWNlIiwgU2xpY2VXaXRob3V0UHJlZml4 LCBTbGljZUhpc3RvZ3JhbUVudW1NYXgpOwotICAgIHJldHVybiBzbGljZUludGVybmFsKHN0YXJ0 LCBlbmQsIGNvbnRlbnRUeXBlKTsKLX0KLQotUGFzc1JlZlB0cjxCbG9iPiBCbG9iOjp3ZWJraXRT bGljZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0LCBsb25nIGxvbmcgc3RhcnQsIGxv bmcgbG9uZyBlbmQsIGNvbnN0IFN0cmluZyYgY29udGVudFR5cGUpIGNvbnN0Ci17Ci0gICAgU3Ry aW5nIG1lc3NhZ2UoIkJsb2Iud2Via2l0U2xpY2UoKSBpcyBkZXByZWNhdGVkLiBVc2UgQmxvYi5z bGljZSgpIGluc3RlYWQuIik7Ci0gICAgY29udGV4dC0+YWRkQ29uc29sZU1lc3NhZ2UoSlNNZXNz YWdlU291cmNlLCBMb2dNZXNzYWdlVHlwZSwgV2FybmluZ01lc3NhZ2VMZXZlbCwgbWVzc2FnZSk7 Ci0KLSAgICBIaXN0b2dyYW1TdXBwb3J0OjpoaXN0b2dyYW1FbnVtZXJhdGlvbigiV2ViQ29yZS5C bG9iLnNsaWNlIiwgU2xpY2VXaXRoUHJlZml4LCBTbGljZUhpc3RvZ3JhbUVudW1NYXgpOwotICAg IHJldHVybiBzbGljZUludGVybmFsKHN0YXJ0LCBlbmQsIGNvbnRlbnRUeXBlKTsKLX0KLQotUGFz c1JlZlB0cjxCbG9iPiBCbG9iOjpzbGljZUludGVybmFsKGxvbmcgbG9uZyBzdGFydCwgbG9uZyBs b25nIGVuZCwgY29uc3QgU3RyaW5nJiBjb250ZW50VHlwZSkgY29uc3QKLXsKICAgICAvLyBXaGVu IHdlIHNsaWNlIGEgZmlsZSBmb3IgdGhlIGZpcnN0IHRpbWUsIHdlIG9idGFpbiBhIHNuYXBzaG90 IG9mIHRoZSBmaWxlIGJ5IGNhcHR1cmluZyBpdHMgY3VycmVudCBzaXplIGFuZCBtb2RpZmljYXRp b24gdGltZS4KICAgICAvLyBUaGUgbW9kaWZpY2F0aW9uIHRpbWUgd2lsbCBiZSB1c2VkIHRvIHZl cmlmeSBpZiB0aGUgZmlsZSBoYXMgYmVlbiBjaGFuZ2VkIG9yIG5vdCwgd2hlbiB0aGUgdW5kZXJs eWluZyBkYXRhIGFyZSBhY2Nlc3NlZC4KICAgICBsb25nIGxvbmcgc2l6ZTsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvQmxvYi5oIGIvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9C bG9iLmgKaW5kZXggOWNkODAwMDhhOWQ3MzdkOWNlMmYyZjdlNzk5M2EzNjIxM2M5MDRlMy4uOTg5 OGUyMzhiZWRlYWFiYTJjMjc0YThiZTY1ZGUzOTcyNDcxMTgyYiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZmlsZWFwaS9CbG9iLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9CbG9i LmgKQEAgLTcxLDEwICs3MSw2IEBAIHB1YmxpYzoKIAogI2lmIEVOQUJMRShCTE9CKQogICAgIFBh c3NSZWZQdHI8QmxvYj4gc2xpY2UobG9uZyBsb25nIHN0YXJ0ID0gMCwgbG9uZyBsb25nIGVuZCA9 IHN0ZDo6bnVtZXJpY19saW1pdHM8bG9uZyBsb25nPjo6bWF4KCksIGNvbnN0IFN0cmluZyYgY29u dGVudFR5cGUgPSBTdHJpbmcoKSkgY29uc3Q7Ci0KLSAgICAvLyBQcmVmaXhlZCB2ZXJzaW9uIGlz IGRlcHJlY2F0ZWQuIFRoaXMgaW50ZXJuYWxseSBjYWxscyBzbGljZUludGVybmFsKCkgKGFzIHNs aWNlKCkgZG9lcykgYWZ0ZXIgc2hvd2luZyBhIGRlcHJlY2F0aW9uIG1lc3NhZ2UuCi0gICAgUGFz c1JlZlB0cjxCbG9iPiB3ZWJraXRTbGljZShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgbG9uZyBs b25nIHN0YXJ0ID0gMCwgbG9uZyBsb25nIGVuZCA9IHN0ZDo6bnVtZXJpY19saW1pdHM8bG9uZyBs b25nPjo6bWF4KCksIGNvbnN0IFN0cmluZyYgY29udGVudFR5cGUgPSBTdHJpbmcoKSkgY29uc3Q7 Ci0KICNlbmRpZgogCiBwcm90ZWN0ZWQ6CkBAIC04NCwxMCArODAsNiBAQCBwcm90ZWN0ZWQ6CiAg ICAgLy8gRm9yIGRlc2VyaWFsaXphdGlvbi4KICAgICBCbG9iKGNvbnN0IEtVUkwmIHNyY1VSTCwg Y29uc3QgU3RyaW5nJiB0eXBlLCBsb25nIGxvbmcgc2l6ZSk7CiAKLSNpZiBFTkFCTEUoQkxPQikK LSAgICBQYXNzUmVmUHRyPEJsb2I+IHNsaWNlSW50ZXJuYWwobG9uZyBsb25nIHN0YXJ0LCBsb25n IGxvbmcgZW5kLCBjb25zdCBTdHJpbmcmIGNvbnRlbnRUeXBlKSBjb25zdDsKLSNlbmRpZgotCiAg ICAgLy8gVGhpcyBpcyBhbiBpbnRlcm5hbCBVUkwgcmVmZXJyaW5nIHRvIHRoZSBibG9iIGRhdGEg YXNzb2NpYXRlZCB3aXRoIHRoaXMgb2JqZWN0LiBJdCBzZXJ2ZXMKICAgICAvLyBhcyBhbiBpZGVu dGlmaWVyIGZvciB0aGlzIGJsb2IuIFRoZSBpbnRlcm5hbCBVUkwgaXMgbmV2ZXIgdXNlZCB0byBz b3VyY2UgdGhlIGJsb2IncyBjb250ZW50CiAgICAgLy8gaW50byBhbiBIVE1MIG9yIGZvciBGaWxl UmVhZCdpbmcsIHB1YmxpYyBibG9iIFVSTHMgbXVzdCBiZSB1c2VkIGZvciB0aG9zZSBwdXJwb3Nl cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvQmxvYi5pZGwgYi9Tb3VyY2Uv V2ViQ29yZS9maWxlYXBpL0Jsb2IuaWRsCmluZGV4IGI0NGViNDM3NTUyNDk5NTRmNTdiMzU5NGUx OTA0NGRlNDNlNGZmMjEuLjk1ODcyYWEzZDg2YzgwY2Q2YTYxNjZlZTdmYTlmNWE0Mzc2ZGI4YjEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvQmxvYi5pZGwKKysrIGIvU291cmNl L1dlYkNvcmUvZmlsZWFwaS9CbG9iLmlkbApAQCAtNDMsMTAgKzQzLDYgQEAgbW9kdWxlIGh0bWwg ewogI2lmICFkZWZpbmVkKExBTkdVQUdFX09CSkVDVElWRV9DKQogI2lmIGRlZmluZWQoRU5BQkxF X0JMT0IpICYmIEVOQUJMRV9CTE9CCiAgICAgICAgIEJsb2Igc2xpY2UoaW4gW09wdGlvbmFsXSBs b25nIGxvbmcgc3RhcnQsIGluIFtPcHRpb25hbF0gbG9uZyBsb25nIGVuZCwgaW4gW09wdGlvbmFs LCBUcmVhdE51bGxBcz1OdWxsU3RyaW5nLCBUcmVhdFVuZGVmaW5lZEFzPU51bGxTdHJpbmddIERP TVN0cmluZyBjb250ZW50VHlwZSk7Ci0jaWYgIWRlZmluZWQoTEFOR1VBR0VfR09CSkVDVCkgfHwg IUxBTkdVQUdFX0dPQkpFQ1QKLSAgICAgICAgLy8gUHJlZml4ZWQgdmVyc2lvbiBpcyBnb2luZyB0 byBiZSBkZXByZWNhdGVkLgotICAgICAgICBbQ2FsbFdpdGg9U2NyaXB0RXhlY3V0aW9uQ29udGV4 dF0gQmxvYiB3ZWJraXRTbGljZShpbiBbT3B0aW9uYWxdIGxvbmcgbG9uZyBzdGFydCwgaW4gW09w dGlvbmFsXSBsb25nIGxvbmcgZW5kLCBpbiBbT3B0aW9uYWwsIFRyZWF0TnVsbEFzPU51bGxTdHJp bmcsIFRyZWF0VW5kZWZpbmVkQXM9TnVsbFN0cmluZ10gRE9NU3RyaW5nIGNvbnRlbnRUeXBlKTsK LSNlbmRpZgogI2VuZGlmCiAjZW5kaWYKICAgICB9OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZmlsZWFwaS9GaWxlLmggYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0ZpbGUuaAppbmRleCBj ODA5NmQxYzU2ZWE5OTNkNTdlMjgxNWMxZjZmNjYwODYzMGNmMDQ1Li5kNDY2YWRjZTgyMGRlMWJm MmNkM2JlZmIwMmViNTE4YzcyNjg4NDU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9maWxl YXBpL0ZpbGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0ZpbGUuaApAQCAtMTIzLDcg KzEyMyw3IEBAIHByaXZhdGU6CiAjaWYgRU5BQkxFKEZJTEVfU1lTVEVNKQogICAgIEtVUkwgbV9m aWxlU3lzdGVtVVJMOwogCi0gICAgLy8gSWYgbV9zbmFwc2hvdFNpemUgaXMgbmVnYXRpdmUgKGlu aXRpYWxpemVkIHRvIC0xIGJ5IGRlZmF1bHQpLCB0aGUgc25hcHNob3QgbWV0YWRhdGEgaXMgaW52 YWxpZCBhbmQgd2UgcmV0cmlldmUgdGhlIGxhdGVzdCBtZXRhZGF0YSBzeW5jaHJvbm91c2x5IGlu IHNpemUoKSwgbGFzdE1vZGlmaWVkVGltZSgpIGFuZCB3ZWJraXRTbGljZSgpLgorICAgIC8vIElm IG1fc25hcHNob3RTaXplIGlzIG5lZ2F0aXZlIChpbml0aWFsaXplZCB0byAtMSBieSBkZWZhdWx0 KSwgdGhlIHNuYXBzaG90IG1ldGFkYXRhIGlzIGludmFsaWQgYW5kIHdlIHJldHJpZXZlIHRoZSBs YXRlc3QgbWV0YWRhdGEgc3luY2hyb25vdXNseSBpbiBzaXplKCksIGxhc3RNb2RpZmllZFRpbWUo KSBhbmQgc2xpY2UoKS4KICAgICAvLyBPdGhlcndpc2UsIHRoZSBzbmFwc2hvdCBtZXRhZGF0YSBh cmUgdXNlZCBkaXJlY3RseSBpbiB0aG9zZSBtZXRob2RzLgogICAgIGNvbnN0IGxvbmcgbG9uZyBt X3NuYXBzaG90U2l6ZTsKICAgICBjb25zdCBkb3VibGUgbV9zbmFwc2hvdE1vZGlmaWNhdGlvblRp bWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0ZpbGVV dGlscy5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRmlsZVV0aWxzLmpz CmluZGV4IDlkOTVhNTMxZjVhNTNiZWFiZTgyZjk0YjJhMGVjMWYxODFlZjY0NjcuLjY1YjQ5Y2I5 MTEzOTdkYjlhZTczMDg1NDM2NTQ0ODZhODQwNDE0OTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRmlsZVV0aWxzLmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvRmlsZVV0aWxzLmpzCkBAIC0xNTEsNyArMTUxLDcgQEAgV2Vi SW5zcGVjdG9yLkNodW5rZWRGaWxlUmVhZGVyLnByb3RvdHlwZSA9IHsKICAgICB7CiAgICAgICAg IHZhciBjaHVua1N0YXJ0ID0gdGhpcy5fbG9hZGVkU2l6ZTsKICAgICAgICAgdmFyIGNodW5rRW5k ID0gTWF0aC5taW4odGhpcy5fZmlsZVNpemUsIGNodW5rU3RhcnQgKyB0aGlzLl9jaHVua1NpemUp Ci0gICAgICAgIHZhciBuZXh0UGFydCA9IHRoaXMuX2ZpbGUud2Via2l0U2xpY2UoY2h1bmtTdGFy dCwgY2h1bmtFbmQpOworICAgICAgICB2YXIgbmV4dFBhcnQgPSB0aGlzLl9maWxlLnNsaWNlKGNo dW5rU3RhcnQsIGNodW5rRW5kKTsKICAgICAgICAgdGhpcy5fcmVhZGVyLnJlYWRBc1RleHQobmV4 dFBhcnQpOwogICAgIH0KIH0K