9671 2006-06-30 16:13:09 -0700 Style rules not supported by autoformatters 2009-03-10 11:29:36 -0700 1 1 1 Unclassified WebKit Tools / Tests 420+ PC OS X 10.4 RESOLVED FIXED P2 Normal --- 1 mike.emmel webkit-unassigned ddkilzer oldest_to_newest 47878 0 mike.emmel 2006-06-30 16:13:09 -0700 The current style rules for WebKit http://webkit.opendarwin.org/coding/coding-style.html Are not directly supported by available auto-code formatters astyle,indent etc. First it would be nice to develop either a modified style guidelines that would allow the use of at least one command line code formatter. I've developed a set of rules for astyle that seem close. astyle \ --mode=c \ --convert-tabs \ --indent=spaces=4 \ --brackets=linux \ --indent-switches \ --max-instatement-indent=40 \ --min-conditional-indent=4 \ --one-line=keep-statements \ --one-line=keep-blocks \ --pad=oper \ $@ But they do not work completely namespace foo { becomes namespace foo { And if() -> if () is not supported. Other artifacts are possbile. The following is needed 1.) Determine the best formatter 2.) Modify formatter if needed to fit the current rules. 3.) Change the rules to follow the formatter where its difficult or impossible to follow the current formatting rules. Note desired formatting that is not handled by auto formatting as strong suggestions. Finally schedule a full reformat of the code base if desired. 51956 1 mike.emmel 2006-10-18 09:53:38 -0700 I made this bug critical because until the choice of auto formatting tools is chosen it blocks contributions to webkit from people with a disability like dyslexia from contributing. The first step is to determine which autoformat tools are candidates for acceptance. Eclipse might be a good choice for example. Next since almost all of these tools produce unwanted changes we need to identify those. In most cases simple pattern matches can be used to find and revert unwanted autoformat changes. 49651 2 11220 mike.emmel 2006-10-25 22:32:35 -0700 Created attachment 11220 Format rules using astyle This script almost formats correctly for the Webkit style guidlines The current obvious failure is bit vars used in node and other place are not formatted correctly thus foo:1 is turun 49652 3 11221 mike.emmel 2006-10-25 22:33:24 -0700 Created attachment 11221 Format rules using astyle This script almost formats correctly for the Webkit style guidlines The current obvious failure is bit vars used in node and other place are not formatted correctly thus foo:1; becomes foo: 1; foo:1 is turun 48439 4 mjs 2006-10-31 04:00:00 -0800 The autoformatting script looks good, but I'm not sure what you'd like us to do with it since it is not, as such, a patch. If you provide a patch to add the script to WebKitTools/Scripts (with a ChangeLog or what have you) I'll happily r+ it. 48404 5 11221 mjs 2006-10-31 04:14:27 -0800 Comment on attachment 11221 Format rules using astyle r- because this is not a patch. Please resubmit as a patch, thanks! 48405 6 11220 mjs 2006-10-31 04:14:31 -0800 Comment on attachment 11220 Format rules using astyle r- because this is not a patch. Please resubmit as a patch, thanks! 48383 7 11299 mike.emmel 2006-10-31 09:02:39 -0800 Created attachment 11299 astyle and sed script for webkit style rules Astyle does not handle WebKit C++ class constructor rules. And it messes up on formatting bitfields. I will file a astyle bug on this. 47518 8 11299 mjs 2006-11-01 19:02:12 -0800 Comment on attachment 11299 astyle and sed script for webkit style rules Thanks! Also needs a ChangeLog entry and copyright notice. Please add these. 47540 9 11347 mike.emmel 2006-11-02 08:56:37 -0800 Created attachment 11347 Style script Patch with copyright and changelog entry 47616 10 mjs 2006-11-03 04:05:23 -0800 Thanks, r=me 47618 11 mjs 2006-11-03 05:01:53 -0800 Oops, didn't mean to close this. 47619 12 11347 mjs 2006-11-03 05:02:18 -0800 Comment on attachment 11347 Style script r=me 47636 13 ap 2006-11-03 11:05:51 -0800 Committed revision 17575. 113025 14 ddkilzer 2009-03-10 11:29:36 -0700 See also Bug 17124. 11220 2006-10-25 22:32:35 -0700 2006-11-02 08:56:37 -0800 Format rules using astyle wkstyle text/plain 486 mike.emmel YXN0eWxlIFwKLS1zdHlsZT1saW51eCBcCi0taW5kZW50PXNwYWNlcz00IFwKLS1jb252ZXJ0LXRh YnMgXAokQAoKI2FzdHlsZSBkb2VzIG5vdCBzdXBwb3J0IHVucGFkZGluZyBzbyB3ZSB1c2Ugc2Vk CmZvciBpIGluICRACmRvCmVjaG8gJGkKI2ZpcnN0IHByaW50IHRoZSBjaGFuZ2VzIHdlIGFyZSBt YWtpbmcKc2VkICAtbiAtZSAnCi8oIC4qL3AgIApzLyggLygvZ3AgICAKLyouICkvcApzLyApLykv Z3AgICAKI3N1cHJlc3MgcHJpbnRpbmcgdGhpcwojL15uYW1lc3BhY2UgV2ViQ29yZS97CiNOCiNz L1xuey8gey9wCiN9CicgJGkgCgojZG8gaXQgZm9yIHJlYWwKc2VkIC1lICcKI3VucGFkIGxlYWRp bmcgc3BhY2VzCnMvKCAvKC9nCiN1bnBhZCB0cmFsaW5nIHNwYWNlcwpzLyApLykvZwojZml4dXAg dGhlIG5hbXNwZWMgZGVjbAovXm5hbWVzcGFjZSBXZWJDb3JlL3sKTgpzL1xuey8gey8KfQonICRp ID4gJGkuc2VkCm12ICRpLnNlZCAkaQpkb25lCgoK 11221 2006-10-25 22:33:24 -0700 2006-11-02 08:56:37 -0800 Format rules using astyle wkstyle text/plain 486 mike.emmel YXN0eWxlIFwKLS1zdHlsZT1saW51eCBcCi0taW5kZW50PXNwYWNlcz00IFwKLS1jb252ZXJ0LXRh YnMgXAokQAoKI2FzdHlsZSBkb2VzIG5vdCBzdXBwb3J0IHVucGFkZGluZyBzbyB3ZSB1c2Ugc2Vk CmZvciBpIGluICRACmRvCmVjaG8gJGkKI2ZpcnN0IHByaW50IHRoZSBjaGFuZ2VzIHdlIGFyZSBt YWtpbmcKc2VkICAtbiAtZSAnCi8oIC4qL3AgIApzLyggLygvZ3AgICAKLyouICkvcApzLyApLykv Z3AgICAKI3N1cHJlc3MgcHJpbnRpbmcgdGhpcwojL15uYW1lc3BhY2UgV2ViQ29yZS97CiNOCiNz L1xuey8gey9wCiN9CicgJGkgCgojZG8gaXQgZm9yIHJlYWwKc2VkIC1lICcKI3VucGFkIGxlYWRp bmcgc3BhY2VzCnMvKCAvKC9nCiN1bnBhZCB0cmFsaW5nIHNwYWNlcwpzLyApLykvZwojZml4dXAg dGhlIG5hbXNwZWMgZGVjbAovXm5hbWVzcGFjZSBXZWJDb3JlL3sKTgpzL1xuey8gey8KfQonICRp ID4gJGkuc2VkCm12ICRpLnNlZCAkaQpkb25lCgoK 11299 2006-10-31 09:02:39 -0800 2006-11-02 08:56:37 -0800 astyle and sed script for webkit style rules wkstyle.patch text/plain 882 mike.emmel SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2tzdHlsZQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRU b29scy9TY3JpcHRzL3drc3R5bGUJKHJldmlzaW9uIDApCisrKyBXZWJLaXRUb29scy9TY3JpcHRz L3drc3R5bGUJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMzkgQEAKK2FzdHlsZSBcCistLXN0eWxl PWxpbnV4IFwKKy0taW5kZW50PXNwYWNlcz00IFwKKy0tY29udmVydC10YWJzIFwKKyRACisKKyNh c3R5bGUgZG9lcyBub3Qgc3VwcG9ydCB1bnBhZGRpbmcgc28gd2UgdXNlIHNlZAorZm9yIGkgaW4g JEAKK2RvCitlY2hvICRpCisjZmlyc3QgcHJpbnQgdGhlIGNoYW5nZXMgd2UgYXJlIG1ha2luZwor c2VkICAtbiAtZSAnCisvKCAuKi9wICAKK3MvKCAvKC9ncCAgIAorLyouICkvcAorcy8gKS8pL2dw ICAgCisjc3VwcmVzcyBwcmludGluZyB0aGlzCisjL15uYW1lc3BhY2UgV2ViQ29yZS97CisjTgor I3MvXG57LyB7L3AKKyN9CisnICRpIAorCisjZG8gaXQgZm9yIHJlYWwKK3NlZCAtZSAnCisjdW5w YWQgbGVhZGluZyBzcGFjZXMKK3MvKCAvKC9nCisjdW5wYWQgdHJhbGluZyBzcGFjZXMKK3MvICkv KS9nCisjZml4dXAgdGhlIG5hbXNwZWMgZGVjbAorL15uYW1lc3BhY2UgV2ViQ29yZS97CitOCitz L1xuey8gey8KK30KKycgJGkgPiAkaS5zZWQKK212ICRpLnNlZCAkaQorZG9uZQorCisKClByb3Bl cnR5IGNoYW5nZXMgb246IFdlYktpdFRvb2xzL1NjcmlwdHMvd2tzdHlsZQpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5h bWU6IHN2bjpleGVjdXRhYmxlCiAgICsgKgoK 11347 2006-11-02 08:56:37 -0800 2006-11-03 05:02:18 -0800 Style script wkstyle.patch text/plain 3042 mike.emmel SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE3NTM0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDYtMTEtMDIgIE1pY2hhZWwgRW1tZWwgIDxt aWtlLmVtbWVsQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkuCisgICAg ICAgIAorICAgICAgICBBZGRzIGFzdHlsZSBzZWQgc2NyaXB0IGZvcm1hdHMgYWNjb3JkaW5nIHRv IG1vc3Qgb2YgdGhlIHN0eWxlCisJCWd1aWRlbGluZXMuIAorICAgICAgICAKKyAgICAgICAgRml4 ZXMgYnVnCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2 NzEKKworICAgICAgICAqIFNjcmlwdHMvd2tzdHlsZToKKwogMjAwNi0xMS0wMSAgU3RlcGhhbmll IExld2lzICA8c2xld2lzQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZXZpbi4K SW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2tzdHlsZQo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRU b29scy9TY3JpcHRzL3drc3R5bGUJKHJldmlzaW9uIDApCisrKyBXZWJLaXRUb29scy9TY3JpcHRz L3drc3R5bGUJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNjYgQEAKKworIyBDb3B5cmlnaHQgKEMp IDIwMDYgTWljaGFlbCBFbW1lbDxtaWtlLmVtbWVsQGdtYWlsLmNvbT4gIEFsbCByaWdodHMgcmVz ZXJ2ZWQuCisjCisjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkg Zm9ybXMsIHdpdGggb3Igd2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJv dmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyMgYXJlIG1ldDoKKyMKKyMgMS4g IFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29w eXJpZ2h0CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9s bG93aW5nIGRpc2NsYWltZXIuCisjIDIuICBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0g bXVzdCByZXByb2R1Y2UgdGhlIGFib3ZlIGNvcHlyaWdodAorIyAgICAgbm90aWNlLCB0aGlzIGxp c3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorIyAg ICAgZG9jdW1lbnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhl IGRpc3RyaWJ1dGlvbi4KKyMgMy4gIE5laXRoZXIgdGhlIG5hbWUgb2YgQXBwbGUgQ29tcHV0ZXIs IEluYy4gKCJBcHBsZSIpIG5vciB0aGUgbmFtZXMgb2YKKyMgICAgIGl0cyBjb250cmlidXRvcnMg bWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBvciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQKKyMgICAg IGZyb20gdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlz c2lvbi4KKyMKKyMgVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBBTkQgSVRTIENP TlRSSUJVVE9SUyAiQVMgSVMiIEFORCBBTlkKKyMgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJ RVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorIyBXQVJSQU5U SUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBP U0UgQVJFCisjIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIE9SIElUUyBDT05U UklCVVRPUlMgQkUgTElBQkxFIEZPUiBBTlkKKyMgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRB TCwgU1BFQ0lBTCwgRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMKKyMgKElOQ0xV RElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RT IE9SIFNFUlZJQ0VTOworIyBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5F U1MgSU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQKKyMgT04gQU5ZIFRIRU9SWSBPRiBM SUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQK KyMgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZ IE9VVCBPRiBUSEUgVVNFIE9GCisjIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBU SEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisKK2FzdHlsZSBcCistLXN0eWxlPWxpbnV4 IFwKKy0taW5kZW50PXNwYWNlcz00IFwKKy0tY29udmVydC10YWJzIFwKKyRACisKKyNhc3R5bGUg ZG9lcyBub3Qgc3VwcG9ydCB1bnBhZGRpbmcgc28gd2UgdXNlIHNlZAorZm9yIGkgaW4gJEAKK2Rv CitlY2hvICRpCisjZmlyc3QgcHJpbnQgdGhlIGNoYW5nZXMgd2UgYXJlIG1ha2luZworc2VkICAt biAtZSAnCisvKCAuKi9wICAKK3MvKCAvKC9ncCAgIAorLyouICkvcAorcy8gKS8pL2dwICAgCisj c3VwcmVzcyBwcmludGluZyB0aGlzCisjL15uYW1lc3BhY2UgV2ViQ29yZS97CisjTgorI3MvXG57 LyB7L3AKKyN9CisnICRpIAorCisjZG8gaXQgZm9yIHJlYWwKK3NlZCAtZSAnCisjdW5wYWQgbGVh ZGluZyBzcGFjZXMKK3MvKCAvKC9nCisjdW5wYWQgdHJhbGluZyBzcGFjZXMKK3MvICkvKS9nCisj Zml4dXAgdGhlIG5hbXNwZWMgZGVjbAorL15uYW1lc3BhY2UgV2ViQ29yZS97CitOCitzL1xuey8g ey8KK30KKycgJGkgPiAkaS5zZWQKK212ICRpLnNlZCAkaQorZG9uZQorCisKClByb3BlcnR5IGNo YW5nZXMgb246IFdlYktpdFRvb2xzL1NjcmlwdHMvd2tzdHlsZQpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2 bjpleGVjdXRhYmxlCiAgICsgKgoK