96698 2012-09-13 14:53:59 -0700 Lots of repaints in the top left tile on this site 2019-07-15 01:27:56 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://www.telegraaf.nl/ P2 Normal --- 1 simon.fraser simon.fraser andersca simon.fraser thorton oldest_to_newest 719979 0 simon.fraser 2012-09-13 14:53:59 -0700 Note how, when you load http://www.telegraaf.nl/, the top left tile is continually repainting. If you scroll down you'll see a ticker on the right; deleting this ticker stops the repaints. But why is the top left tile repainting? TileCache::setNeedsDisplayInRect() calls: getTileIndexRangeForRect(intersection(enclosingIntRect(scaledRect), m_tileCoverageRect), topLeft, bottomRight); but in some cases intersection(enclosingIntRect(scaledRect), m_tileCoverageRect) returns an empty rect. However, getTileIndexRangeForRect happily returns tile 0,0 in that case, so we dirty the top left tile anyway. 719981 1 simon.fraser 2012-09-13 14:55:58 -0700 Oh, I think the repaint will fall outside of the tile rect so this is probably a no-op. However, with repaint counters on, we dirty the repaint counter in the tile. So some cleanup would be good. 720099 2 163999 simon.fraser 2012-09-13 16:39:16 -0700 Created attachment 163999 Patch 720121 3 simon.fraser 2012-09-13 17:02:41 -0700 http://trac.webkit.org/changeset/128529 163999 2012-09-13 16:39:16 -0700 2012-09-13 16:39:48 -0700 Patch bug-96698-20120913163852.patch text/plain 2220 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Nzk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGU4OTc3MzE4NTY5MDBj ZGNhYzdhZWYxMjdjNzk4MWJlODBhYWZiYi4uYzA3YWNmYTUzNzE1MmRkNTAxODM3NmFmMTc2Mjc1 ZWU3YmNiMTIzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA5LTEzICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIExvdHMgb2YgcmVw YWludHMgaW4gdGhlIHRvcCBsZWZ0IHRpbGUgb24gdGhpcyBzaXRlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjY5OAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gZ2l2ZW4gYSByZWN0IG91dHNpZGUg b2YgdGhlIGN1cnJlbnQgdGlsZSBjb3ZlcmFnZSByZWN0LAorICAgICAgICBUaWxlQ2FjaGU6OnNl dE5lZWRzRGlzcGxheUluUmVjdCgpIHdvdWxkIHRyeSB0byBpbnZhbGlkYXRlIHRoZQorICAgICAg ICB0b3AgbGVmdCB0aWxlLiBUaGlzIHdvdWxkIG5vcm1hbGx5IGJlIGEgbm8tb3AsIGV4Y2VwdCB3 aGVuIHJlcGFpbnQKKyAgICAgICAgY291bnRlcnMgYXJlIHZpc2libGUsIGluIHdoaWNoIGNhc2Ug aXQgd291bGQgaW52YWxpZGF0ZSB0aGUgY291bnRlcgorICAgICAgICBhcmVhLgorICAgICAgICAK KyAgICAgICAgRml4IGJ5IGRvaW5nIGFuIGVhcmx5IHJldHVybiBpZiB0aGUgaW50ZXJzZWN0aW9u IGJldHdlZW4gdGhlIHJlcGFpbnQKKyAgICAgICAgcmVjdCBhbmQgdGhlIHRpbGUgY292ZXJhZ2Ug cmVjdCBpcyBlbXB0eS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9UaWxl Q2FjaGUubW06CisgICAgICAgIChXZWJDb3JlOjpUaWxlQ2FjaGU6OnNldE5lZWRzRGlzcGxheUlu UmVjdCk6CisKIDIwMTItMDktMDYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5j b20+CiAKICAgICAgICAgUGFyY2VsIHVwIGxvZ2ljIHJlbGF0ZWQgdG8gc3RpY2t5IHBvc2l0aW9u aW5nIGludG8gYSBDb25zdHJhaW50cyBjbGFzcyB0aGF0IHdpbGwgbGF0ZXIgYmUgdXNlZCBmb3Ig dGhyZWFkZWQgc2Nyb2xsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jYS9tYWMvVGlsZUNhY2hlLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY2EvbWFjL1RpbGVDYWNoZS5tbQppbmRleCBhOGVkNGFhY2EwYjA2OGU0ZTc2MDM2ODQ2 MmFjMWFkNTIyZmRlZjk2Li42YmE1MjgwODkyNTFkNGNiNWY2ZWNmODVmYmY4NGQ2YWRkZGM5NTkz IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYS9tYWMvVGls ZUNhY2hlLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL21hYy9U aWxlQ2FjaGUubW0KQEAgLTEwOCw5ICsxMDgsMTMgQEAgdm9pZCBUaWxlQ2FjaGU6OnNldE5lZWRz RGlzcGxheUluUmVjdChjb25zdCBJbnRSZWN0JiByZWN0KQogICAgIHNjYWxlZFJlY3Quc2NhbGUo bV9zY2FsZSk7CiAKICAgICAvLyBGaW5kIHRoZSB0aWxlcyB0aGF0IG5lZWQgdG8gYmUgaW52YWxp ZGF0ZWQuCisgICAgSW50UmVjdCBjb3ZlcmVkUmVjdCA9IGludGVyc2VjdGlvbihlbmNsb3NpbmdJ bnRSZWN0KHNjYWxlZFJlY3QpLCBtX3RpbGVDb3ZlcmFnZVJlY3QpOworICAgIGlmIChjb3ZlcmVk UmVjdC5pc0VtcHR5KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIFRpbGVJbmRleCB0b3BMZWZ0 OwogICAgIFRpbGVJbmRleCBib3R0b21SaWdodDsKLSAgICBnZXRUaWxlSW5kZXhSYW5nZUZvclJl Y3QoaW50ZXJzZWN0aW9uKGVuY2xvc2luZ0ludFJlY3Qoc2NhbGVkUmVjdCksIG1fdGlsZUNvdmVy YWdlUmVjdCksIHRvcExlZnQsIGJvdHRvbVJpZ2h0KTsKKyAgICBnZXRUaWxlSW5kZXhSYW5nZUZv clJlY3QoY292ZXJlZFJlY3QsIHRvcExlZnQsIGJvdHRvbVJpZ2h0KTsKIAogICAgIGZvciAoaW50 IHkgPSB0b3BMZWZ0LnkoKTsgeSA8PSBib3R0b21SaWdodC55KCk7ICsreSkgewogICAgICAgICBm b3IgKGludCB4ID0gdG9wTGVmdC54KCk7IHggPD0gYm90dG9tUmlnaHQueCgpOyArK3gpIHsK