96685 2012-09-13 12:50:07 -0700 Rename forEachCell to forEachLiveCell 2012-09-13 13:08:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg ggaren oldest_to_newest 719816 0 mhahnenberg 2012-09-13 12:50:07 -0700 forEachCell actually only iterates over live cells. We should rename it to reflect what it actually does. This is also helpful because I want to add a new forEachCell that actually does iterate each and every cell in a MarkedBlock regardless of whether or not it is live. 719832 1 163945 mhahnenberg 2012-09-13 13:04:07 -0700 Created attachment 163945 Patch 719838 2 mhahnenberg 2012-09-13 13:08:27 -0700 Committed r128498: <http://trac.webkit.org/changeset/128498> 163945 2012-09-13 13:04:07 -0700 2012-09-13 13:07:36 -0700 Patch bug-96685-20120913130339.patch text/plain 6152 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI4NDk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI5IEBA CisyMDEyLTA5LTEzICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgUmVuYW1lIGZvckVhY2hDZWxsIHRvIGZvckVhY2hMaXZlQ2VsbAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY2ODUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmb3JFYWNoQ2VsbCBhY3R1YWxs eSBvbmx5IGl0ZXJhdGVzIG92ZXIgbGl2ZSBjZWxscy4gV2Ugc2hvdWxkIHJlbmFtZSBpdCB0byAK KyAgICAgICAgcmVmbGVjdCB3aGF0IGl0IGFjdHVhbGx5IGRvZXMuIFRoaXMgaXMgYWxzbyBoZWxw ZnVsIGJlY2F1c2Ugd2Ugd2FudCB0byBhZGQgYSBuZXcgCisgICAgICAgIGZvckVhY2hDZWxsIHRo YXQgYWN0dWFsbHkgZG9lcyBpdGVyYXRlIGVhY2ggYW5kIGV2ZXJ5IGNlbGwgaW4gYSBNYXJrZWRC bG9jayAKKyAgICAgICAgcmVnYXJkbGVzcyBvZiB3aGV0aGVyIG9yIG5vdCBpdCBpcyBsaXZlLgor CisgICAgICAgICogZGVidWdnZXIvRGVidWdnZXIuY3BwOgorICAgICAgICAoSlNDOjpEZWJ1Z2dl cjo6cmVjb21waWxlQWxsSlNGdW5jdGlvbnMpOgorICAgICAgICAqIGhlYXAvSGVhcC5jcHA6Cisg ICAgICAgIChKU0M6OkhlYXA6Omdsb2JhbE9iamVjdENvdW50KToKKyAgICAgICAgKEpTQzo6SGVh cDo6b2JqZWN0VHlwZUNvdW50cyk6CisgICAgICAgICogaGVhcC9NYXJrZWRCbG9jay5oOgorICAg ICAgICAoTWFya2VkQmxvY2spOgorICAgICAgICAoSlNDOjpNYXJrZWRCbG9jazo6Zm9yRWFjaExp dmVDZWxsKToKKyAgICAgICAgKiBoZWFwL01hcmtlZFNwYWNlLmg6CisgICAgICAgIChNYXJrZWRT cGFjZSk6CisgICAgICAgIChKU0M6Ok1hcmtlZFNwYWNlOjpmb3JFYWNoTGl2ZUNlbGwpOgorICAg ICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxEYXRhLmNwcDoKKyAgICAgICAgKEpTQzo6SlNHbG9iYWxE YXRhOjpyZWxlYXNlRXhlY3V0YWJsZU1lbW9yeSk6CisKIDIwMTItMDktMTMgIEZpbGlwIFBpemxv ICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBbUXRdW1dpbl0gUkVHUkVTU0lPTihyMTI4 NDAwKTogSXQgYnJva2UgdGhlIGJ1aWxkCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGVi dWdnZXIvRGVidWdnZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9k ZWJ1Z2dlci9EZWJ1Z2dlci5jcHAJKHJldmlzaW9uIDEyODQ3NikKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9kZWJ1Z2dlci9EZWJ1Z2dlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExOCw3ICsx MTgsNyBAQCB2b2lkIERlYnVnZ2VyOjpyZWNvbXBpbGVBbGxKU0Z1bmN0aW9ucyhKCiAgICAgICAg IHJldHVybjsKIAogICAgIFJlY29tcGlsZXIgcmVjb21waWxlcih0aGlzKTsKLSAgICBnbG9iYWxE YXRhLT5oZWFwLm9iamVjdFNwYWNlKCkuZm9yRWFjaENlbGwocmVjb21waWxlcik7CisgICAgZ2xv YmFsRGF0YS0+aGVhcC5vYmplY3RTcGFjZSgpLmZvckVhY2hMaXZlQ2VsbChyZWNvbXBpbGVyKTsK IH0KIAogSlNWYWx1ZSBldmFsdWF0ZUluR2xvYmFsQ2FsbEZyYW1lKGNvbnN0IFN0cmluZyYgc2Ny aXB0LCBKU1ZhbHVlJiBleGNlcHRpb24sIEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QpCklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkocmV2aXNpb24gMTI4NDc2KQorKysg U291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvSGVhcC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYx OCw3ICs2MTgsNyBAQCBzaXplX3QgSGVhcDo6cHJvdGVjdGVkR2xvYmFsT2JqZWN0Q291bnQoCiAK IHNpemVfdCBIZWFwOjpnbG9iYWxPYmplY3RDb3VudCgpCiB7Ci0gICAgcmV0dXJuIG1fb2JqZWN0 U3BhY2UuZm9yRWFjaENlbGw8Q291bnRJZkdsb2JhbE9iamVjdD4oKTsKKyAgICByZXR1cm4gbV9v YmplY3RTcGFjZS5mb3JFYWNoTGl2ZUNlbGw8Q291bnRJZkdsb2JhbE9iamVjdD4oKTsKIH0KIAog c2l6ZV90IEhlYXA6OnByb3RlY3RlZE9iamVjdENvdW50KCkKQEAgLTYzMyw3ICs2MzMsNyBAQCBQ YXNzT3duUHRyPFR5cGVDb3VudFNldD4gSGVhcDo6cHJvdGVjdGVkCiAKIFBhc3NPd25QdHI8VHlw ZUNvdW50U2V0PiBIZWFwOjpvYmplY3RUeXBlQ291bnRzKCkKIHsKLSAgICByZXR1cm4gbV9vYmpl Y3RTcGFjZS5mb3JFYWNoQ2VsbDxSZWNvcmRUeXBlPigpOworICAgIHJldHVybiBtX29iamVjdFNw YWNlLmZvckVhY2hMaXZlQ2VsbDxSZWNvcmRUeXBlPigpOwogfQogCiB2b2lkIEhlYXA6OmRlbGV0 ZUFsbENvbXBpbGVkQ29kZSgpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJr ZWRCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtl ZEJsb2NrLmgJKHJldmlzaW9uIDEyODQ3NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L01hcmtlZEJsb2NrLmgJKHdvcmtpbmcgY29weSkKQEAgLTE4NSw3ICsxODUsNyBAQCBuYW1lc3Bh Y2UgSlNDIHsKICAgICAgICAgdGVtcGxhdGUgPGludCBzaXplPiBpbmxpbmUgdm9pZCBnYXRoZXJE aXJ0eUNlbGxzV2l0aFNpemUoRGlydHlDZWxsVmVjdG9yJik7CiAjZW5kaWYKIAotICAgICAgICB0 ZW1wbGF0ZSA8dHlwZW5hbWUgRnVuY3Rvcj4gdm9pZCBmb3JFYWNoQ2VsbChGdW5jdG9yJik7Cisg ICAgICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBGdW5jdG9yPiB2b2lkIGZvckVhY2hMaXZlQ2VsbChG dW5jdG9yJik7CiAgICAgICAgIHRlbXBsYXRlIDx0eXBlbmFtZSBGdW5jdG9yPiB2b2lkIGZvckVh Y2hEZWFkQ2VsbChGdW5jdG9yJik7CiAKICAgICBwcml2YXRlOgpAQCAtNDA3LDcgKzQwNyw3IEBA IG5hbWVzcGFjZSBKU0MgewogICAgICAgICByZXR1cm4gaXNMaXZlKHN0YXRpY19jYXN0PGNvbnN0 IEpTQ2VsbCo+KHApKTsKICAgICB9CiAKLSAgICB0ZW1wbGF0ZSA8dHlwZW5hbWUgRnVuY3Rvcj4g aW5saW5lIHZvaWQgTWFya2VkQmxvY2s6OmZvckVhY2hDZWxsKEZ1bmN0b3ImIGZ1bmN0b3IpCisg ICAgdGVtcGxhdGUgPHR5cGVuYW1lIEZ1bmN0b3I+IGlubGluZSB2b2lkIE1hcmtlZEJsb2NrOjpm b3JFYWNoTGl2ZUNlbGwoRnVuY3RvciYgZnVuY3RvcikKICAgICB7CiAgICAgICAgIGZvciAoc2l6 ZV90IGkgPSBmaXJzdEF0b20oKTsgaSA8IG1fZW5kQXRvbTsgaSArPSBtX2F0b21zUGVyQ2VsbCkg ewogICAgICAgICAgICAgSlNDZWxsKiBjZWxsID0gcmVpbnRlcnByZXRfY2FzdF9wdHI8SlNDZWxs Kj4oJmF0b21zKClbaV0pOwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya2Vk U3BhY2UuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrZWRT cGFjZS5oCShyZXZpc2lvbiAxMjg0NzYpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9N YXJrZWRTcGFjZS5oCSh3b3JraW5nIGNvcHkpCkBAIC05Myw4ICs5Myw4IEBAIHB1YmxpYzoKIAog ICAgIHR5cGVkZWYgSGFzaFNldDxNYXJrZWRCbG9jayo+OjppdGVyYXRvciBCbG9ja0l0ZXJhdG9y OwogICAgIAotICAgIHRlbXBsYXRlPHR5cGVuYW1lIEZ1bmN0b3I+IHR5cGVuYW1lIEZ1bmN0b3I6 OlJldHVyblR5cGUgZm9yRWFjaENlbGwoRnVuY3RvciYpOwotICAgIHRlbXBsYXRlPHR5cGVuYW1l IEZ1bmN0b3I+IHR5cGVuYW1lIEZ1bmN0b3I6OlJldHVyblR5cGUgZm9yRWFjaENlbGwoKTsKKyAg ICB0ZW1wbGF0ZTx0eXBlbmFtZSBGdW5jdG9yPiB0eXBlbmFtZSBGdW5jdG9yOjpSZXR1cm5UeXBl IGZvckVhY2hMaXZlQ2VsbChGdW5jdG9yJik7CisgICAgdGVtcGxhdGU8dHlwZW5hbWUgRnVuY3Rv cj4gdHlwZW5hbWUgRnVuY3Rvcjo6UmV0dXJuVHlwZSBmb3JFYWNoTGl2ZUNlbGwoKTsKICAgICB0 ZW1wbGF0ZTx0eXBlbmFtZSBGdW5jdG9yPiB0eXBlbmFtZSBGdW5jdG9yOjpSZXR1cm5UeXBlIGZv ckVhY2hCbG9jayhGdW5jdG9yJik7CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgRnVuY3Rvcj4gdHlw ZW5hbWUgRnVuY3Rvcjo6UmV0dXJuVHlwZSBmb3JFYWNoQmxvY2soKTsKICAgICAKQEAgLTE0MCwy MCArMTQwLDIwIEBAIHByaXZhdGU6CiAgICAgTWFya2VkQmxvY2tTZXQgbV9ibG9ja3M7CiB9Owog Ci10ZW1wbGF0ZTx0eXBlbmFtZSBGdW5jdG9yPiBpbmxpbmUgdHlwZW5hbWUgRnVuY3Rvcjo6UmV0 dXJuVHlwZSBNYXJrZWRTcGFjZTo6Zm9yRWFjaENlbGwoRnVuY3RvciYgZnVuY3RvcikKK3RlbXBs YXRlPHR5cGVuYW1lIEZ1bmN0b3I+IGlubGluZSB0eXBlbmFtZSBGdW5jdG9yOjpSZXR1cm5UeXBl IE1hcmtlZFNwYWNlOjpmb3JFYWNoTGl2ZUNlbGwoRnVuY3RvciYgZnVuY3RvcikKIHsKICAgICBj YW5vbmljYWxpemVDZWxsTGl2ZW5lc3NEYXRhKCk7CiAKICAgICBCbG9ja0l0ZXJhdG9yIGVuZCA9 IG1fYmxvY2tzLnNldCgpLmVuZCgpOwogICAgIGZvciAoQmxvY2tJdGVyYXRvciBpdCA9IG1fYmxv Y2tzLnNldCgpLmJlZ2luKCk7IGl0ICE9IGVuZDsgKytpdCkKLSAgICAgICAgKCppdCktPmZvckVh Y2hDZWxsKGZ1bmN0b3IpOworICAgICAgICAoKml0KS0+Zm9yRWFjaExpdmVDZWxsKGZ1bmN0b3Ip OwogICAgIHJldHVybiBmdW5jdG9yLnJldHVyblZhbHVlKCk7CiB9CiAKLXRlbXBsYXRlPHR5cGVu YW1lIEZ1bmN0b3I+IGlubGluZSB0eXBlbmFtZSBGdW5jdG9yOjpSZXR1cm5UeXBlIE1hcmtlZFNw YWNlOjpmb3JFYWNoQ2VsbCgpCit0ZW1wbGF0ZTx0eXBlbmFtZSBGdW5jdG9yPiBpbmxpbmUgdHlw ZW5hbWUgRnVuY3Rvcjo6UmV0dXJuVHlwZSBNYXJrZWRTcGFjZTo6Zm9yRWFjaExpdmVDZWxsKCkK IHsKICAgICBGdW5jdG9yIGZ1bmN0b3I7Ci0gICAgcmV0dXJuIGZvckVhY2hDZWxsKGZ1bmN0b3Ip OworICAgIHJldHVybiBmb3JFYWNoTGl2ZUNlbGwoZnVuY3Rvcik7CiB9CiAKIGlubGluZSBNYXJr ZWRBbGxvY2F0b3ImIE1hcmtlZFNwYWNlOjpmaXJzdEFsbG9jYXRvcigpCkluZGV4OiBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbERhdGEuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsRGF0YS5jcHAJKHJldmlzaW9uIDEy ODQ3NikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsRGF0YS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQ1OSw3ICs0NTksNyBAQCB2b2lkIEpTR2xvYmFsRGF0YTo6cmVs ZWFzZUV4ZWN1dGFibGVNZW1vCiAgICAgICAgICAgICAgICAgcmVjb21waWxlci5jdXJyZW50bHlF eGVjdXRpbmdGdW5jdGlvbnMuYWRkKHN0YXRpY19jYXN0PEZ1bmN0aW9uRXhlY3V0YWJsZSo+KGV4 ZWN1dGFibGUpKTsKICAgICAgICAgICAgICAgICAKICAgICAgICAgfQotICAgICAgICBoZWFwLm9i amVjdFNwYWNlKCkuZm9yRWFjaENlbGw8U3RhY2tQcmVzZXJ2aW5nUmVjb21waWxlcj4ocmVjb21w aWxlcik7CisgICAgICAgIGhlYXAub2JqZWN0U3BhY2UoKS5mb3JFYWNoTGl2ZUNlbGw8U3RhY2tQ cmVzZXJ2aW5nUmVjb21waWxlcj4ocmVjb21waWxlcik7CiAgICAgfQogICAgIG1fcmVnRXhwQ2Fj aGUtPmludmFsaWRhdGVDb2RlKCk7CiAgICAgaGVhcC5jb2xsZWN0QWxsR2FyYmFnZSgpOwo=