96682 2012-09-13 12:26:30 -0700 Add a style guide rule for signed and unsigned int 2012-09-13 13:56:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rniwa rniwa dbates kenneth mitz oldest_to_newest 719790 0 rniwa 2012-09-13 12:26:30 -0700 Add a style guide rule for signed and unsigned int 719792 1 163935 rniwa 2012-09-13 12:27:32 -0700 Created attachment 163935 Patch 719813 2 163935 ggaren 2012-09-13 12:49:43 -0700 Comment on attachment 163935 Patch r=me 719848 3 rniwa 2012-09-13 13:17:09 -0700 Committed r128499: <http://trac.webkit.org/changeset/128499> 719869 4 163935 darin 2012-09-13 13:31:32 -0700 Comment on attachment 163935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163935&action=review > Websites/webkit.org/coding/coding-style.html:1065 > +signed b; // Uses "singed" instead of "int". Typo: singed 719880 5 rniwa 2012-09-13 13:49:29 -0700 Fixed the typo in r128503. 719886 6 163935 dbates 2012-09-13 13:55:33 -0700 Comment on attachment 163935 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163935&action=review > Websites/webkit.org/coding/coding-style.html:1055 > +Omit "int" when using "unsigned" modifier. Do not use "signed" modifier. Use "int" by itself instead. We should be explicit about not using the "signed" modifier for integer types. This part of the rule shouldn't be applied to objects of type char used in a bit-fields by bug 54807 comment 9 (*). (*) For completeness, Final Committee Draft of "ISO/IEC IS 14882 – Programming Languages – C++" (28 February 2011) is at <http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2011/n3242.pdf>. Bug 54807 comment 9 references an incorrect URL that was corrected in bug 54807 comment 10). For completeness, a newer 163935 2012-09-13 12:27:32 -0700 2012-09-13 13:55:33 -0700 Patch bug-96682-20120913122704.patch text/plain 1459 rniwa SW5kZXg6IFdlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYnNp dGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjg0OTIpCisrKyBXZWJzaXRlcy93 ZWJraXQub3JnL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEy LTA5LTEzICBSeW9zdWtlIE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIEFkZCBh IHN0eWxlIGd1aWRlIHJ1bGUgZm9yIHNpZ25lZCBhbmQgdW5zaWduZWQgaW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjY4MgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHJ1bGUgcGVyIGh0dHA6 Ly9saXN0cy53ZWJraXQub3JnL3BpcGVybWFpbC93ZWJraXQtZGV2LzIwMTItU2VwdGVtYmVyLzAy MjE5OS5odG1sLgorCisgICAgICAgICogY29kaW5nL2NvZGluZy1zdHlsZS5odG1sOgorCiAyMDEy LTA4LTMwICBCZW5qYW1pbiBQb3VsYWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFJlcGxhY2UgSlNDOjpVU3RyaW5nIGJ5IFdURjo6U3RyaW5nCkluZGV4OiBXZWJzaXRlcy93ZWJr aXQub3JnL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJzaXRlcy93 ZWJraXQub3JnL2NvZGluZy9jb2Rpbmctc3R5bGUuaHRtbAkocmV2aXNpb24gMTI2NjI3KQorKysg V2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTEwNDgsNiArMTA0OCwyNiBAQCB1c2luZyBuYW1lc3BhY2Ugb3RoZXI7CiAKIDwvb2w+ CiAKKzxoMyBpZD0idHlwZXMiPlR5cGVzPC9oMz4KKworPG9sPgorPGxpIGlkPSJ0eXBlcy11bnNp Z25lZCI+CitPbWl0ICJpbnQiIHdoZW4gdXNpbmcgInVuc2lnbmVkIiBtb2RpZmllci4gRG8gbm90 IHVzZSAic2lnbmVkIiBtb2RpZmllci4gVXNlICJpbnQiIGJ5IGl0c2VsZiBpbnN0ZWFkLgorPGg0 IGNsYXNzPSJyaWdodCI+UmlnaHQ6PC9oND4KKzxwcmUgY2xhc3M9ImNvZGUiPgordW5zaWduZWQg YTsKK2ludCBiOworPC9wcmU+CisKKzxoNCBjbGFzcz0id3JvbmciPldyb25nOjwvaDQ+Cis8cHJl IGNsYXNzPSJjb2RlIj4KK3Vuc2lnbmVkIGludCBhOyAvLyBEb2Vzbid0IG9taXQgImludCIuCitz aWduZWQgYjsgLy8gVXNlcyAic2luZ2VkIiBpbnN0ZWFkIG9mICJpbnQiLgorc2lnbmVkIGludCBj OyAvLyBEb2Vzbid0IG9taXQgInNpZ25lZCIuCis8L3ByZT4KKzwvbGk+Cis8L29sPgorCiA8aDMg aWQ9ImNsYXNzZXMiPkNsYXNzZXM8L2gzPgogCiA8b2w+Cg==