96679 2012-09-13 12:07:08 -0700 Typo in RenderStyle::isFlippedLinesWritingMode(), small refactoring possible 2012-09-13 14:20:52 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 giles_joplin giles_joplin eric webkit.review.bot oldest_to_newest 719758 0 giles_joplin 2012-09-13 12:07:08 -0700 The following comment from RenderStyle.h is wrong, "vertical-rl" should be vertical-lr: // Bottom of the line occurs earlier in the block; modes vertical-rl or horizontal-bt. bool isFlippedLinesWritingMode() const { return writingMode() == LeftToRightWritingMode || writingMode() == BottomToTopWritingMode; } The semantics of the inline functions in WritingMode.h are a little bit difficult to divine, at least they were for me. The functions are essentially duplicated in RenderStyle.h, where they appear with comments. The RenderStyle.h versions should be defined int terms of the inlines defined in WritingMode.h, and the handy comments could be relocated to WritingMode.h. 719777 1 163933 giles_joplin 2012-09-13 12:19:49 -0700 Created attachment 163933 Patch 719931 2 163933 webkit.review.bot 2012-09-13 14:20:49 -0700 Comment on attachment 163933 Patch Clearing flags on attachment: 163933 Committed r128508: <http://trac.webkit.org/changeset/128508> 719932 3 webkit.review.bot 2012-09-13 14:20:52 -0700 All reviewed patches have been landed. Closing bug. 163933 2012-09-13 12:19:49 -0700 2012-09-13 14:20:49 -0700 Patch tmp.patch text/plain 3708 giles_joplin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0NTBjY2I1Li4xNjcwM2U0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTItMDktMTMgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAg ICAgVHlwbyBpbiBSZW5kZXJTdHlsZTo6aXNGbGlwcGVkTGluZXNXcml0aW5nTW9kZSgpLCBzbWFs bCByZWZhY3RvcmluZyBwb3NzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTY2NzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBGaXhlZCBhIHR5cG8gaW4gdGhlIGNvbW1lbnQgZm9yIFJlbmRlclN0eWxl Ojppc0ZsaXBwZWRMaW5lc1dyaXRpbmdNb2RlKCkgYW5kIHJlZmFjdG9yZWQgdGhlCisgICAgICAg IHRocmVlIFJlbmRlcnNTdHlsZTo6aXNYWFhXcml0aW5nTW9kZSgpIGlubGluZXMgdG8gdXNlIHRo ZSBpbmxpbmVzIGRlZmluZWQgaW4gV3JpdGluZ01vZGUuaC4KKyAgICAgICAgTW92ZWQgdGhlIGNv bW1lbnRzIHRvIFdyaXRpbmdNb2RlLmgKKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgor CisgICAgICAgICogcGxhdGZvcm0vdGV4dC9Xcml0aW5nTW9kZS5oOgorICAgICAgICAoV2ViQ29y ZSk6CisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmg6CisKIDIwMTItMDkt MTMgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBGbGV4aXRlbSBt YXJnaW5zIHNob3VsZCBiZSBiYXNlZCBvbiBjb250ZW50IHdpZHRoLCBub3Qgd2lkdGgKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvV3JpdGluZ01vZGUuaCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL3RleHQvV3JpdGluZ01vZGUuaAppbmRleCA5YTRhMjA2Li45ZTVk MjhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1dyaXRpbmdNb2Rl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Xcml0aW5nTW9kZS5oCkBAIC0z NywxNiArMzcsMTkgQEAgZW51bSBXcml0aW5nTW9kZSB7CiAgICAgVG9wVG9Cb3R0b21Xcml0aW5n TW9kZSwgUmlnaHRUb0xlZnRXcml0aW5nTW9kZSwgTGVmdFRvUmlnaHRXcml0aW5nTW9kZSwgQm90 dG9tVG9Ub3BXcml0aW5nTW9kZQogfTsKIAorLy8gTGluZXMgaGF2ZSBob3Jpem9udGFsIG9yaWVu dGF0aW9uOyBtb2RlcyBob3Jpem9udGFsLXRiIG9yIGhvcml6b250YWwtYnQuCiBpbmxpbmUgYm9v bCBpc0hvcml6b250YWxXcml0aW5nTW9kZShXcml0aW5nTW9kZSB3cml0aW5nTW9kZSkKIHsKICAg ICByZXR1cm4gd3JpdGluZ01vZGUgPT0gVG9wVG9Cb3R0b21Xcml0aW5nTW9kZSB8fCB3cml0aW5n TW9kZSA9PSBCb3R0b21Ub1RvcFdyaXRpbmdNb2RlOwogfQogCisvLyBCb3R0b20gb2YgdGhlIGxp bmUgb2NjdXJzIGVhcmxpZXIgaW4gdGhlIGJsb2NrOyBtb2RlcyB2ZXJ0aWNhbC1sciBvciBob3Jp em9udGFsLWJ0LgogaW5saW5lIGJvb2wgaXNGbGlwcGVkTGluZXNXcml0aW5nTW9kZShXcml0aW5n TW9kZSB3cml0aW5nTW9kZSkKIHsKICAgICByZXR1cm4gd3JpdGluZ01vZGUgPT0gTGVmdFRvUmln aHRXcml0aW5nTW9kZSB8fCB3cml0aW5nTW9kZSA9PSBCb3R0b21Ub1RvcFdyaXRpbmdNb2RlOwog fQogCisvLyBCbG9jayBwcm9ncmVzc2lvbiBpbmNyZWFzZXMgaW4gdGhlIG9wcG9zaXRlIGRpcmVj dGlvbiB0byBub3JtYWw7IG1vZGVzIHZlcnRpY2FsLXJsIG9yIGhvcml6b250YWwtYnQuCiBpbmxp bmUgYm9vbCBpc0ZsaXBwZWRCbG9ja3NXcml0aW5nTW9kZShXcml0aW5nTW9kZSB3cml0aW5nTW9k ZSkKIHsKICAgICByZXR1cm4gd3JpdGluZ01vZGUgPT0gUmlnaHRUb0xlZnRXcml0aW5nTW9kZSB8 fCB3cml0aW5nTW9kZSA9PSBCb3R0b21Ub1RvcFdyaXRpbmdNb2RlOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmggYi9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAppbmRleCA1MDM1OWZlLi43YTExNzQ0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaApAQCAtOTU5 LDEyICs5NTksOSBAQCBwdWJsaWM6CiAgICAgRVRleHRTZWN1cml0eSB0ZXh0U2VjdXJpdHkoKSBj b25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxFVGV4dFNlY3VyaXR5PihyYXJlSW5oZXJpdGVkRGF0 YS0+dGV4dFNlY3VyaXR5KTsgfQogCiAgICAgV3JpdGluZ01vZGUgd3JpdGluZ01vZGUoKSBjb25z dCB7IHJldHVybiBzdGF0aWNfY2FzdDxXcml0aW5nTW9kZT4oaW5oZXJpdGVkX2ZsYWdzLm1fd3Jp dGluZ01vZGUpOyB9Ci0gICAgLy8gTGluZXMgaGF2ZSBob3Jpem9udGFsIG9yaWVudGF0aW9uOyBt b2RlcyBob3Jpem9udGFsLXRiIG9yIGhvcml6b250YWwtYnQuCi0gICAgYm9vbCBpc0hvcml6b250 YWxXcml0aW5nTW9kZSgpIGNvbnN0IHsgcmV0dXJuIHdyaXRpbmdNb2RlKCkgPT0gVG9wVG9Cb3R0 b21Xcml0aW5nTW9kZSB8fCB3cml0aW5nTW9kZSgpID09IEJvdHRvbVRvVG9wV3JpdGluZ01vZGU7 IH0KLSAgICAvLyBCb3R0b20gb2YgdGhlIGxpbmUgb2NjdXJzIGVhcmxpZXIgaW4gdGhlIGJsb2Nr OyBtb2RlcyB2ZXJ0aWNhbC1ybCBvciBob3Jpem9udGFsLWJ0LgotICAgIGJvb2wgaXNGbGlwcGVk TGluZXNXcml0aW5nTW9kZSgpIGNvbnN0IHsgcmV0dXJuIHdyaXRpbmdNb2RlKCkgPT0gTGVmdFRv UmlnaHRXcml0aW5nTW9kZSB8fCB3cml0aW5nTW9kZSgpID09IEJvdHRvbVRvVG9wV3JpdGluZ01v ZGU7IH0KLSAgICAvLyBCbG9jayBwcm9ncmVzc2lvbiBpbmNyZWFzZXMgaW4gdGhlIG9wcG9zaXRl IGRpcmVjdGlvbiB0byBub3JtYWw7IG1vZGVzIHZlcnRpY2FsLXJsIG9yIGhvcml6b250YWwtYnQu Ci0gICAgYm9vbCBpc0ZsaXBwZWRCbG9ja3NXcml0aW5nTW9kZSgpIGNvbnN0IHsgcmV0dXJuIHdy aXRpbmdNb2RlKCkgPT0gUmlnaHRUb0xlZnRXcml0aW5nTW9kZSB8fCB3cml0aW5nTW9kZSgpID09 IEJvdHRvbVRvVG9wV3JpdGluZ01vZGU7IH0KKyAgICBib29sIGlzSG9yaXpvbnRhbFdyaXRpbmdN b2RlKCkgY29uc3QgeyByZXR1cm4gV2ViQ29yZTo6aXNIb3Jpem9udGFsV3JpdGluZ01vZGUod3Jp dGluZ01vZGUoKSk7IH0KKyAgICBib29sIGlzRmxpcHBlZExpbmVzV3JpdGluZ01vZGUoKSBjb25z dCB7IHJldHVybiBXZWJDb3JlOjppc0ZsaXBwZWRMaW5lc1dyaXRpbmdNb2RlKHdyaXRpbmdNb2Rl KCkpOyB9CisgICAgYm9vbCBpc0ZsaXBwZWRCbG9ja3NXcml0aW5nTW9kZSgpIGNvbnN0IHsgcmV0 dXJuIFdlYkNvcmU6OmlzRmxpcHBlZEJsb2Nrc1dyaXRpbmdNb2RlKHdyaXRpbmdNb2RlKCkpOyB9 CiAKICNpZiBFTkFCTEUoQ1NTX0lNQUdFX09SSUVOVEFUSU9OKQogICAgIEltYWdlT3JpZW50YXRp b25FbnVtIGltYWdlT3JpZW50YXRpb24oKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxJbWFn ZU9yaWVudGF0aW9uRW51bT4ocmFyZUluaGVyaXRlZERhdGEtPm1faW1hZ2VPcmllbnRhdGlvbik7 IH0K