96661 2012-09-13 09:35:26 -0700 [BlackBerry] ResourceRequest string optimizations 2012-09-13 13:04:37 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 staikos yong.li.webkit mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 719590 0 staikos 2012-09-13 09:35:26 -0700 Reduce string ops in ResourceRequest 719592 1 163890 staikos 2012-09-13 09:37:02 -0700 Created attachment 163890 Patch 719757 2 163929 yong.li.webkit 2012-09-13 12:07:06 -0700 Created attachment 163929 the patch 719782 3 yong.li.webkit 2012-09-13 12:21:50 -0700 forgot to put the PR in changelog. it is PR 207965. 719806 4 163929 rwlbuis 2012-09-13 12:45:40 -0700 Comment on attachment 163929 the patch Looks good, more concise :) 719822 5 163929 webkit.review.bot 2012-09-13 12:55:20 -0700 Comment on attachment 163929 the patch Rejecting attachment 163929 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ueue/Source/WebKit/chromium/third_party/leveldatabase/src --revision 67 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 37>At revision 67. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13855116 719833 6 yong.li.webkit 2012-09-13 13:04:23 -0700 manually landed @r128497 719835 7 163929 yong.li.webkit 2012-09-13 13:04:37 -0700 Comment on attachment 163929 the patch clear flags 163890 2012-09-13 09:37:02 -0700 2012-09-13 12:07:06 -0700 Patch 96661.patch text/plain 2254 staikos SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODQ3NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTEzICBHZW9yZ2Ug U3RhaWtvcyAgPHN0YWlrb3NAd2Via2l0Lm9yZz4KKworICAgICAgICBbQmxhY2tCZXJyeV0gUmVt b3ZlIHNvbWUgZXh0cmEgc3RyaW5nIG9wZXJhdGlvbnMgZnJvbSBSZXNvdXJjZVJlcXVlc3QuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjY2MQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlcGxhY2Ugc3Rk OjpzdHJpbmcgdXNhZ2Ugd2l0aCBXVEY6OlN0cmluZyB3aGljaCBhbGxvd3MgdXMgdG8gYmUgZmFy CisgICAgICAgIG1vcmUgZWZmaWNpZW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtIG5vIGZ1 bmN0aW9uYWwgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5 L1Jlc291cmNlUmVxdWVzdEJsYWNrQmVycnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3Vy Y2VSZXF1ZXN0Ojppbml0aWFsaXplUGxhdGZvcm1SZXF1ZXN0KToKKwogMjAxMi0wOS0xMyAgU2lt b24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBwcm9zcGVjdGl2ZSBRdC9NU1ZDIGJ1aWxkIGZpeC4KSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVy cnkvUmVzb3VyY2VSZXF1ZXN0QmxhY2tCZXJyeS5jcHAJKHJldmlzaW9uIDEyODQ3MykKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVlc3RC bGFja0JlcnJ5LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjI4LDE0ICsyMjgsMTIgQEAgdm9pZCBS ZXNvdXJjZVJlcXVlc3Q6OmluaXRpYWxpemVQbGF0Zm9ybQogCiAgICAgICAgIGlmICghaHR0cEhl YWRlckZpZWxkcygpLmNvbnRhaW5zKCJBY2NlcHQtTGFuZ3VhZ2UiKSkgewogICAgICAgICAgICAg Ly8gTG9jYWxlIGhhcyB0aGUgZm9ybSAiZW4tVVMiLiBDb25zdHJ1Y3QgYWNjZXB0IGxhbmd1YWdl IGxpa2UgImVuLVVTLCBlbjtxPTAuOCIuCi0gICAgICAgICAgICBzdGQ6OnN0cmluZyBsb2NhbGUg PSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6TG9jYWxlSGFuZGxlcjo6aW5zdGFuY2UoKS0+bGFuZ3Vh Z2UoKTsKKyAgICAgICAgICAgIFN0cmluZyBsb2NhbGUgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6 TG9jYWxlSGFuZGxlcjo6aW5zdGFuY2UoKS0+bGFuZ3VhZ2UoKS5jX3N0cigpOwogICAgICAgICAg ICAgLy8gUE9TSVggbG9jYWxlIGhhcyAnXycgaW5zdGVhZCBvZiAnLScuCiAgICAgICAgICAgICAv LyBSZXBsYWNlIHRvIGNvbmZvcm0gdG8gSFRUUCBzcGVjLgotICAgICAgICAgICAgc2l6ZV90IHVu ZGVyc2NvcmUgPSBsb2NhbGUuZmluZCgnXycpOwotICAgICAgICAgICAgaWYgKHVuZGVyc2NvcmUg IT0gc3RkOjpzdHJpbmc6Om5wb3MpCi0gICAgICAgICAgICAgICAgbG9jYWxlLnJlcGxhY2UodW5k ZXJzY29yZSwgMSwgIi0iKTsKLSAgICAgICAgICAgIHN0ZDo6c3RyaW5nIGFjY2VwdExhbmd1YWdl ID0gbG9jYWxlICsgIiwgIiArIGxvY2FsZS5zdWJzdHIoMCwgMikgKyAiO3E9MC44IjsKLSAgICAg ICAgICAgIHBsYXRmb3JtUmVxdWVzdC5hZGRIZWFkZXIoIkFjY2VwdC1MYW5ndWFnZSIsIGFjY2Vw dExhbmd1YWdlLmNfc3RyKCkpOworICAgICAgICAgICAgbG9jYWxlLnJlcGxhY2UoJ18nLCAnLScp OworICAgICAgICAgICAgU3RyaW5nIGFjY2VwdExhbmd1YWdlID0gbG9jYWxlICsgIiwgIiArIGxv Y2FsZS5zdWJzdHJpbmcoMCwgMikgKyAiO3E9MC44IjsKKyAgICAgICAgICAgIHBsYXRmb3JtUmVx dWVzdC5hZGRIZWFkZXIoIkFjY2VwdC1MYW5ndWFnZSIsIGFjY2VwdExhbmd1YWdlLmxhdGluMSgp LmRhdGEoKSk7CiAgICAgICAgIH0KICAgICB9CiB9Cg== 163929 2012-09-13 12:07:06 -0700 2012-09-13 13:04:37 -0700 the patch 96661.patch text/plain 1668 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9S ZXNvdXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9SZXNvdXJjZVJlcXVlc3RCbGFja0JlcnJ5LmNwcAppbmRleCBlMWMy NTFlLi4wNjI5MTlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2JsYWNrYmVycnkvUmVzb3VyY2VSZXF1ZXN0QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L1Jlc291cmNlUmVxdWVzdEJsYWNrQmVy cnkuY3BwCkBAIC0yMiw3ICsyMiw2IEBACiAjaW5jbHVkZSAiQmxvYlJlZ2lzdHJ5SW1wbC5oIgog I2luY2x1ZGUgIkNvb2tpZU1hbmFnZXIuaCIKICNpbmNsdWRlICJSZWFkT25seUxhdGluMVN0cmlu Zy5oIgotI2luY2x1ZGUgPExvY2FsZUhhbmRsZXIuaD4KICNpbmNsdWRlIDxuZXR3b3JrL05ldHdv cmtSZXF1ZXN0Lmg+CiAjaW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvdGV4 dC9DU3RyaW5nLmg+CkBAIC0yMjYsMTcgKzIyNSw4IEBAIHZvaWQgUmVzb3VyY2VSZXF1ZXN0Ojpp bml0aWFsaXplUGxhdGZvcm1SZXF1ZXN0KE5ldHdvcmtSZXF1ZXN0JiBwbGF0Zm9ybVJlcXVlc3Qs CiAgICAgICAgICAgICAgICAgcGxhdGZvcm1SZXF1ZXN0LmFkZEhlYWRlcigiQ29va2llIiwgY29v a2llUGFpcnMuY29udGFpbnNPbmx5TGF0aW4xKCkgPyBjb29raWVQYWlycy5sYXRpbjEoKS5kYXRh KCkgOiBjb29raWVQYWlycy51dGY4KCkuZGF0YSgpKTsKICAgICAgICAgfQogCi0gICAgICAgIGlm ICghaHR0cEhlYWRlckZpZWxkcygpLmNvbnRhaW5zKCJBY2NlcHQtTGFuZ3VhZ2UiKSkgewotICAg ICAgICAgICAgLy8gTG9jYWxlIGhhcyB0aGUgZm9ybSAiZW4tVVMiLiBDb25zdHJ1Y3QgYWNjZXB0 IGxhbmd1YWdlIGxpa2UgImVuLVVTLCBlbjtxPTAuOCIuCi0gICAgICAgICAgICBzdGQ6OnN0cmlu ZyBsb2NhbGUgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6TG9jYWxlSGFuZGxlcjo6aW5zdGFuY2Uo KS0+bGFuZ3VhZ2UoKTsKLSAgICAgICAgICAgIC8vIFBPU0lYIGxvY2FsZSBoYXMgJ18nIGluc3Rl YWQgb2YgJy0nLgotICAgICAgICAgICAgLy8gUmVwbGFjZSB0byBjb25mb3JtIHRvIEhUVFAgc3Bl Yy4KLSAgICAgICAgICAgIHNpemVfdCB1bmRlcnNjb3JlID0gbG9jYWxlLmZpbmQoJ18nKTsKLSAg ICAgICAgICAgIGlmICh1bmRlcnNjb3JlICE9IHN0ZDo6c3RyaW5nOjpucG9zKQotICAgICAgICAg ICAgICAgIGxvY2FsZS5yZXBsYWNlKHVuZGVyc2NvcmUsIDEsICItIik7Ci0gICAgICAgICAgICBz dGQ6OnN0cmluZyBhY2NlcHRMYW5ndWFnZSA9IGxvY2FsZSArICIsICIgKyBsb2NhbGUuc3Vic3Ry KDAsIDIpICsgIjtxPTAuOCI7Ci0gICAgICAgICAgICBwbGF0Zm9ybVJlcXVlc3QuYWRkSGVhZGVy KCJBY2NlcHQtTGFuZ3VhZ2UiLCBhY2NlcHRMYW5ndWFnZS5jX3N0cigpKTsKLSAgICAgICAgfQor ICAgICAgICBpZiAoIWh0dHBIZWFkZXJGaWVsZHMoKS5jb250YWlucygiQWNjZXB0LUxhbmd1YWdl IikpCisgICAgICAgICAgICBwbGF0Zm9ybVJlcXVlc3QuYWRkQWNjZXB0TGFuZ3VhZ2VIZWFkZXIo KTsKICAgICB9CiB9CiAK