96656 2012-09-13 08:35:09 -0700 check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros 2012-09-14 10:05:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zoltan zoltan abarth darin dpranke eric levin ojan webkit.review.bot oldest_to_newest 719534 0 zoltan 2012-09-13 08:35:09 -0700 Stylebot sends (More than one command on the same line [whitespace/newline] [4]) warning if WTF_MAKE_NONCOPYABLE(ClassName); and WTF_MAKE_FAST_ALLOCATED; macros are used in the same line. Since it is the preferred style, the script should not warn about it. (e.g. https://bugs.webkit.org/show_bug.cgi?id=96512#c2) 720506 1 164085 zoltan 2012-09-14 03:16:42 -0700 Created attachment 164085 Patch 720859 2 164085 abarth 2012-09-14 09:58:34 -0700 Comment on attachment 164085 Patch ok 720869 3 164085 webkit.review.bot 2012-09-14 10:05:10 -0700 Comment on attachment 164085 Patch Clearing flags on attachment: 164085 Committed r128624: <http://trac.webkit.org/changeset/128624> 720871 4 webkit.review.bot 2012-09-14 10:05:14 -0700 All reviewed patches have been landed. Closing bug. 164085 2012-09-14 03:16:42 -0700 2012-09-14 10:05:10 -0700 Patch bug-96656-20120914121359.patch text/plain 2894 zoltan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4NTcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDQ5MDk2OWM5Nzc1MmI3ODY0NGJhM2NmNzU0NDBiNWI4 ZDM3NWEwYy4uNTBjZjU2YzE4Nzg3NGU3NDIzMjdiNThjMDY3NjM1Nzc1ZWVlNTlhOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA5LTE0ICBab2x0YW4gSG9ydmF0aCAgPHpvbHRhbkB3ZWJraXQub3JnPgorCisg ICAgICAgIGNoZWNrLXdlYmtpdC1zdHlsZSBzaG91bGQgbm90IHdhcm4gaW4gY2FzZSBvZiBOT05D T1BZQUJMRSBhbmQgRkFTVF9BTExPQ0FURUQgbWFjcm9zCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjY1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBhbGxvdyB0byB1c2UgV1RGX01BS0Vf Tk9OQ09QWUFCTEUoQ2xhc3NOYW1lKSBhbmQgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQKKyAgICAg ICAgbWFjcm9zIGluIDEgbGluZS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvc3R5bGUv Y2hlY2tlcnMvY3BwLnB5OgorICAgICAgICAoY2hlY2tfc3R5bGUuZGVmaW5pdGlvbnMpOgorICAg ICAgICAoY2hlY2tfc3R5bGUpOiBBZGQgcnVsZS4KKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5 L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKFdlYktpdFN0eWxlVGVz dC50ZXN0X2xpbmVfYnJlYWtpbmcpOiBBZGQgdW5pdHRlc3QuCisKIDIwMTItMDktMTQgIEd5dXlv dW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCByb2xsaW5nIG91dCByMTI4NTA3LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHAucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcC5weQppbmRleCA2YTIwYjU1YzJkOTMyYmFjOWMyODI1MGYxNjBkMGRiNWYxMzM5 MzVlLi4wOTFmZTdkNDUyNjkyYmViN2VmODZjNTcwNGYxNzAyMDRhZDJhYTUxIDEwMDY0NAotLS0g YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQpAQCAtMjU2Nyw3ICsyNTY3 LDEwIEBAIGRlZiBjaGVja19zdHlsZShjbGVhbl9saW5lcywgbGluZV9udW1iZXIsIGZpbGVfZXh0 ZW5zaW9uLCBjbGFzc19zdGF0ZSwgZmlsZV9zdGF0CiAgICAgICAgIGFuZCBub3QgKG1hdGNoKHIn LipcKC4qXCkuKnsuKi59JywgbGluZSkKICAgICAgICAgICAgICAgICAgYW5kIGNsYXNzX3N0YXRl LmNsYXNzaW5mb19zdGFjawogICAgICAgICAgICAgICAgICBhbmQgbGluZS5jb3VudCgneycpID09 IGxpbmUuY291bnQoJ30nKSkKLSAgICAgICAgYW5kIG5vdCBjbGVhbnNlZF9saW5lLnN0YXJ0c3dp dGgoJyNkZWZpbmUgJykpOgorICAgICAgICBhbmQgbm90IGNsZWFuc2VkX2xpbmUuc3RhcnRzd2l0 aCgnI2RlZmluZSAnKQorICAgICAgICAjIEl0J3Mgb2sgdG8gdXNlIHVzZSBXVEZfTUFLRV9OT05D T1BZQUJMRSBhbmQgV1RGX01BS0VfRkFTVF9BTExPQ0FURUQgbWFjcm9zIGluIDEgbGluZQorICAg ICAgICBhbmQgbm90IChjbGVhbnNlZF9saW5lLmZpbmQoIldURl9NQUtFX05PTkNPUFlBQkxFIikg IT0gLTEKKyAgICAgICAgICAgICAgICAgYW5kIGNsZWFuc2VkX2xpbmUuZmluZCgiV1RGX01BS0Vf RkFTVF9BTExPQ0FURUQiKSAhPSAtMSkpOgogICAgICAgICBlcnJvcihsaW5lX251bWJlciwgJ3do aXRlc3BhY2UvbmV3bGluZScsIDQsCiAgICAgICAgICAgICAgICdNb3JlIHRoYW4gb25lIGNvbW1h bmQgb24gdGhlIHNhbWUgbGluZScpCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0ZXN0LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkKaW5kZXggZGU5OWY1ZWQxYTgyMDZjMGIw MTNiNWU2OWE3ZjdkNDZiODQzODg4ZS4uYmNiMjhkMmVkYjFjMzYwYTM1ZWE3ZWM5MDM2YzBjMGUz ZWRkOWFkMyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vy cy9jcHBfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVj a2Vycy9jcHBfdW5pdHRlc3QucHkKQEAgLTM4NjEsNiArMzg2MSw5IEBAIGNsYXNzIFdlYktpdFN0 eWxlVGVzdChDcHBTdHlsZVRlc3RCYXNlKToKICAgICAgICAgIyAgICAgJyNkZWZpbmUgVEVTVF9B U1NFUlQoZXhwcmVzc2lvbikgZG8geyBpZiAoIShleHByZXNzaW9uKSkgeyBUZXN0c0NvbnRyb2xs ZXI6OnNoYXJlZCgpLnRlc3RGYWlsZWQoX19GSUxFX18sIF9fTElORV9fLCAjZXhwcmVzc2lvbik7 IHJldHVybjsgfSB9IHdoaWxlICgwIClcbicsCiAgICAgICAgICMgICAgICdNaXNtYXRjaGluZyBz cGFjZXMgaW5zaWRlICgpIGluIGlmICBbd2hpdGVzcGFjZS9wYXJlbnNdIFs1XScpCiAgICAgICAg IHNlbGYuYXNzZXJ0X211bHRpX2xpbmVfbGludCgKKyAgICAgICAgICAgICdXVEZfTUFLRV9OT05D T1BZQUJMRShDbGFzc05hbWUpOyBXVEZfTUFLRV9GQVNUX0FMTE9DQVRFRDtcbicsCisgICAgICAg ICAgICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbXVsdGlfbGluZV9saW50KAogICAgICAgICAg ICAgJ2lmIChjb25kaXRpb24pIHtcbicKICAgICAgICAgICAgICcgICAgZG9Tb21ldGhpbmcoKTtc bicKICAgICAgICAgICAgICcgICAgZG9Tb21ldGhpbmdBZ2FpbigpO1xuJwo=