96655 2012-09-13 08:20:49 -0700 [BLACKBERRY] Mouse events are lost. 2012-09-13 10:29:00 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 gmak webkit-unassigned mifenton tonikitoo webkit.review.bot oldest_to_newest 719517 0 gmak 2012-09-13 08:20:49 -0700 If you touch down on a non-scrollable page and move around, mouse events should always be sent unless Touch Move is consumed. 719532 1 163883 gmak 2012-09-13 08:30:57 -0700 Created attachment 163883 patch with commit log 719538 2 163883 tonikitoo 2012-09-13 08:36:38 -0700 Comment on attachment 163883 patch with commit log View in context: https://bugs.webkit.org/attachment.cgi?id=163883&action=review > Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:182 > + return viewportSize.width() < contentsSize.width() && viewportSize.height() < contentsSize.height(); do we want || here? so it can be scrollable in one direction only... > Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:280 > + if (isMainFrameScrollable(m_webPage->viewportSize(), m_webPage->contentsSize())) Given the function name I would rather pass the m_webPage object, and check all inside. Also, maybe we want actualVisibleViewportSize? 719612 3 163896 gmak 2012-09-13 10:02:28 -0700 Created attachment 163896 patch with commit log 719616 4 webkit.review.bot 2012-09-13 10:05:05 -0700 Attachment 163896 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/ChangeLog', u'Sou..." exit_code: 1 Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:278: Extra space before ) in if [whitespace/parens] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 719618 5 163896 tonikitoo 2012-09-13 10:05:21 -0700 Comment on attachment 163896 patch with commit log View in context: https://bugs.webkit.org/attachment.cgi?id=163896&action=review > Source/WebKit/blackberry/WebKitSupport/TouchEventHandler.cpp:280 > + if (isMainFrameScrollable(m_webPage) || m_webPage->m_inRegionScroller->d->isActive() ) extra spcace before last ) 719648 6 163896 webkit.review.bot 2012-09-13 10:28:58 -0700 Comment on attachment 163896 patch with commit log Clearing flags on attachment: 163896 Committed r128479: <http://trac.webkit.org/changeset/128479> 719649 7 webkit.review.bot 2012-09-13 10:29:00 -0700 All reviewed patches have been landed. Closing bug. 163883 2012-09-13 08:30:57 -0700 2012-09-13 10:02:28 -0700 patch with commit log 0001-2012-09-13-Genevieve-Mak-gmak-rim.com.patch text/plain 3132 gmak RnJvbSBkNTY3MGRiNWQxNDVkNzZhYzBkYmZmNDEwOWMxYmE4NzhjM2ZjMjQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZW5ldmlldmUgTWFrIDxnbWFrQHJpbS5jb20+CkRhdGU6IFRo dSwgMTMgU2VwIDIwMTIgMTE6MTc6MDIgLTA0MDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA5LTEz ICBHZW5ldmlldmUgTWFrICA8Z21ha0ByaW0uY29tPgoKICAgICAgICBDb250aW51ZSB0byBzZW5k IG1vdXNlIG1vdmUgZXZlbnRzIHRvIGEgbm9uLXNjcm9sbGFibGUgcGFnZQogICAgICAgIGV2ZW4g aWYgdGhleSBhcmUgbm90IGNvbnN1bWVkLgogICAgICAgIFBSICMyMDcwMjQKICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY2NTUKCiAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICogV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50 SGFuZGxlci5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6aXNNYWluRnJhbWVTY3Jv bGxhYmxlKToKICAgICAgICAoV2ViS2l0KToKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpU b3VjaEV2ZW50SGFuZGxlcjo6aGFuZGxlVG91Y2hQb2ludCk6Ci0tLQogU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysr CiAuLi4vYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcCB8ICAg IDkgKysrKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggMDQ4ODI0Ni4uYTg3OTQx NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTIt MDktMTMgIEdlbmV2aWV2ZSBNYWsgIDxnbWFrQHJpbS5jb20+CisKKyAgICAgICAgQ29udGludWUg dG8gc2VuZCBtb3VzZSBtb3ZlIGV2ZW50cyB0byBhIG5vbi1zY3JvbGxhYmxlIHBhZ2UKKyAgICAg ICAgZXZlbiBpZiB0aGV5IGFyZSBub3QgY29uc3VtZWQuCisgICAgICAgIFBSICMyMDcwMjQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NjU1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRTdXBw b3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 aXNNYWluRnJhbWVTY3JvbGxhYmxlKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChCbGFj a0JlcnJ5OjpXZWJLaXQ6OlRvdWNoRXZlbnRIYW5kbGVyOjpoYW5kbGVUb3VjaFBvaW50KToKKwog MjAxMi0wOS0xMSAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CiAKICAgICAgICAg W0JsYWNrQmVycnldIFNlbGVjdGlvbkhhbmRsZXIgZHJvcHMgY2FyZXQgY2hhbmdlIG5vdGlmaWNh dGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L1RvdWNoRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcAppbmRleCA0ZWNkNWI0Li41YWI0YmZjIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50 SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQv VG91Y2hFdmVudEhhbmRsZXIuY3BwCkBAIC0xNzcsNiArMTc3LDExIEBAIHZvaWQgVG91Y2hFdmVu dEhhbmRsZXI6OnRvdWNoSG9sZEV2ZW50KCkKICAgICAgICAgbV93ZWJQYWdlLT5jbGVhckZvY3Vz Tm9kZSgpOwogfQogCitzdGF0aWMgYm9vbCBpc01haW5GcmFtZVNjcm9sbGFibGUoY29uc3QgSW50 U2l6ZSYgdmlld3BvcnRTaXplLCBjb25zdCBJbnRTaXplJiBjb250ZW50c1NpemUpCit7CisgICAg cmV0dXJuIHZpZXdwb3J0U2l6ZS53aWR0aCgpIDwgY29udGVudHNTaXplLndpZHRoKCkgJiYgdmll d3BvcnRTaXplLmhlaWdodCgpIDwgY29udGVudHNTaXplLmhlaWdodCgpOworfQorCiBib29sIFRv dWNoRXZlbnRIYW5kbGVyOjpoYW5kbGVUb3VjaFBvaW50KFBsYXRmb3JtOjpUb3VjaFBvaW50JiBw b2ludCwgYm9vbCB1c2VGYXRGaW5nZXJzKQogewogICAgIC8vIEVuYWJsZSBpbnB1dCBtb2RlIG9u IGFueSB0b3VjaCBldmVudC4KQEAgLTI3MSw3ICsyNzYsOSBAQCBib29sIFRvdWNoRXZlbnRIYW5k bGVyOjpoYW5kbGVUb3VjaFBvaW50KFBsYXRmb3JtOjpUb3VjaFBvaW50JiBwb2ludCwgYm9vbCB1 c2VGYQogICAgICAgICAgICAgUGxhdGZvcm1Nb3VzZUV2ZW50IG1vdXNlRXZlbnQocG9pbnQubV9w b3MsIG1fbGFzdFNjcmVlblBvaW50LCBQbGF0Zm9ybUV2ZW50OjpNb3VzZU1vdmVkLCAxLCBMZWZ0 QnV0dG9uLCBUb3VjaFNjcmVlbik7CiAgICAgICAgICAgICBtX2xhc3RTY3JlZW5Qb2ludCA9IHBv aW50Lm1fc2NyZWVuUG9zOwogICAgICAgICAgICAgaWYgKCFtX3dlYlBhZ2UtPmhhbmRsZU1vdXNl RXZlbnQobW91c2VFdmVudCkpIHsKLSAgICAgICAgICAgICAgICBtX2NvbnZlcnRUb3VjaFRvTW91 c2UgPSBwdXJlV2l0aE1vdXNlQ29udmVyc2lvbjsKKyAgICAgICAgICAgICAgICAvLyBJZiB0aGUg cGFnZSBpcyBzY3JvbGxhYmxlIGFuZCB0aGUgZmlyc3QgZXZlbnQgaXMgbm90IGhhbmRsZWQsIGln bm9yZSBzdWJzZXF1ZW50IG1vdXNlIG1vdmVzLgorICAgICAgICAgICAgICAgIGlmIChpc01haW5G cmFtZVNjcm9sbGFibGUobV93ZWJQYWdlLT52aWV3cG9ydFNpemUoKSwgbV93ZWJQYWdlLT5jb250 ZW50c1NpemUoKSkpCisgICAgICAgICAgICAgICAgICAgIG1fY29udmVydFRvdWNoVG9Nb3VzZSA9 IHB1cmVXaXRoTW91c2VDb252ZXJzaW9uOwogICAgICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK ICAgICAgICAgICAgIH0KICAgICAgICAgICAgIHJldHVybiB0cnVlOwotLSAKMS43LjcuNAoK 163896 2012-09-13 10:02:28 -0700 2012-09-13 10:28:57 -0700 patch with commit log 0001-2012-09-13-Genevieve-Mak-gmak-rim.com.patch text/plain 3140 gmak RnJvbSBjY2MzNWRmZDc2NjIzM2QyOGIxOTQ4OTc2MjgyMTU4MDgzMzFhZmI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHZW5ldmlldmUgTWFrIDxnbWFrQHJpbS5jb20+CkRhdGU6IFRo dSwgMTMgU2VwIDIwMTIgMTE6MTc6MDIgLTA0MDAKU3ViamVjdDogW1BBVENIXSAyMDEyLTA5LTEz ICBHZW5ldmlldmUgTWFrICA8Z21ha0ByaW0uY29tPgoKICAgICAgICBDb250aW51ZSB0byBzZW5k IG1vdXNlIG1vdmUgZXZlbnRzIHRvIGEgbm9uLXNjcm9sbGFibGUgcGFnZQogICAgICAgIGV2ZW4g aWYgdGhleSBhcmUgbm90IGNvbnN1bWVkLgogICAgICAgIFBSICMyMDcwMjQKICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY2NTUKCiAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgICogV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50 SGFuZGxlci5jcHA6CiAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6aXNNYWluRnJhbWVTY3Jv bGxhYmxlKToKICAgICAgICAoV2ViS2l0KToKICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpU b3VjaEV2ZW50SGFuZGxlcjo6aGFuZGxlVG91Y2hQb2ludCk6Ci0tLQogU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysr CiAuLi4vYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcCB8ICAg IDkgKysrKysrKystCiAyIGZpbGVzIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggMDQ4ODI0Ni4uYTg3OTQx NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTIt MDktMTMgIEdlbmV2aWV2ZSBNYWsgIDxnbWFrQHJpbS5jb20+CisKKyAgICAgICAgQ29udGludWUg dG8gc2VuZCBtb3VzZSBtb3ZlIGV2ZW50cyB0byBhIG5vbi1zY3JvbGxhYmxlIHBhZ2UKKyAgICAg ICAgZXZlbiBpZiB0aGV5IGFyZSBub3QgY29uc3VtZWQuCisgICAgICAgIFBSICMyMDcwMjQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NjU1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXRTdXBw b3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcDoKKyAgICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6 aXNNYWluRnJhbWVTY3JvbGxhYmxlKToKKyAgICAgICAgKFdlYktpdCk6CisgICAgICAgIChCbGFj a0JlcnJ5OjpXZWJLaXQ6OlRvdWNoRXZlbnRIYW5kbGVyOjpoYW5kbGVUb3VjaFBvaW50KToKKwog MjAxMi0wOS0xMSAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxzc29uQHJpbS5jb20+CiAKICAgICAgICAg W0JsYWNrQmVycnldIFNlbGVjdGlvbkhhbmRsZXIgZHJvcHMgY2FyZXQgY2hhbmdlIG5vdGlmaWNh dGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0 L1RvdWNoRXZlbnRIYW5kbGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcAppbmRleCA0ZWNkNWI0Li5mNzliMTMxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50 SGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQv VG91Y2hFdmVudEhhbmRsZXIuY3BwCkBAIC0xNzcsNiArMTc3LDExIEBAIHZvaWQgVG91Y2hFdmVu dEhhbmRsZXI6OnRvdWNoSG9sZEV2ZW50KCkKICAgICAgICAgbV93ZWJQYWdlLT5jbGVhckZvY3Vz Tm9kZSgpOwogfQogCitzdGF0aWMgYm9vbCBpc01haW5GcmFtZVNjcm9sbGFibGUoY29uc3QgV2Vi UGFnZVByaXZhdGUqIHBhZ2UpCit7CisgICAgcmV0dXJuIHBhZ2UtPnZpZXdwb3J0U2l6ZSgpLndp ZHRoKCkgPCBwYWdlLT5jb250ZW50c1NpemUoKS53aWR0aCgpIHx8IHBhZ2UtPnZpZXdwb3J0U2l6 ZSgpLmhlaWdodCgpIDwgcGFnZS0+Y29udGVudHNTaXplKCkuaGVpZ2h0KCk7Cit9CisKIGJvb2wg VG91Y2hFdmVudEhhbmRsZXI6OmhhbmRsZVRvdWNoUG9pbnQoUGxhdGZvcm06OlRvdWNoUG9pbnQm IHBvaW50LCBib29sIHVzZUZhdEZpbmdlcnMpCiB7CiAgICAgLy8gRW5hYmxlIGlucHV0IG1vZGUg b24gYW55IHRvdWNoIGV2ZW50LgpAQCAtMjcxLDcgKzI3Niw5IEBAIGJvb2wgVG91Y2hFdmVudEhh bmRsZXI6OmhhbmRsZVRvdWNoUG9pbnQoUGxhdGZvcm06OlRvdWNoUG9pbnQmIHBvaW50LCBib29s IHVzZUZhCiAgICAgICAgICAgICBQbGF0Zm9ybU1vdXNlRXZlbnQgbW91c2VFdmVudChwb2ludC5t X3BvcywgbV9sYXN0U2NyZWVuUG9pbnQsIFBsYXRmb3JtRXZlbnQ6Ok1vdXNlTW92ZWQsIDEsIExl ZnRCdXR0b24sIFRvdWNoU2NyZWVuKTsKICAgICAgICAgICAgIG1fbGFzdFNjcmVlblBvaW50ID0g cG9pbnQubV9zY3JlZW5Qb3M7CiAgICAgICAgICAgICBpZiAoIW1fd2ViUGFnZS0+aGFuZGxlTW91 c2VFdmVudChtb3VzZUV2ZW50KSkgewotICAgICAgICAgICAgICAgIG1fY29udmVydFRvdWNoVG9N b3VzZSA9IHB1cmVXaXRoTW91c2VDb252ZXJzaW9uOworICAgICAgICAgICAgICAgIC8vIElmIHRo ZSBwYWdlIGlzIHNjcm9sbGFibGUgYW5kIHRoZSBmaXJzdCBldmVudCBpcyBub3QgaGFuZGxlZCwg aWdub3JlIHN1YnNlcXVlbnQgbW91c2UgbW92ZXMuCisgICAgICAgICAgICAgICAgaWYgKGlzTWFp bkZyYW1lU2Nyb2xsYWJsZShtX3dlYlBhZ2UpIHx8IG1fd2ViUGFnZS0+bV9pblJlZ2lvblNjcm9s bGVyLT5kLT5pc0FjdGl2ZSgpICkKKyAgICAgICAgICAgICAgICAgICAgbV9jb252ZXJ0VG91Y2hU b01vdXNlID0gcHVyZVdpdGhNb3VzZUNvbnZlcnNpb247CiAgICAgICAgICAgICAgICAgcmV0dXJu IGZhbHNlOwogICAgICAgICAgICAgfQogICAgICAgICAgICAgcmV0dXJuIHRydWU7Ci0tIAoxLjcu Ny40Cgo=