<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>96644</bug_id>
          
          <creation_ts>2012-09-13 07:17:44 -0700</creation_ts>
          <short_desc>Issue with convolver node usage in webkit2:webAudio API</short_desc>
          <delta_ts>2023-03-23 08:38:48 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Audio</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>Blocker</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="kdj">kdj.tikka</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>alexwriter2003</cc>
    
    <cc>gouache95</cc>
    
    <cc>pnormand</cc>
    
    <cc>s.choi</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>719435</commentid>
    <comment_count>0</comment_count>
    <who name="kdj">kdj.tikka</who>
    <bug_when>2012-09-13 07:17:44 -0700</bug_when>
    <thetext>Hi,

I was trying to run few WebAudio API applications from chrome site; especially for convolverNode.

App name: Digital DJ 
Link: http://chromium.googlecode.com/svn/trunk/samples/audio/dj.html
This application did not work properly, for small fraction the audio came and further the silence played out.

After removing the convolverNode; referring the lines in application.
...
line no.: 386: //convolver.connect(preCompressorGain);
...
line no.: 397: //setReverbImpulseResponse(&apos;impulse-responses/filter-rhythm2.wav&apos;);
...

The application worked perfectly :-) 

To investigate further, with enabled convolverNode and I added data dump logs in following places at same time:
1. ConvolverNode::process() for input(0)-&gt;bus(), to check input to convolverNode.
2. webKitWebAudioSrcLoop(), for (const_cast&lt;float*&gt;(priv-&gt;bus-&gt;channel(index)-&gt;data())).

The data for 1. is complete silence whereas for 2. it is proper convoluted stream.

Here it seems that the WebAudio API convolverNode has issue before connecting to other node. 
I tried to other application which are using ConvolverNode; result is same &quot;for small fraction the audio came and further the silence played out&quot;.

Please share your views.

Thanks and regards,
kaustubh</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>719449</commentid>
    <comment_count>1</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2012-09-13 07:36:15 -0700</bug_when>
    <thetext>That demo works fine here with your patch from bug 95833. Without that patch I can hear the pop noise glitches of bug 82347 (so I&apos;ll close the last as dupe of the first btw).

Tested with a 64-bit release build of webkitgtk.

Should we close this one?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720241</commentid>
    <comment_count>2</comment_count>
    <who name="kdj">kdj.tikka</who>
    <bug_when>2012-09-13 19:34:34 -0700</bug_when>
    <thetext>Good it is working on 64-bit !

I have tested with 32-bit machine.

Could you please share your 64-bit release details on which it is working. So that I can try for the same one at my end.

Is it OK to take tar ball &quot;WebKit r128500&quot; ?

Thanks,
kdj</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720348</commentid>
    <comment_count>3</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2012-09-13 23:21:02 -0700</bug_when>
    <thetext>What kind of details about my setup do you need?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720535</commentid>
    <comment_count>4</comment_count>
    <who name="kdj">kdj.tikka</who>
    <bug_when>2012-09-14 03:44:04 -0700</bug_when>
    <thetext>I am getting this error with WebKit r128500:

  CXX    Source/JavaScriptCore/Programs_jsc_3-jsc.o
  CXX    Source/WebKit2/gtk/Programs_WebKitWebProcess-MainGtk.o
  CXXLD  Programs/WebKitPluginProcess
libtool: link: cannot find the library `libjavascriptcoregtk-3.0.la&apos; or unhandled argument `libjavascriptcoregtk-3.0.la&apos;
make[1]: *** [Programs/WebKitPluginProcess] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory `/home/newgen/webkit-org/WebKit-r128500/WebKitBuild/Release&apos;
make: *** [all] Error 2

I tried with this path:  http://savannah.gnu.org/bugs/?30653

Could you please tell/guide the exact patch for the same ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720540</commentid>
    <comment_count>5</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2012-09-14 03:52:51 -0700</bug_when>
    <thetext>If you do build-webkit --gtk --update-gtk it should work. Please join #webkitgtk+ if you have build issues, bugzilla is not the best place to discuss about that.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>721420</commentid>
    <comment_count>6</comment_count>
    <who name="kdj">kdj.tikka</who>
    <bug_when>2012-09-15 04:24:51 -0700</bug_when>
    <thetext>Ok, I registered to #webkitgtk+ and able to build on 64bit webkitGtk with webaudio.
I tried to run the same app link. But not able to hear the audio. 

Please tell me anything more you are doing at your end.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>721685</commentid>
    <comment_count>7</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2012-09-16 22:51:39 -0700</bug_when>
    <thetext>Have you set the AUDIO_RESOURCES_PATH env variable to point to .../Source/WebCore/platform/audio/resources ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>721721</commentid>
    <comment_count>8</comment_count>
    <who name="kdj">kdj.tikka</who>
    <bug_when>2012-09-17 00:29:34 -0700</bug_when>
    <thetext>yes, after setting same Env var, Convolver node is working; thanks philippe.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>