96632 2012-09-13 04:43:43 -0700 [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp 2012-09-13 05:11:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar webkit-unassigned mario svillar webkit.review.bot oldest_to_newest 719337 0 svillar 2012-09-13 04:43:43 -0700 The problem is that getChildren() calls childrenCount() which uses getChildren() causing a never ending recursive loop. 719341 1 svillar 2012-09-13 04:47:37 -0700 BTW fixing this would be great as this is causing ~100 crashes in the WK2 bot 719344 2 163841 mario 2012-09-13 04:49:22 -0700 Created attachment 163841 Patch proposal Here is the simple patch. Sorry for the hassle, and feel free to set cq+ when reviewing it (if approved) 719355 3 163841 webkit.review.bot 2012-09-13 05:11:13 -0700 Comment on attachment 163841 Patch proposal Clearing flags on attachment: 163841 Committed r128447: <http://trac.webkit.org/changeset/128447> 719357 4 webkit.review.bot 2012-09-13 05:11:15 -0700 All reviewed patches have been landed. Closing bug. 163841 2012-09-13 04:49:22 -0700 2012-09-13 05:11:13 -0700 Patch proposal 0001-2012-09-13-Mario-Sanchez-Prada-msanchez-igalia.com.patch text/plain 2603 mario RnJvbSAyNjg4YTg1MTNlMjY3MjdlM2I3NzM4YTkwMjQyYmQ5OTc2YjY1MDg3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJpbyBTYW5jaGV6IFByYWRhIDxtc2FuY2hlekBpZ2FsaWEu Y29tPgpEYXRlOiBUaHUsIDEzIFNlcCAyMDEyIDEzOjQ3OjEyICswMjAwClN1YmplY3Q6IFtQQVRD SF0gMjAxMi0wOS0xMyAgTWFyaW8gU2FuY2hleiBQcmFkYSAgPG1zYW5jaGV6QGlnYWxpYS5jb20+ CgogICAgICAgIFtHVEtdICJJbmZpbml0ZSIgbG9vcCBpbiBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50 R3RrLmNwcAogICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NjYzMgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgRml4IHRo aXMgYnkgdXNpbmcgYXRrX29iamVjdF9nZXRfbl9hY2Nlc3NpYmxlX2NoaWxkcmVuIGluc3RlYWQg b2YKICAgICAgICBjYWxsaW5nIGdldENoaWxkcmVuKCkgZnJvbSBjaGlsZENvdW50LgoKICAgICAg ICAqIFdlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVs ZW1lbnRHdGsuY3BwOgogICAgICAgIChXVFI6OkFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmNoaWxk cmVuQ291bnQpOiBBdm9pZCB0aGUgaW5maW5pdGUKICAgICAgICBsb29wIGJ5IHVzaW5nIGF0a19v YmplY3RfZ2V0X25fYWNjZXNzaWJsZV9jaGlsZHJlbigpLgotLS0KIFRvb2xzL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAxNCArKysrKysrKysr KysrKwogLi4uL0luamVjdGVkQnVuZGxlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNw cCAgICAgICB8ICA3ICsrKystLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwg MyBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFu Z2VMb2cKaW5kZXggOTk2YjRjYy4uOWVhNDNmYSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9n CisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTEzICBNYXJp byBTYW5jaGV6IFByYWRhICA8bXNhbmNoZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSAi SW5maW5pdGUiIGxvb3AgaW4gQWNjZXNzaWJpbGl0eVVJRWxlbWVudEd0ay5jcHAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NjMyCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoaXMgYnkgdXNpbmcg YXRrX29iamVjdF9nZXRfbl9hY2Nlc3NpYmxlX2NoaWxkcmVuIGluc3RlYWQgb2YKKyAgICAgICAg Y2FsbGluZyBnZXRDaGlsZHJlbigpIGZyb20gY2hpbGRDb3VudC4KKworICAgICAgICAqIFdlYktp dFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsu Y3BwOgorICAgICAgICAoV1RSOjpBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpjaGlsZHJlbkNvdW50 KTogQXZvaWQgdGhlIGluZmluaXRlCisgICAgICAgIGxvb3AgYnkgdXNpbmcgYXRrX29iamVjdF9n ZXRfbl9hY2Nlc3NpYmxlX2NoaWxkcmVuKCkuCisKIDIwMTItMDktMDEgIFhpYW56aHUgV2FuZyAg PHdhbmd4aWFuemh1QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbQ2hyb21pdW0tQW5kcm9pZF0g UmVtb3ZlIGhhcmQtY29kZWQgc2tpcHBlZCBkaXJlY3RvcmllcyBpbiBjaHJvbWl1bV9hbmRyb2lk LnB5CmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL2d0 ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3RrLmNwcCBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCmluZGV4IGU4 M2I3ODQuLjY1OTkzNDYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0 ZWRCdW5kbGUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCisrKyBiL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRH dGsuY3BwCkBAIC0xNjYsOSArMTY2LDEwIEBAIHZvaWQgQWNjZXNzaWJpbGl0eVVJRWxlbWVudDo6 Z2V0Q2hpbGRyZW5XaXRoUmFuZ2UoVmVjdG9yPFJlZlB0cjxBY2Nlc3NpYmlsaXR5VUlFCiAKIGlu dCBBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpjaGlsZHJlbkNvdW50KCkKIHsKLSAgICBWZWN0b3I8 UmVmUHRyPEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ+ID4gY2hpbGRyZW47Ci0gICAgZ2V0Q2hpbGRy ZW4oY2hpbGRyZW4pOwotICAgIHJldHVybiBjaGlsZHJlbi5zaXplKCk7CisgICAgaWYgKCFtX2Vs ZW1lbnQpCisgICAgICAgIHJldHVybiAwOworCisgICAgcmV0dXJuIGF0a19vYmplY3RfZ2V0X25f YWNjZXNzaWJsZV9jaGlsZHJlbihBVEtfT0JKRUNUKG1fZWxlbWVudCkpOwogfQogCiBQYXNzUmVm UHRyPEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ+IEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmVsZW1l bnRBdFBvaW50KGludCB4LCBpbnQgeSkKLS0gCjEuNy4xMS40Cgo=