96619 2012-09-13 01:05:15 -0700 [EFL] REGRESSION (r128274): fast/overflow/overflow-height-float-not-removed-crash.html 2012-09-13 04:48:31 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mikhail.pozdnyakov mikhail.pozdnyakov gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 719189 0 mikhail.pozdnyakov 2012-09-13 01:05:15 -0700 fast/overflow/overflow-height-float-not-removed-crash.html is crashing after r128274 719244 1 163817 mikhail.pozdnyakov 2012-09-13 01:52:19 -0700 Created attachment 163817 patch 719249 2 163817 kenneth 2012-09-13 02:05:58 -0700 Comment on attachment 163817 patch It is fine, but did you look into why it was failing to create? 719255 3 163817 webkit.review.bot 2012-09-13 02:10:42 -0700 Comment on attachment 163817 patch Clearing flags on attachment: 163817 Committed r128431: <http://trac.webkit.org/changeset/128431> 719256 4 webkit.review.bot 2012-09-13 02:10:46 -0700 All reviewed patches have been landed. Closing bug. 719284 5 mikhail.pozdnyakov 2012-09-13 02:59:17 -0700 (In reply to comment #2) > (From update of attachment 163817 [details]) > It is fine, but did you look into why it was failing to create? The size argument was too big 719322 6 kenneth 2012-09-13 04:15:01 -0700 (In reply to comment #5) > (In reply to comment #2) > > (From update of attachment 163817 [details] [details]) > > It is fine, but did you look into why it was failing to create? > > The size argument was too big OK then, does that mean that we just doesn't cache it and are still painting it? Or are we not painting it in that case? 719336 7 mikhail.pozdnyakov 2012-09-13 04:41:28 -0700 (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #2) > > > (From update of attachment 163817 [details] [details] [details]) > > > It is fine, but did you look into why it was failing to create? > > > > The size argument was too big > > OK then, does that mean that we just doesn't cache it and are still painting it? Or are we not painting it in that case? entry = getThemePartFromCache(type, rect.size()); if (!entry) return false; I guess, it won't be painted 719342 8 kenneth 2012-09-13 04:48:31 -0700 > I guess, it won't be painted That is what I guessed. Maybe we should look into that? and adds some efl tests? 163817 2012-09-13 01:52:19 -0700 2012-09-13 02:10:41 -0700 patch bug96619 text/plain 2831 mikhail.pozdnyakov Y29tbWl0IDhkZmIxODA3OWViYzAxMmFkMzBjYTAwY2FhY2Y5YmI3YzkwMWY1ZTIKQXV0aG9yOiBN aWtoYWlsIFBvemRueWFrb3YgPG1pa2hhaWwucG96ZG55YWtvdkBpbnRlbC5jb20+CkRhdGU6ICAg VGh1IFNlcCAxMyAxMTo0ODo0NiAyMDEyICswMzAwCgogICAgYnVnOTY2MTkKCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5k ZXggNDBhMDRiNi4uNDg4MmQwOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5 LTEzICBNaWtoYWlsIFBvemRueWFrb3YgIDxtaWtoYWlsLnBvemRueWFrb3ZAaW50ZWwuY29tPgor CisgICAgICAgIFtFRkxdIFJFR1JFU1NJT04gKHIxMjgyNzQpOiBmYXN0L292ZXJmbG93L292ZXJm bG93LWhlaWdodC1mbG9hdC1ub3QtcmVtb3ZlZC1jcmFzaC5odG1sCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjYxOQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZW1lUGFydENhY2hlRW50cnk6OmNyZWF0 ZSgpIGNhbiByZXR1cm4gJzAnIGlmIGNyZWF0aW9uIGZhaWxzLCB0aGlzIHdhcyBub3QgY2hlY2tl ZAorICAgICAgICB3aGlsZSBUaGVtZSBQYXJ0IGNhY2hlIHBvcHVsYXRpbmcuIEEgTlVMTCBwb2lu dGVyIHdhcyBkZXJlZmVyZW5jZWQgdGhlbiBjYXVzaW5nIGNyYXNoLgorCisgICAgICAgIFRlc3Q6 IGZhc3Qvb3ZlcmZsb3cvb3ZlcmZsb3ctaGVpZ2h0LWZsb2F0LW5vdC1yZW1vdmVkLWNyYXNoLmh0 bWwuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6UmVuZGVyVGhlbWVFZmw6OmdldFRoZW1lUGFydEZyb21DYWNoZSk6CisKIDIw MTItMDktMTMgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBuZXcg dGVzdCBmYXN0L2NhbnZhcy9jYW52YXMtY3NzLWNyYXp5Lmh0bWwgZmFpbHMgb24gTWFjCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmNwcAppbmRleCBiM2Vl NDM0Li4xM2FlMGM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvUmVu ZGVyVGhlbWVFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJU aGVtZUVmbC5jcHAKQEAgLTI3OCw2ICsyNzgsNyBAQCBSZW5kZXJUaGVtZUVmbDo6VGhlbWVQYXJ0 Q2FjaGVFbnRyeSogUmVuZGVyVGhlbWVFZmw6OmdldFRoZW1lUGFydEZyb21DYWNoZShGb3JtVAog ICAgIGVuZCA9IG1fcGFydENhY2hlLmVuZCgpOwogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpdCAh PSBlbmQ7IGkrKywgaXQrKykgewogICAgICAgICBUaGVtZVBhcnRDYWNoZUVudHJ5KiBlbnRyeSA9 ICppdDsKKyAgICAgICAgQVNTRVJUKGVudHJ5KTsKICAgICAgICAgaWYgKGVudHJ5LT5zaXplID09 IHNpemUpIHsKICAgICAgICAgICAgIGlmIChlbnRyeS0+dHlwZSA9PSB0eXBlKQogICAgICAgICAg ICAgICAgIHJldHVybiBlbnRyeTsKQEAgLTI4Nyw3ICsyODgsOCBAQCBSZW5kZXJUaGVtZUVmbDo6 VGhlbWVQYXJ0Q2FjaGVFbnRyeSogUmVuZGVyVGhlbWVFZmw6OmdldFRoZW1lUGFydEZyb21DYWNo ZShGb3JtVAogCiAgICAgaWYgKG1fcGFydENhY2hlLnNpemUoKSA8IFJFTkRFUl9USEVNRV9FRkxf UEFSVF9DQUNIRV9NQVgpIHsKICAgICAgICAgVGhlbWVQYXJ0Q2FjaGVFbnRyeSogZW50cnkgPSBU aGVtZVBhcnRDYWNoZUVudHJ5OjpjcmVhdGUodGhlbWVQYXRoKCksIHR5cGUsIHNpemUpOwotICAg ICAgICBtX3BhcnRDYWNoZS5wcmVwZW5kKGVudHJ5KTsKKyAgICAgICAgaWYgKGVudHJ5KSAvLyBD YW4gYmUgJzAnLCBpZiBjcmVhdGlvbiBmYWlscy4gRG8gbm90IHN0b3JlIGl0IGluIHRoaXMgY2Fz ZS4KKyAgICAgICAgICAgIG1fcGFydENhY2hlLnByZXBlbmQoZW50cnkpOwogICAgICAgICByZXR1 cm4gZW50cnk7CiAgICAgfQogCkBAIC0yOTYsNiArMjk4LDcgQEAgUmVuZGVyVGhlbWVFZmw6OlRo ZW1lUGFydENhY2hlRW50cnkqIFJlbmRlclRoZW1lRWZsOjpnZXRUaGVtZVBhcnRGcm9tQ2FjaGUo Rm9ybVQKIAogICAgIGlmIChsYXN0V2l0aFJlcXVlc3RlZFNpemUgIT0gbm90Rm91bmQgJiYgbGFz dFdpdGhSZXF1ZXN0ZWRTaXplICE9IDEpIHsKICAgICAgICAgVGhlbWVQYXJ0Q2FjaGVFbnRyeSog ZW50cnkgPSBtX3BhcnRDYWNoZS5hdChsYXN0V2l0aFJlcXVlc3RlZFNpemUpOworICAgICAgICBB U1NFUlQoZW50cnkpOwogICAgICAgICBlbnRyeS0+cmV1c2UodGhlbWVQYXRoKCksIHR5cGUpOwog ICAgICAgICBtX3BhcnRDYWNoZS5yZW1vdmUobGFzdFdpdGhSZXF1ZXN0ZWRTaXplKTsKICAgICAg ICAgbV9wYXJ0Q2FjaGUucHJlcGVuZChlbnRyeSk7CkBAIC0zMDMsNiArMzA2LDcgQEAgUmVuZGVy VGhlbWVFZmw6OlRoZW1lUGFydENhY2hlRW50cnkqIFJlbmRlclRoZW1lRWZsOjpnZXRUaGVtZVBh cnRGcm9tQ2FjaGUoRm9ybVQKICAgICB9CiAKICAgICBUaGVtZVBhcnRDYWNoZUVudHJ5KiBlbnRy eSA9IG1fcGFydENhY2hlLmxhc3QoKTsKKyAgICBBU1NFUlQoZW50cnkpOwogICAgIGVudHJ5LT5y ZXVzZSh0aGVtZVBhdGgoKSwgdHlwZSwgc2l6ZSk7CiAgICAgbV9wYXJ0Q2FjaGUucmVtb3ZlTGFz dCgpOwogICAgIG1fcGFydENhY2hlLnByZXBlbmQoZW50cnkpOwo=