96603 2012-09-12 22:47:18 -0700 [Qt][WK2] Memory leaks in Qt's TestRunner 2012-09-13 01:14:32 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis ossy webkit.review.bot oldest_to_newest 719063 0 naginenis 2012-09-12 22:47:18 -0700 WkString created with WKStringCreateWithQString() is leaking in TestController::initializeInjectedBundlePath(). ==31701== 24 bytes in 1 blocks are definitely lost in loss record 2,310 of 8,474 ==31701== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==31701== by 0x7166E6E: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==31701== by 0x55EF2D6: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==31701== by 0x560DCC8: WebKit::WebString::create(WTF::String const&) (WebString.h:50) ==31701== by 0x560DDCC: WebKit::toCopiedAPI(WTF::String const&) (WKSharedAPICast.h:149) ==31701== by 0x566949D: WKStringCreateWithQString(QString const&) (WKStringQt.cpp:34) ==31701== by 0x412CF5: WTR::TestController::initializeInjectedBundlePath() (TestControllerQt.cpp:102) ==31701== by 0x4140A3: WTR::TestController::initialize(int, char const**) (TestController.cpp:312) ==31701== by 0x4136AA: WTR::TestController::TestController(int, char const**) (TestController.cpp:98) ==31701== by 0x40B52C: Launcher::launch() (main.cpp:61) Fixed the same case for EFL in r128327. 719070 1 163780 naginenis 2012-09-12 22:57:53 -0700 Created attachment 163780 Patch 719084 2 163780 ossy 2012-09-12 23:20:27 -0700 Comment on attachment 163780 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163780&action=review LGTM, r=me with some nit. > Tools/ChangeLog:3 > + [QT] [WK2] Memory leaks in Qt's TestRunner s/[QT] [WK2]/[Qt][WK2]/ > Tools/ChangeLog:8 > + Fix memory leaks in QT's TestRunner code by adopting WKString s/QT/Qt/ 719144 3 163799 naginenis 2012-09-13 00:26:02 -0700 Created attachment 163799 Patch Fixed nits. Thanks for reviewing, Ossy. 719201 4 163799 webkit.review.bot 2012-09-13 01:14:29 -0700 Comment on attachment 163799 Patch Clearing flags on attachment: 163799 Committed r128419: <http://trac.webkit.org/changeset/128419> 719202 5 webkit.review.bot 2012-09-13 01:14:32 -0700 All reviewed patches have been landed. Closing bug. 163780 2012-09-12 22:57:53 -0700 2012-09-13 00:26:02 -0700 Patch 96603.patch text/plain 1905 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZjRm MWU2Li44MWIxYzZjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDktMTIgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW1FUXSBbV0sy XSBNZW1vcnkgbGVha3MgaW4gUXQncyBUZXN0UnVubmVyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjYwMworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBtZW1vcnkgbGVha3MgaW4gUVQncyBUZXN0UnVu bmVyIGNvZGUgYnkgYWRvcHRpbmcgV0tTdHJpbmcKKyAgICAgICAgY3JlYXRlZCB3aXRoIFdLU3Ry aW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVy L3F0L1Rlc3RDb250cm9sbGVyUXQuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6 aW5pdGlhbGl6ZUluamVjdGVkQnVuZGxlUGF0aCk6CisgICAgICAgIChXVFI6OlRlc3RDb250cm9s bGVyOjppbml0aWFsaXplVGVzdFBsdWdpbkRpcmVjdG9yeSk6CisKIDIwMTItMDktMTIgIENzYWJh IE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgU1ZOIG1pcnJv ciBoYW5kbGluZyBmZWF0dXJlIHRvIGJ1aWxkLndlYmtpdC5vcmcKZGlmZiAtLWdpdCBhL1Rvb2xz L1dlYktpdFRlc3RSdW5uZXIvcXQvVGVzdENvbnRyb2xsZXJRdC5jcHAgYi9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL3F0L1Rlc3RDb250cm9sbGVyUXQuY3BwCmluZGV4IDRhNGNiZWMuLmRlZGIxOGFh IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1Rlc3RDb250cm9sbGVyUXQu Y3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvVGVzdENvbnRyb2xsZXJRdC5jcHAK QEAgLTk5LDcgKzk5LDcgQEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZUluamVjdGVk QnVuZGxlUGF0aCgpCiAgICAgaWYgKCFpc0V4aXN0aW5nTGlicmFyeShwYXRoKSkKICAgICAgICAg cUZhdGFsKCJDYW5ub3QgZmluZCB0aGUgaW5qZWN0ZWQgYnVuZGxlIGF0ICVzXG4iLCBxUHJpbnRh YmxlKHBhdGgpKTsKIAotICAgIG1faW5qZWN0ZWRCdW5kbGVQYXRoID0gV0tTdHJpbmdDcmVhdGVX aXRoUVN0cmluZyhwYXRoKTsKKyAgICBtX2luamVjdGVkQnVuZGxlUGF0aC5hZG9wdChXS1N0cmlu Z0NyZWF0ZVdpdGhRU3RyaW5nKHBhdGgpKTsKIH0KIAogdm9pZCBUZXN0Q29udHJvbGxlcjo6aW5p dGlhbGl6ZVRlc3RQbHVnaW5EaXJlY3RvcnkoKQpAQCAtMTA3LDcgKzEwNyw3IEBAIHZvaWQgVGVz dENvbnRyb2xsZXI6OmluaXRpYWxpemVUZXN0UGx1Z2luRGlyZWN0b3J5KCkKICAgICAvLyBGSVhN RTogdGhlIHRlc3QgcGx1Z2luIGNhdXNlIHNvbWUgdHJvdWJsZSBmb3IgdXMsIHNvIHdlIGRvbid0 IGxvYWQgaXQgZm9yIHRoZSB0aW1lIGJlaW5nLgogICAgIC8vIFNlZTogaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NjIwCiAKLSAgICAvLyBtX3Rlc3RQbHVnaW5EaXJl Y3RvcnkgPSBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhxZ2V0ZW52KCJRVFdFQktJVF9Q TFVHSU5fUEFUSCIpLmNvbnN0RGF0YSgpKTsKKyAgICAvLyBtX3Rlc3RQbHVnaW5EaXJlY3Rvcnku YWRvcHQoV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcocWdldGVudigiUVRXRUJLSVRfUExV R0lOX1BBVEgiKS5jb25zdERhdGEoKSkpOwogfQogCiB2b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0 Zm9ybUluaXRpYWxpemVDb250ZXh0KCkK 163799 2012-09-13 00:26:02 -0700 2012-09-13 01:14:29 -0700 Patch 96603.patch text/plain 1908 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBmZjRm MWU2Li42MTliNzc5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDktMTMgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW1F0XVtXSzJd IE1lbW9yeSBsZWFrcyBpbiBRdCdzIFRlc3RSdW5uZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NjAzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQ3Nh YmEgT3N6dHJvZ29uw6FjLgorCisgICAgICAgIEZpeCBtZW1vcnkgbGVha3MgaW4gUXQncyBUZXN0 UnVubmVyIGNvZGUgYnkgYWRvcHRpbmcgV0tTdHJpbmcKKyAgICAgICAgY3JlYXRlZCB3aXRoIFdL U3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCkuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVu bmVyL3F0L1Rlc3RDb250cm9sbGVyUXQuY3BwOgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxl cjo6aW5pdGlhbGl6ZUluamVjdGVkQnVuZGxlUGF0aCk6CisgICAgICAgIChXVFI6OlRlc3RDb250 cm9sbGVyOjppbml0aWFsaXplVGVzdFBsdWdpbkRpcmVjdG9yeSk6CisKIDIwMTItMDktMTIgIENz YWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBBZGQgU1ZOIG1p cnJvciBoYW5kbGluZyBmZWF0dXJlIHRvIGJ1aWxkLndlYmtpdC5vcmcKZGlmZiAtLWdpdCBhL1Rv b2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvVGVzdENvbnRyb2xsZXJRdC5jcHAgYi9Ub29scy9XZWJL aXRUZXN0UnVubmVyL3F0L1Rlc3RDb250cm9sbGVyUXQuY3BwCmluZGV4IDRhNGNiZWMuLmRlZGIx OGFhIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1Rlc3RDb250cm9sbGVy UXQuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvVGVzdENvbnRyb2xsZXJRdC5j cHAKQEAgLTk5LDcgKzk5LDcgQEAgdm9pZCBUZXN0Q29udHJvbGxlcjo6aW5pdGlhbGl6ZUluamVj dGVkQnVuZGxlUGF0aCgpCiAgICAgaWYgKCFpc0V4aXN0aW5nTGlicmFyeShwYXRoKSkKICAgICAg ICAgcUZhdGFsKCJDYW5ub3QgZmluZCB0aGUgaW5qZWN0ZWQgYnVuZGxlIGF0ICVzXG4iLCBxUHJp bnRhYmxlKHBhdGgpKTsKIAotICAgIG1faW5qZWN0ZWRCdW5kbGVQYXRoID0gV0tTdHJpbmdDcmVh dGVXaXRoUVN0cmluZyhwYXRoKTsKKyAgICBtX2luamVjdGVkQnVuZGxlUGF0aC5hZG9wdChXS1N0 cmluZ0NyZWF0ZVdpdGhRU3RyaW5nKHBhdGgpKTsKIH0KIAogdm9pZCBUZXN0Q29udHJvbGxlcjo6 aW5pdGlhbGl6ZVRlc3RQbHVnaW5EaXJlY3RvcnkoKQpAQCAtMTA3LDcgKzEwNyw3IEBAIHZvaWQg VGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemVUZXN0UGx1Z2luRGlyZWN0b3J5KCkKICAgICAvLyBG SVhNRTogdGhlIHRlc3QgcGx1Z2luIGNhdXNlIHNvbWUgdHJvdWJsZSBmb3IgdXMsIHNvIHdlIGRv bid0IGxvYWQgaXQgZm9yIHRoZSB0aW1lIGJlaW5nLgogICAgIC8vIFNlZTogaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NjIwCiAKLSAgICAvLyBtX3Rlc3RQbHVnaW5E aXJlY3RvcnkgPSBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhxZ2V0ZW52KCJRVFdFQktJ VF9QTFVHSU5fUEFUSCIpLmNvbnN0RGF0YSgpKTsKKyAgICAvLyBtX3Rlc3RQbHVnaW5EaXJlY3Rv cnkuYWRvcHQoV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcocWdldGVudigiUVRXRUJLSVRf UExVR0lOX1BBVEgiKS5jb25zdERhdGEoKSkpOwogfQogCiB2b2lkIFRlc3RDb250cm9sbGVyOjpw bGF0Zm9ybUluaXRpYWxpemVDb250ZXh0KCkK