96602 2012-09-12 22:16:31 -0700 -ldl should not be hardcoded into OPENGL_LIBS 2013-01-14 12:43:55 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 tetromino webkit-unassigned gnome patnicolas webkit.review.bot oldest_to_newest 719046 0 tetromino 2012-09-12 22:16:31 -0700 (As reported downstream at https://bugs.gentoo.org/show_bug.cgi?id=417523) Some non-linux systems, for example freebsd, have dlopen()/dlclose()/dlsym() etc. in their core libc, and do not install a separate libdl. On such systems, "-ldl" in OPENGL_LIBS leads to linking failure. webkit's configure should check whether libc provides dlopen, and add -ldl to OPENGL_LIBS only if it's needed. 719048 1 163774 tetromino 2012-09-12 22:19:58 -0700 Created attachment 163774 proposed patch for current svn trunk 723303 2 patnicolas 2012-09-18 23:15:23 -0700 The patch adds twice the dash: OPENGL_LIBS="-lGL --libdl" and build fails (In reply to comment #1) > Created an attachment (id=163774) [details] > proposed patch for current svn trunk 723311 3 164670 tetromino 2012-09-18 23:25:35 -0700 Created attachment 164670 proposed patch, v2 (In reply to comment #2) > The patch adds twice the dash: OPENGL_LIBS="-lGL --libdl" and build fails You are right, thanks for noticing. Fixed in this revision. 749473 4 170343 tetromino 2012-10-24 01:45:02 -0700 Created attachment 170343 proposed patch, v3 Updated for current svn trunk 749478 5 170343 xan.lopez 2012-10-24 02:14:03 -0700 Comment on attachment 170343 proposed patch, v3 View in context: https://bugs.webkit.org/attachment.cgi?id=170343&action=review > configure.ac:282 > +AC_SUBST([DLOPEN_LIBS]) This makes sense, but would you mind adding a small comment saying what it does? Mostly because it's checking for the uncommon case (BSD-ish systems), so it's possible that a maintainer will be confused in the future. Something like: "We check whether dlopen is in the core libraries; if it's not we pull in libdl if it has dlopen and is available, as it's needed in GNU/Linux." Thanks! 749494 6 170351 tetromino 2012-10-24 03:08:57 -0700 Created attachment 170351 proposed patch, v4 (In reply to comment #5) OK, comment added. 806532 7 170351 webkit.review.bot 2013-01-14 12:43:52 -0800 Comment on attachment 170351 proposed patch, v4 Clearing flags on attachment: 170351 Committed r139643: <http://trac.webkit.org/changeset/139643> 806533 8 webkit.review.bot 2013-01-14 12:43:55 -0800 All reviewed patches have been landed. Closing bug. 163774 2012-09-12 22:19:58 -0700 2012-09-18 23:25:35 -0700 proposed patch for current svn trunk do-not-hardcode-ldl-in-OPENGL_LIBS.patch text/plain 1218 tetromino SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyODQw MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5 LTEyICBBbGV4YW5kcmUgUm9zdG92dHNldiAgPHRldHJvbWlub0BnZW50b28ub3JnPgorCisgICAg ICAgIERvIG5vdCBoYXJkY29kZSAtbGRsIGluIE9QRU5HTF9MSUJTCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjYwMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWUgbm9uLWxpbnV4IHN5c3RlbXMsIGUu Zy4gZnJlZWJzZCwgaGF2ZSBkbG9wZW4oKSBhcyBwYXJ0IG9mIHRoZWlyCisgICAgICAgIGxpYmMs IGFuZCBkbyBub3QgdXNlIGEgc2VwYXJhdGUgbGliZGwuCisKKyAgICAgICAgKiBjb25maWd1cmUu YWM6CisKIDIwMTItMDktMTIgIEt5dW5nVGFlIEtpbSAgPGt0Zi5raW1Ac2Ftc3VuZy5jb20+CiAK ICAgICAgICAgW0VGTF0gU3VwcG9ydCBkb3dubG9hZCBhdHRyaWJ1dGUgZmVhdHVyZQpJbmRleDog Y29uZmlndXJlLmFjCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNvbmZpZ3VyZS5hYwkocmV2aXNpb24gMTI4Mzk3 KQorKysgY29uZmlndXJlLmFjCSh3b3JraW5nIGNvcHkpCkBAIC0yNzgsNiArMjc4LDEwIEBACiBB Q19TVUJTVChbT0xFMzJfTElCU10pCiAKIAorQUNfQ0hFQ0tfRlVOQyhbZGxvcGVuXSwgW10sIFtB Q19DSEVDS19MSUIoW2RsXSwgW2Rsb3Blbl0sIFtETE9QRU5fTElCUz0iLWxkbCJdKV0pCitBQ19T VUJTVChbRExPUEVOX0xJQlNdKQorCisKICMgZGV0ZXJtaW5lIHRoZSBHVEsrIHZlcnNpb24gdG8g dXNlCiBBQ19NU0dfQ0hFQ0tJTkcoW3RoZSBHVEsrIHZlcnNpb24gdG8gdXNlXSkKIEFDX0FSR19X SVRIKFtndGtdLApAQCAtMTEyNCw3ICsxMTI4LDcgQEAKIGZpCiAKIGlmIHRlc3QgIiR3aXRoX2Fj Y2VsZXJhdGlvbl9iYWNrZW5kIiA9ICJvcGVuZ2wiOyB0aGVuCi0gICAgT1BFTkdMX0xJQlM9Ii1s R0wgLWxkbCIKKyAgICBPUEVOR0xfTElCUz0iLWxHTCAtJERMT1BFTl9MSUJTIgogZmkKIEFDX1NV QlNUKFtPUEVOR0xfTElCU10pCiAK 164670 2012-09-18 23:25:35 -0700 2012-10-24 01:45:02 -0700 proposed patch, v2 do-not-hardcode-ldl-in-OPENGL_LIBS.patch text/plain 1217 tetromino SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEyODQw MikKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5 LTEyICBBbGV4YW5kcmUgUm9zdG92dHNldiAgPHRldHJvbWlub0BnZW50b28ub3JnPgorCisgICAg ICAgIERvIG5vdCBoYXJkY29kZSAtbGRsIGluIE9QRU5HTF9MSUJTCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjYwMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWUgbm9uLWxpbnV4IHN5c3RlbXMsIGUu Zy4gZnJlZWJzZCwgaGF2ZSBkbG9wZW4oKSBhcyBwYXJ0IG9mIHRoZWlyCisgICAgICAgIGxpYmMs IGFuZCBkbyBub3QgdXNlIGEgc2VwYXJhdGUgbGliZGwuCisKKyAgICAgICAgKiBjb25maWd1cmUu YWM6CisKIDIwMTItMDktMTIgIEt5dW5nVGFlIEtpbSAgPGt0Zi5raW1Ac2Ftc3VuZy5jb20+CiAK ICAgICAgICAgW0VGTF0gU3VwcG9ydCBkb3dubG9hZCBhdHRyaWJ1dGUgZmVhdHVyZQpJbmRleDog Y29uZmlndXJlLmFjCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNvbmZpZ3VyZS5hYwkocmV2aXNpb24gMTI4Mzk3 KQorKysgY29uZmlndXJlLmFjCSh3b3JraW5nIGNvcHkpCkBAIC0yNzgsNiArMjc4LDEwIEBACiBB Q19TVUJTVChbT0xFMzJfTElCU10pCiAKIAorQUNfQ0hFQ0tfRlVOQyhbZGxvcGVuXSwgW10sIFtB Q19DSEVDS19MSUIoW2RsXSwgW2Rsb3Blbl0sIFtETE9QRU5fTElCUz0iLWxkbCJdKV0pCitBQ19T VUJTVChbRExPUEVOX0xJQlNdKQorCisKICMgZGV0ZXJtaW5lIHRoZSBHVEsrIHZlcnNpb24gdG8g dXNlCiBBQ19NU0dfQ0hFQ0tJTkcoW3RoZSBHVEsrIHZlcnNpb24gdG8gdXNlXSkKIEFDX0FSR19X SVRIKFtndGtdLApAQCAtMTEyNCw3ICsxMTI4LDcgQEAKIGZpCiAKIGlmIHRlc3QgIiR3aXRoX2Fj Y2VsZXJhdGlvbl9iYWNrZW5kIiA9ICJvcGVuZ2wiOyB0aGVuCi0gICAgT1BFTkdMX0xJQlM9Ii1s R0wgLWxkbCIKKyAgICBPUEVOR0xfTElCUz0iLWxHTCAkRExPUEVOX0xJQlMiCiBmaQogQUNfU1VC U1QoW09QRU5HTF9MSUJTXSkKIAo= 170343 2012-10-24 01:45:02 -0700 2012-10-24 03:08:57 -0700 proposed patch, v3 do-not-hardcode-ldl-in-OPENGL_LIBS.patch text/plain 1298 tetromino SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjMy OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEw LTI0ICBBbGV4YW5kcmUgUm9zdG92dHNldiAgPHRldHJvbWlub0BnZW50b28ub3JnPgorCisgICAg ICAgIERvIG5vdCBoYXJkY29kZSAtbGRsIGluIE9QRU5HTF9MSUJTCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjYwMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWUgbm9uLWxpbnV4IHN5c3RlbXMsIGUu Zy4gZnJlZWJzZCwgaGF2ZSBkbG9wZW4oKSBhcyBwYXJ0IG9mIHRoZWlyCisgICAgICAgIGxpYmMs IGFuZCBkbyBub3QgdXNlIGEgc2VwYXJhdGUgbGliZGwuCisKKyAgICAgICAgKiBjb25maWd1cmUu YWM6CisKIDIwMTItMTAtMjQgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpb0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFtXSzJdIFtHVEtdIFRlc3RXZWJLaXRBY2Nlc3NpYmlsaXR5IGlzIG5vdCBi ZWluZyBydW4KSW5kZXg6IGNvbmZpZ3VyZS5hYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjb25maWd1cmUuYWMJ KHJldmlzaW9uIDEzMjMyOSkKKysrIGNvbmZpZ3VyZS5hYwkod29ya2luZyBjb3B5KQpAQCAtMjc4 LDYgKzI3OCwxMCBAQAogQUNfU1VCU1QoW09MRTMyX0xJQlNdKQogCiAKK0FDX0NIRUNLX0ZVTkMo W2Rsb3Blbl0sIFtdLCBbQUNfQ0hFQ0tfTElCKFtkbF0sIFtkbG9wZW5dLCBbRExPUEVOX0xJQlM9 Ii1sZGwiXSldKQorQUNfU1VCU1QoW0RMT1BFTl9MSUJTXSkKKworCiAjIGRldGVybWluZSB0aGUg R1RLKyB2ZXJzaW9uIHRvIHVzZQogQUNfTVNHX0NIRUNLSU5HKFt0aGUgR1RLKyB2ZXJzaW9uIHRv IHVzZV0pCiBBQ19BUkdfV0lUSChbZ3RrXSwKQEAgLTEwMzksNyArMTA0Myw3IEBACiAgICBpZiB0 ZXN0ICIkZW5hYmxlX2dseCIgPSAieWVzIjsgdGhlbgogICAgIGFjY2VsZXJhdGlvbl9iYWNrZW5k X2Rlc2NyaXB0aW9uKz0iLCBnbHgiCiAgICBmaQotICAgT1BFTkdMX0xJQlMrPSIgLWxkbCIKKyAg IE9QRU5HTF9MSUJTKz0iICRETE9QRU5fTElCUyIKICAgIGFjY2VsZXJhdGlvbl9iYWNrZW5kX2Rl c2NyaXB0aW9uKz0iKSIKIGZpCiBBQ19TVUJTVChbT1BFTkdMX0xJQlNdKQo= 170351 2012-10-24 03:08:57 -0700 2013-01-14 12:43:52 -0800 proposed patch, v4 do-not-hardcode-ldl-in-OPENGL_LIBS.patch text/plain 1446 tetromino SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzMjMy OSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEw LTI0ICBBbGV4YW5kcmUgUm9zdG92dHNldiAgPHRldHJvbWlub0BnZW50b28ub3JnPgorCisgICAg ICAgIERvIG5vdCBoYXJkY29kZSAtbGRsIGluIE9QRU5HTF9MSUJTCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjYwMgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWUgbm9uLUxpbnV4IHN5c3RlbXMsIGUu Zy4gRnJlZUJTRCwgaGF2ZSBkbG9wZW4oKSBhcyBwYXJ0IG9mIHRoZWlyCisgICAgICAgIGxpYmMs IGFuZCBkbyBub3QgdXNlIGEgc2VwYXJhdGUgbGliZGwuCisKKyAgICAgICAgKiBjb25maWd1cmUu YWM6CisKIDIwMTItMTAtMjQgIE1hcmlvIFNhbmNoZXogUHJhZGEgIDxtYXJpb0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFtXSzJdIFtHVEtdIFRlc3RXZWJLaXRBY2Nlc3NpYmlsaXR5IGlzIG5vdCBi ZWluZyBydW4KSW5kZXg6IGNvbmZpZ3VyZS5hYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjb25maWd1cmUuYWMJ KHJldmlzaW9uIDEzMjMyOSkKKysrIGNvbmZpZ3VyZS5hYwkod29ya2luZyBjb3B5KQpAQCAtMjc4 LDYgKzI3OCwxMiBAQAogQUNfU1VCU1QoW09MRTMyX0xJQlNdKQogCiAKKyMgY2hlY2sgd2hldGhl ciBkbG9wZW4oKSBpcyBpbiB0aGUgY29yZSBsaWJjIGxpa2Ugb24gRnJlZUJTRCwgb3IgaW4gYSBz ZXBhcmF0ZQorIyBsaWJkbCBsaWtlIG9uIEdOVS9MaW51eCAoaW4gd2hpY2ggY2FzZSB3ZSB3YW50 IHRvIGxpbmsgdG8gbGliZGwpCitBQ19DSEVDS19GVU5DKFtkbG9wZW5dLCBbXSwgW0FDX0NIRUNL X0xJQihbZGxdLCBbZGxvcGVuXSwgW0RMT1BFTl9MSUJTPSItbGRsIl0pXSkKK0FDX1NVQlNUKFtE TE9QRU5fTElCU10pCisKKwogIyBkZXRlcm1pbmUgdGhlIEdUSysgdmVyc2lvbiB0byB1c2UKIEFD X01TR19DSEVDS0lORyhbdGhlIEdUSysgdmVyc2lvbiB0byB1c2VdKQogQUNfQVJHX1dJVEgoW2d0 a10sCkBAIC0xMDM5LDcgKzEwNDUsNyBAQAogICAgaWYgdGVzdCAiJGVuYWJsZV9nbHgiID0gInll cyI7IHRoZW4KICAgICBhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNjcmlwdGlvbis9IiwgZ2x4Igog ICAgZmkKLSAgIE9QRU5HTF9MSUJTKz0iIC1sZGwiCisgICBPUEVOR0xfTElCUys9IiAkRExPUEVO X0xJQlMiCiAgICBhY2NlbGVyYXRpb25fYmFja2VuZF9kZXNjcmlwdGlvbis9IikiCiBmaQogQUNf U1VCU1QoW09QRU5HTF9MSUJTXSkK