9658 2006-06-29 20:14:20 -0700 REGRESSION: Check Spelling does not work in textarea elements 2006-07-14 13:51:17 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED data:text/html,<textarea> HasReduction, InRadar, Regression P1 Normal --- 1 darin andersca adele ian webkit-bugs oldest_to_newest 47781 0 darin 2006-06-29 20:14:20 -0700 Go to a web page with a textarea element, like any Bugzilla bug. Click in the textarea. Now choose Check Spelling from the contextual menu. You get a beep, and spell checking does not take place. 47782 1 darin 2006-06-29 20:14:52 -0700 The bug is in the WebCore::FrameMac::advanceToNextMisspelling function. 47784 2 webkit-bugs 2006-06-29 20:24:55 -0700 How odd, this is what I originally filed bug 9580 on. 47845 3 darin 2006-06-30 11:09:37 -0700 (In reply to comment #2) > How odd, this is what I originally filed bug 9580 on. Maybe it's what you meant, but it's not what you wrote in the bug -- I just re-read it to be sure. If you go back and read that bug you'll see that you mentioned "Check Spelling as You Type", which is not the same thing as "Check Spelling". "Check Spelling as You Type" is working now, which is why that bug is marked resolved. 48347 4 alice.barraclough 2006-07-05 12:10:57 -0700 <rdar://problem/4613948> 49547 5 ddkilzer 2006-07-12 21:16:07 -0700 This seems to be working as of a locally-built WebKit r15401. Please retest. However, setting the WebContinuousSpellCheckingEnabled default doesn't enable this by default for all text fields and text areas. (Perhaps this is a different bug?) 49565 6 ddkilzer 2006-07-12 21:29:35 -0700 (In reply to comment #5) > However, setting the WebContinuousSpellCheckingEnabled default doesn't enable > this by default for all text fields and text areas. (Perhaps this is a > different bug?) Filed Bug 9887 for this issue. 49833 7 9452 andersca 2006-07-14 13:02:45 -0700 Created attachment 9452 Patch 49837 8 9452 justin.garcia 2006-07-14 13:19:32 -0700 Comment on attachment 9452 Patch Hey anders I think you could set the start/end to the first/last nodes in an editable div for all editable divs.  I don't think you need to special case shadow divs.  but this  is just a suggestion. r=me 49839 9 9452 justin.garcia 2006-07-14 13:25:57 -0700 Comment on attachment 9452 Patch I think you could also do setEnd(topNode, maxDeepOffset(topNode) setStart(topNode, 0) and remove the logic that you added. 49842 10 andersca 2006-07-14 13:51:17 -0700 Committed revision 15435. 9452 2006-07-14 13:02:45 -0700 2006-07-14 13:19:32 -0700 Patch spell-checking.txt text/plain 4381 andersca SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1NDMw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDYtMDct MTQgIEFuZGVycyBDYXJsc3NvbiAgPGFjYXJsc3NvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3ppbGxhLm9wZW5k YXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05NjU4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 NjEzOTQ4PgorICAgICAgICBSRUdSRVNTSU9OOiBDaGVjayBTcGVsbGluZyBkb2VzIG5vdCB3b3Jr IGluIHRleHRhcmVhIGVsZW1lbnRzCisgICAgICAgIAorICAgICAgICAqIGJyaWRnZS9tYWMvRnJh bWVNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpGcmFtZU1hYzo6YWR2YW5jZVRvTmV4dE1pc3Nw ZWxsaW5nKTogICAgICAgIAorICAgICAgICBGb3IgaW5wdXQgYW5kIHRleHRhcmVhIGVsZW1lbnRz LCBzZXQgdGhlIHN0YXJ0IGFuZCBlbmQgbm9kZXMgdG8gdGhlIGZpcnN0IGFuZCBsYXN0IHRleHQg bm9kZXMKKyAgICAgICAgaW4gdGhlIHNoYWRvdyB0cmVlLiBGb3IgcmVndWxhciBlZGl0YWJsZSBk aXZzLCB0aGUgc3RhcnQgYW5kIGVuZCBub2RlcyBhcmUgc2V0IHRvIHRoZSBjb250YWluZXIgbm9k ZS4KKyAgICAgICAgCisgICAgICAgICogZG9tL1JhbmdlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlJhbmdlOjpjaGVja05vZGVCQSk6CisgICAgICAgIEFsbG93IHJhbmdlIG9wZXJhdGlvbnMgb24g c2hhZG93IHRyZWVzLgorCisgICAgICAgICogbWFudWFsLXRlc3RzL2Zvcm0tZWxlbWVudC1zcGVs bGluZy5odG1sOiBBZGRlZC4KKwogMjAwNi0wNy0xNCAgQWRlbGUgUGV0ZXJzb24gIDxhZGVsZUBh cHBsZS5jb20+CiAKICAgICAgICAgUlMgYnkgRGFyaW4uCkluZGV4OiBicmlkZ2UvbWFjL0ZyYW1l TWFjLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIGJyaWRnZS9tYWMvRnJhbWVNYWMubW0JKHJldmlzaW9uIDE1 NDI4KQorKysgYnJpZGdlL21hYy9GcmFtZU1hYy5tbQkod29ya2luZyBjb3B5KQpAQCAtNjkzLDkg KzY5MywxNyBAQCBTdHJpbmcgRnJhbWVNYWM6OmFkdmFuY2VUb05leHRNaXNzcGVsbGluCiAgICAg ICAgIHN0YXJ0ZWRXaXRoU2VsZWN0aW9uID0gZmFsc2U7ICAgLy8gd29uJ3QgbmVlZCB0byB3cmFw CiAgICAgfQogICAgIAotICAgIC8vIHRvcE5vZGUgZGVmaW5lcyB0aGUgd2hvbGUgcmFuZ2Ugd2Ug d2FudCB0byBvcGVyYXRlIG9uIAotICAgIE5vZGUgKnRvcE5vZGUgPSBlZGl0YWJsZU5vZGUtPnJv b3RFZGl0YWJsZUVsZW1lbnQoKTsKLSAgICBzZWFyY2hSYW5nZS0+c2V0RW5kQWZ0ZXIodG9wTm9k ZSwgZXhjZXB0aW9uKTsKKyAgICBOb2RlKiBzdGFydE5vZGU7CisgICAgTm9kZSogZW5kTm9kZTsg ICAgCisgICAgTm9kZSogc2hhZG93QW5jZXN0b3IgPSBlZGl0YWJsZU5vZGUtPnNoYWRvd0FuY2Vz dG9yTm9kZSgpOworICAgIGlmIChzaGFkb3dBbmNlc3RvciAmJiAoc2hhZG93QW5jZXN0b3ItPmhh c1RhZ05hbWUoaW5wdXRUYWcpIHx8IHNoYWRvd0FuY2VzdG9yLT5oYXNUYWdOYW1lKHRleHRhcmVh VGFnKSkpIHsKKyAgICAgICAgQVNTRVJUKGVkaXRhYmxlTm9kZS0+aXNUZXh0Tm9kZSgpKTsKKyAg ICAgICAgc3RhcnROb2RlID0gZWRpdGFibGVOb2RlLT5wYXJlbnROb2RlKCktPmZpcnN0Q2hpbGQo KTsKKyAgICAgICAgZW5kTm9kZSA9IGVkaXRhYmxlTm9kZS0+cGFyZW50Tm9kZSgpLT5sYXN0Q2hp bGQoKTsKKyAgICB9IGVsc2UKKyAgICAgICAgc3RhcnROb2RlID0gZW5kTm9kZSA9IGVkaXRhYmxl Tm9kZS0+cm9vdEVkaXRhYmxlRWxlbWVudCgpOworCisgICAgc2VhcmNoUmFuZ2UtPnNldEVuZEFm dGVyKGVuZE5vZGUsIGV4Y2VwdGlvbik7CiAKICAgICAvLyBNYWtlIHN1cmUgc3RhcnQgb2Ygc2Vh cmNoUmFuZ2UgaXMgbm90IGluIHRoZSBtaWRkbGUgb2YgYSB3b3JkLiAgSnVtcGluZyBiYWNrIGEg Y2hhciBhbmQgdGhlbgogICAgIC8vIGZvcndhcmQgYnkgYSB3b3JkIGhhcHBlbnMgdG8gZG8gdGhl IHRyaWNrLgpAQCAtNzU3LDcgKzc2NSw3IEBAIFN0cmluZyBGcmFtZU1hYzo6YWR2YW5jZVRvTmV4 dE1pc3NwZWxsaW4KICAgICAgICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICAgICAgLy8gd2Un dmUgZ29uZSBmcm9tIHRoZSBzZWxlY3Rpb24gdG8gdGhlIGVuZCBvZiBkb2MsIG5vdyB3cmFwIGFy b3VuZAogICAgICAgICAgICAgICAgIHdyYXBwZWQgPSBZRVM7Ci0gICAgICAgICAgICAgICAgc2Vh cmNoUmFuZ2UtPnNldFN0YXJ0QmVmb3JlKHRvcE5vZGUsIGV4Y2VwdGlvbik7CisgICAgICAgICAg ICAgICAgc2VhcmNoUmFuZ2UtPnNldFN0YXJ0QmVmb3JlKHN0YXJ0Tm9kZSwgZXhjZXB0aW9uKTsK ICAgICAgICAgICAgICAgICAvLyBnb2luZyB1bnRpbCB0aGUgZW5kIG9mIHRoZSB2ZXJ5IGZpcnN0 IGNodW5rIHdlIHRlc3RlZCBpcyBmYXIgZW5vdWdoCiAgICAgICAgICAgICAgICAgc2VhcmNoUmFu Z2UtPnNldEVuZChzZWFyY2hFbmRBZnRlcldyYXBOb2RlLCBzZWFyY2hFbmRBZnRlcldyYXBPZmZz ZXQsIGV4Y2VwdGlvbik7CiAgICAgICAgICAgICAgICAgaXQgPSBXb3JkQXdhcmVJdGVyYXRvcihz ZWFyY2hSYW5nZS5nZXQoKSk7CkluZGV4OiBkb20vUmFuZ2UuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRv bS9SYW5nZS5jcHAJKHJldmlzaW9uIDE1NDI4KQorKysgZG9tL1JhbmdlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTAyMywxNCArMTAyMywxNSBAQCB2b2lkIFJhbmdlOjpjaGVja05vZGVXT2Zmc2V0 KCBOb2RlICpuLCBpCiB2b2lkIFJhbmdlOjpjaGVja05vZGVCQSggTm9kZSAqbiwgRXhjZXB0aW9u Q29kZSYgZWMpIGNvbnN0CiB7CiAgICAgLy8gSU5WQUxJRF9OT0RFX1RZUEVfRVJSOiBSYWlzZWQg aWYgdGhlIHJvb3QgY29udGFpbmVyIG9mIHJlZk5vZGUgaXMgbm90IGFuCi0gICAgLy8gQXR0ciwg RG9jdW1lbnQgb3IgRG9jdW1lbnRGcmFnbWVudCBub2RlIG9yIGlmIHJlZk5vZGUgaXMgYSBEb2N1 bWVudCwKLSAgICAvLyBEb2N1bWVudEZyYWdtZW50LCBBdHRyLCBFbnRpdHksIG9yIE5vdGF0aW9u IG5vZGUuCisgICAgLy8gQXR0ciwgRG9jdW1lbnQgb3IgRG9jdW1lbnRGcmFnbWVudCBub2RlIG9y IHBhcnQgb2YgYSBzaGFkb3cgRE9NIHRyZWUKKyAgICAvLyBvciBpZiByZWZOb2RlIGlzIGEgRG9j dW1lbnQsIERvY3VtZW50RnJhZ21lbnQsIEF0dHIsIEVudGl0eSwgb3IgTm90YXRpb24gbm9kZS4K ICAgICBOb2RlICpyb290ID0gbjsKICAgICB3aGlsZSAocm9vdC0+cGFyZW50Tm9kZSgpKQogICAg ICAgICByb290ID0gcm9vdC0+cGFyZW50Tm9kZSgpOwogICAgIGlmICghKHJvb3QtPm5vZGVUeXBl KCkgPT0gTm9kZTo6QVRUUklCVVRFX05PREUgfHwKICAgICAgICAgICByb290LT5ub2RlVHlwZSgp ID09IE5vZGU6OkRPQ1VNRU5UX05PREUgfHwKLSAgICAgICAgICByb290LT5ub2RlVHlwZSgpID09 IE5vZGU6OkRPQ1VNRU5UX0ZSQUdNRU5UX05PREUpKSB7CisgICAgICAgICAgcm9vdC0+bm9kZVR5 cGUoKSA9PSBOb2RlOjpET0NVTUVOVF9GUkFHTUVOVF9OT0RFIHx8CisgICAgICAgICAgcm9vdC0+ aXNTaGFkb3dOb2RlKCkpKSB7CiAgICAgICAgIGVjID0gSU5WQUxJRF9OT0RFX1RZUEVfRVJSOwog ICAgICAgICByZXR1cm47CiAgICAgfQpJbmRleDogbWFudWFsLXRlc3RzL2Zvcm0tZWxlbWVudC1z cGVsbGluZy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIG1hbnVhbC10ZXN0cy9mb3JtLWVsZW1lbnQtc3Bl bGxpbmcuaHRtbAkocmV2aXNpb24gMCkKKysrIG1hbnVhbC10ZXN0cy9mb3JtLWVsZW1lbnQtc3Bl bGxpbmcuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2IEBACis8aHRtbD4KKzxib2R5Pgor ICAgIDx0ZXh0YXJlYT5IZWxvIGV2ZXJpYm9keTwvdGV4dGFyZWE+PGlucHV0IHR5cGU9InRleHQi IHZhbHVlPSJIZWxvIGV2ZXJpYm9keSI+CisgICAgPHA+VGVzdCB0aGF0IGl0J3MgcG9zc2libGUg dG8gZG8gc3BlbGwtY2hlY2tpbmcgaW4gdGhlIHR3byBlbGVtZW50cyBhYm92ZS4gQ2hvb3NlICJD aGVjayBTcGVsbGluZyIgb3IgIlNwZWxsaW5nLi4uIiBmcm9tIHRoZSBjb250ZXh0dWFsIG1lbnUg YW5kIHZlcmlmeSB0aGF0IGJvdGggd29yay48L3A+Cis8L2JvZHk+Cis8L2h0bWw+Cg==