96567 2012-09-12 15:12:42 -0700 [V8] ScriptController::compileAndRunScript() can crash 2013-09-12 22:35:41 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED WONTFIX P2 Normal --- 1 haraken haraken abarth andersca japhet webkit.review.bot oldest_to_newest 718783 0 haraken 2012-09-12 15:12:42 -0700 See chromium bug: http://code.google.com/p/chromium/issues/detail?id=146776 The root cause is the following code in ScriptSourceCode.h: CachedScript* cachedScript() const { return m_cachedScript.get(); } Here m_cachedScript can be 0. 718798 1 163715 haraken 2012-09-12 15:21:58 -0700 Created attachment 163715 Patch 718820 2 163715 abarth 2012-09-12 15:40:27 -0700 Comment on attachment 163715 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163715&action=review > Source/WebCore/bindings/v8/ScriptSourceCode.h:67 > - CachedScript* cachedScript() const { return m_cachedScript.get(); } > + CachedScript* cachedScript() const { return m_cachedScript ? m_cachedScript.get() : 0; } What does it mean for m_cachedScript to be 0? It is held as a member, not as a pointer. 718832 3 163715 haraken 2012-09-12 15:50:49 -0700 Comment on attachment 163715 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163715&action=review >> Source/WebCore/bindings/v8/ScriptSourceCode.h:67 >> + CachedScript* cachedScript() const { return m_cachedScript ? m_cachedScript.get() : 0; } > > What does it mean for m_cachedScript to be 0? It is held as a member, not as a pointer. Ah, good point... maybe I was confused. More investigation is needed. 723156 4 164640 haraken 2012-09-18 17:55:16 -0700 Created attachment 164640 Patch 723681 5 164640 abarth 2012-09-19 11:24:50 -0700 Comment on attachment 164640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164640&action=review ok > Source/WebCore/bindings/v8/ScriptSourceCode.cpp:53 > + if (!scriptData.get()) > + return nullptr; There's no reason to call get() here. OwnPtr has a bool operator. 723982 6 164805 haraken 2012-09-19 17:05:33 -0700 Created attachment 164805 patch for landing 724000 7 164805 webkit.review.bot 2012-09-19 17:41:04 -0700 Comment on attachment 164805 patch for landing Clearing flags on attachment: 164805 Committed r129077: <http://trac.webkit.org/changeset/129077> 724001 8 164640 haraken 2012-09-19 17:41:54 -0700 Comment on attachment 164640 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=164640&action=review >> Source/WebCore/bindings/v8/ScriptSourceCode.cpp:53 >> + return nullptr; > > There's no reason to call get() here. OwnPtr has a bool operator. Fixed. Thanks. 928649 9 andersca 2013-09-12 22:35:41 -0700 V8 is gone. 163715 2012-09-12 15:21:58 -0700 2012-09-18 17:55:12 -0700 Patch bug-96567-20120913072131.patch text/plain 2699 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MzY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjE0MWIxMTQzMGExODdk YjMzMTY3Yzg1MWU4NjgxMGE5NzgzNTAzYS4uZTIzZTViNzk4NjE2YThiMjZkNDc1ZGNjZDliNGYz ODFmMTU5NzAzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQ0IEBACisyMDEyLTA5LTEyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFNjcmlwdENv bnRyb2xsZXI6OmNvbXBpbGVBbmRSdW5TY3JpcHQoKSBjYW4gY3Jhc2gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NTY3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9yIGRldGFpbHMsIHNlZSBjaHJvbWl1 bSBidWc6CisgICAgICAgIGh0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9jaHJvbWl1bS9pc3N1ZXMv ZGV0YWlsP2lkPTE0Njc3NgorCisgICAgICAgIFRoZSByb290IGNhdXNlIGlzIHRoZSBmb2xsb3dp bmcgY29kZSBpbiBTY3JpcHRTb3VyY2VDb2RlLmg6CisKKyAgICAgICAgICBDYWNoZWRTY3JpcHQq IGNhY2hlZFNjcmlwdCgpIGNvbnN0IHsgcmV0dXJuIG1fY2FjaGVkU2NyaXB0LmdldCgpOyB9CisK KyAgICAgICAgSGVyZSBtX2NhY2hlZFNjcmlwdCBjYW4gYmUgMC4gVGhpcyBwYXRjaCBpbnNlcnRz IGEgTlVMTCBjaGVjay4KKworICAgICAgICBJZiBtX2NhY2hlZFNjcmlwdCBpcyAwLCBTY3JpcHRT b3VyY2VDb2RlOjpjYWNoZWRTY3JpcHQoKQorICAgICAgICByZXR1cm5zIDAuIElmIFNjcmlwdFNv dXJjZUNvZGU6OmNhY2hlZFNjcmlwdCgpIHJldHVybnMgMCwKKyAgICAgICAgU2NyaXB0Q29udHJv bGxlcjo6Y29tcGlsZUFuZFJ1blNjcmlwdCgpIHBhc3NlcyAwIHRvCisgICAgICAgIFNjcmlwdFNv dXJjZUNvZGU6OnByZWNvbXBpbGVTY3JpcHQoLi4uLCBjYWNoZWRTY3JpcHQpLgorICAgICAgICBJ ZiBjYWNoZWRTY3JpcHQgaXMgMCwgU2NyaXB0U291cmNlQ29kZTo6cHJlY29tcGlsZVNjcmlwdCgp CisgICAgICAgIHJldHVybnMgbnVsbHB0ciwgd2hpY2ggaXMgYW4gZXhwZWN0ZWQgYmVoYXZpb3Iu CisKKyAgICAgICAgTm8gdGVzdHMuIEkgbWFudWFsbHkgdGVzdGVkIGluIHRoZSBmb2xsb3dpbmcg Y29kZQorICAgICAgICAoU2VlIHRoZSBjaHJvbWl1bSBidWcgcmVwb3J0IGZvciBtb3JlIGRldGFp bHMpOgorCisgICAgICAgIGlmICh3VVJMRi5zZWFyY2goIiIpPj0pIHt9CisgICAgICAgIGVsc2Ug aWYgKHdVUkxGLnNlYXJjaCgiIik+PSkge30KKyAgICAgICAgZWxzZSBpZiAod1VSTEYuc2VhcmNo KCIiKT49KSB7fQorICAgICAgICBlbHNlIGlmICh3VVJMRi5zZWFyY2goIiIpPj0pIHt9CisgICAg ICAgIC4uLjsgLy8gMTQ4MzAgdGltZXMKKyAgICAgICAgZWxzZSBpZiAod1VSTEYuc2VhcmNoKCIi KT49KSB7fQorCisgICAgICAgIEdpdmVuIHRoYXQgdGhlIG51bWJlciBvZiAnZWxzZSBpZicgdGhh dCBjYXVzZXMgY3Jhc2gKKyAgICAgICAgaXMgZmxha3kgYW5kIHRoYXQgd2UgZG8gbm90IHdhbnQg dG8gYWRkIGEgbGFyZ2UgdGVzdAorICAgICAgICBhbmQgdGhhdCB0aGlzIGlzIGp1c3QgYSBzaW1w bGUgTlVMTCBjaGVjayBmaXgsCisgICAgICAgIEkgZGlkbid0IGFkZCB0aGUgdGVzdCB0byB0aGlz IHBhdGNoLgorCisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0U291cmNlQ29kZS5oOgorICAg ICAgICAoV2ViQ29yZTo6U2NyaXB0U291cmNlQ29kZTo6Y2FjaGVkU2NyaXB0KToKKwogMjAxMi0w OS0xMiAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBFbGVt ZW50OjpjbGFzc0F0dHJpYnV0ZUNoYW5nZWQgc2hvdWxkIHVzZSBjaGFyYWN0ZXJzOC8xNiB0byBm aW5kIGZpcnN0IG5vbi13aGl0ZXNwYWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9TY3JpcHRTb3VyY2VDb2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9T Y3JpcHRTb3VyY2VDb2RlLmgKaW5kZXggNTczZTc3YzAzMTEyZDNkNDE0MTgwZjk4YTU0MzhlMmE5 ZDg3YzA1Ni4uMGU2MmIzM2ZjZGY0ZWZjMTI0Y2M5MzRiMjA5MWU5YmYxMjFkYjAxZSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0U291cmNlQ29kZS5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFNvdXJjZUNvZGUuaApAQCAtNjQsNyAr NjQsNyBAQCBwdWJsaWM6CiAgICAgYm9vbCBpc0VtcHR5KCkgY29uc3QgeyByZXR1cm4gbV9zb3Vy Y2UuaXNFbXB0eSgpOyB9CiAKICAgICBjb25zdCBTdHJpbmcmIHNvdXJjZSgpIGNvbnN0IHsgcmV0 dXJuIG1fc291cmNlOyB9Ci0gICAgQ2FjaGVkU2NyaXB0KiBjYWNoZWRTY3JpcHQoKSBjb25zdCB7 IHJldHVybiBtX2NhY2hlZFNjcmlwdC5nZXQoKTsgfQorICAgIENhY2hlZFNjcmlwdCogY2FjaGVk U2NyaXB0KCkgY29uc3QgeyByZXR1cm4gbV9jYWNoZWRTY3JpcHQgPyBtX2NhY2hlZFNjcmlwdC5n ZXQoKSA6IDA7IH0KICAgICBjb25zdCBLVVJMJiB1cmwoKSBjb25zdAogICAgIHsKICAgICAgICAg aWYgKG1fY2FjaGVkU2NyaXB0KQo= 164640 2012-09-18 17:55:16 -0700 2012-09-19 17:41:54 -0700 Patch bug-96567-20120919095442.patch text/plain 2583 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMwMmI4MWQ1MWFjMjk2 YTg5M2Y3NjExNmE5OTNmZDhlNjY4MGEyYi4uNTA3YzgwYjVlMzg0NGY1ODA0Mjc3N2QzZjAzNjZm ZmI2MWM2NTBkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDEyLTA5LTE4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFNjcmlwdENv bnRyb2xsZXI6OmNvbXBpbGVBbmRSdW5TY3JpcHQoKSBjYW4gY3Jhc2gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NTY3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2VlIGNocm9taXVtIGJ1ZzogaHR0cDov L2NvZGUuZ29vZ2xlLmNvbS9wL2Nocm9taXVtL2lzc3Vlcy9kZXRhaWw/aWQ9MTQ2Nzc2CisKKyAg ICAgICAgVGhlIHJvb3QgY2F1c2UgaXMgdGhhdCB2ODo6UHJlQ29tcGlsZSgpIGNhbiByZXR1cm4g MCB3aGVuIHRoZSBzdGFjayBvZgorICAgICAgICBWOCdzIHBhcnNlciBvdmVyZmxvd3MgKGMuZi4g aHR0cDovL2NvZGUuZ29vZ2xlLmNvbS9jb2Rlc2VhcmNoI09BTWx4X2pvLWNrL3NyYy92OC9zcmMv cGFyc2VyLmNjJmV4YWN0X3BhY2thZ2U9Y2hyb21pdW0mcT1rUHJlUGFyc2VTdGFja092ZXJmbG93 JnR5cGU9Y3MmbD02MDIxKS4KKworICAgICAgICBUaGlzIHBhdGNoIGFkZHMgdGhlIDAgY2hlY2sg dG8gdGhlIGNhbGxlciBzaWRlLiBHaXZlbiB0aGF0IHByZWNvbXBpbGVTY3JpcHQoKQorICAgICAg ICBpcyBqdXN0IHRyeWluZyB0byBzcGVjdWxhdGl2ZWx5IHByZWNvbXBpbGUgYSBzY3JpcHQsIGl0 J3MgT0sgdG8gZ2l2ZSB1cAorICAgICAgICBwcmVjb21waWxpbmcgZm9yIHN1Y2ggZWRnZSBjYXNl cy4KKworICAgICAgICBNYW51YWxseSB0ZXN0ZWQgd2l0aCB0aGUgaHRtbCBnZW5lcmF0ZWQgYnkg dGhlIGZvbGxvd2luZyBzaGVsbCBzY3JpcHQ6CisKKyAgICAgICAgICBlY2hvICc8c2NyaXB0IGxh bmd1YWdlPSJKYXZhU2NyaXB0IiB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iYXNhbi1jcmFz aC5qcyI+PC9zY3JpcHQ+JyA+IGFzYW4tY3Jhc2guaHRtbAorICAgICAgICAgIGVjaG8gJ2lmKHdV UkxGLnNlYXJjaCgiIik+PTApIHt9JyA+IGFzYW4tY3Jhc2guanMKKyAgICAgICAgICBmb3IgaSBp biBgc2VxIDE0ODMwYAorICAgICAgICAgIGRvCisgICAgICAgICAgICBlY2hvICdlbHNlIGlmKHdV UkxGLnNlYXJjaCgiIik+PTApIHt9JyA+PiBhc2FuLWNyYXNoLmpzCisgICAgICAgICAgZG9uZQor CisgICAgICAgIEkgZGlkbid0IGFkZCB0aGUgdGVzdCBiZWNhdXNlICcxNDM4MCcgZGVwZW5kcyBv biBhbiBlbnZpcm9ubWVudAorICAgICAgICBhbmQgYmVjYXVzZSB3ZSBkb24ndCB3YW50IHRvIGFk ZCBhIGh1Z2UgaHRtbCB0ZXN0LgorCisgICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0U291cmNl Q29kZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRTb3VyY2VDb2RlOjpwcmVjb21waWxl U2NyaXB0KToKKwogMjAxMi0wOS0xNyAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgRXhwb3J0IFJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OmlzTGFuZ0F0dHJpYnV0 ZUF3YXJlRm9ybUNvbnRyb2xVSUVuYWJsZWQgY29ycmVjdGx5CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRTb3VyY2VDb2RlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1NjcmlwdFNvdXJjZUNvZGUuY3BwCmluZGV4IGVmZmY2M2UxN2RhMTVmYTFh MGU5ZWNiNDc3NmJhZDE1ZWQ4YmRjMjUuLjJjOTMzY2ZmNjkyMDA5MmFlZTA3ZTQ2YTQ4NDg1MWJl OTRkNzcwZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFNv dXJjZUNvZGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFNvdXJj ZUNvZGUuY3BwCkBAIC00OSw2ICs0OSw5IEBAIFBhc3NPd25QdHI8djg6OlNjcmlwdERhdGE+IFNj cmlwdFNvdXJjZUNvZGU6OnByZWNvbXBpbGVTY3JpcHQodjg6OkhhbmRsZTx2ODo6U3RyCiAgICAg ICAgIHJldHVybiBhZG9wdFB0cih2ODo6U2NyaXB0RGF0YTo6TmV3KGNhY2hlZE1ldGFkYXRhLT5k YXRhKCksIGNhY2hlZE1ldGFkYXRhLT5zaXplKCkpKTsKIAogICAgIE93blB0cjx2ODo6U2NyaXB0 RGF0YT4gc2NyaXB0RGF0YSA9IGFkb3B0UHRyKHY4OjpTY3JpcHREYXRhOjpQcmVDb21waWxlKGNv ZGUpKTsKKyAgICBpZiAoIXNjcmlwdERhdGEuZ2V0KCkpCisgICAgICAgIHJldHVybiBudWxscHRy OworCiAgICAgY2FjaGVkU2NyaXB0LT5zZXRDYWNoZWRNZXRhZGF0YShkYXRhVHlwZUlELCBzY3Jp cHREYXRhLT5EYXRhKCksIHNjcmlwdERhdGEtPkxlbmd0aCgpKTsKIAogICAgIHJldHVybiBzY3Jp cHREYXRhLnJlbGVhc2UoKTsK 164805 2012-09-19 17:05:33 -0700 2012-09-19 17:41:04 -0700 patch for landing bug-96567-20120920090458.patch text/plain 2573 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4ODUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjMwMmI4MWQ1MWFjMjk2 YTg5M2Y3NjExNmE5OTNmZDhlNjY4MGEyYi4uMDM1ZGYyOWY0Mzc2MjVhODZmMDhlYjM3NWQwYWMw MWI3ODhjOTUyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDEyLTA5LTE4ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFNjcmlwdENv bnRyb2xsZXI6OmNvbXBpbGVBbmRSdW5TY3JpcHQoKSBjYW4gY3Jhc2gKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NTY3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgQWRhbSBCYXJ0aC4KKworICAgICAgICBTZWUgY2hyb21pdW0gYnVnOiBodHRwOi8vY29k ZS5nb29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD0xNDY3NzYKKworICAgICAg ICBUaGUgcm9vdCBjYXVzZSBpcyB0aGF0IHY4OjpQcmVDb21waWxlKCkgY2FuIHJldHVybiAwIHdo ZW4gdGhlIHN0YWNrIG9mCisgICAgICAgIFY4J3MgcGFyc2VyIG92ZXJmbG93cyAoYy5mLiBodHRw Oi8vY29kZS5nb29nbGUuY29tL2NvZGVzZWFyY2gjT0FNbHhfam8tY2svc3JjL3Y4L3NyYy9wYXJz ZXIuY2MmZXhhY3RfcGFja2FnZT1jaHJvbWl1bSZxPWtQcmVQYXJzZVN0YWNrT3ZlcmZsb3cmdHlw ZT1jcyZsPTYwMjEpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkcyB0aGUgMCBjaGVjayB0byB0 aGUgY2FsbGVyIHNpZGUuIEdpdmVuIHRoYXQgcHJlY29tcGlsZVNjcmlwdCgpCisgICAgICAgIGlz IGp1c3QgdHJ5aW5nIHRvIHNwZWN1bGF0aXZlbHkgcHJlY29tcGlsZSBhIHNjcmlwdCwgaXQncyBP SyB0byBnaXZlIHVwCisgICAgICAgIHByZWNvbXBpbGluZyBmb3Igc3VjaCBlZGdlIGNhc2VzLgor CisgICAgICAgIE1hbnVhbGx5IHRlc3RlZCB3aXRoIHRoZSBodG1sIGdlbmVyYXRlZCBieSB0aGUg Zm9sbG93aW5nIHNoZWxsIHNjcmlwdDoKKworICAgICAgICAgIGVjaG8gJzxzY3JpcHQgbGFuZ3Vh Z2U9IkphdmFTY3JpcHQiIHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJhc2FuLWNyYXNoLmpz Ij48L3NjcmlwdD4nID4gYXNhbi1jcmFzaC5odG1sCisgICAgICAgICAgZWNobyAnaWYod1VSTEYu c2VhcmNoKCIiKT49MCkge30nID4gYXNhbi1jcmFzaC5qcworICAgICAgICAgIGZvciBpIGluIGBz ZXEgMTQ4MzBgCisgICAgICAgICAgZG8KKyAgICAgICAgICAgIGVjaG8gJ2Vsc2UgaWYod1VSTEYu c2VhcmNoKCIiKT49MCkge30nID4+IGFzYW4tY3Jhc2guanMKKyAgICAgICAgICBkb25lCisKKyAg ICAgICAgSSBkaWRuJ3QgYWRkIHRoZSB0ZXN0IGJlY2F1c2UgJzE0MzgwJyBkZXBlbmRzIG9uIGFu IGVudmlyb25tZW50CisgICAgICAgIGFuZCBiZWNhdXNlIHdlIGRvbid0IHdhbnQgdG8gYWRkIGEg aHVnZSBodG1sIHRlc3QuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TY3JpcHRTb3VyY2VDb2Rl LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFNvdXJjZUNvZGU6OnByZWNvbXBpbGVTY3Jp cHQpOgorCiAyMDEyLTA5LTE3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KIAog ICAgICAgICBFeHBvcnQgUnVudGltZUVuYWJsZWRGZWF0dXJlczo6aXNMYW5nQXR0cmlidXRlQXdh cmVGb3JtQ29udHJvbFVJRW5hYmxlZCBjb3JyZWN0bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFNvdXJjZUNvZGUuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvU2NyaXB0U291cmNlQ29kZS5jcHAKaW5kZXggZWZmZjYzZTE3ZGExNWZhMWEwZTll Y2I0Nzc2YmFkMTVlZDhiZGMyNS4uOGM3OGI2NGEyZTIxMWY1ZTQ1OWI0ODE4YjRlOTg0NjM2ZWZk Y2JjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0U291cmNl Q29kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0U291cmNlQ29k ZS5jcHAKQEAgLTQ5LDYgKzQ5LDkgQEAgUGFzc093blB0cjx2ODo6U2NyaXB0RGF0YT4gU2NyaXB0 U291cmNlQ29kZTo6cHJlY29tcGlsZVNjcmlwdCh2ODo6SGFuZGxlPHY4OjpTdHIKICAgICAgICAg cmV0dXJuIGFkb3B0UHRyKHY4OjpTY3JpcHREYXRhOjpOZXcoY2FjaGVkTWV0YWRhdGEtPmRhdGEo KSwgY2FjaGVkTWV0YWRhdGEtPnNpemUoKSkpOwogCiAgICAgT3duUHRyPHY4OjpTY3JpcHREYXRh PiBzY3JpcHREYXRhID0gYWRvcHRQdHIodjg6OlNjcmlwdERhdGE6OlByZUNvbXBpbGUoY29kZSkp OworICAgIGlmICghc2NyaXB0RGF0YSkKKyAgICAgICAgcmV0dXJuIG51bGxwdHI7CisKICAgICBj YWNoZWRTY3JpcHQtPnNldENhY2hlZE1ldGFkYXRhKGRhdGFUeXBlSUQsIHNjcmlwdERhdGEtPkRh dGEoKSwgc2NyaXB0RGF0YS0+TGVuZ3RoKCkpOwogCiAgICAgcmV0dXJuIHNjcmlwdERhdGEucmVs ZWFzZSgpOwo=