96540 2012-09-12 12:10:24 -0700 [EFL] Compilation error in RenderThemeEfl.cpp 2012-09-12 13:44:16 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96501 1 cdumez cdumez gyuyoung.kim kenneth lucas.de.marchi naginenis rakuco tmpsantos webkit.review.bot oldest_to_newest 718573 0 cdumez 2012-09-12 12:10:24 -0700 We get the following error on the EFL debug build bot: Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/platform/efl/RenderThemeEfl.cpp.o Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/platform/efl/ScrollbarEfl.cpp.o /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/efl/RenderThemeEfl.cpp: In member function ‘WTF::String WebCore::RenderThemeEfl::themePath() const’: /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/efl/RenderThemeEfl.cpp:495:14: error: passing ‘const WebCore::RenderThemeEfl’ as ‘this’ argument of ‘Evas_Object* WebCore::RenderThemeEfl::edje()’ discards qualifiers [-fpermissive] /home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebCore/platform/efl/RenderThemeEfl.cpp:497:35: error: passing ‘const WebCore::RenderThemeEfl’ as ‘this’ argument of ‘Evas_Object* WebCore::RenderThemeEfl::edje()’ discards qualifiers [-fpermissive] make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/platform/efl/RenderThemeEfl.cpp.o] Error 1 718576 1 163669 cdumez 2012-09-12 12:12:19 -0700 Created attachment 163669 Patch 718610 2 tmpsantos 2012-09-12 12:32:52 -0700 Thanks for fixing Chris! 718615 3 163669 webkit.review.bot 2012-09-12 12:41:23 -0700 Comment on attachment 163669 Patch Clearing flags on attachment: 163669 Committed r128350: <http://trac.webkit.org/changeset/128350> 718616 4 webkit.review.bot 2012-09-12 12:41:27 -0700 All reviewed patches have been landed. Closing bug. 718678 5 naginenis 2012-09-12 13:44:16 -0700 Thanks for the fix, Chris. 163669 2012-09-12 12:12:19 -0700 2012-09-12 12:41:23 -0700 Patch 96540_build_fix.patch text/plain 1437 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlOTljNjhhLi42YTMwMWIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDktMTIgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXSBDb21waWxhdGlvbiBlcnJvciBpbiBSZW5kZXJUaGVtZUVm bC5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2 NTQwCisKKyAgICAgICAgVW5yZXZpZXdlZCBidWlsZCBmaXguCisKKyAgICAgICAgRml4IGNvbXBp bGF0aW9uIGVycm9yIGluIFJlbmRlclRoZW1lRWZsLmNwcCB3aGVuIGJ1aWxkaW5nCisgICAgICAg IGluIGRlYnVnIG1vZGUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvUmVuZGVyVGhlbWVFZmwu aDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lRWZsOjpjYW52YXMpOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyVGhlbWVFZmw6OmVkamUpOgorCiAyMDEyLTA5LTEyICBNaWtlIEZlbnRv biAgPG1pZmVudG9uQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkZCBjdXN0b20g bWVzc2FnZXMgZm9yIGlucHV0IHR5cGUgdmFsaWRhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2VmbC9SZW5kZXJUaGVtZUVmbC5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKaW5kZXggMjA0NzJjZi4uNmQ2MmFkNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1JlbmRlclRoZW1lRWZsLmgKQEAgLTIyMiw4ICsy MjIsOCBAQCBwcml2YXRlOgogICAgICAgICByZXR1cm4gbV9lZGplIHx8ICghbV90aGVtZVBhdGgu aXNFbXB0eSgpICYmIGNvbnN0X2Nhc3Q8UmVuZGVyVGhlbWVFZmwqPih0aGlzKS0+bG9hZFRoZW1l KCkpOwogICAgIH0KIAotICAgIEFMV0FZU19JTkxJTkUgRWNvcmVfRXZhcyogY2FudmFzKCkgeyBy ZXR1cm4gbV9jYW52YXMuZ2V0KCk7IH0KLSAgICBBTFdBWVNfSU5MSU5FIEV2YXNfT2JqZWN0KiBl ZGplKCkgeyByZXR1cm4gbV9lZGplLmdldCgpOyB9CisgICAgQUxXQVlTX0lOTElORSBFY29yZV9F dmFzKiBjYW52YXMoKSBjb25zdCB7IHJldHVybiBtX2NhbnZhcy5nZXQoKTsgfQorICAgIEFMV0FZ U19JTkxJTkUgRXZhc19PYmplY3QqIGVkamUoKSBjb25zdCB7IHJldHVybiBtX2VkamUuZ2V0KCk7 IH0KIAogICAgIHZvaWQgYXBwbHlQYXJ0RGVzY3JpcHRpb25zRnJvbShjb25zdCBTdHJpbmcmIHRo ZW1lUGF0aCk7CiAK