96539 2012-09-12 12:08:13 -0700 REGRESSION(r106730): iframes with scrolling=no can't scroll to anchors 2012-10-02 19:43:24 -0700 1 1 1 Unclassified WebKit Frames 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 61558 1 japhet japhet eric simon.fraser spottabathini tonikitoo webkit.review.bot oldest_to_newest 718571 0 japhet 2012-09-12 12:08:13 -0700 Original report: http://code.google.com/p/chromium/issues/detail?id=119666 If an iframe with scrolling=no contains a link to an anchor in the same document, we do not properly scroll to the anchor when it is clicked. This appears to be a regression from http://trac.webkit.org/changeset/106730 . 718584 1 163670 japhet 2012-09-12 12:18:54 -0700 Created attachment 163670 patch 732964 2 163670 tonikitoo 2012-10-02 12:44:20 -0700 Comment on attachment 163670 patch View in context: https://bugs.webkit.org/attachment.cgi?id=163670&action=review > Source/WebCore/rendering/RenderLayer.cpp:1793 > + if ((frameElement && frameElement->scrollingMode() != ScrollbarAlwaysOff) || (!frameView->frame()->eventHandler()->autoscrollInProgress() && !frameView->wasScrolledByUser())) { it is turning to be a long line. 733154 3 166765 japhet 2012-10-02 15:42:15 -0700 Created attachment 166765 Patch for landing 733180 4 166765 webkit.review.bot 2012-10-02 16:14:49 -0700 Comment on attachment 166765 Patch for landing Clearing flags on attachment: 166765 Committed r130226: <http://trac.webkit.org/changeset/130226> 733181 5 webkit.review.bot 2012-10-02 16:14:52 -0700 All reviewed patches have been landed. Closing bug. 733219 6 163670 darin 2012-10-02 16:45:34 -0700 Comment on attachment 163670 patch View in context: https://bugs.webkit.org/attachment.cgi?id=163670&action=review >> Source/WebCore/rendering/RenderLayer.cpp:1793 >> + if ((frameElement && frameElement->scrollingMode() != ScrollbarAlwaysOff) || (!frameView->frame()->eventHandler()->autoscrollInProgress() && !frameView->wasScrolledByUser())) { > > it is turning to be a long line. An inline helper function could spread this out over multiple lines and allow a comment on each line. 733322 7 tonikitoo 2012-10-02 19:43:24 -0700 > > > > it is turning to be a long line. > > An inline helper function could spread this out over multiple lines and allow a comment on each line. Nate, lets please go for it. 163670 2012-09-12 12:18:54 -0700 2012-10-02 16:45:34 -0700 patch iframescroll.txt text/plain 5748 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAkocmV2aXNpb24gMTI4MzQ1KQorKysg U291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTA5 LDYgKzEwOSw3IEBACiAgICAgdm9pZCBzdG9wQXV0b3Njcm9sbFRpbWVyKGJvb2wgcmVuZGVyZXJJ c0JlaW5nRGVzdHJveWVkID0gZmFsc2UpOwogICAgIFJlbmRlck9iamVjdCogYXV0b3Njcm9sbFJl bmRlcmVyKCkgY29uc3Q7CiAgICAgdm9pZCB1cGRhdGVBdXRvc2Nyb2xsUmVuZGVyZXIoKTsKKyAg ICBib29sIGF1dG9zY3JvbGxJblByb2dyZXNzKCkgY29uc3QgeyByZXR1cm4gbV9hdXRvc2Nyb2xs SW5Qcm9ncmVzczsgfQogCiAgICAgdm9pZCBkaXNwYXRjaEZha2VNb3VzZU1vdmVFdmVudFNvb24o KTsKICAgICB2b2lkIGRpc3BhdGNoRmFrZU1vdXNlTW92ZUV2ZW50U29vbkluUXVhZChjb25zdCBG bG9hdFF1YWQmKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODM0NSkKKysrIFNvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5 LTEyICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgaWZyYW1l cyB3aXRoIHNjcm9sbGluZz1ubyBjYW4ndCBzY3JvbGwgdG8gYW5jaG9ycworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY1MzkKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGFwcGVhcnMgdG8gaGF2ZSBy ZWdyZXNzZWQgaW4gcjEwNjczMC4gVGhpcyBwYXRjaCBtYXRjaGVzIEZpcmVmb3gncyBiZWhhdmlv ci4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItaW4t bm9zY3JvbGwtaWZyYW1lLmh0bWwKKworICAgICAgICAqIHBhZ2UvRXZlbnRIYW5kbGVyLmg6Cisg ICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJl bmRlckxheWVyOjpzY3JvbGxSZWN0VG9WaXNpYmxlKTogQ3VycmVudGx5IHNjcm9sbHMgYXJlIGFs d2F5cyBmb3JiaWRkZW4KKyAgICAgICAgICAgaWYgc2Nyb2xsYmFycyBhcmUgZXhwbGljaXRseSBk aXNhYmxlZC4gVGhpcyBhZGRzIGFuIGV4Y2VwdGlvbiBmb3Igc2Nyb2xscyB0aGF0CisgICAgICAg ICAgIGFyZSBub3QgdXNlci1pbml0aWF0ZWQgYW5kIGFyZSBub3QgYXV0b3Njcm9sbHMuCisKIDIw MTItMDktMTIgIE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAg QnVpbGQgZml4ZWQgZm9yIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEyODI0MwpJ bmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShyZXZpc2lvbiAx MjgzNDUpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNzkwLDcgKzE3OTAsNyBAQAogICAgICAgICAgICAgICAgIGlmIChvd25l ckVsZW1lbnQtPmhhc1RhZ05hbWUoZnJhbWVUYWcpIHx8IG93bmVyRWxlbWVudC0+aGFzVGFnTmFt ZShpZnJhbWVUYWcpKQogICAgICAgICAgICAgICAgICAgICBmcmFtZUVsZW1lbnQgPSBzdGF0aWNf Y2FzdDxIVE1MRnJhbWVFbGVtZW50Kj4ob3duZXJFbGVtZW50KTsKIAotICAgICAgICAgICAgICAg IGlmIChmcmFtZUVsZW1lbnQgJiYgZnJhbWVFbGVtZW50LT5zY3JvbGxpbmdNb2RlKCkgIT0gU2Ny b2xsYmFyQWx3YXlzT2ZmKSB7CisgICAgICAgICAgICAgICAgaWYgKChmcmFtZUVsZW1lbnQgJiYg ZnJhbWVFbGVtZW50LT5zY3JvbGxpbmdNb2RlKCkgIT0gU2Nyb2xsYmFyQWx3YXlzT2ZmKSB8fCAo IWZyYW1lVmlldy0+ZnJhbWUoKS0+ZXZlbnRIYW5kbGVyKCktPmF1dG9zY3JvbGxJblByb2dyZXNz KCkgJiYgIWZyYW1lVmlldy0+d2FzU2Nyb2xsZWRCeVVzZXIoKSkpIHsKICAgICAgICAgICAgICAg ICAgICAgTGF5b3V0UmVjdCB2aWV3UmVjdCA9IGZyYW1lVmlldy0+dmlzaWJsZUNvbnRlbnRSZWN0 KCk7CiAgICAgICAgICAgICAgICAgICAgIExheW91dFJlY3QgZXhwb3NlUmVjdCA9IGdldFJlY3RU b0V4cG9zZSh2aWV3UmVjdCwgcmVjdCwgYWxpZ25YLCBhbGlnblkpOwogCkluZGV4OiBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItaW4tbm9zY3JvbGwtaWZyYW1l LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5j aG9yRWxlbWVudC9hbmNob3ItaW4tbm9zY3JvbGwtaWZyYW1lLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1p bi1ub3Njcm9sbC1pZnJhbWUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEs MiBAQAorVGhpcyB0ZXN0cyB3aGV0aGVyIGNsaWNraW5nIG9uIGFuIGFuY2hvciBpbiBhbiBpZnJh bWUgd2l0aCBzY3JvbGxpbmc9Im5vIiB3aWxsIHNjcm9sbCB0byBhbmNob3IuIElmIGNsaWNraW5n IG9uIHRoZSBsaW5rIGJlbG93IHRyaWdnZXJzIGEgc2Nyb2xsLCB0aGUgdGVzdCBwYXNzZXMuCitQ QVNTCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9yZXNvdXJj ZXMvaWZyYW1lLXdpdGgtYW5jaG9yLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC9kb20vSFRNTEFuY2hvckVsZW1lbnQvcmVzb3VyY2VzL2lmcmFtZS13aXRoLWFuY2hvci5odG1s CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQv cmVzb3VyY2VzL2lmcmFtZS13aXRoLWFuY2hvci5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAg KzEsNDIgQEAKKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgorCitpZiAod2luZG93LnRlc3RSdW5u ZXIpIHsKKyAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB0ZXN0UnVubmVyLmR1 bXBBc1RleHQoKTsKK30KKworZnVuY3Rpb24gcnVuKCkgeworaWYgKHdpbmRvdy5ldmVudFNlbmRl cikgeworICAgIHZhciBhbmNob3IgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3RhcnQiKTsK KyAgICB2YXIgeCA9IHdpbmRvdy5mcmFtZUVsZW1lbnQub2Zmc2V0TGVmdCArIGFuY2hvci5vZmZz ZXRMZWZ0ICsgMjsKKyAgICB2YXIgeSA9IHdpbmRvdy5mcmFtZUVsZW1lbnQub2Zmc2V0VG9wICsg YW5jaG9yLm9mZnNldFRvcCArIDI7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oeCwgeSk7 CisgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VVcCgp OworICAgIHNldFRpbWVvdXQoZmluaXNoLCAxMDAwKTsKK30KKworZnVuY3Rpb24gZmluaXNoKCkg eworICAgIHZhciByZXN1bHQ7CisgICAgaWYgKHdpbmRvdy50b3Auc2Nyb2xsWSA9PSAwKQorICAg ICAgICByZXN1bHQgPSAiRkFJTDogbmF2aWdhdGluZyB0byB0aGUgYW5jaG9yIHNob3VsZCB0cmln Z2VyIGEgc2Nyb2xsIjsKKyAgICBlbHNlCisgICAgICAgIHJlc3VsdCA9ICJQQVNTIjsKKworICAg IHdpbmRvdy50b3AuZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0 Tm9kZShyZXN1bHQpKTsKKyAgICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RS dW5uZXIubm90aWZ5RG9uZSgpOworfQorCit9Cis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IG9u bG9hZD0icnVuKCk7Ij4KKworPGEgaWQ9InN0YXJ0IiBocmVmPSIjYW5jaG9yIj5HbyB0byBhbmNo b3I8L2E+Cis8ZGl2IHN0eWxlPSJoZWlnaHQ6IDEwMDBweCI+PC9kaXY+Cis8YSBuYW1lPSJhbmNo b3IiPkFuY2hvcjwvYT4KKzwvYm9keT4KKzwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3Qv ZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1pbi1ub3Njcm9sbC1pZnJhbWUuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3It aW4tbm9zY3JvbGwtaWZyYW1lLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItaW4tbm9zY3JvbGwtaWZyYW1lLmh0bWwJKHdv cmtpbmcgY29weSkKQEAgLTAsMCArMSw2IEBACis8aHRtbD4KKzxib2R5PgorVGhpcyB0ZXN0cyB3 aGV0aGVyIGNsaWNraW5nIG9uIGFuIGFuY2hvciBpbiBhbiBpZnJhbWUgd2l0aCBzY3JvbGxpbmc9 Im5vIiB3aWxsIHNjcm9sbCB0byBhbmNob3IuIElmIGNsaWNraW5nIG9uIHRoZSBsaW5rIGJlbG93 IHRyaWdnZXJzIGEgc2Nyb2xsLCB0aGUgdGVzdCBwYXNzZXMuPGJyPgorPGlmcmFtZSBzcmM9InJl c291cmNlcy9pZnJhbWUtd2l0aC1hbmNob3IuaHRtbCIgd2lkdGg9IjEwMCUiIGhlaWdodD0iMjAw MCIgc2Nyb2xsaW5nPSJubyI+PC9pZnJhbWU+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShy ZXZpc2lvbiAxMjgzNDUpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxNCBAQAorMjAxMi0wOS0xMiAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NjUzOS4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1pbi1ub3Njcm9s bC1pZnJhbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9IVE1MQW5j aG9yRWxlbWVudC9hbmNob3ItaW4tbm9zY3JvbGwtaWZyYW1lLmh0bWw6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L3Jlc291cmNlczogQWRkZWQuCisgICAgICAg ICogZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvcmVzb3VyY2VzL2lmcmFtZS13aXRoLWFuY2hv ci5odG1sOiBBZGRlZC4KKwogMjAxMi0wOS0xMiAgWmFuIERvYmVyc2VrICA8emFuZG9iZXJzZWtA Z21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgR1RLIGdhcmRlbmluZy4K 166765 2012-10-02 15:42:15 -0700 2012-10-02 16:14:49 -0700 Patch for landing bug-96539-20121002154128.patch text/plain 5908 japhet SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDIwMykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTEyICBOYXRlIENo YXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgaWZyYW1lcyB3aXRoIHNjcm9s bGluZz1ubyBjYW4ndCBzY3JvbGwgdG8gYW5jaG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY1MzkKKworICAgICAgICBSZXZpZXdlZCBieSBBbnRv bmlvIEdvbWVzLgorCisgICAgICAgIFRoaXMgYXBwZWFycyB0byBoYXZlIHJlZ3Jlc3NlZCBpbiBy MTA2NzMwLiBUaGlzIHBhdGNoIG1hdGNoZXMgRmlyZWZveCdzIGJlaGF2aW9yLgorCisgICAgICAg IFRlc3Q6IGZhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1pbi1ub3Njcm9sbC1pZnJh bWUuaHRtbAorCisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuaDoKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXI6OnNj cm9sbFJlY3RUb1Zpc2libGUpOiBDdXJyZW50bHkgc2Nyb2xscyBhcmUgYWx3YXlzIGZvcmJpZGRl bgorICAgICAgICAgICBpZiBzY3JvbGxiYXJzIGFyZSBleHBsaWNpdGx5IGRpc2FibGVkLiBUaGlz IGFkZHMgYW4gZXhjZXB0aW9uIGZvciBzY3JvbGxzIHRoYXQKKyAgICAgICAgICAgYXJlIG5vdCB1 c2VyLWluaXRpYXRlZCBhbmQgYXJlIG5vdCBhdXRvc2Nyb2xscy4KKwogMjAxMi0xMC0wMiAgRXJp ayBBcnZpZHNzb24gIDxhcnZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIGNyZWF0ZUhUTUxEb2N1 bWVudCgpIHNob3VsZCBub3QgY3JlYXRlIGEgdGl0bGUgZWxlbWVudCBpZiB0aGUgdGl0bGUgYXJn dW1lbnQgaXMgbGVmdCBvdXQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVy LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAkocmV2 aXNpb24gMTMwMjAzKQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9FdmVudEhhbmRsZXIuaAkod29y a2luZyBjb3B5KQpAQCAtMTExLDYgKzExMSw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHN0b3BBdXRv c2Nyb2xsVGltZXIoYm9vbCByZW5kZXJlcklzQmVpbmdEZXN0cm95ZWQgPSBmYWxzZSk7CiAgICAg UmVuZGVyT2JqZWN0KiBhdXRvc2Nyb2xsUmVuZGVyZXIoKSBjb25zdDsKICAgICB2b2lkIHVwZGF0 ZUF1dG9zY3JvbGxSZW5kZXJlcigpOworICAgIGJvb2wgYXV0b3Njcm9sbEluUHJvZ3Jlc3MoKSBj b25zdCB7IHJldHVybiBtX2F1dG9zY3JvbGxJblByb2dyZXNzOyB9CiAKICAgICB2b2lkIGRpc3Bh dGNoRmFrZU1vdXNlTW92ZUV2ZW50U29vbigpOwogICAgIHZvaWQgZGlzcGF0Y2hGYWtlTW91c2VN b3ZlRXZlbnRTb29uSW5RdWFkKGNvbnN0IEZsb2F0UXVhZCYpOwpJbmRleDogU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCShyZXZpc2lvbiAxMzAyMDMpCisrKyBTb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xODA2 LDcgKzE4MDYsOCBAQCB2b2lkIFJlbmRlckxheWVyOjpzY3JvbGxSZWN0VG9WaXNpYmxlKGNvCiAg ICAgICAgICAgICAgICAgaWYgKG93bmVyRWxlbWVudC0+aGFzVGFnTmFtZShmcmFtZVRhZykgfHwg b3duZXJFbGVtZW50LT5oYXNUYWdOYW1lKGlmcmFtZVRhZykpCiAgICAgICAgICAgICAgICAgICAg IGZyYW1lRWxlbWVudCA9IHN0YXRpY19jYXN0PEhUTUxGcmFtZUVsZW1lbnQqPihvd25lckVsZW1l bnQpOwogCi0gICAgICAgICAgICAgICAgaWYgKGZyYW1lRWxlbWVudCAmJiBmcmFtZUVsZW1lbnQt PnNjcm9sbGluZ01vZGUoKSAhPSBTY3JvbGxiYXJBbHdheXNPZmYpIHsKKyAgICAgICAgICAgICAg ICBpZiAoKGZyYW1lRWxlbWVudCAmJiBmcmFtZUVsZW1lbnQtPnNjcm9sbGluZ01vZGUoKSAhPSBT Y3JvbGxiYXJBbHdheXNPZmYpCisgICAgICAgICAgICAgICAgICAgIHx8ICghZnJhbWVWaWV3LT5m cmFtZSgpLT5ldmVudEhhbmRsZXIoKS0+YXV0b3Njcm9sbEluUHJvZ3Jlc3MoKSAmJiAhZnJhbWVW aWV3LT53YXNTY3JvbGxlZEJ5VXNlcigpKSkgewogICAgICAgICAgICAgICAgICAgICBMYXlvdXRS ZWN0IHZpZXdSZWN0ID0gZnJhbWVWaWV3LT52aXNpYmxlQ29udGVudFJlY3QoKTsKICAgICAgICAg ICAgICAgICAgICAgTGF5b3V0UmVjdCBleHBvc2VSZWN0ID0gZ2V0UmVjdFRvRXhwb3NlKHZpZXdS ZWN0LCByZWN0LCBhbGlnblgsIGFsaWduWSk7CiAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxv Zwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzMDIwMykK KysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTA5LTEyICBOYXRlIENoYXBpbiAgPGphcGhldEBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgVGVzdCBmb3IgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NTM5 LgorCisgICAgICAgIFJldmlld2VkIGJ5IEFudG9uaW8gR29tZXMuCisKKyAgICAgICAgKiBmYXN0 L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItaW4tbm9zY3JvbGwtaWZyYW1lLWV4cGVjdGVk LnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9y LWluLW5vc2Nyb2xsLWlmcmFtZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2RvbS9IVE1M QW5jaG9yRWxlbWVudC9yZXNvdXJjZXM6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9tL0hUTUxB bmNob3JFbGVtZW50L3Jlc291cmNlcy9pZnJhbWUtd2l0aC1hbmNob3IuaHRtbDogQWRkZWQuCisK IDIwMTItMTAtMDIgIEVyaWsgQXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBjcmVhdGVIVE1MRG9jdW1lbnQoKSBzaG91bGQgbm90IGNyZWF0ZSBhIHRpdGxlIGVsZW1lbnQg aWYgdGhlIHRpdGxlIGFyZ3VtZW50IGlzIGxlZnQgb3V0CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItaW4tbm9zY3JvbGwtaWZyYW1lLWV4cGVjdGVk LnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVu dC9hbmNob3ItaW4tbm9zY3JvbGwtaWZyYW1lLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysr IExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L2FuY2hvci1pbi1ub3Njcm9s bC1pZnJhbWUtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMiBAQAorVGhp cyB0ZXN0cyB3aGV0aGVyIGNsaWNraW5nIG9uIGFuIGFuY2hvciBpbiBhbiBpZnJhbWUgd2l0aCBz Y3JvbGxpbmc9Im5vIiB3aWxsIHNjcm9sbCB0byBhbmNob3IuIElmIGNsaWNraW5nIG9uIHRoZSBs aW5rIGJlbG93IHRyaWdnZXJzIGEgc2Nyb2xsLCB0aGUgdGVzdCBwYXNzZXMuCitQQVNTCkluZGV4 OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9hbmNob3ItaW4tbm9zY3Jv bGwtaWZyYW1lLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFu Y2hvckVsZW1lbnQvYW5jaG9yLWluLW5vc2Nyb2xsLWlmcmFtZS5odG1sCShyZXZpc2lvbiAwKQor KysgTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvYW5jaG9yLWluLW5vc2Ny b2xsLWlmcmFtZS5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNiBAQAorPGh0bWw+Cis8 Ym9keT4KK1RoaXMgdGVzdHMgd2hldGhlciBjbGlja2luZyBvbiBhbiBhbmNob3IgaW4gYW4gaWZy YW1lIHdpdGggc2Nyb2xsaW5nPSJubyIgd2lsbCBzY3JvbGwgdG8gYW5jaG9yLiBJZiBjbGlja2lu ZyBvbiB0aGUgbGluayBiZWxvdyB0cmlnZ2VycyBhIHNjcm9sbCwgdGhlIHRlc3QgcGFzc2VzLjxi cj4KKzxpZnJhbWUgc3JjPSJyZXNvdXJjZXMvaWZyYW1lLXdpdGgtYW5jaG9yLmh0bWwiIHdpZHRo PSIxMDAlIiBoZWlnaHQ9IjIwMDAiIHNjcm9sbGluZz0ibm8iPjwvaWZyYW1lPgorPC9ib2R5Pgor PC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9kb20vSFRNTEFuY2hvckVsZW1lbnQvcmVz b3VyY2VzL2lmcmFtZS13aXRoLWFuY2hvci5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L3Jlc291cmNlcy9pZnJhbWUtd2l0aC1hbmNob3Iu aHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVt ZW50L3Jlc291cmNlcy9pZnJhbWUtd2l0aC1hbmNob3IuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MCwwICsxLDQyIEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KKworaWYgKHdpbmRvdy50ZXN0 UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisgICAgdGVzdFJ1bm5l ci5kdW1wQXNUZXh0KCk7Cit9CisKK2Z1bmN0aW9uIHJ1bigpIHsKK2lmICh3aW5kb3cuZXZlbnRT ZW5kZXIpIHsKKyAgICB2YXIgYW5jaG9yID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInN0YXJ0 Iik7CisgICAgdmFyIHggPSB3aW5kb3cuZnJhbWVFbGVtZW50Lm9mZnNldExlZnQgKyBhbmNob3Iu b2Zmc2V0TGVmdCArIDI7CisgICAgdmFyIHkgPSB3aW5kb3cuZnJhbWVFbGVtZW50Lm9mZnNldFRv cCArIGFuY2hvci5vZmZzZXRUb3AgKyAyOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgs IHkpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOworICAgIGV2ZW50U2VuZGVyLm1vdXNl VXAoKTsKKyAgICBzZXRUaW1lb3V0KGZpbmlzaCwgMTAwMCk7Cit9CisKK2Z1bmN0aW9uIGZpbmlz aCgpIHsKKyAgICB2YXIgcmVzdWx0OworICAgIGlmICh3aW5kb3cudG9wLnNjcm9sbFkgPT0gMCkK KyAgICAgICAgcmVzdWx0ID0gIkZBSUw6IG5hdmlnYXRpbmcgdG8gdGhlIGFuY2hvciBzaG91bGQg dHJpZ2dlciBhIHNjcm9sbCI7CisgICAgZWxzZQorICAgICAgICByZXN1bHQgPSAiUEFTUyI7CisK KyAgICB3aW5kb3cudG9wLmRvY3VtZW50LmJvZHkuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRl VGV4dE5vZGUocmVzdWx0KSk7CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0 ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKK30KKworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9k eSBvbmxvYWQ9InJ1bigpOyI+CisKKzxhIGlkPSJzdGFydCIgaHJlZj0iI2FuY2hvciI+R28gdG8g YW5jaG9yPC9hPgorPGRpdiBzdHlsZT0iaGVpZ2h0OiAxMDAwcHgiPjwvZGl2PgorPGEgbmFtZT0i YW5jaG9yIj5BbmNob3I8L2E+Cis8L2JvZHk+Cis8L2h0bWw+Cg==