96538 2012-09-12 11:58:52 -0700 IndexedDB: Result of IDBFactory.deleteDatabase() should be undefined, not null 2012-09-17 12:59:51 -0700 1 1 1 Unclassified WebKit WebCore Misc. 523.x (Safari 3) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jsbell jsbell alecflett dgrogan tony webkit.review.bot oldest_to_newest 718562 0 jsbell 2012-09-12 11:58:52 -0700 The spec http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html sayeth: deleteDatabase ... "If the steps above are successful, the implementation must set the result of the request to undefined..." Currently, in WebKit, we return null: void IDBDatabaseBackendImpl::deleteDatabase(PassRefPtr<IDBCallbacks> prpCallbacks) { ... callbacks->onSuccess(SerializedScriptValue::nullValue()); } 718564 1 jsbell 2012-09-12 11:59:16 -0700 Found c/o the W3C test submission: http://w3c-test.org/webapps/IndexedDB/tests/submissions/Microsoft/idbfactory_deleteDatabase2.htm 718633 2 163675 jsbell 2012-09-12 13:01:28 -0700 Created attachment 163675 Patch 718634 3 jsbell 2012-09-12 13:01:55 -0700 dgrogan@ - can you take a look? 718640 4 163675 dgrogan 2012-09-12 13:05:03 -0700 Comment on attachment 163675 Patch LGTM 718650 5 jsbell 2012-09-12 13:12:18 -0700 easy one - tony@ - r? cq? 721985 6 jsbell 2012-09-17 09:19:46 -0700 tony@ r? cq? 722196 7 163675 webkit.review.bot 2012-09-17 12:59:48 -0700 Comment on attachment 163675 Patch Clearing flags on attachment: 163675 Committed r128795: <http://trac.webkit.org/changeset/128795> 722197 8 webkit.review.bot 2012-09-17 12:59:51 -0700 All reviewed patches have been landed. Closing bug. 163675 2012-09-12 13:01:28 -0700 2012-09-17 12:59:48 -0700 Patch bug-96538-20120912130101.patch text/plain 5565 jsbell U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MjY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjU2YTA4Nzg4ZTc3ZWU5 M2Y3MTlhZmFhODI5NzdkN2ZhNDA4ZTVmMi4uNDYxNWZhOTlhOWFlNDg2OTMyYjQ2MTQ0MWNlYTBl MmJjZWJhZDgyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTEyICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBSZXN1 bHQgb2YgSURCRmFjdG9yeS5kZWxldGVEYXRhYmFzZSgpIHNob3VsZCBiZSB1bmRlZmluZWQsIG5v dCBudWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NjUzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRy aXZpYWwgaW1wbGVtZW50YXRpb24gY2hhbmdlIHRvIG1hdGNoIHRoZSBzcGVjLgorCisgICAgICAg IFRlc3RzOiBzdG9yYWdlL2luZGV4ZWRkYi9mYWN0b3J5LWRlbGV0ZWRhdGFiYXNlLWV4cGVjdGVk Lmh0bWwKKyAgICAgICAgICAgICAgIHN0b3JhZ2UvaW5kZXhlZGRiL2ludHZlcnNpb24tbG9uZy1x dWV1ZS1leHBlY3RlZC5odG1sCisKKyAgICAgICAgKiBNb2R1bGVzL2luZGV4ZWRkYi9JREJEYXRh YmFzZUJhY2tlbmRJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklEQkRhdGFiYXNlQmFja2Vu ZEltcGw6OmRlbGV0ZURhdGFiYXNlKToKKwogMjAxMi0wOS0xMiAgQWxleGFuZHJlIEVsaWFzICA8 YWVsaWFzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIEZsaXAgWSBhbmQgc3dp enpsZSBpbnNpZGUgY29tcG9zaXRlQW5kUmVhZGJhY2sgaW1wbGVtZW50YXRpb24KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvaW5kZXhlZGRiL0lEQkRhdGFiYXNlQmFja2VuZElt cGwuY3BwIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNr ZW5kSW1wbC5jcHAKaW5kZXggODExMGMyNGMxM2IzYzQ2M2VlMzdiMjBkNGNmZmE3MTI0MjQ0YjYz OS4uZGNkMjg2YmQ1ZDI0ZGRjMjM5NGE3YmYyY2FhN2FhMWYzMDc5NmNhZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNrZW5kSW1wbC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9pbmRleGVkZGIvSURCRGF0YWJhc2VCYWNr ZW5kSW1wbC5jcHAKQEAgLTU1Nyw3ICs1NTcsNyBAQCB2b2lkIElEQkRhdGFiYXNlQmFja2VuZElt cGw6OmRlbGV0ZURhdGFiYXNlKFBhc3NSZWZQdHI8SURCQ2FsbGJhY2tzPiBwcnBDYWxsYmFjawog ICAgIG1faWQgPSBJbnZhbGlkSWQ7CiAgICAgbV9pbnRWZXJzaW9uID0gSURCRGF0YWJhc2VNZXRh ZGF0YTo6Tm9JbnRWZXJzaW9uOwogICAgIG1fb2JqZWN0U3RvcmVzLmNsZWFyKCk7Ci0gICAgY2Fs bGJhY2tzLT5vblN1Y2Nlc3MoU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpudWxsVmFsdWUoKSk7Cisg ICAgY2FsbGJhY2tzLT5vblN1Y2Nlc3MoU2VyaWFsaXplZFNjcmlwdFZhbHVlOjp1bmRlZmluZWRW YWx1ZSgpKTsKIH0KIAogdm9pZCBJREJEYXRhYmFzZUJhY2tlbmRJbXBsOjpjbG9zZShQYXNzUmVm UHRyPElEQkRhdGFiYXNlQ2FsbGJhY2tzPiBwcnBDYWxsYmFja3MpCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYTIyZjcwODM5 NTA4NzBlOGY5ZjM1ODQzMDczNzdhYjE2MzE2M2QwZC4uYmQyMmRmN2Y1MGYwNzI4MTgyZmJjMTUw Y2VhZWQ0MThhOTIwMTZiMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTEyICBKb3No dWEgQmVsbCAgPGpzYmVsbEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgSW5kZXhlZERCOiBSZXN1 bHQgb2YgSURCRmFjdG9yeS5kZWxldGVEYXRhYmFzZSgpIHNob3VsZCBiZSB1bmRlZmluZWQsIG5v dCBudWxsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NjUzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENo ZWNrIHJlc3VsdCBvZiBJREJGYWN0b3J5LmRlbGV0ZURhdGFiYXNlKCkgLSBvbmUgdXBkYXRlZCBh c3NlcnRpb24sIG9uZSBhZGRlZCBhc3NlcnRpb24uCisKKyAgICAgICAgKiBzdG9yYWdlL2luZGV4 ZWRkYi9mYWN0b3J5LWRlbGV0ZWRhdGFiYXNlLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBzdG9y YWdlL2luZGV4ZWRkYi9pbnR2ZXJzaW9uLWxvbmctcXVldWUtZXhwZWN0ZWQudHh0OgorICAgICAg ICAqIHN0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9mYWN0b3J5LWRlbGV0ZWRhdGFiYXNlLmpz OiBBZGQgbmV3IGFzc2VydGlvbi4KKyAgICAgICAgKHJlb3BlbkRhdGFiYXNlKToKKyAgICAgICAg KiBzdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvaW50dmVyc2lvbi1sb25nLXF1ZXVlLmpzOiBV cGRhdGUgZXhpc3RpbmcgYXNzZXJ0aW9uLgorICAgICAgICAoZGVsZXRlRGF0YWJhc2VTdWNjZXNz Q2FsbGJhY2spOgorCiAyMDEyLTA5LTExICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9y Zz4KIAogICAgICAgICBbQ2hyb21pdW1dIFRlc3QgZXhwZWN0YXRpb24gdXBkYXRlCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9mYWN0b3J5LWRlbGV0ZWRhdGFiYXNl LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2ZhY3RvcnktZGVs ZXRlZGF0YWJhc2UtZXhwZWN0ZWQudHh0CmluZGV4IDI3ZTdjODRiZTQ1MzhmZTc0YjVkYzc4MjQz M2ZlZTBkODg3N2ViMmEuLmUzZTViMjA0ZWM4YmM5Y2ZmNDJkZWEzYTVjNzY1YWZmOWZkYjAwNTgg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2ZhY3RvcnktZGVsZXRl ZGF0YWJhc2UtZXhwZWN0ZWQudHh0CisrKyBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRi L2ZhY3RvcnktZGVsZXRlZGF0YWJhc2UtZXhwZWN0ZWQudHh0CkBAIC0yMCw2ICsyMCw3IEBAIHN0 b3JlLmdldCgna2V5JykKIFBBU1MgZXZlbnQudGFyZ2V0LnJlc3VsdCBpcyAidmFsdWUiCiBkYi5z ZXRWZXJzaW9uKCduZXcgdmVyc2lvbicpCiByZXF1ZXN0ID0gaW5kZXhlZERCLmRlbGV0ZURhdGFi YXNlKCdkYXRhYmFzZS10by1kZWxldGUnKQorUEFTUyByZXF1ZXN0LnJlc3VsdCBpcyB1bmRlZmlu ZWQuCiBpbmRleGVkREIub3BlbignZGF0YWJhc2UtdG8tZGVsZXRlJykKIGRiID0gZXZlbnQudGFy Z2V0LnJlc3VsdAogZGIuc2V0VmVyc2lvbignbmV3IHZlcnNpb24nKQpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvaW50dmVyc2lvbi1sb25nLXF1ZXVlLWV4cGVjdGVk LnR4dCBiL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL2ludHZlcnNpb24tbG9uZy1xdWV1 ZS1leHBlY3RlZC50eHQKaW5kZXggY2VmZjA5NWMzZjYzOTA3Njc5MzY5NGQxNTdlNmZhMTMyMDFi MzY3Yi4uZjViMmRlMTBkMTBkZDUzY2NiMGJiMmVlY2RiODUxNjQyMThhNmU3ZiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvaW50dmVyc2lvbi1sb25nLXF1ZXVlLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9pbnR2ZXJzaW9u LWxvbmctcXVldWUtZXhwZWN0ZWQudHh0CkBAIC02Myw3ICs2Myw3IEBAIEZBSUwgZXZlbnQudmVy c2lvbiBzaG91bGQgYmUgdW5kZWZpbmVkLiBXYXMKIGRlbGV0ZURhdGFiYXNlU3VjY2Vzc0NhbGxi YWNrKCk6CiBGQUlMIGV2ZW50Lm9sZFZlcnNpb24gc2hvdWxkIGJlIG5vbi1udWxsLiBXYXMgdW5k ZWZpbmVkCiBGQUlMIGV2ZW50Lm5ld1ZlcnNpb24gc2hvdWxkIGJlIG51bGwgKG9mIHR5cGUgb2Jq ZWN0KS4gV2FzIHVuZGVmaW5lZCAob2YgdHlwZSB1bmRlZmluZWQpLgotUEFTUyBldmVudC50YXJn ZXQucmVzdWx0IGlzIG51bGwKK1BBU1MgZXZlbnQudGFyZ2V0LnJlc3VsdCBpcyB1bmRlZmluZWQu CiAKIHVwZ3JhZGVOZWVkZWRDYWxsYmFjaygpOgogZ290VXBncmFkZU5lZWRlZEV2ZW50ID0gdHJ1 ZQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2VzL2Zh Y3RvcnktZGVsZXRlZGF0YWJhc2UuanMgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9y ZXNvdXJjZXMvZmFjdG9yeS1kZWxldGVkYXRhYmFzZS5qcwppbmRleCA2ODFkOGEwYTNlMjdjNDU0 YzY4MTQ1MjlkY2U4YjNhZjhlZWY2NTViLi5hMzNlMDcwNTEyOTkzMDdmNjJjOWFmYzZiOTdkMGJj MDJmYTVlZTkzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNv dXJjZXMvZmFjdG9yeS1kZWxldGVkYXRhYmFzZS5qcworKysgYi9MYXlvdXRUZXN0cy9zdG9yYWdl L2luZGV4ZWRkYi9yZXNvdXJjZXMvZmFjdG9yeS1kZWxldGVkYXRhYmFzZS5qcwpAQCAtNjcsNiAr NjcsNyBAQCBmdW5jdGlvbiBkZWxldGVEYXRhYmFzZSgpCiAKIGZ1bmN0aW9uIHJlb3BlbkRhdGFi YXNlKCkKIHsKKyAgICBzaG91bGRCZVVuZGVmaW5lZCgicmVxdWVzdC5yZXN1bHQiKTsKICAgICBy ZXF1ZXN0ID0gZXZhbEFuZExvZygiaW5kZXhlZERCLm9wZW4oJ2RhdGFiYXNlLXRvLWRlbGV0ZScp Iik7CiAgICAgcmVxdWVzdC5vbnN1Y2Nlc3MgPSBzdGFydFNldFZlcnNpb25BZ2FpbjsKICAgICBy ZXF1ZXN0Lm9uZXJyb3IgPSB1bmV4cGVjdGVkRXJyb3JDYWxsYmFjazsKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9pbnR2ZXJzaW9uLWxvbmctcXVl dWUuanMgYi9MYXlvdXRUZXN0cy9zdG9yYWdlL2luZGV4ZWRkYi9yZXNvdXJjZXMvaW50dmVyc2lv bi1sb25nLXF1ZXVlLmpzCmluZGV4IDZmMTNhZDk5MjEwNDljYzg5ZDhmOTRjOGVjMWYyNWE3Y2Y5 MzJkMDUuLjQ2YmYwYzhiNjdjYTQ5NzcwMzZhY2VkZjRkYjc5NzRkNmFkMDY0NDkgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL3N0b3JhZ2UvaW5kZXhlZGRiL3Jlc291cmNlcy9pbnR2ZXJzaW9uLWxv bmctcXVldWUuanMKKysrIGIvTGF5b3V0VGVzdHMvc3RvcmFnZS9pbmRleGVkZGIvcmVzb3VyY2Vz L2ludHZlcnNpb24tbG9uZy1xdWV1ZS5qcwpAQCAtMTA5LDcgKzEwOSw3IEBAIGZ1bmN0aW9uIGRl bGV0ZURhdGFiYXNlU3VjY2Vzc0NhbGxiYWNrKGV2dCkKICAgICBwcmVhbWJsZShldnQpOwogICAg IHNob3VsZEJlTm9uTnVsbCgiZXZlbnQub2xkVmVyc2lvbiIpOwogICAgIHNob3VsZEJlTnVsbCgi ZXZlbnQubmV3VmVyc2lvbiIpOwotICAgIHNob3VsZEJlTnVsbCgiZXZlbnQudGFyZ2V0LnJlc3Vs dCIpOworICAgIHNob3VsZEJlVW5kZWZpbmVkKCJldmVudC50YXJnZXQucmVzdWx0Iik7CiB9CiAK IHZhciBnb3RVcGdyYWRlTmVlZGVkRXZlbnQgPSBmYWxzZTsK