96537 2012-09-12 11:40:26 -0700 Regression(r128338): Broke Windows build 2012-09-12 12:25:34 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96496 1 cdumez cdumez kenneth rakuco webkit.review.bot oldest_to_newest 718545 0 cdumez 2012-09-12 11:40:26 -0700 r128338 broke Apple-Win build: 9>..\InjectedBundle\TestRunner.cpp(337) : error C2057: expected constant expression 9>..\InjectedBundle\TestRunner.cpp(337) : error C2466: cannot allocate an array of constant size 0 9>..\InjectedBundle\TestRunner.cpp(337) : error C2133: 'jsStringsArray' : unknown size 718547 1 163663 cdumez 2012-09-12 11:43:22 -0700 Created attachment 163663 Patch 718559 2 163665 cdumez 2012-09-12 11:52:43 -0700 Created attachment 163665 Patch Use OwnArrayPtr. 718601 3 163665 webkit.review.bot 2012-09-12 12:25:30 -0700 Comment on attachment 163665 Patch Clearing flags on attachment: 163665 Committed r128349: <http://trac.webkit.org/changeset/128349> 718602 4 webkit.review.bot 2012-09-12 12:25:34 -0700 All reviewed patches have been landed. Closing bug. 163663 2012-09-12 11:43:22 -0700 2012-09-12 11:52:43 -0700 Patch 96537_buildfix.patch text/plain 1720 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNDhi MWFkLi4wYWZiZjA2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDktMTIgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMjgzMzgp OiBCcm9rZSBXaW5kb3dzIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05NjUzNworCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisg ICAgICAgIEZpeCBBcHBsZS1XaW4gYnVpbGQgYnkgYWxsb2NhdGluZyBhcnJheSBkeW5hbWljYWxs eQorICAgICAgICBzaW5jZSBpdHMgc2l6ZSBpcyBub3QgY29uc3RhbnQuCisKKyAgICAgICAgKiBX ZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwOgorICAgICAgICAo V1RSOjpzdHJpbmdBcnJheVRvSlMpOgorCiAyMDEyLTA5LTEyICBBZGFtIEtsZWluICA8YWRhbWtA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIGNvbnRlbnRfYnJvd3NlcnRl c3RzIHRvIHRoZSBmbGFraW5lc3MgZGFzaGJvYXJkCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNwcAppbmRleCBjODIyMzRiLi42Yjdm NWMwIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rl c3RSdW5uZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUv VGVzdFJ1bm5lci5jcHAKQEAgLTMzNCwxNCArMzM0LDE3IEBAIHN0YXRpYyBpbmxpbmUgSlNWYWx1 ZVJlZiBzdHJpbmdBcnJheVRvSlMoSlNDb250ZXh0UmVmIGNvbnRleHQsIFdLQXJyYXlSZWYgc3Ry aW5nCiB7CiAgICAgY29uc3Qgc2l6ZV90IGNvdW50ID0gV0tBcnJheUdldFNpemUoc3RyaW5ncyk7 CiAKLSAgICBKU1ZhbHVlUmVmIGpzU3RyaW5nc0FycmF5W2NvdW50XTsKKyAgICBKU1ZhbHVlUmVm KiBqc1N0cmluZ3NBcnJheSA9IG5ldyBKU1ZhbHVlUmVmW2NvdW50XTsKICAgICBmb3IgKHNpemVf dCBpID0gMDsgaSA8IGNvdW50OyArK2kpIHsKICAgICAgICAgV0tTdHJpbmdSZWYgc3RyaW5nUmVm ID0gc3RhdGljX2Nhc3Q8V0tTdHJpbmdSZWY+KFdLQXJyYXlHZXRJdGVtQXRJbmRleChzdHJpbmdz LCBpKSk7CiAgICAgICAgIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBzdHJpbmdKUyA9IHRvSlMo c3RyaW5nUmVmKTsKICAgICAgICAganNTdHJpbmdzQXJyYXlbaV0gPSBKU1ZhbHVlTWFrZVN0cmlu Zyhjb250ZXh0LCBzdHJpbmdKUy5nZXQoKSk7CiAgICAgfQogCi0gICAgcmV0dXJuIEpTT2JqZWN0 TWFrZUFycmF5KGNvbnRleHQsIGNvdW50LCBqc1N0cmluZ3NBcnJheSwgMCk7CisgICAgSlNWYWx1 ZVJlZiBqc1ZhbHVlID0gSlNPYmplY3RNYWtlQXJyYXkoY29udGV4dCwgY291bnQsIGpzU3RyaW5n c0FycmF5LCAwKTsKKyAgICBkZWxldGVbXSBqc1N0cmluZ3NBcnJheTsKKworICAgIHJldHVybiBq c1ZhbHVlOwogfQogCiBKU1ZhbHVlUmVmIFRlc3RSdW5uZXI6Om9yaWdpbnNXaXRoQXBwbGljYXRp b25DYWNoZSgpCg== 163665 2012-09-12 11:52:43 -0700 2012-09-12 12:25:30 -0700 Patch 96537_buildfix.patch text/plain 1920 cdumez ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNDhi MWFkLi4wYWZiZjA2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDktMTIgIENocmlzdG9waGUgRHVtZXogIDxj aHJpc3RvcGhlLmR1bWV6QGludGVsLmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMjgzMzgp OiBCcm9rZSBXaW5kb3dzIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD05NjUzNworCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisg ICAgICAgIEZpeCBBcHBsZS1XaW4gYnVpbGQgYnkgYWxsb2NhdGluZyBhcnJheSBkeW5hbWljYWxs eQorICAgICAgICBzaW5jZSBpdHMgc2l6ZSBpcyBub3QgY29uc3RhbnQuCisKKyAgICAgICAgKiBX ZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwOgorICAgICAgICAo V1RSOjpzdHJpbmdBcnJheVRvSlMpOgorCiAyMDEyLTA5LTEyICBBZGFtIEtsZWluICA8YWRhbWtA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gQWRkIGNvbnRlbnRfYnJvd3NlcnRl c3RzIHRvIHRoZSBmbGFraW5lc3MgZGFzaGJvYXJkCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRU ZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwIGIvVG9vbHMvV2ViS2l0VGVz dFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNwcAppbmRleCBjODIyMzRiLi41M2Zi OGYxIDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rl c3RSdW5uZXIuY3BwCisrKyBiL1Rvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUv VGVzdFJ1bm5lci5jcHAKQEAgLTQ2LDYgKzQ2LDggQEAKICNpbmNsdWRlIDxXZWJLaXQyL1dlYktp dDJfQy5oPgogI2luY2x1ZGUgPHd0Zi9DdXJyZW50VGltZS5oPgogI2luY2x1ZGUgPHd0Zi9IYXNo TWFwLmg+CisjaW5jbHVkZSA8d3RmL093bkFycmF5UHRyLmg+CisjaW5jbHVkZSA8d3RmL1Bhc3NP d25BcnJheVB0ci5oPgogI2luY2x1ZGUgPHd0Zi90ZXh0L1N0cmluZ0J1aWxkZXIuaD4KIAogI2lm IEVOQUJMRShXRUJfSU5URU5UUykKQEAgLTMzNCwxNCArMzM2LDE0IEBAIHN0YXRpYyBpbmxpbmUg SlNWYWx1ZVJlZiBzdHJpbmdBcnJheVRvSlMoSlNDb250ZXh0UmVmIGNvbnRleHQsIFdLQXJyYXlS ZWYgc3RyaW5nCiB7CiAgICAgY29uc3Qgc2l6ZV90IGNvdW50ID0gV0tBcnJheUdldFNpemUoc3Ry aW5ncyk7CiAKLSAgICBKU1ZhbHVlUmVmIGpzU3RyaW5nc0FycmF5W2NvdW50XTsKKyAgICBPd25B cnJheVB0cjxKU1ZhbHVlUmVmPiBqc1N0cmluZ3NBcnJheSA9IGFkb3B0QXJyYXlQdHIobmV3IEpT VmFsdWVSZWZbY291bnRdKTsKICAgICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IGNvdW50OyArK2kp IHsKICAgICAgICAgV0tTdHJpbmdSZWYgc3RyaW5nUmVmID0gc3RhdGljX2Nhc3Q8V0tTdHJpbmdS ZWY+KFdLQXJyYXlHZXRJdGVtQXRJbmRleChzdHJpbmdzLCBpKSk7CiAgICAgICAgIEpTUmV0YWlu UHRyPEpTU3RyaW5nUmVmPiBzdHJpbmdKUyA9IHRvSlMoc3RyaW5nUmVmKTsKICAgICAgICAganNT dHJpbmdzQXJyYXlbaV0gPSBKU1ZhbHVlTWFrZVN0cmluZyhjb250ZXh0LCBzdHJpbmdKUy5nZXQo KSk7CiAgICAgfQogCi0gICAgcmV0dXJuIEpTT2JqZWN0TWFrZUFycmF5KGNvbnRleHQsIGNvdW50 LCBqc1N0cmluZ3NBcnJheSwgMCk7CisgICAgcmV0dXJuIEpTT2JqZWN0TWFrZUFycmF5KGNvbnRl eHQsIGNvdW50LCBqc1N0cmluZ3NBcnJheS5nZXQoKSwgMCk7CiB9CiAKIEpTVmFsdWVSZWYgVGVz dFJ1bm5lcjo6b3JpZ2luc1dpdGhBcHBsaWNhdGlvbkNhY2hlKCkK