96536 2012-09-12 11:37:56 -0700 [chromium] Fix search tickmarks not disappearing when compositing is enabled 2012-09-12 14:03:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 enne enne enne eric jamesr webkit.review.bot oldest_to_newest 718542 0 enne 2012-09-12 11:37:56 -0700 [chromium] Fix search tickmarks not disappearing when compositing is enabled 718549 1 enne 2012-09-12 11:44:49 -0700 See: http://code.google.com/p/chromium/issues/detail?id=140927 The approach in this patch works, but I'm not convinced it's the best way to do it. Another approach might be to have WebViewImpl::invalidateRootLayerRect implicitly invalidate scrollbars, but then we'd have to figure out which layers were the scrollbar layers (or expose that on FrameView). Thoughts? 718550 2 163664 enne 2012-09-12 11:44:59 -0700 Created attachment 163664 Patch 718695 3 163664 webkit.review.bot 2012-09-12 14:03:50 -0700 Comment on attachment 163664 Patch Clearing flags on attachment: 163664 Committed r128358: <http://trac.webkit.org/changeset/128358> 718697 4 webkit.review.bot 2012-09-12 14:03:53 -0700 All reviewed patches have been landed. Closing bug. 163664 2012-09-12 11:44:59 -0700 2012-09-12 14:03:50 -0700 Patch bug-96536-20120912114433.patch text/plain 2152 enne U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4Mjc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY4MDFkM2VhY2I2ZTI1OGRlYjZjZTMyNmQ2NjBmYzYwZmFmODc3YmYuLmEyODZiNzA3MjJiZGJi MDM0YjY3MDMxMmVjNjY2Mzc5NzZjMGMwMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMDktMTIgIEFkcmllbm5lIFdhbGtlciAgPGVubmVAZ29vZ2xl LmNvbT4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCBzZWFyY2ggdGlja21hcmtzIG5vdCBkaXNh cHBlYXJpbmcgd2hlbiBjb21wb3NpdGluZyBpcyBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjUzNgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHZpZXctPmludmFsaWRhdGVSZWN0KCkgb24gdGhl IHJvb3QgZnJhbWUganVzdCBpbnZhbGlkYXRlcyB0aGUKKyAgICAgICAgY29udGVudHMsIHNpbmNl IFdlYlZpZXdJbXBsIGRvZXNuJ3Qga25vdyBhbnl0aGluZyBhYm91dCBzY3JvbGxiYXIKKyAgICAg ICAgbGF5ZXJzLiBUaGlzIGNhdXNlcyBhbiAiSW52YWxpZGF0ZUFsbCIgdG8gbm90IGFjdHVhbGx5 IGludmFsaWRhdGUgdGhlCisgICAgICAgIHNjcm9sbGJhcnMuCisKKyAgICAgICAgVG8gZml4IHRo aXMsIG1ha2UgV2ViRnJhbWVJbXBsIGV4cGxpY2l0bHkgaW52YWxpZGF0ZSB0aGUKKyAgICAgICAg c2Nyb2xsYmFycyB3aGVuIHJlcXVpcmVkLgorCisgICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5j cHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lSW1wbDo6aW52YWxpZGF0ZUFyZWEpOgorCiAy MDEyLTA5LTEyICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFtjaHJvbWl1bV0gY29uc3VtYWJsZSB1c2VyIGdlc3R1cmUgY291bnQgb2ZmIGZvciBpbnB1 dCBldmVudHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1l SW1wbC5jcHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCmlu ZGV4IDFkMTg3ZjA5ZTAwMGY1OTMzZjMwNDkxMDBlYjA4MzIzMmJjMjBiNDcuLmZiYWZjNTcyOTQ5 ZmJkMjNiNjY4NjlhZDZkY2Y3NDhjOGVkN2MyMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1 bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApAQCAtMjU3MSwxMyArMjU3MSwxMyBAQCB2b2lkIFdlYkZy YW1lSW1wbDo6aW52YWxpZGF0ZUFyZWEoQXJlYVRvSW52YWxpZGF0ZSBhcmVhKQogICAgICAgICAg ICAgY29udGVudEFyZWEubW92ZSgtZnJhbWVSZWN0LngoKSwgLWZyYW1lUmVjdC55KCkpOwogICAg ICAgICAgICAgdmlldy0+aW52YWxpZGF0ZVJlY3QoY29udGVudEFyZWEpOwogICAgICAgICB9Cisg ICAgfQogCi0gICAgICAgIGlmICgoYXJlYSAmIEludmFsaWRhdGVTY3JvbGxiYXIpID09IEludmFs aWRhdGVTY3JvbGxiYXIpIHsKLSAgICAgICAgICAgIC8vIEludmFsaWRhdGUgdGhlIHZlcnRpY2Fs IHNjcm9sbCBiYXIgcmVnaW9uIGZvciB0aGUgdmlldy4KLSAgICAgICAgICAgIFNjcm9sbGJhciog c2Nyb2xsYmFyID0gdmlldy0+dmVydGljYWxTY3JvbGxiYXIoKTsKLSAgICAgICAgICAgIGlmIChz Y3JvbGxiYXIpCi0gICAgICAgICAgICAgICAgc2Nyb2xsYmFyLT5pbnZhbGlkYXRlKCk7Ci0gICAg ICAgIH0KKyAgICBpZiAoKGFyZWEgJiBJbnZhbGlkYXRlU2Nyb2xsYmFyKSA9PSBJbnZhbGlkYXRl U2Nyb2xsYmFyKSB7CisgICAgICAgIC8vIEludmFsaWRhdGUgdGhlIHZlcnRpY2FsIHNjcm9sbCBi YXIgcmVnaW9uIGZvciB0aGUgdmlldy4KKyAgICAgICAgU2Nyb2xsYmFyKiBzY3JvbGxiYXIgPSB2 aWV3LT52ZXJ0aWNhbFNjcm9sbGJhcigpOworICAgICAgICBpZiAoc2Nyb2xsYmFyKQorICAgICAg ICAgICAgc2Nyb2xsYmFyLT5pbnZhbGlkYXRlKCk7CiAgICAgfQogfQogCg==