96528 2012-09-12 08:39:56 -0700 Respect WEBKITOUTPUTDIR when running EFL tests 2012-09-12 14:48:50 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kenneth kenneth abarth dpranke eric gyuyoung.kim hausmann ojan rakuco tmpsantos webkit.review.bot oldest_to_newest 718405 0 kenneth 2012-09-12 08:39:56 -0700 SSIA 718409 1 163641 kenneth 2012-09-12 08:41:21 -0700 Created attachment 163641 Patch 718448 2 163641 dpranke 2012-09-12 09:24:57 -0700 Comment on attachment 163641 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163641&action=review > Tools/Scripts/webkitpy/layout_tests/port/driver.py:280 > + environment['WEBKITOUTPUTDIR'] = os.environ['WEBKITOUTPUTDIR'] I think this probably needs to be guarded by if 'WEBKITOUTPUTDIR' in os.environ since this may not always be set ... 718686 3 kenneth 2012-09-12 13:55:26 -0700 (In reply to comment #2) > I think this probably needs to be guarded by if 'WEBKITOUTPUTDIR' in os.environ since this may not always be set ... You are right, python loves throwing exceptions instead of returning None :-) 718687 4 163686 kenneth 2012-09-12 13:56:05 -0700 Created attachment 163686 Patch 718753 5 163686 webkit.review.bot 2012-09-12 14:48:46 -0700 Comment on attachment 163686 Patch Clearing flags on attachment: 163686 Committed r128364: <http://trac.webkit.org/changeset/128364> 718754 6 webkit.review.bot 2012-09-12 14:48:50 -0700 All reviewed patches have been landed. Closing bug. 163641 2012-09-12 08:41:21 -0700 2012-09-12 13:55:59 -0700 Patch bug-96528-20120912174052.patch text/plain 1877 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4Mjg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWU4ZGNlNDkxYTA0ZTc1NzEyNmVhMzMwYThkMTc4ZTI3 MjQ0YWU4NS4uYjcwM2U3MzAzZGM4ZTk4YTgwM2Q5MTJiY2I5NDBiYzAyNDgyZTM4OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA5LTEyICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXNwZWN0IFdFQktJVE9VVFBVVERJUiB3aGVuIHJ1bm5pbmcg RUZMIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NjUyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEV4cG9zZSB1c2VyIHNldCBXRUJLSVRPVVRQVVRESVIgdG8gdGhlIHdlYiBwcm9jZXNzLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9kcml2ZXIucHk6Cisg ICAgICAgIChEcml2ZXIuX3N0YXJ0KTogQWRkIFdFQktJVE9VVFBVVERJUiB0byB0aGUgZW52aXJv bm1lbnQKKyAgICAgICAgb2YgdGhlIHdlYiBwcm9jZXNzIGFuZCBpdHMgcG90ZW50aWFsIGpoYnVp bGQgd3JhcHBlci4KKwogMjAxMi0wOS0xMCAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxr ZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gTWFrZSBEdW1wUmVuZGVyVHJlZSBz bWFydGVyIGF0IGZpbmRpbmcgdGhlIGZvbnRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2RyaXZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZHJpdmVyLnB5CmluZGV4IDcxNWZlN2MxYTZjNzkxMzhjYmEz ZTE1ODZhZDZhM2Y2YzY4MmE0YjQuLjJiYzYxMDYwYWE1NTE2N2UzOTAzMTliOTUyMzJlNmZlOTAz ODVjYjAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvZHJpdmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvZHJpdmVyLnB5CkBAIC0zMyw2ICszMyw3IEBAIGltcG9ydCByZQogaW1wb3J0IHNobGV4CiBp bXBvcnQgc3lzCiBpbXBvcnQgdGltZQoraW1wb3J0IG9zCiAKIGZyb20gd2Via2l0cHkuY29tbW9u LnN5c3RlbSBpbXBvcnQgcGF0aAogCkBAIC0yNzYsNiArMjc3LDcgQEAgY2xhc3MgRHJpdmVyKG9i amVjdCk6CiAgICAgICAgICMgRklYTUU6IFdlJ3JlIGFzc3VtaW5nIHRoYXQgV2ViS2l0VGVzdFJ1 bm5lciBjaGVja3MgdGhpcyBEdW1wUmVuZGVyVHJlZS1uYW1lZCBlbnZpcm9ubWVudCB2YXJpYWJs ZS4KICAgICAgICAgZW52aXJvbm1lbnRbJ0RVTVBSRU5ERVJUUkVFX1RFTVAnXSA9IHN0cihzZWxm Ll9kcml2ZXJfdGVtcGRpcikKICAgICAgICAgZW52aXJvbm1lbnRbJ0xPQ0FMX1JFU09VUkNFX1JP T1QnXSA9IHNlbGYuX3BvcnQubGF5b3V0X3Rlc3RzX2RpcigpCisgICAgICAgIGVudmlyb25tZW50 WydXRUJLSVRPVVRQVVRESVInXSA9IG9zLmVudmlyb25bJ1dFQktJVE9VVFBVVERJUiddCiAgICAg ICAgIHNlbGYuX2NyYXNoZWRfcHJvY2Vzc19uYW1lID0gTm9uZQogICAgICAgICBzZWxmLl9jcmFz aGVkX3BpZCA9IE5vbmUKICAgICAgICAgc2VsZi5fc2VydmVyX3Byb2Nlc3MgPSBzZWxmLl9wb3J0 Ll9zZXJ2ZXJfcHJvY2Vzc19jb25zdHJ1Y3RvcihzZWxmLl9wb3J0LCBzZXJ2ZXJfbmFtZSwgc2Vs Zi5jbWRfbGluZShwaXhlbF90ZXN0cywgcGVyX3Rlc3RfYXJncyksIGVudmlyb25tZW50KQo= 163686 2012-09-12 13:56:05 -0700 2012-09-12 14:48:46 -0700 Patch bug-96528-20120912225537.patch text/plain 1926 kenneth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4Mjg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWU4ZGNlNDkxYTA0ZTc1NzEyNmVhMzMwYThkMTc4ZTI3 MjQ0YWU4NS4uYjcwM2U3MzAzZGM4ZTk4YTgwM2Q5MTJiY2I5NDBiYzAyNDgyZTM4OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDEyLTA5LTEyICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXNwZWN0IFdFQktJVE9VVFBVVERJUiB3aGVuIHJ1bm5pbmcg RUZMIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NjUyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEV4cG9zZSB1c2VyIHNldCBXRUJLSVRPVVRQVVRESVIgdG8gdGhlIHdlYiBwcm9jZXNzLgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9kcml2ZXIucHk6Cisg ICAgICAgIChEcml2ZXIuX3N0YXJ0KTogQWRkIFdFQktJVE9VVFBVVERJUiB0byB0aGUgZW52aXJv bm1lbnQKKyAgICAgICAgb2YgdGhlIHdlYiBwcm9jZXNzIGFuZCBpdHMgcG90ZW50aWFsIGpoYnVp bGQgd3JhcHBlci4KKwogMjAxMi0wOS0xMCAgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4gIDxr ZW5uZXRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW0VGTF0gTWFrZSBEdW1wUmVuZGVyVHJlZSBz bWFydGVyIGF0IGZpbmRpbmcgdGhlIGZvbnRzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2RyaXZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZHJpdmVyLnB5CmluZGV4IDcxNWZlN2MxYTZjNzkxMzhjYmEz ZTE1ODZhZDZhM2Y2YzY4MmE0YjQuLjRiZjUzZDQ2YTc1NWY4Yjg4Y2Y2ZTQ1NjAzODIxZjQyNWZh M2NhNGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvZHJpdmVyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Bv cnQvZHJpdmVyLnB5CkBAIC0zMyw2ICszMyw3IEBAIGltcG9ydCByZQogaW1wb3J0IHNobGV4CiBp bXBvcnQgc3lzCiBpbXBvcnQgdGltZQoraW1wb3J0IG9zCiAKIGZyb20gd2Via2l0cHkuY29tbW9u LnN5c3RlbSBpbXBvcnQgcGF0aAogCkBAIC0yNzYsNiArMjc3LDggQEAgY2xhc3MgRHJpdmVyKG9i amVjdCk6CiAgICAgICAgICMgRklYTUU6IFdlJ3JlIGFzc3VtaW5nIHRoYXQgV2ViS2l0VGVzdFJ1 bm5lciBjaGVja3MgdGhpcyBEdW1wUmVuZGVyVHJlZS1uYW1lZCBlbnZpcm9ubWVudCB2YXJpYWJs ZS4KICAgICAgICAgZW52aXJvbm1lbnRbJ0RVTVBSRU5ERVJUUkVFX1RFTVAnXSA9IHN0cihzZWxm Ll9kcml2ZXJfdGVtcGRpcikKICAgICAgICAgZW52aXJvbm1lbnRbJ0xPQ0FMX1JFU09VUkNFX1JP T1QnXSA9IHNlbGYuX3BvcnQubGF5b3V0X3Rlc3RzX2RpcigpCisgICAgICAgIGlmICdXRUJLSVRP VVRQVVRESVInIGluIG9zLmVudmlyb246CisgICAgICAgICAgICBlbnZpcm9ubWVudFsnV0VCS0lU T1VUUFVURElSJ10gPSBvcy5lbnZpcm9uWydXRUJLSVRPVVRQVVRESVInXQogICAgICAgICBzZWxm Ll9jcmFzaGVkX3Byb2Nlc3NfbmFtZSA9IE5vbmUKICAgICAgICAgc2VsZi5fY3Jhc2hlZF9waWQg PSBOb25lCiAgICAgICAgIHNlbGYuX3NlcnZlcl9wcm9jZXNzID0gc2VsZi5fcG9ydC5fc2VydmVy X3Byb2Nlc3NfY29uc3RydWN0b3Ioc2VsZi5fcG9ydCwgc2VydmVyX25hbWUsIHNlbGYuY21kX2xp bmUocGl4ZWxfdGVzdHMsIHBlcl90ZXN0X2FyZ3MpLCBlbnZpcm9ubWVudCkK