96525 2012-09-12 08:34:23 -0700 [EFL] [WK2] Memory leaks in TestControllerEfl 2012-09-12 09:41:39 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis kenneth lucas.de.marchi webkit.review.bot oldest_to_newest 718391 0 naginenis 2012-09-12 08:34:23 -0700 Valgrind reports the following memory leaks in WTR when I run the tests. ==21236== 24 bytes in 1 blocks are definitely lost in loss record 296 of 1,028 ==21236== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==21236== by 0x5620AF2: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==21236== by 0x52CD2F8: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==21236== by 0xB46976D: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==21236== by 0xB46936D: WKStringCreateWithUTF8CString (WKString.cpp:41) ==21236== by 0x4243FF: WTR::TestController::initializeInjectedBundlePath() (TestControllerEfl.cpp:88) ==21236== by 0x414A5C: WTR::TestController::initialize(int, char const**) (TestController.cpp:312) ==21236== by 0x414010: WTR::TestController::TestController(int, char const**) (TestController.cpp:98) ==21236== by 0x42454F: main (main.cpp:51) ==21236== ==21236== 24 bytes in 1 blocks are definitely lost in loss record 297 of 1,028 ==21236== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==21236== by 0x5620AF2: WTF::fastMalloc(unsigned long) (FastMalloc.cpp:268) ==21236== by 0x52CD2F8: WTF::ThreadSafeRefCountedBase::operator new(unsigned long) (ThreadSafeRefCounted.h:72) ==21236== by 0xB46976D: WebKit::WebString::createFromUTF8String(char const*) (WebString.h:60) ==21236== by 0xB46936D: WKStringCreateWithUTF8CString (WKString.cpp:41) ==21236== by 0x42443B: WTR::TestController::initializeTestPluginDirectory() (TestControllerEfl.cpp:94) ==21236== by 0x414A6B: WTR::TestController::initialize(int, char const**) (TestController.cpp:313) ==21236== by 0x414010: WTR::TestController::TestController(int, char const**) (TestController.cpp:98) ==21236== by 0x42454F: main (main.cpp:51) 718417 1 163642 naginenis 2012-09-12 08:53:33 -0700 Created attachment 163642 Patch 718466 2 163642 webkit.review.bot 2012-09-12 09:41:36 -0700 Comment on attachment 163642 Patch Clearing flags on attachment: 163642 Committed r128327: <http://trac.webkit.org/changeset/128327> 718467 3 webkit.review.bot 2012-09-12 09:41:39 -0700 All reviewed patches have been landed. Closing bug. 163642 2012-09-12 08:53:33 -0700 2012-09-12 09:41:36 -0700 Patch 96525.patch text/plain 1815 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxNzk2 MmE3Li41ZDFmMTIwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTItMDktMTIgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW1dL Ml0gTWVtb3J5IGxlYWtzIGluIFRlc3RDb250cm9sbGVyRWZsCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjUyNQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBtZW1vcnkgbGVha3MgaW4gRUZMJ3MgVGVz dFJ1bm5lciBjb2RlIGJ5IGFkb3B0aW5nIGFuIGFsbG9jYXRpb24KKyAgICAgICAgb2YgV0tTdHJp bmcgY3JlYXRlZCB3aXRoIFdLU3RyaW5nQ3JlYXRlV2l0aFVURjhDU3RyaW5nKCkuCisKKyAgICAg ICAgKiBXZWJLaXRUZXN0UnVubmVyL2VmbC9UZXN0Q29udHJvbGxlckVmbC5jcHA6CisgICAgICAg IChXVFI6OlRlc3RDb250cm9sbGVyOjppbml0aWFsaXplSW5qZWN0ZWRCdW5kbGVQYXRoKToKKyAg ICAgICAgKFdUUjo6VGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemVUZXN0UGx1Z2luRGlyZWN0b3J5 KToKKwogMjAxMi0wOS0xMiAgSm9jaGVuIEVpc2luZ2VyICA8am9jaGVuQGNocm9taXVtLm9yZz4K IAogICAgICAgICBbY2hyb21pdW1dIENvbnN1bWUgYSB1c2VyIGdlc3R1cmUgd2hlbiBjcmVhdGlu ZyBhIG5ldyB2aWV3LgpkaWZmIC0tZ2l0IGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvVGVz dENvbnRyb2xsZXJFZmwuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9lZmwvVGVzdENvbnRy b2xsZXJFZmwuY3BwCmluZGV4IGExODRmNmQuLmY2ODM1MWQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1dl YktpdFRlc3RSdW5uZXIvZWZsL1Rlc3RDb250cm9sbGVyRWZsLmNwcAorKysgYi9Ub29scy9XZWJL aXRUZXN0UnVubmVyL2VmbC9UZXN0Q29udHJvbGxlckVmbC5jcHAKQEAgLTg1LDEzICs4NSwxMyBA QCBzdGF0aWMgY29uc3QgY2hhciogZ2V0RW52aXJvbm1lbnRWYXJpYWJsZU9yRXhpdChjb25zdCBj aGFyKiB2YXJpYWJsZU5hbWUpCiB2b2lkIFRlc3RDb250cm9sbGVyOjppbml0aWFsaXplSW5qZWN0 ZWRCdW5kbGVQYXRoKCkKIHsKICAgICBjb25zdCBjaGFyKiBidW5kbGVQYXRoID0gZ2V0RW52aXJv bm1lbnRWYXJpYWJsZU9yRXhpdCgiVEVTVF9SVU5ORVJfSU5KRUNURURfQlVORExFX0ZJTEVOQU1F Iik7Ci0gICAgbV9pbmplY3RlZEJ1bmRsZVBhdGggPSBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0 cmluZyhidW5kbGVQYXRoKTsKKyAgICBtX2luamVjdGVkQnVuZGxlUGF0aC5hZG9wdChXS1N0cmlu Z0NyZWF0ZVdpdGhVVEY4Q1N0cmluZyhidW5kbGVQYXRoKSk7CiB9CiAKIHZvaWQgVGVzdENvbnRy b2xsZXI6OmluaXRpYWxpemVUZXN0UGx1Z2luRGlyZWN0b3J5KCkKIHsKICAgICBjb25zdCBjaGFy KiBwbHVnaW5QYXRoID0gZ2V0RW52aXJvbm1lbnRWYXJpYWJsZU9yRXhpdCgiVEVTVF9SVU5ORVJf UExVR0lOX1BBVEgiKTsKLSAgICBtX3Rlc3RQbHVnaW5EaXJlY3RvcnkgPSBXS1N0cmluZ0NyZWF0 ZVdpdGhVVEY4Q1N0cmluZyhwbHVnaW5QYXRoKTsKKyAgICBtX3Rlc3RQbHVnaW5EaXJlY3Rvcnku YWRvcHQoV0tTdHJpbmdDcmVhdGVXaXRoVVRGOENTdHJpbmcocGx1Z2luUGF0aCkpOwogfQogCiB2 b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUluaXRpYWxpemVDb250ZXh0KCkK