96514 2012-09-12 07:51:05 -0700 [Gtk EWS] EWS for Gtk+ should generate the mangled symbols for unresolved symbols 2013-08-15 14:35:31 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 115323 115732 1 vivekgalatage gustavo commit-queue dpranke goatman.py gtk-ews gustavo mrobinson pnormand vivekg xan.lopez zan oldest_to_newest 718352 0 vivekgalatage 2012-09-12 07:51:05 -0700 It would be great if EWS for Gtk+ generate the mangled version of the unresolved symbols. Currently the non-mangled symbols are generated thereby the developer must have gtk+ environment to generate these symbols. But considering cross-platform nature of Webkit, it would be really nice if this information can be generated by the EWS so then the developers can directly use these symbols while exporting it. 719481 1 pnormand 2012-09-13 07:54:30 -0700 +Gustavo,Martin Any idea how we can accomplish this? :) 719582 2 mrobinson 2012-09-13 09:28:02 -0700 If we actually know the missing symbols we could run c++filt on the symbol table of the library and then create a map to map backward to the mangled symbol. 882366 3 zan 2013-04-27 23:25:47 -0700 There's the --no-demangle option that can be passed to the linker to stop the missing symbol being written out in the demangled form. There's also the COLLECT_NO_DEMANGLE env which has the same effect when set. http://linux.die.net/man/1/ld I'll see what the ld and gold linkers support. 882375 4 zan 2013-04-28 03:19:27 -0700 Setting the COLLECT_NO_DEMANGLE in the environment works with both linkers, so that's what I'd propose doing on the EWS systems. I also think this would make sense on the buildbots, just so someone can see what symbols need exporting when trying to fix the build. EWS adjustments should be done by their owners while for the buildbots the variable can be listed somewhere in the buildbot configuration files. 882491 5 pnormand 2013-04-29 00:37:38 -0700 (In reply to comment #4) > Setting the COLLECT_NO_DEMANGLE in the environment works with both linkers, so that's what I'd propose doing on the EWS systems. > > I also think this would make sense on the buildbots, just so someone can see what symbols need exporting when trying to fix the build. > > EWS adjustments should be done by their owners while for the buildbots the variable can be listed somewhere in the buildbot configuration files. I've set that variable on my gtk-wk2-ews. Thanks for investigating this issue! 882524 6 199998 gustavo 2013-04-29 06:19:28 -0700 Created attachment 199998 Patch 882526 7 gustavo 2013-04-29 06:20:20 -0700 How about something like this, so there's one less thing we need to remember when running the queue? 882541 8 199998 zan 2013-04-29 07:01:23 -0700 Comment on attachment 199998 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=199998&action=review > Tools/Scripts/webkitpy/port/gtk.py:46 > + os.environ['COLLECT_NO_DEMANGLE'] = '1' Does this properly translate into the EWS's environment? 882999 9 zan 2013-04-30 03:20:14 -0700 Hrm, the proposed hack ... is a hack. It probably would work for EWSs. Another solution that I should have pushed for (and I apologize for not doing so) is to pass the --no-demangle flag to the linker. This can be easily done by listing the flag in the AM_LDFLAGS assignment in the root GNUmakefile.am. This way the linker outputs mangled symbols by default, though if someone needs clarification on what the symbol is representing, he can still run the symbol through c++filt. This would remove the need for exporting the COLLECT_NO_DEMANGLE env on both EWSs and the builders. Thoughts? 883804 10 gustavo 2013-05-02 08:44:55 -0700 I like that solution. The mangled symbols are usually more interesting for developers, and anyone who needs it can demangle the symbol very easily, so I think it's OK to add it to the linker arguments. 886227 11 201043 zan 2013-05-08 01:33:05 -0700 Created attachment 201043 Test patch Just a test patch to see how EWSs now behave. 886228 12 201043 gtk-ews 2013-05-08 01:41:56 -0700 Comment on attachment 201043 Test patch Attachment 201043 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/436014 886229 13 zan 2013-05-08 01:43:16 -0700 Success: ./.libs/libWebCoreInternals.a(./.libs/../Source/WebCore/testing/.libs/libWebCoreInternals_la-Internals.o):Internals.cpp:function _ZN7WebCore9Internals23inspectorHighlightRectsEPNS_8DocumentERi: error: undefined reference to '_ZN7WebCore14ClientRectListC1ERKN3WTF6VectorINS_9FloatQuadELm0ENS1_15CrashOnOverflowEEE' collect2: error: ld returned 1 exit status make[1]: *** [Programs/DumpRenderTree] Error 1 Closing the bug. 886230 14 199998 zan 2013-05-08 01:43:48 -0700 Comment on attachment 199998 Patch Clearing the r? flag. 886231 15 vivekg 2013-05-08 01:46:30 -0700 (In reply to comment #13) > Success: > > ./.libs/libWebCoreInternals.a(./.libs/../Source/WebCore/testing/.libs/libWebCoreInternals_la-Internals.o):Internals.cpp:function _ZN7WebCore9Internals23inspectorHighlightRectsEPNS_8DocumentERi: error: undefined reference to '_ZN7WebCore14ClientRectListC1ERKN3WTF6VectorINS_9FloatQuadELm0ENS1_15CrashOnOverflowEEE' > collect2: error: ld returned 1 exit status > make[1]: *** [Programs/DumpRenderTree] Error 1 > > Closing the bug. Thank you for handling this :) Really appreciated! 886352 16 gustavo 2013-05-08 08:07:58 -0700 There's a catch! The EWS bots have the environment variable set. I'll take it off so we can get a real test run done, need to ask rego and philln to remove it from theirs too. 888017 17 zan 2013-05-12 13:55:27 -0700 Yeah, true, didn't cross my mind. I'll ensure people have the env unset and then retest, IMO it should be just a formality. 888491 18 201624 zan 2013-05-13 13:23:24 -0700 Created attachment 201624 Patch Test #2 888518 19 201624 gtk-ews 2013-05-13 14:09:57 -0700 Comment on attachment 201624 Patch Attachment 201624 did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/468194 888519 20 zan 2013-05-13 14:11:28 -0700 All EWSs had the COLLECT_NO_DEMANGLE env removed, and the mangled symbols in the output persist: ./.libs/libWebCoreInternals.a(./.libs/../Source/WebCore/testing/.libs/libWebCoreInternals_la-Internals.o):Internals.cpp:function _ZN7WebCore9Internals23inspectorHighlightRectsEPNS_8DocumentERi: error: undefined reference to '_ZN7WebCore14ClientRectListC1ERKN3WTF6VectorINS_9FloatQuadELm0ENS1_15CrashOnOverflowEEE' collect2: error: ld returned 1 exit status make[1]: *** [Programs/DumpRenderTree] Error 1 This now works as expected, closing the bug. 917691 21 gustavo 2013-08-15 14:12:52 -0700 Looks like we need to do something for this to work on the buildbots as well? Or did we regress? http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release/builds/39871/steps/compile-webkit/logs/stdio 917698 22 zan 2013-08-15 14:25:32 -0700 Everything on the builder seems fine (i.e. --no-demangle is present in LDFLAGS), don't really have an idea where this might be failing. 917709 23 zan 2013-08-15 14:35:31 -0700 Still works on the 64-bit debug builder: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20WK1/builds/3611/steps/compile-webkit/logs/stdio 199998 2013-04-29 06:19:28 -0700 2013-05-13 13:23:11 -0700 Patch bug-96514-20130429101844.patch text/plain 1441 gustavo U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5Mjc3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDhjYzZkZTMxOTYzODlkNThkYzMzNTExZWQzZmUwZDhh MGQ3M2U5Ni4uMjczMjA1NWQ1Mjc4NTZkNWE5YmQ2ZTAyMzlkNDAyZTY1Nzk3Mjk3MSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEzLTA0LTI5ICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9uaGFA Y29sbGFib3JhLmNvbT4KKworICAgICAgICBbR3RrIEVXU10gRVdTIGZvciBHdGsrIHNob3VsZCBn ZW5lcmF0ZSB0aGUgbWFuZ2xlZCBzeW1ib2xzIGZvciB1bnJlc29sdmVkIHN5bWJvbHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NTE0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtp dHB5L3BvcnQvZ3RrLnB5OgorICAgICAgICAoR3RrUG9ydC5fX2luaXRfXyk6IHVzZSBDT0xMRUNU X05PX0RFTUFOR0xFIHRvIGVhc2UgYWRkaW5nIG5ldyBzeW1ib2xzIHRvIHRoZSBleHBvcnQgZmls ZS4KKwogMjAxMy0wNC0yOSAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0dUS10gRXhwb3J0IHRoZSBDT0xMRUNUX05PX0RFTUFOR0xFIHZhcmlhYmxlIG9u IHRoZSBidWlsZGVycwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0 ay5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsucHkKaW5kZXggYzk0ZjAzNmVk MDU5MGRhOTE4NmQzNjQwODMxZjZiMmZlODUzYTFmMS4uMDYwZmVhYWI4ZmY5ZTU3NDQ2NGIyNjFk NDM1YTU2YTA3MWIxOGZmOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0 L2d0ay5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5CkBAIC00Miw2 ICs0Miw5IEBAIGNsYXNzIEd0a1BvcnQoUG9ydCk6CiAgICAgICAgIHN1cGVyKEd0a1BvcnQsIHNl bGYpLl9faW5pdF9fKCphcmdzLCAqKmt3YXJncykKICAgICAgICAgc2VsZi5fcHVsc2VhdWRpb19z YW5pdGl6ZXIgPSBQdWxzZUF1ZGlvU2FuaXRpemVyKCkKIAorICAgICAgICAjIFJlcG9ydGluZyBt YW5nbGVkIG5hbWVzIGRvZXMgbm90IGhlbHAgcGVvcGxlIHdobyBuZWVkIHRvIGVkaXQgdGhlIHN5 bWJvbHMgZXhwb3J0IGZpbGUuCisgICAgICAgIG9zLmVudmlyb25bJ0NPTExFQ1RfTk9fREVNQU5H TEUnXSA9ICcxJworCiAgICAgZGVmIHdhcm5faWZfYnVnX21pc3NpbmdfaW5fdGVzdF9leHBlY3Rh dGlvbnMoc2VsZik6CiAgICAgICAgIHJldHVybiBub3Qgc2VsZi5nZXRfb3B0aW9uKCd3ZWJraXRf dGVzdF9ydW5uZXInKQogCg== 201043 2013-05-08 01:33:05 -0700 2013-05-13 13:23:18 -0700 Test patch bug-96514-20130508103210.patch text/plain 1729 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ5NzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvYXV0b3Rvb2xz L3N5bWJvbHMuZmlsdGVyIGIvU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlcgppbmRleCA5 MDY5Y2RkOWY2OWQ1NjQ0NWRjNTNmM2QwMzkyOTEwNmNjNjBhZTU3Li5iN2E2NGNkMGI0YjgxMTVi NGQxMzQxNWNkMWI0ZDMwZjYyMDA5N2EzIDEwMDY0NAotLS0gYS9Tb3VyY2UvYXV0b3Rvb2xzL3N5 bWJvbHMuZmlsdGVyCisrKyBiL1NvdXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0ZXIKQEAgLTMw MCw4ICszMDAsNiBAQCBfWk43V2ViQ29yZTIxU2VyaWFsaXplZFNjcmlwdFZhbHVlNmNyZWF0ZUVQ TjNKU0M5RXhlY1N0YXRlRU5TMV83SlNWYWx1ZUVQTjNXVEY2VgogX1pON1dlYkNvcmUyMVNlcmlh bGl6ZWRTY3JpcHRWYWx1ZTZjcmVhdGVFUE4zSlNDOUV4ZWNTdGF0ZUVOUzFfN0pTVmFsdWVFUE4z V1RGNlZlY3RvcklOUzVfNlJlZlB0cklOU18xMU1lc3NhZ2VQb3J0RUVFTGoxRU5TNV8xNUNyYXNo T25PdmVyZmxvd0VFRVBOUzZfSU5TN19JTlM1XzExQXJyYXlCdWZmZXJFRUVMajFFU0FfRUVOU18y MlNlcmlhbGl6YXRpb25FcnJvck1vZGVFOwogX1pON1dlYkNvcmUyMVNlcmlhbGl6ZWRTY3JpcHRW YWx1ZUMxRVJOM1dURjZWZWN0b3JJaExtMEVOUzFfMTVDcmFzaE9uT3ZlcmZsb3dFRUU7CiBfWk43 V2ViQ29yZTIxU2VyaWFsaXplZFNjcmlwdFZhbHVlQzFFUk4zV1RGNlZlY3RvckloTGowRU5TMV8x NUNyYXNoT25PdmVyZmxvd0VFRTsKLV9aTjdXZWJDb3JlMTRDbGllbnRSZWN0TGlzdEMxRVJLTjNX VEY2VmVjdG9ySU5TXzlGbG9hdFF1YWRFTG0wRU5TMV8xNUNyYXNoT25PdmVyZmxvd0VFRTsKLV9a TjdXZWJDb3JlMTRDbGllbnRSZWN0TGlzdEMxRVJLTjNXVEY2VmVjdG9ySU5TXzlGbG9hdFF1YWRF TGowRU5TMV8xNUNyYXNoT25PdmVyZmxvd0VFRTsKIF9aTjdXZWJDb3JlMTBUaW1lUmFuZ2VzM2Fk ZEVkZDsKIF9aTjdXZWJDb3JlMTJ0b1RpbWVSYW5nZXNFTjNKU0M3SlNWYWx1ZUU7CiBfWk43V2Vi Q29yZTE0dG9GbG9hdDMyQXJyYXlFTjNKU0M3SlNWYWx1ZUU7CmRpZmYgLS1naXQgYS9DaGFuZ2VM b2cgYi9DaGFuZ2VMb2cKaW5kZXggMjg5OGE4YzgxOTI1Njg0ZjcyNThjZTU0YzhhMjJlZTE2N2Qy YjU4OS4uYTQyOGZlNTY5NDJlYzcyMThlNjJmZjQwYWYwYjI1YTNhMmRkM2VjYSAxMDA2NDQKLS0t IGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE0IEBACiAyMDEzLTA1LTA4 ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR3RrIEVX U10gRVdTIGZvciBHdGsrIHNob3VsZCBnZW5lcmF0ZSB0aGUgbWFuZ2xlZCBzeW1ib2xzIGZvciB1 bnJlc29sdmVkIHN5bWJvbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk2NTE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBTb3VyY2UvYXV0b3Rvb2xzL3N5bWJvbHMuZmlsdGVyOgorCisyMDEzLTA1LTA4 ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKwogICAgICAgICBbQXV0b21h a2VdIFBhc3MgLS1uby1kZW1hbmdsZSB0byB0aGUgbGlua2VyIGJ5IGRlZmF1bHQgdG8gZ2V0IHRo ZSBtYW5nbGVkIHN5bWJvbHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTExNTczMgogCg== 201624 2013-05-13 13:23:24 -0700 2013-05-13 14:09:57 -0700 Patch bug-96514-20130513222223.patch text/plain 1525 zan SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1MDAz NCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEzLTA1 LTEzICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtAaWdhbGlhLmNvbT4KKworICAgICAgICBbR3Rr IEVXU10gRVdTIGZvciBHdGsrIHNob3VsZCBnZW5lcmF0ZSB0aGUgbWFuZ2xlZCBzeW1ib2xzIGZv ciB1bnJlc29sdmVkIHN5bWJvbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk2NTE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBTb3VyY2UvYXV0b3Rvb2xzL3N5bWJvbHMuZmlsdGVyOgorCiAyMDEzLTA1 LTExICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBb R1RLXSBBZGQgYSBiYXNpYyBjbWFrZSBidWlsZCBmb3IgV1RGIGFuZCBKYXZhU2NyaXB0Q29yZQpJ bmRleDogU291cmNlL2F1dG90b29scy9zeW1ib2xzLmZpbHRlcgo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvYXV0b3Rvb2xzL3N5bWJvbHMuZmlsdGVyCShyZXZpc2lvbiAxNTAwMzQpCisrKyBTb3VyY2Uv YXV0b3Rvb2xzL3N5bWJvbHMuZmlsdGVyCSh3b3JraW5nIGNvcHkpCkBAIC0zMDAsOCArMzAwLDYg QEAgX1pON1dlYkNvcmUyMVNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTZjcmVhdAogX1pON1dlYkNvcmUy MVNlcmlhbGl6ZWRTY3JpcHRWYWx1ZTZjcmVhdGVFUE4zSlNDOUV4ZWNTdGF0ZUVOUzFfN0pTVmFs dWVFUE4zV1RGNlZlY3RvcklOUzVfNlJlZlB0cklOU18xMU1lc3NhZ2VQb3J0RUVFTGoxRU5TNV8x NUNyYXNoT25PdmVyZmxvd0VFRVBOUzZfSU5TN19JTlM1XzExQXJyYXlCdWZmZXJFRUVMajFFU0Ff RUVOU18yMlNlcmlhbGl6YXRpb25FcnJvck1vZGVFOwogX1pON1dlYkNvcmUyMVNlcmlhbGl6ZWRT Y3JpcHRWYWx1ZUMxRVJOM1dURjZWZWN0b3JJaExtMEVOUzFfMTVDcmFzaE9uT3ZlcmZsb3dFRUU7 CiBfWk43V2ViQ29yZTIxU2VyaWFsaXplZFNjcmlwdFZhbHVlQzFFUk4zV1RGNlZlY3RvckloTGow RU5TMV8xNUNyYXNoT25PdmVyZmxvd0VFRTsKLV9aTjdXZWJDb3JlMTRDbGllbnRSZWN0TGlzdEMx RVJLTjNXVEY2VmVjdG9ySU5TXzlGbG9hdFF1YWRFTG0wRU5TMV8xNUNyYXNoT25PdmVyZmxvd0VF RTsKLV9aTjdXZWJDb3JlMTRDbGllbnRSZWN0TGlzdEMxRVJLTjNXVEY2VmVjdG9ySU5TXzlGbG9h dFF1YWRFTGowRU5TMV8xNUNyYXNoT25PdmVyZmxvd0VFRTsKIF9aTjdXZWJDb3JlMTBUaW1lUmFu Z2VzM2FkZEVkZDsKIF9aTjdXZWJDb3JlMTJ0b1RpbWVSYW5nZXNFTjNKU0M3SlNWYWx1ZUU7CiBf Wk43V2ViQ29yZTE0dG9GbG9hdDMyQXJyYXlFTjNKU0M3SlNWYWx1ZUU7Cg==