96502 2012-09-12 05:45:21 -0700 [GTK] ControlsPanel string is not localized in LocalizedStringsGtk 2012-09-20 10:55:41 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned cfleizach eric.carlson feature-media-reviews jdiggs mario webkit.review.bot zan oldest_to_newest 718260 0 pnormand 2012-09-12 05:45:21 -0700 I don't have time to dig which commit introduced this regression. With a debug build: run-launcher --gtk --debug LayoutTests/media/content/test.wav Program received signal SIGSEGV, Segmentation fault. 0x00007ffff5e9264f in WebCore::localizedMediaControlElementString (name="ControlsPanel") at ../../Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp:562 562 ASSERT_NOT_REACHED(); (gdb) bt #0 0x00007ffff5e9264f in WebCore::localizedMediaControlElementString (name="ControlsPanel") at ../../Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp:562 #1 0x00007ffff4a5318c in WebCore::AccessibilityMediaControl::title (this=0x7d5000) at ../../Source/WebCore/accessibility/AccessibilityMediaControls.cpp:148 #2 0x00007ffff5e65d42 in webkitAccessibleGetName (object=0xaf5850) at ../../Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:144 #3 0x00007fffe743499a in append_cache_item (obj=obj@entry=0xaf5850, data=data@entry= 0x7fffffffcee0) at cache-adaptor.c:192 #4 0x00007fffe7434e44 in emit_cache_add (cache=<optimized out>, obj=obj@entry=0xaf5850) at cache-adaptor.c:270 #5 0x00007ffff2e88b74 in g_cclosure_marshal_VOID__OBJECTv (closure=0x566fe0, return_value=<optimized out>, instance=0x563190, args=<optimized out>, marshal_data=<optimized out>, n_params=<optimized out>, param_types=0x565e30) at gmarshal.c:1312 #6 0x00007ffff2e85927 in _g_closure_invoke_va (closure=0x566fe0, return_value=0x0, instance= 0x563190, args=0x7fffffffd258, n_params=1, param_types=0x565e30) at gclosure.c:840 #7 0x00007ffff2e9efb8 in g_signal_emit_valist (instance=0x563190, signal_id=<optimized out>, detail=0, var_args=var_args@entry=0x7fffffffd258) at gsignal.c:3207 #8 0x00007ffff2e9f6f2 in g_signal_emit (instance=instance@entry=0x563190, signal_id=<optimized out>, detail=detail@entry=0) at gsignal.c:3352 #9 0x00007fffe742c373 in add_object (gobj=0xaf5850, cache=0x563190) at ../../atk-adaptor/accessible-cache.c:197 #10 add_pending_items (data=<optimized out>) at ../../atk-adaptor/accessible-cache.c:304 #11 0x00007ffff2d9c695 in g_main_dispatch (context=0x466dd0) at gmain.c:2539 #12 g_main_context_dispatch (context=context@entry=0x466dd0) at gmain.c:3075 #13 0x00007ffff2d9c9c8 in g_main_context_iterate (context=0x466dd0, block=block@entry=1, dispatch=dispatch@entry=1, self=<error reading variable: Unhandled dwarf expression opcode 0xfa>) at gmain.c:3146 #14 0x00007ffff2d9cdc2 in g_main_loop_run (loop=0x6cf3b0) at gmain.c:3340 #15 0x00007ffff364b9c5 in gtk_main () at gtkmain.c:1161 #16 0x0000000000405a86 in main (argc=1, argv=0x7fffffffd628) at ../../Tools/GtkLauncher/main.c:534 (gdb) 724335 1 164873 jdiggs 2012-09-20 03:07:09 -0700 Created attachment 164873 Patch 724344 2 jdiggs 2012-09-20 03:14:07 -0700 (In reply to comment #0) > I don't have time to dig which commit introduced this regression. And I didn't keep digging to find out. It *might* be due to a change in accessible hierarchy that exposed the ControlsPanel whereas it wasn't before. But the bottom line is: That object should be exposed to ATs. It is now exposed to ATs. It would be more accessible with a meaningful accessible name. And localizing the string makes that happen and also fixes your reported bug. So that's what I wound up doing. 724346 3 pnormand 2012-09-20 03:15:41 -0700 It strucks me that we're the only port hitting this issue. Especially given this FIXME in LocalizedStrings.cpp // FIXME: the ControlsPanel container should never be visible in the accessibility hierarchy. Can you clarify this please? :) 724394 4 jdiggs 2012-09-20 04:02:34 -0700 (In reply to comment #3) > It strucks me that we're the only port hitting this issue. Especially given this FIXME in LocalizedStrings.cpp > > // FIXME: the ControlsPanel container should never be visible in the accessibility hierarchy. > > Can you clarify this please? :) It took a bit of spelunking (this FIXME is well traveled, having been moved several times as part of refactors and other changes). But I discovered its birth: http://trac.webkit.org/changeset/49206/trunk/WebKit/mac/WebCoreSupport/WebViewFactory.mm I don't know what other platforms expect, but having media controls floating outside of a logical parent container strikes me as being quite odd. Would you like me to amend the FIXME to indicate that at least the Gtk port expects this object? 724396 5 jdiggs 2012-09-20 04:12:14 -0700 Chris, mind taking a look at this and chiming in? Thanks in advance! 724641 6 164873 webkit.review.bot 2012-09-20 10:55:38 -0700 Comment on attachment 164873 Patch Clearing flags on attachment: 164873 Committed r129141: <http://trac.webkit.org/changeset/129141> 724642 7 webkit.review.bot 2012-09-20 10:55:41 -0700 All reviewed patches have been landed. Closing bug. 164873 2012-09-20 03:07:09 -0700 2012-09-20 10:55:38 -0700 Patch bug-96502-20120920060633.patch text/plain 4608 jdiggs U3VidmVyc2lvbiBSZXZpc2lvbjogMTI5MDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDk3NTk4MzIyNjQ3ZDk3 MDM5NmI1MzI1YTIzZTlkMzU3YjUwMGRkMC4uYjQ2NjkwMmEyNWEyNTFmNGEzNTk2YTAxOGFkN2Qx ZDI3NWQ0MDk0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTIwICBKb2Fu bWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBDb250cm9s c1BhbmVsIHN0cmluZyBpcyBub3QgbG9jYWxpemVkIGluIExvY2FsaXplZFN0cmluZ3NHdGsKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NTAyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkcyB0aGUgQ29u dHJvbHNQYW5lbCBzdHJpbmcgdG8gdGhlIHN0cmluZ3MgbG9jYWxpemVkIGluIExvY2FsaXplZFN0 cmluZ3NHdGsuCisKKyAgICAgICAgVGVzdDogcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbWVk aWEtY29udHJvbHMtcGFuZWwtdGl0bGUuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL0xv Y2FsaXplZFN0cmluZ3NHdGsuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bG9jYWxpemVkTWVkaWFD b250cm9sRWxlbWVudFN0cmluZyk6CisKIDIwMTItMDktMTkgIERvbWluaWMgTWF6em9uaSAgPGRt YXp6b25pQGdvb2dsZS5jb20+CiAKICAgICAgICAgQVg6IEEgZmV3IGNvbnRyb2wgdHlwZXMgYXJl IHJldHVybmluZyB0aGUgd3JvbmcgYW5zd2VyIGZvciBpc1JlYWRPbmx5CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5nc0d0ay5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvTG9jYWxpemVkU3RyaW5nc0d0ay5jcHAKaW5kZXggNWQ2 NDI5ZGEyN2IwNGFlMTBiNGNmOWYzYmM4YTFlZDdlOWYzZjRkYS4uOTFiMzVkMDRiZDM0MDFlYTg0 YjE0ZTE0N2NlYjg5YWVkZWVjMDc2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL0xvY2FsaXplZFN0cmluZ3NHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9Mb2NhbGl6ZWRTdHJpbmdzR3RrLmNwcApAQCAtNTU4LDYgKzU1OCw4IEBAIFN0cmlu ZyBsb2NhbGl6ZWRNZWRpYUNvbnRyb2xFbGVtZW50U3RyaW5nKGNvbnN0IFN0cmluZyYgbmFtZSkK ICAgICAgICAgcmV0dXJuIFN0cmluZzo6ZnJvbVVURjgoXygic2hvdyBjbG9zZWQgY2FwdGlvbnMi KSk7CiAgICAgaWYgKG5hbWUgPT0gIkhpZGVDbG9zZWRDYXB0aW9uc0J1dHRvbiIpCiAgICAgICAg IHJldHVybiBTdHJpbmc6OmZyb21VVEY4KF8oImhpZGUgY2xvc2VkIGNhcHRpb25zIikpOworICAg IGlmIChuYW1lID09ICJDb250cm9sc1BhbmVsIikKKyAgICAgICAgcmV0dXJuIFN0cmluZzo6ZnJv bVVURjgoXygibWVkaWEgY29udHJvbHMiKSk7CiAKICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsK ICAgICByZXR1cm4gU3RyaW5nKCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzBiMTljNDQ3ZDU2ZmRjZjU3ODA1ZjY0ZDhj MDQ3MjgwNzJiY2IzNS4uMDcwZjA3ZWMzM2QyNGY4MjcyZDQyNzAxYTlhNTljYWVjODEyZWI1MiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTIwICBKb2FubWFyaWUgRGlnZ3MgIDxqZGln Z3NAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBDb250cm9sc1BhbmVsIHN0cmluZyBpcyBu b3QgbG9jYWxpemVkIGluIExvY2FsaXplZFN0cmluZ3NHdGsKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NTAyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgYSBuZXcgdGVzdCB0byB2ZXJpZnkgdGhh dCB0aGUgYWNjZXNzaWJsZSBvYmplY3QgYXNzb2NpYXRlZCB3aXRoIHRoZQorICAgICAgICBNZWRp YUNvbnRyb2xzUGFuZWwgaGFzIHRoZSBleHBlY3RlZCBhY2Nlc3NpYmxlIG5hbWUuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9tZWRpYS1jb250cm9scy1wYW5lbC10aXRs ZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9hY2Nlc3NpYmls aXR5L21lZGlhLWNvbnRyb2xzLXBhbmVsLXRpdGxlLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA5LTE5 ICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgogCiAgICAgICAgIEFYOiBB IGZldyBjb250cm9sIHR5cGVzIGFyZSByZXR1cm5pbmcgdGhlIHdyb25nIGFuc3dlciBmb3IgaXNS ZWFkT25seQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxp dHkvbWVkaWEtY29udHJvbHMtcGFuZWwtdGl0bGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbWVkaWEtY29udHJvbHMtcGFuZWwtdGl0bGUtZXhw ZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAuLmI2MDRmZDNkZTNmMjkwZjUzMjc2ZDgxOGQxN2U3ZTU1MTBk NzY1OWMKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNz aWJpbGl0eS9tZWRpYS1jb250cm9scy1wYW5lbC10aXRsZS1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSwxMyBAQAorVGhpcyB0ZXN0cyB0aGF0IHRoZSBtZWRpYSBjb250cm9scyBwYW5lbCBoYXMgdGhl IGNvcnJlY3QgbmFtZSBhbmQgcm9sZQorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJp ZXMgb2YgIlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKwor UEFTUyBlbGVtZW50LnJvbGUgaXMgJ0FYUm9sZTogcGFuZWwnCitQQVNTIGVsZW1lbnQudGl0bGUg aXMgJ0FYVGl0bGU6ICcKK1BBU1MgZWxlbWVudC5yb2xlIGlzICdBWFJvbGU6IHRvb2wgYmFyJwor UEFTUyBlbGVtZW50LnRpdGxlIGlzICdBWFRpdGxlOiBtZWRpYSBjb250cm9scycKK1BBU1Mgc3Vj Y2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9tZWRpYS1jb250cm9scy1wYW5l bC10aXRsZS5odG1sIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbWVk aWEtY29udHJvbHMtcGFuZWwtdGl0bGUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hNTZlNjIzZmUzYzdhYjMx ZjdiMzUyMDBjNTAxMWY1MjJhY2QyZDZkCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv cGxhdGZvcm0vZ3RrL2FjY2Vzc2liaWxpdHkvbWVkaWEtY29udHJvbHMtcGFuZWwtdGl0bGUuaHRt bApAQCAtMCwwICsxLDI2IEBACis8IURPQ1RZUEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBI VE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3QvanMv cmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlkPSJi b2R5Ij4KKzx2aWRlbyBjb250cm9scz0iIiBhdXRvcGxheT0iIiBuYW1lPSJtZWRpYSIgc3JjPSIu Li8uLi8uLi9tZWRpYS9jb250ZW50L3Rlc3Qud2F2Ij48L3ZpZGVvPgorPHAgaWQ9ImRlc2NyaXB0 aW9uIj48L3A+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQ+CitkZXNjcmlwdGlv bigiVGhpcyB0ZXN0cyB0aGF0IHRoZSBtZWRpYSBjb250cm9scyBwYW5lbCBoYXMgdGhlIGNvcnJl Y3QgbmFtZSBhbmQgcm9sZSIpOworaWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikg eworICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJib2R5IikuZm9jdXMoKTsKKyAgICB2YXIg d2ViQXJlYSA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50OworICAgIHZh ciBlbGVtZW50ID0gd2ViQXJlYS5jaGlsZEF0SW5kZXgoMCk7CisgICAgc2hvdWxkQmUoImVsZW1l bnQucm9sZSIsICInQVhSb2xlOiBwYW5lbCciKTsKKyAgICBzaG91bGRCZSgiZWxlbWVudC50aXRs ZSIsICInQVhUaXRsZTogJyIpOworICAgIGVsZW1lbnQgPSBlbGVtZW50LmNoaWxkQXRJbmRleCgw KTsKKyAgICBzaG91bGRCZSgiZWxlbWVudC5yb2xlIiwgIidBWFJvbGU6IHRvb2wgYmFyJyIpOwor ICAgIHNob3VsZEJlKCJlbGVtZW50LnRpdGxlIiwgIidBWFRpdGxlOiBtZWRpYSBjb250cm9scyci KTsKK30KKworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJj ZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K