96500 2012-09-12 05:20:18 -0700 [WK2] Improve log channel decision routine on WebKit 2012-09-12 23:39:06 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 96478 1 ky0.choi ky0.choi abecsi ap cmarcelo menard rakuco webkit.review.bot zoltan oldest_to_newest 718231 0 ky0.choi 2012-09-12 05:20:18 -0700 initializeLogChannel() on GTK and QT on WebKit2 is not effective. It's not necessary to call initializeLogChannel() for every log channels. 718252 1 163603 ky0.choi 2012-09-12 05:36:20 -0700 Created attachment 163603 Patch 718667 2 163603 ap 2012-09-12 13:32:44 -0700 Comment on attachment 163603 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163603&action=review This > Source/WebKit2/Platform/mac/Logging.mac.mm:54 > +void platformInitializeLogChannels() > +{ > + initializeLogChannel(&LogContextMenu); > + initializeLogChannel(&LogIconDatabase); > + initializeLogChannel(&LogKeyHandling); > + initializeLogChannel(&LogSessionState); > + initializeLogChannel(&LogTextInput); > + initializeLogChannel(&LogView); As a result of this patch, each platform is responsible for knowing about all log channels, not just about how to initialize them. This is not maintainable - adding a logging channel should not require changing platform specific code. 718970 3 163603 ky0.choi 2012-09-12 18:37:18 -0700 Comment on attachment 163603 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163603&action=review >> Source/WebKit2/Platform/mac/Logging.mac.mm:54 >> + initializeLogChannel(&LogView); > > As a result of this patch, each platform is responsible for knowing about all log channels, not just about how to initialize them. This is not maintainable - adding a logging channel should not require changing platform specific code. The reason why I am not changing the routine of Mac port is because its routine in WebCore is same. And I'm not familiar with Objective-C. GTK and QT will find the enabled log channels based on environment variable. It need not to be executed if there is no environment variable. 719010 4 ap 2012-09-12 20:28:07 -0700 This issue needs to be addressed in a way that doesn't introduce the design problem I pointed out. Perhaps Gtk and Qt could cache some results to avoid recalculating them unnecessarily. Also, I'm not sure why this is a problem to begin with, as this code is debug only. 719100 5 ky0.choi 2012-09-12 23:39:06 -0700 (In reply to comment #4) > This issue needs to be addressed in a way that doesn't introduce the design problem I pointed out. Perhaps Gtk and Qt could cache some results to avoid recalculating them unnecessarily. > > Also, I'm not sure why this is a problem to begin with, as this code is debug only. I just wanted to add this feature to EFL port. And I think, it can be modified to WebCore style implementation before I add it to EFL port. I will found out how to add this feature to EFL without changing previous implementation. Thank you for review. 163603 2012-09-12 05:36:20 -0700 2012-09-12 18:37:18 -0700 Patch diff text/plain 7345 ky0.choi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBiYTIyMTk2Li5kN2Y0NGZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTItMDktMTIgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW1dLMl0gSW1wcm92ZSBsb2cgY2hhbm5lbCBkZWNpc2lvbiByb3V0aW5lIGluIFdl YktpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY1 MDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUg ZnVuY3Rpb24gaW5pdGlhbGl6ZUxvZ0NoYW5uZWwoKSBvbiBHVEsgYW5kIFFUIGluIFdlYktpdDIg aXMgbm90IGVmZmVjdGl2ZS4KKyAgICAgICAgSXQncyBub3QgbmVjZXNzYXJ5IHRvIGNhbGwgaW5p dGlhbGl6ZUxvZ0NoYW5uZWwoKSBmb3IgZXZlcnkgbG9nIGNoYW5uZWxzLgorCisgICAgICAgIFRo ZSByb3V0aW5lIGluIHBsYXRmb3JtSW5pdGlhbGl6ZUxvZ0NoYW5uZWxzKCkgaXMgY29waWVkIGZy b20KKyAgICAgICAgaW5pdGlhbGl6ZUxvZ2dpbmdDaGFubmVsc0lmTmVjZXNzYXJ5KCkgaW4gV2Vi Q29yZS4gSXQgY2hlY2tzIGVudmlyb25tZW50CisgICAgICAgIHZhcmlhYmxlIGFuZCBzZXQgdGhl IGNoYW5uZWwgc3RhdGUuCisKKyAgICAgICAgKiBQbGF0Zm9ybS9Mb2dnaW5nLmNwcDoKKyAgICAg ICAgKFdlYktpdDo6cGxhdGZvcm1Jbml0aWFsaXplTG9nQ2hhbm5lbHMpOgorICAgICAgICAoV2Vi S2l0Ojppbml0aWFsaXplTG9nQ2hhbm5lbHNJZk5lY2Vzc2FyeSk6CisgICAgICAgICogUGxhdGZv cm0vTG9nZ2luZy5oOgorICAgICAgICAoV2ViS2l0KToKKyAgICAgICAgKiBQbGF0Zm9ybS9ndGsv TG9nZ2luZ0d0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OnBsYXRmb3JtSW5pdGlhbGl6ZUxvZ0No YW5uZWxzKToKKyAgICAgICAgKiBQbGF0Zm9ybS9tYWMvTG9nZ2luZy5tYWMubW06CisgICAgICAg IChXZWJLaXQ6OnBsYXRmb3JtSW5pdGlhbGl6ZUxvZ0NoYW5uZWxzKToKKyAgICAgICAgKFdlYktp dCk6CisgICAgICAgICogUGxhdGZvcm0vcXQvTG9nZ2luZ1F0LmNwcDoKKyAgICAgICAgKFdlYktp dDo6cGxhdGZvcm1Jbml0aWFsaXplTG9nQ2hhbm5lbHMpOgorCiAyMDEyLTA5LTExICBBbmRlcnMg Q2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWNjZWxlcmF0ZWQgY29t cG9zaXRpbmcgc2hvdWxkIGFsd2F5cyBiZSBmb3JjZWQgd2hlbiB1c2luZyB0aGUgdGlsZWQgZHJh d2luZyBhcmVhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Mb2dnaW5nLmNw cCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0xvZ2dpbmcuY3BwCmluZGV4IDMzYjQ2MzcuLmYx ODNmNjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0xvZ2dpbmcuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0xvZ2dpbmcuY3BwCkBAIC0zOSw5ICszOSw5IEBA IFdURkxvZ0NoYW5uZWwgTG9nSWNvbkRhdGFiYXNlID0geyAweDAwMDAwMDEwLCAiV2ViS2l0Mkxv Z0xldmVsIiwgV1RGTG9nQ2hhbm5lbE9mCiBXVEZMb2dDaGFubmVsIExvZ0tleUhhbmRsaW5nICA9 IHsgMHgwMDAwMDAyMCwgIldlYktpdDJMb2dMZXZlbCIsIFdURkxvZ0NoYW5uZWxPZmYgfTsKIAog I2lmICFQTEFURk9STShNQUMpICYmICFQTEFURk9STShHVEspICYmICFQTEFURk9STShRVCkKLXZv aWQgaW5pdGlhbGl6ZUxvZ0NoYW5uZWwoV1RGTG9nQ2hhbm5lbCogY2hhbm5lbCkKK3ZvaWQgcGxh dGZvcm1Jbml0aWFsaXplTG9nQ2hhbm5lbHMoKQogewotICAgIC8vIEZJWE1FOiBFYWNoIHBsYXRm b3JtIHdpbGwgbmVlZCB0byBkZWZpbmUgdGhlaXIgb3duIGluaXRpYWxpemVMb2dDaGFubmVsKCku CisgICAgLy8gRklYTUU6IEVhY2ggcGxhdGZvcm0gd2lsbCBuZWVkIHRvIGRlZmluZSB0aGVpciBv d24gcGxhdGZvcm1Jbml0aWFsaXplTG9nQ2hhbm5lbHMoKS4KIH0KICNlbmRpZgogCkBAIC04MCwx MiArODAsNyBAQCB2b2lkIGluaXRpYWxpemVMb2dDaGFubmVsc0lmTmVjZXNzYXJ5KCkKICAgICAg ICAgcmV0dXJuOwogICAgIGhhdmVJbml0aWFsaXplZExvZ0NoYW5uZWxzID0gdHJ1ZTsKIAotICAg IGluaXRpYWxpemVMb2dDaGFubmVsKCZMb2dDb250ZXh0TWVudSk7Ci0gICAgaW5pdGlhbGl6ZUxv Z0NoYW5uZWwoJkxvZ0ljb25EYXRhYmFzZSk7Ci0gICAgaW5pdGlhbGl6ZUxvZ0NoYW5uZWwoJkxv Z0tleUhhbmRsaW5nKTsKLSAgICBpbml0aWFsaXplTG9nQ2hhbm5lbCgmTG9nU2Vzc2lvblN0YXRl KTsKLSAgICBpbml0aWFsaXplTG9nQ2hhbm5lbCgmTG9nVGV4dElucHV0KTsKLSAgICBpbml0aWFs aXplTG9nQ2hhbm5lbCgmTG9nVmlldyk7CisgICAgcGxhdGZvcm1Jbml0aWFsaXplTG9nQ2hhbm5l bHMoKTsKIH0KIAogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9QbGF0Zm9ybS9Mb2dnaW5nLmggYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9Mb2dnaW5n LmgKaW5kZXggYzQ3YmZmZi4uNDE4OGUxZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGxh dGZvcm0vTG9nZ2luZy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL0xvZ2dpbmcuaApA QCAtNDQsNyArNDQsNyBAQCBleHRlcm4gV1RGTG9nQ2hhbm5lbCBMb2dTZXNzaW9uU3RhdGU7CiBl eHRlcm4gV1RGTG9nQ2hhbm5lbCBMb2dUZXh0SW5wdXQ7CiBleHRlcm4gV1RGTG9nQ2hhbm5lbCBM b2dWaWV3OwogCi12b2lkIGluaXRpYWxpemVMb2dDaGFubmVsKFdURkxvZ0NoYW5uZWwqKTsKK3Zv aWQgcGxhdGZvcm1Jbml0aWFsaXplTG9nQ2hhbm5lbHMoKTsKIHZvaWQgaW5pdGlhbGl6ZUxvZ0No YW5uZWxzSWZOZWNlc3Nhcnkodm9pZCk7CiAjaWYgUExBVEZPUk0oR1RLKSB8fCBQTEFURk9STShR VCkKIFdURkxvZ0NoYW5uZWwqIGdldENoYW5uZWxGcm9tTmFtZShjb25zdCBTdHJpbmcmIGNoYW5u ZWxOYW1lKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2d0ay9Mb2dnaW5n R3RrLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL2d0ay9Mb2dnaW5nR3RrLmNwcAppbmRl eCA4NjM3YzFlLi42MTQzZWJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9ybS9n dGsvTG9nZ2luZ0d0ay5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvUGxhdGZvcm0vZ3RrL0xvZ2dp bmdHdGsuY3BwCkBAIC0yNiwzNSArMjYsMzYgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNs dWRlICJMb2dnaW5nLmgiCiAKKyNpZiAhTE9HX0RJU0FCTEVECisKICNpbmNsdWRlIDxnbGliLmg+ CisjaW5jbHVkZSA8c3RyaW5nLmg+CisjaW5jbHVkZSA8d3RmL3RleHQvV1RGU3RyaW5nLmg+CiAK IG5hbWVzcGFjZSBXZWJLaXQgewogCi0jaWYgIUxPR19ESVNBQkxFRAotCi12b2lkIGluaXRpYWxp emVMb2dDaGFubmVsKFdURkxvZ0NoYW5uZWwqIGNoYW5uZWwpCit2b2lkIHBsYXRmb3JtSW5pdGlh bGl6ZUxvZ0NoYW5uZWxzKCkKIHsKLSAgICBzdGF0aWMgVmVjdG9yPFdURkxvZ0NoYW5uZWwqPiBh Y3RpdmF0ZWRDaGFubmVsczsKLSAgICBjb25zdCBzdGF0aWMgU3RyaW5nIGxvZ1ZhbHVlKGdfZ2V0 ZW52KCJXRUJLSVRfREVCVUciKSk7Ci0KLSAgICBpZiAobG9nVmFsdWUuaXNFbXB0eSgpKQorICAg IGNoYXIqIGxvZ0VudiA9IGdldGVudigiV0VCS0lUX0RFQlVHIik7CisgICAgaWYgKCFsb2dFbnYp CiAgICAgICAgIHJldHVybjsKIAotICAgIC8vIEZpbGwgYWN0aXZhdGVkQ2hhbm5lbHMgdmVjdG9y IG9ubHkgb25jZSBiYXNlZCBvbiBuYW1lcyBzZXQgaW4gbG9nVmFsdWUuCi0gICAgaWYgKGFjdGl2 YXRlZENoYW5uZWxzLmlzRW1wdHkoKSkgewotICAgICAgICBzdGF0aWMgVmVjdG9yPFN0cmluZz4g YWN0aXZhdGVkTmFtZXM7Ci0gICAgICAgIGxvZ1ZhbHVlLnNwbGl0KCIgIiwgYWN0aXZhdGVkTmFt ZXMpOwotICAgICAgICBmb3IgKHVuc2lnbmVkIGludCBpID0gMDsgaSA8IGFjdGl2YXRlZE5hbWVz LnNpemUoKTsgaSsrKSB7Ci0gICAgICAgICAgICBXVEZMb2dDaGFubmVsKiBhY3RpdmVDaGFubmVs ID0gZ2V0Q2hhbm5lbEZyb21OYW1lKGFjdGl2YXRlZE5hbWVzW2ldKTsKLSAgICAgICAgICAgIGlm IChhY3RpdmVDaGFubmVsKQotICAgICAgICAgICAgICAgIGFjdGl2YXRlZENoYW5uZWxzLmFwcGVu ZChhY3RpdmVDaGFubmVsKTsKLSAgICAgICAgfQorICAgIC8vIHdlIHNldCB1cCB0aGUgbG9ncyBh bnl3YXkgYmVjYXVzZSBzb21lIG9mIG91ciBsb2dnaW5nLCBzdWNoIGFzCisgICAgLy8gc291cCdz IGlzIGF2YWlsYWJsZSBpbiByZWxlYXNlIGJ1aWxkcworI2lmIGRlZmluZWQoTkRFQlVHKQorICAg IGdfd2FybmluZygiV0VCS0lUX0RFQlVHIGlzIG5vdCBlbXB0eSwgYnV0IHRoaXMgaXMgYSByZWxl YXNlIGJ1aWxkLiBOb3RpY2UgdGhhdCBtYW55IGxvZyBtZXNzYWdlcyB3aWxsIG9ubHkgYXBwZWFy IGluIGEgZGVidWcgYnVpbGQuIik7CisjZW5kaWYKKworICAgIGNoYXIqKiBsb2d2ID0gZ19zdHJz cGxpdChsb2dFbnYsICIgIiwgLTEpOworCisgICAgZm9yIChpbnQgaSA9IDA7IGxvZ3ZbaV07IGkr KykgeworICAgICAgICBpZiAoV1RGTG9nQ2hhbm5lbCogY2hhbm5lbCA9IGdldENoYW5uZWxGcm9t TmFtZShsb2d2W2ldKSkKKyAgICAgICAgICAgIGNoYW5uZWwtPnN0YXRlID0gV1RGTG9nQ2hhbm5l bE9uOwogICAgIH0KIAotICAgIGlmIChhY3RpdmF0ZWRDaGFubmVscy5jb250YWlucyhjaGFubmVs KSkKLSAgICAgICAgY2hhbm5lbC0+c3RhdGUgPSBXVEZMb2dDaGFubmVsT247CisgICAgZ19zdHJm cmVldihsb2d2KTsKIH0KIAotI2VuZGlmIC8vICFMT0dfRElTQUJMRUQKK30gLy8gbmFtZXNwYWNl IFdlYktpdAogCi19CisjZW5kaWYgLy8gIUxPR19ESVNBQkxFRApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvUGxhdGZvcm0vbWFjL0xvZ2dpbmcubWFjLm1tIGIvU291cmNlL1dlYktpdDIvUGxh dGZvcm0vbWFjL0xvZ2dpbmcubWFjLm1tCmluZGV4IDZlNDU4MjguLjRjNzlhNGQgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1BsYXRmb3JtL21hYy9Mb2dnaW5nLm1hYy5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9QbGF0Zm9ybS9tYWMvTG9nZ2luZy5tYWMubW0KQEAgLTQ0LDYgKzQ0LDE2IEBA IHZvaWQgaW5pdGlhbGl6ZUxvZ0NoYW5uZWwoV1RGTG9nQ2hhbm5lbCogY2hhbm5lbCkKICAgICAg ICAgY2hhbm5lbC0+c3RhdGUgPSBXVEZMb2dDaGFubmVsT247CiB9CiAKK3ZvaWQgcGxhdGZvcm1J bml0aWFsaXplTG9nQ2hhbm5lbHMoKQoreworICAgIGluaXRpYWxpemVMb2dDaGFubmVsKCZMb2dD b250ZXh0TWVudSk7CisgICAgaW5pdGlhbGl6ZUxvZ0NoYW5uZWwoJkxvZ0ljb25EYXRhYmFzZSk7 CisgICAgaW5pdGlhbGl6ZUxvZ0NoYW5uZWwoJkxvZ0tleUhhbmRsaW5nKTsKKyAgICBpbml0aWFs aXplTG9nQ2hhbm5lbCgmTG9nU2Vzc2lvblN0YXRlKTsKKyAgICBpbml0aWFsaXplTG9nQ2hhbm5l bCgmTG9nVGV4dElucHV0KTsKKyAgICBpbml0aWFsaXplTG9nQ2hhbm5lbCgmTG9nVmlldyk7Cit9 CisKICNlbmRpZgogCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1BsYXRmb3JtL3F0L0xvZ2dpbmdRdC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9QbGF0Zm9y bS9xdC9Mb2dnaW5nUXQuY3BwCmluZGV4IDNjNDRlMjMuLmU2MWE1NzMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1BsYXRmb3JtL3F0L0xvZ2dpbmdRdC5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvUGxhdGZvcm0vcXQvTG9nZ2luZ1F0LmNwcApAQCAtMjcsMzQgKzI3LDMxIEBACiAjaW5jbHVk ZSAiY29uZmlnLmgiCiAjaW5jbHVkZSAiTG9nZ2luZy5oIgogCisjaWYgIUxPR19ESVNBQkxFRAor CiAjaW5jbHVkZSA8UURlYnVnPgogI2luY2x1ZGUgPFFTdHJpbmdMaXN0PgorI2luY2x1ZGUgPHd0 Zi90ZXh0L1dURlN0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAotI2lmICFMT0dfRElT QUJMRUQKLQotdm9pZCBpbml0aWFsaXplTG9nQ2hhbm5lbChXVEZMb2dDaGFubmVsKiBjaGFubmVs KQordm9pZCBwbGF0Zm9ybUluaXRpYWxpemVMb2dDaGFubmVscygpCiB7Ci0gICAgc3RhdGljIFZl Y3RvcjxXVEZMb2dDaGFubmVsKj4gYWN0aXZhdGVkQ2hhbm5lbHM7Ci0KICAgICBRQnl0ZUFycmF5 IGxvZ2dpbmdFbnYgPSBxZ2V0ZW52KCJRVF9XRUJLSVRfTE9HIik7CiAgICAgaWYgKGxvZ2dpbmdF bnYuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKLSAgICAvLyBGaWxsIGFjdGl2YXRlZENo YW5uZWxzIHZlY3RvciBvbmx5IG9uY2UgYmFzZWQgb24gbmFtZXMgc2V0IGluIGxvZ1ZhbHVlLgot ICAgIGlmIChhY3RpdmF0ZWRDaGFubmVscy5pc0VtcHR5KCkpIHsKLSAgICAgICAgUVN0cmluZ0xp c3QgY2hhbm5lbHMgPSBRU3RyaW5nOjpmcm9tTG9jYWw4Qml0KGxvZ2dpbmdFbnYpLnNwbGl0KFFM YXRpbjFTdHJpbmcoIiwiKSk7Ci0gICAgICAgIGZvciAoaW50IGkgPSAwOyBpIDwgY2hhbm5lbHMu Y291bnQoKTsgaSsrKSB7Ci0gICAgICAgICAgICBpZiAoV1RGTG9nQ2hhbm5lbCogYWN0aXZlQ2hh bm5lbCA9IGdldENoYW5uZWxGcm9tTmFtZShjaGFubmVscy5hdChpKSkpCi0gICAgICAgICAgICAg ICAgYWN0aXZhdGVkQ2hhbm5lbHMuYXBwZW5kKGFjdGl2ZUNoYW5uZWwpOwotICAgICAgICB9Cisj aWYgZGVmaW5lZChOREVCVUcpCisgICAgcVdhcm5pbmcoIlRoaXMgaXMgYSByZWxlYXNlIGJ1aWxk LiBTZXR0aW5nIFFUX1dFQktJVF9MT0cgd2lsbCBoYXZlIG5vIGVmZmVjdC4iKTsKKyNlbHNlCisg ICAgUVN0cmluZ0xpc3QgY2hhbm5lbHMgPSBRU3RyaW5nOjpmcm9tTG9jYWw4Qml0KGxvZ2dpbmdF bnYpLnNwbGl0KFFMYXRpbjFTdHJpbmcoIiwiKSk7CisgICAgZm9yIChpbnQgaSA9IDA7IGkgPCBj aGFubmVscy5jb3VudCgpOyBpKyspIHsKKyAgICAgICAgaWYgKFdURkxvZ0NoYW5uZWwqIGNoYW5u ZWwgPSBnZXRDaGFubmVsRnJvbU5hbWUoY2hhbm5lbHMuYXQoaSkpKQorICAgICAgICAgICAgY2hh bm5lbC0+c3RhdGUgPSBXVEZMb2dDaGFubmVsT247CiAgICAgfQotCi0gICAgaWYgKGFjdGl2YXRl ZENoYW5uZWxzLmNvbnRhaW5zKGNoYW5uZWwpKQotICAgICAgICBjaGFubmVsLT5zdGF0ZSA9IFdU RkxvZ0NoYW5uZWxPbjsKKyNlbmRpZgogfQogCi0jZW5kaWYgLy8gIUxPR19ESVNBQkxFRAorfSAv LyBuYW1lc3BhY2UgV2ViS2l0CiAKLX0KKyNlbmRpZiAvLyAhTE9HX0RJU0FCTEVECg==