96483 2012-09-12 02:21:19 -0700 Web Inspector: Persistent handle referenced from ScriptWrappable is double counted 2012-09-12 02:44:56 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys yurys abarth alph apavlov benjamin bweinstein haraken japhet joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 718086 0 yurys 2012-09-12 02:21:19 -0700 ScriptWrappable::m_wrapper is a pointer to an entry in the array where all such handles are stored. Since the handle is a part of a bigger object we should not count it second time when visiting the pointer in ScriptWrappable. 718093 1 163558 yurys 2012-09-12 02:31:31 -0700 Created attachment 163558 Patch 718095 2 163558 apavlov 2012-09-12 02:35:04 -0700 Comment on attachment 163558 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163558&action=review > Source/WTF/ChangeLog:10 > + used on fields that are pointers to objects which a parts of bigger memory "a parts" -> "are parts"? > Source/WTF/ChangeLog:11 > + blocks(field of another object, element in an array, object allocated in a Missing whitespace between 's' and '(' > Source/WTF/ChangeLog:12 > + memory arena etc.). We don't want to count such objects memory separately objects' > Source/WebCore/ChangeLog:11 > + second time. In order to make the clang plugin that validate memory instrumentation validate -> validates > Source/WebCore/ChangeLog:12 > + happy we report it here as weak pointer(no-op). missing whitespace 718101 3 yurys 2012-09-12 02:37:14 -0700 (In reply to comment #2) > (From update of attachment 163558 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163558&action=review > > > Source/WTF/ChangeLog:10 > > + used on fields that are pointers to objects which a parts of bigger memory > > "a parts" -> "are parts"? > Done. > > Source/WTF/ChangeLog:11 > > + blocks(field of another object, element in an array, object allocated in a > > Missing whitespace between 's' and '(' > Done. > > Source/WTF/ChangeLog:12 > > + memory arena etc.). We don't want to count such objects memory separately > > objects' > Done. > > Source/WebCore/ChangeLog:11 > > + second time. In order to make the clang plugin that validate memory instrumentation > > validate -> validates > Done. > > Source/WebCore/ChangeLog:12 > > + happy we report it here as weak pointer(no-op). > > missing whitespace Done. 718115 4 yurys 2012-09-12 02:44:56 -0700 Committed r128283: <http://trac.webkit.org/changeset/128283> 163558 2012-09-12 02:31:31 -0700 2012-09-12 02:35:04 -0700 Patch bug-96483-20120912133104.patch text/plain 3496 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MjYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGY2YmI4NzE1MzNkZjkxMmY2ZTQ5YTlm NzQ1N2NhMGUzMzI0YmU3MzcuLjk1NDU4ZDU3MDMwODBhZmY0ZWNiOGIxZjY5NTA1N2E4ODg0YmU1 ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTItMDktMTIgIFl1cnkgU2VtaWtoYXRza3kgIDx5 dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUGVyc2lzdGVudCBo YW5kbGUgcmVmZXJlbmNlZCBmcm9tIFNjcmlwdFdyYXBwYWJsZSBpcyBkb3VibGUgY291bnRlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTY0ODMKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9NZW1v cnlJbnN0cnVtZW50YXRpb24uaDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lbW9yeUNsYXNzSW5mbzo6 YWRkV2Vha1BvaW50ZXIpOiB0aGlzIG1ldGhvZCBpcyBleHBlY3RlZCB0byBiZQorICAgICAgICB1 c2VkIG9uIGZpZWxkcyB0aGF0IGFyZSBwb2ludGVycyB0byBvYmplY3RzIHdoaWNoIGEgcGFydHMg b2YgYmlnZ2VyIG1lbW9yeQorICAgICAgICBibG9ja3MoZmllbGQgb2YgYW5vdGhlciBvYmplY3Qs IGVsZW1lbnQgaW4gYW4gYXJyYXksIG9iamVjdCBhbGxvY2F0ZWQgaW4gYQorICAgICAgICBtZW1v cnkgYXJlbmEgZXRjLikuIFdlIGRvbid0IHdhbnQgdG8gY291bnQgc3VjaCBvYmplY3RzIG1lbW9y eSBzZXBhcmF0ZWx5CisgICAgICAgIGZyb20gdGhlaXIgb3duZXJzIGJ1dCBpbiBvcmRlciB0byBi ZSBhYmxlIHRvIHZhbGlkYXRlIHRoZSBtZW1vcnkgaW5zdHJ1bWVudGF0aW9uCisgICAgICAgIHdp dGggY2xhbmcgcGx1Z2luIHdlIG5lZWQgdG8gbWFrZSBzdXJlIGFsbCBmaWVsZHMgaW4gaW5zdHJ1 bWVudGVkIG9iamVjdHMKKyAgICAgICAgYXJlIHJlcG9ydGVkLgorICAgICAgICAoTWVtb3J5Q2xh c3NJbmZvKToKKwogMjAxMi0wOS0xMSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNv bT4KIAogICAgICAgICBCdWlsZCBmaXhlZCBmb3IgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFu Z2VzZXQvMTI4MjQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTM3NTg0MjRhYWQxMTU4YmY3Y2Q4ZWYwNTZmOGJj NjczNDVkMmZmOS4uNGM3ZGU3OWNkYTJlOTFjYzhmM2Q1NTQ4ZGM5NDc2ZGJjZWJlNjVjOSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTEyICBZdXJ5IFNlbWlraGF0c2t5ICA8 eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFBlcnNpc3RlbnQg aGFuZGxlIHJlZmVyZW5jZWQgZnJvbSBTY3JpcHRXcmFwcGFibGUgaXMgZG91YmxlIGNvdW50ZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NDgzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBiaW5kaW5n cy92OC9TY3JpcHRXcmFwcGFibGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdFdyYXBwYWJs ZTo6cmVwb3J0TWVtb3J5VXNhZ2UpOiB0aGUgaGFuZGxlIGlzIGEgcGFydCBvZiBhbgorICAgICAg ICBhcnJheSB3aGVyZSBhbGwgc3VjaCBoYW5kbGVzIGFyZSBhbGxvY2F0ZWQgYW5kIHNob3VsZCBu b3QgYmUgY291bnRlZCBoZXJlCisgICAgICAgIHNlY29uZCB0aW1lLiBJbiBvcmRlciB0byBtYWtl IHRoZSBjbGFuZyBwbHVnaW4gdGhhdCB2YWxpZGF0ZSBtZW1vcnkgaW5zdHJ1bWVudGF0aW9uCisg ICAgICAgIGhhcHB5IHdlIHJlcG9ydCBpdCBoZXJlIGFzIHdlYWsgcG9pbnRlcihuby1vcCkuCisK IDIwMTItMDktMTEgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFtDTUFLRV0gU3VwcGx5IGZlYXR1cmUgZGVmaW5lcyB0byBDb2RlR2VuZXJhdG9yVGVzdFJ1 bm5lci4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL01lbW9yeUluc3RydW1lbnRhdGlvbi5o IGIvU291cmNlL1dURi93dGYvTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmgKaW5kZXggYWM2N2ZmZmY2 OGY5OWRhYTUyYTExOTA1Y2NjY2VlNWI4ZjA4NmU2Ny4uNTkyNmYyM2E0ZWIxNmZiMTVlMjIwNTcw OGE3YmEwNzNhNjhlOTJjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvTWVtb3J5SW5zdHJ1 bWVudGF0aW9uLmgKKysrIGIvU291cmNlL1dURi93dGYvTWVtb3J5SW5zdHJ1bWVudGF0aW9uLmgK QEAgLTIyMiw2ICsyMjIsOCBAQCBwdWJsaWM6CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVmVjdG9y VHlwZT4gdm9pZCBhZGRWZWN0b3JQdHIoY29uc3QgVmVjdG9yVHlwZSogY29uc3QgdmVjdG9yKSB7 IG1fbWVtb3J5SW5zdHJ1bWVudGF0aW9uLT5hZGRWZWN0b3IoKnZlY3RvciwgbV9vYmplY3RUeXBl LCBmYWxzZSk7IH0KICAgICB2b2lkIGFkZFJhd0J1ZmZlcihjb25zdCB2b2lkKiBjb25zdCYgYnVm ZmVyLCBzaXplX3Qgc2l6ZSkgeyBtX21lbW9yeUluc3RydW1lbnRhdGlvbi0+YWRkUmF3QnVmZmVy KGJ1ZmZlciwgbV9vYmplY3RUeXBlLCBzaXplKTsgfQogCisgICAgdm9pZCBhZGRXZWFrUG9pbnRl cih2b2lkKikgeyB9CisKIHByaXZhdGU6CiAgICAgTWVtb3J5T2JqZWN0SW5mbyogbV9tZW1vcnlP YmplY3RJbmZvOwogICAgIE1lbW9yeUluc3RydW1lbnRhdGlvbiogbV9tZW1vcnlJbnN0cnVtZW50 YXRpb247CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRXcmFw cGFibGUuaCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdFdyYXBwYWJsZS5oCmlu ZGV4IGMwMjAxODA2Y2M1YjQ5ODM2OGY1NmI2ZGVkYjI5YWM3MGZjYTdhZjQuLjI5MTVjYzdjOGU5 MzIyNzQ2ZDkwMzMzMDhkZmNkNGMyMDMxNzNlYjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1NjcmlwdFdyYXBwYWJsZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1NjcmlwdFdyYXBwYWJsZS5oCkBAIC01Niw3ICs1Niw3IEBAIHB1YmxpYzoKICAgICB2 b2lkIHJlcG9ydE1lbW9yeVVzYWdlKE1lbW9yeU9iamVjdEluZm8qIG1lbW9yeU9iamVjdEluZm8p IGNvbnN0CiAgICAgewogICAgICAgICBNZW1vcnlDbGFzc0luZm8gaW5mbyhtZW1vcnlPYmplY3RJ bmZvLCB0aGlzLCBXZWJDb3JlTWVtb3J5VHlwZXM6OkRPTSk7Ci0gICAgICAgIGluZm8uYWRkTWVt YmVyKG1fd3JhcHBlcik7CisgICAgICAgIGluZm8uYWRkV2Vha1BvaW50ZXIobV93cmFwcGVyKTsK ICAgICB9CiAKIHByaXZhdGU6Cg==