96479 2012-09-12 01:39:11 -0700 [Qt] REGRESSION(r128174,r128179): It broke the --minimal --no-webkit2 build 2012-09-12 04:49:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt, QtTriaged P1 Blocker --- 96491 1 ossy hausmann abecsi hausmann ossy vestbo webkit.review.bot oldest_to_newest 718053 0 ossy 2012-09-12 01:39:11 -0700 r128174 broke the minimal build and then it seemed r128179 fixed it, but unfortunately it was't true. After a clean build it is still broken. :( --------------------------------------------------------------------------------------------------------------------- generated/JSDOMWindow.cpp: In function ‘JSC::EncodedJSValue WebCore::jsDOMWindowPrototypeFunctionWebkitRequestAnimationFrame(JSC::ExecState*)’: generated/JSDOMWindow.cpp:9610: error: ‘RequestAnimationFrameCallback’ was not declared in this scope generated/JSDOMWindow.cpp:9610: error: template argument 1 is invalid generated/JSDOMWindow.cpp:9610: error: invalid type in declaration before ‘=’ token generated/JSDOMWindow.cpp:9610: error: ‘JSRequestAnimationFrameCallback’ has not been declared generated/JSDOMWindow.cpp:9612: error: ‘class WebCore::DOMWindow’ has no member named ‘webkitRequestAnimationFrame’ generated/JSDOMWindow.cpp: In function ‘JSC::EncodedJSValue WebCore::jsDOMWindowPrototypeFunctionWebkitCancelAnimationFrame(JSC::ExecState*)’: generated/JSDOMWindow.cpp:9630: error: ‘class WebCore::DOMWindow’ has no member named ‘webkitCancelAnimationFrame’ generated/JSDOMWindow.cpp: In function ‘JSC::EncodedJSValue WebCore::jsDOMWindowPrototypeFunctionWebkitCancelRequestAnimationFrame(JSC::ExecState*)’: generated/JSDOMWindow.cpp:9648: error: ‘class WebCore::DOMWindow’ has no member named ‘webkitCancelRequestAnimationFrame’ make[3]: *** [obj/release/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/Source/WebCore/generated/JSDOMWindow.o] Error 1 make[3]: *** Waiting for unfinished jobs.... Could you check it, please? 718159 1 hausmann 2012-09-12 03:53:48 -0700 Oops, let me change the title back. The fix requires multiple changes, the RAF=0 part being only _one_ aspect. 718177 2 163581 hausmann 2012-09-12 04:33:21 -0700 Created attachment 163581 Patch 718182 3 163581 ossy 2012-09-12 04:37:17 -0700 Comment on attachment 163581 Patch Will it fix --minimal build for WebKit2? (https://bugs.webkit.org/show_bug.cgi?id=93258) 718183 4 163581 hausmann 2012-09-12 04:37:36 -0700 Comment on attachment 163581 Patch GRr, wrong bug 718196 5 ossy 2012-09-12 04:47:34 -0700 Our minimal bot (--minimal --no-webkit2 build) is happy now, shouldn't we track fixing --minimal WK2 build in https://bugs.webkit.org/show_bug.cgi?id=93258? 718197 6 hausmann 2012-09-12 04:48:35 -0700 (In reply to comment #5) > Our minimal bot (--minimal --no-webkit2 build) is happy now, shouldn't we track > fixing --minimal WK2 build in https://bugs.webkit.org/show_bug.cgi?id=93258? You're right. I'll re-arrange the dependencies :) 163581 2012-09-12 04:33:21 -0700 2012-09-12 04:37:36 -0700 Patch bug-96479-20120912133507.patch text/plain 1387 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4Mjg1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMTg2ZjIwYTFhZWI4NTZlMjg1YmFiMGJjMzc0MWQwYjZk NTRmYjY2Ny4uNjgwZmJkOGIwYTMwZjA2ZGQwNDQ0OGVkY2RlZDFlMTRmMGFhYWQ5OSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA5LTEyICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNv bT4KKworICAgICAgICBbUXRdIEZpeCB0aGUgYnVpbGQgd2l0aCBFTkFCTEVfTkVUU0NBUEVfUExV R0lOX0FQST0wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NjQ3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFdLMidzIEVOQUJMRV9QTFVHSU5fUFJPQ0VTUyB1c2VzIHRoZSBOUEFQSSBmdW5jdGlvbnMgdW5j b25kaXRpb25hbGx5LCBzbyBkaXNhYmxlIHRoZQorICAgICAgICBwbHVnaW4gcHJvY2VzcyBmZWF0 dXJlIGlmIHdlIGRvbid0IGhhdmUgTlBBUEkuCisKKyAgICAgICAgKiBxbWFrZS9ta3NwZWNzL2Zl YXR1cmVzL2ZlYXR1cmVzLnByZjoKKwogMjAxMi0wOS0xMiAgQ2hyaXN0b3BoZSBEdW1leiAgPGNo cmlzdG9waGUuZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFtXSzJdW1dLVFJdIFRlc3RSdW5u ZXIgbmVlZHMgdG8gaW1wbGVtZW50IGR1bXBBcHBsaWNhdGlvbkNhY2hlRGVsZWdhdGVDYWxsYmFj a3MKZGlmZiAtLWdpdCBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZmVhdHVyZXMucHJm IGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0dXJlcy5wcmYKaW5kZXggOWM5ZmRl MTIzMTBmNjRhZTM4MTc2MzMxNzliM2M3Y2I1MGU5ODQ1Mi4uMjIzOTk4Y2QxMzFhYTViNWE1MDFm YTZiNGEwZjAwODYxNTBlOWYwZiAxMDA2NDQKLS0tIGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0 dXJlcy9mZWF0dXJlcy5wcmYKKysrIGIvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9mZWF0 dXJlcy5wcmYKQEAgLTE0OSw1ICsxNDksOCBAQCBkZWZpbmVUZXN0KHNhbnRpemVGZWF0dXJlcykg ewogICAgICMgRnVsbHNjcmVlbiBBUEkgcmVsaWVzIG9uIFdlYktpdDIKICAgICAhYnVpbGQ/KHdl YmtpdDIpOiBXRUJLSVRfQ09ORklHIC09IGZ1bGxzY3JlZW5fYXBpCiAKKyAgICAjIFdLMidzIHBs dWdpbiBwcm9jZXNzIGNvZGUgcmVxdWlyZXMgTlBBUEkKKyAgICAhZW5hYmxlPyhuZXRzY2FwZV9w bHVnaW5fYXBpKTogV0VCS0lUX0NPTkZJRyAtPSBwbHVnaW5fcHJvY2VzcworCiAgICAgZXhwb3J0 KFdFQktJVF9DT05GSUcpCiB9Cg==