96464 2012-09-11 20:10:47 -0700 IncrementalSweeper should not sweep/free Zapped blocks 2012-09-12 13:56:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg ggaren jberlin webkit.review.bot oldest_to_newest 717846 0 mhahnenberg 2012-09-11 20:10:47 -0700 This is not beneficial in terms of performance, and since don't take zapped-ness into account when determining whether or not a block is empty to free it, it unintentionally causes pre-mature freeing of blocks. 717848 1 mhahnenberg 2012-09-11 20:12:56 -0700 This was a regression introduced in http://trac.webkit.org/changeset/121316. 717852 2 163505 mhahnenberg 2012-09-11 20:16:31 -0700 Created attachment 163505 Patch 717894 3 163505 webkit.review.bot 2012-09-11 21:25:54 -0700 Comment on attachment 163505 Patch Clearing flags on attachment: 163505 Committed r128262: <http://trac.webkit.org/changeset/128262> 717895 4 webkit.review.bot 2012-09-11 21:25:57 -0700 All reviewed patches have been landed. Closing bug. 718689 5 ap 2012-09-12 13:56:33 -0700 *** Bug 95516 has been marked as a duplicate of this bug. *** 163505 2012-09-11 20:16:31 -0700 2012-09-11 21:25:53 -0700 Patch bug-96464-20120911201606.patch text/plain 1726 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI4MjU3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBA CisyMDEyLTA5LTExICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgSW5jcmVtZW50YWxTd2VlcGVyIHNob3VsZCBub3Qgc3dlZXAvZnJlZSBaYXBwZWQg YmxvY2tzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05 NjQ2NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgaXMgbm90IGJlbmVmaWNpYWwgaW4gdGVybXMgb2YgcGVyZm9ybWFuY2UgYmVjYXVzZSB0aGVy ZSBpc24ndCBhbnkgd2F5IGEgYmxvY2sgY2FuIGVtZXJnZQorICAgICAgICBpbiB0aGUgWmFwcGVk IHN0YXRlIGZyb20gYSBjYWxsIHRvIEhlYXA6OmNvbGxlY3QoKSB1bmxlc3Mgd2UgcnVuIGFuIGVh Z2VyIHN3ZWVwIG9uIGl0LCBpbiB3aGljaCAKKyAgICAgICAgY2FzZSB3ZSd2ZSBhbHJlYWR5IHJ1 biBhbGwgdGhlIGRlc3RydWN0b3JzIHdlIHBvc3NpYmx5IGNhbi4gVGhpcyBhbHNvIGNhdXNlcyBi dWdzIHNpbmNlIHdlIGRvbid0IAorICAgICAgICB0YWtlIHphcHBlZC1uZXNzIGludG8gYWNjb3Vu dCB3aGVuIGRldGVybWluaW5nIHdoZXRoZXIgb3Igbm90IGEgYmxvY2sgaXMgZW1wdHkgdG8gZnJl ZSBpdC4gVGhlIAorICAgICAgICBpbmNyZW1lbnRhbCBzd2VlcGVyIGNhbiB0aGVuIGFjY2lkZW50 YWxseSBmcmVlIGJsb2NrcyB0aGF0IGl0IHRoaW5rcyBhcmUgZW1wdHkgYnV0IGFyZSBpbiBmYWN0 IAorICAgICAgICB6YXBwZWQgd2l0aCBzdGlsbC1saXZlIG9iamVjdHMgaW4gdGhlbS4KKworICAg ICAgICAqIGhlYXAvTWFya2VkQmxvY2suaDoKKyAgICAgICAgKEpTQzo6TWFya2VkQmxvY2s6Om5l ZWRzU3dlZXBpbmcpOiBJdCBpcyBvbmx5IHZhbGlkIHRvIHN3ZWVwIGEgYmxvY2sgaWYgaXQgaXMg aW4gdGhlIE1hcmtlZCBzdGF0ZS4KKwogMjAxMi0wOS0xMSAgTWljaGFlbCBTYWJvZmYgIDxtc2Fi b2ZmQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXhlZCBmb3IgaHR0cDovL3RyYWMud2Vi a2l0Lm9yZy9jaGFuZ2VzZXQvMTI4MjQzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVh cC9NYXJrZWRCbG9jay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFw L01hcmtlZEJsb2NrLmgJKHJldmlzaW9uIDEyODE5OSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL01hcmtlZEJsb2NrLmgJKHdvcmtpbmcgY29weSkKQEAgLTQzMSw3ICs0MzEsNyBAQCBu YW1lc3BhY2UgSlNDIHsKIAogICAgIGlubGluZSBib29sIE1hcmtlZEJsb2NrOjpuZWVkc1N3ZWVw aW5nKCkKICAgICB7Ci0gICAgICAgIHJldHVybiBtX3N0YXRlID09IE1hcmtlZCB8fCBtX3N0YXRl ID09IFphcHBlZDsKKyAgICAgICAgcmV0dXJuIG1fc3RhdGUgPT0gTWFya2VkOwogICAgIH0KIAog I2lmIEVOQUJMRShHR0MpCg==