96461 2012-09-11 19:51:12 -0700 Fix build break with LLINT on 32bit machine after r128219 2012-09-11 20:36:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96417 1 ryuan.choi ryuan.choi fpizlo hojong.han oliver webkit.review.bot oldest_to_newest 717838 0 ryuan.choi 2012-09-11 19:51:12 -0700 I am not sure because I don't know javascript world. But I think that .opGetArrayLengthSlot looks typo. 717839 1 163502 ryuan.choi 2012-09-11 19:54:01 -0700 Created attachment 163502 Patch 717844 2 ryuan.choi 2012-09-11 20:04:59 -0700 This it to fix build break on 32bit EFL built bot. Below is error message in http://build.webkit.org/builders/EFL%20Linux%2032-bit%20Release%20%28Build%29/builds/6487/steps/compile-webkit/logs/stdio offlineasm: Nothing changed. [ 4%] Generating ../../DerivedSources/JavaScriptCore/LLIntAssembly.h offlineasm: Parsing /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/Source/JavaScriptCore/llint/LowLevelInterpreter.asm and /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/WebKitBuild/Release/bin/LLIntOffsetsExtractor and creating assembly file /mnt/buildbot/efl-linux-slave-3/efl-linux-32-release/build/WebKitBuild/Release/DerivedSources/JavaScriptCore/LLIntAssembly.h. offlineasm: Nothing changed. [ 10%] Built target javascriptcore_efl Linking CXX executable ../../../bin/jsc ../../../lib/libjavascriptcore_efl.so.0.1.0: undefined reference to `.L_offlineasm_opGetArrayLengthSlot' collect2: ld returned 1 exit status make[2]: *** [bin/jsc] Error 1 make[1]: *** [Source/JavaScriptCore/shell/CMakeFiles/jsc.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... [ 84%] Built target webcore_efl make: *** [all] Error 2 program finished with exit code 2 elapsedTime=53.367220 717860 3 hojong.han 2012-09-11 20:21:51 -0700 I think so. It should be corrected to opGetArrayLengthSlow 717871 4 163502 webkit.review.bot 2012-09-11 20:36:27 -0700 Comment on attachment 163502 Patch Clearing flags on attachment: 163502 Committed r128259: <http://trac.webkit.org/changeset/128259> 717872 5 webkit.review.bot 2012-09-11 20:36:31 -0700 All reviewed patches have been landed. Closing bug. 163502 2012-09-11 19:54:01 -0700 2012-09-11 20:36:27 -0700 Patch bug-96461-20120912115335.patch text/plain 1414 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MjMyCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAy NTA3NDc2ZmMxMTdjMTNkZjYzY2JhNzQyMjI0ZmUyMWQ1MzJjYjZiLi42NjYxOGY0NzJmZWU3NWI5 MTAxMzIxNzVkMWNmYmZkNjJhNWRmNDg5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxMi0wOS0xMSAgUnl1YW4gQ2hvaSAgPHJ5dWFuLmNob2lAc2Ftc3VuZy5j b20+CisKKyAgICAgICAgRml4IGJ1aWxkIGJyZWFrIHdpdGggTExJTlQgb24gMzJiaXQgbWFjaGlu ZSBhZnRlciByMTI4MjE5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NjQ2MQorCisgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgorCisgICAgICAg ICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlcjMyXzY0LmFzbTogRml4ZWQgdHlwby4KKwogMjAx Mi0wOS0xMSAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIExMSW50 IHNob3VsZCBvcHRpbWl6ZSBhbmQgcHJvZmlsZSBhcnJheSBsZW5ndGggYWNjZXNzZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyMzJf NjQuYXNtIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIz Ml82NC5hc20KaW5kZXggNWJmZjhhNGY5MDlhOWFlNjQ0NWNlZmZmYWQ0M2Q3YmE1ZjNlMmQ0Ni4u YThkYWIxZmQ1NmU3MmEwZGE0YjM5N2QyZmQ3OWU5NzMxY2NiZjllYSAxMDA2NDQKLS0tIGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5hc20KKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2xsaW50L0xvd0xldmVsSW50ZXJwcmV0ZXIzMl82NC5h c20KQEAgLTExNzIsNyArMTE3Miw3IEBAIF9sbGludF9vcF9nZXRfYXJyYXlfbGVuZ3RoOgogICAg IHRyYWNlRXhlY3V0aW9uKCkKICAgICBsb2FkaSA4W1BDXSwgdDAKICAgICBsb2FkcCAxNltQQ10s IHQxCi0gICAgbG9hZENvbnN0YW50T3JWYXJpYWJsZVBheWxvYWQodDAsIENlbGxUYWcsIHQzLCAu b3BHZXRBcnJheUxlbmd0aFNsb3QpCisgICAgbG9hZENvbnN0YW50T3JWYXJpYWJsZVBheWxvYWQo dDAsIENlbGxUYWcsIHQzLCAub3BHZXRBcnJheUxlbmd0aFNsb3cpCiAgICAgbG9hZHAgSlNDZWxs OjptX3N0cnVjdHVyZVt0M10sIHQyCiAgICAgaWYgVkFMVUVfUFJPRklMRVIKICAgICAgICAgc3Rv cmVwIHQyLCBBcnJheVByb2ZpbGU6Om1fbGFzdFNlZW5TdHJ1Y3R1cmVbdDFdCg==