96439 2012-09-11 15:53:45 -0700 jsStringWithCache shouldn't call StringImpl::characters() for single character strings 2012-09-11 17:26:07 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff webkit.review.bot oldest_to_newest 717649 0 msaboff 2012-09-11 15:53:45 -0700 This is to fix two FIXME's in jsStringWithCache. // FIXME: we shouldn't invoke StringImpl::characters(). // FIXME: why not just return a SmallStrings when possible? 717654 1 163464 msaboff 2012-09-11 15:58:56 -0700 Created attachment 163464 Patch 717676 2 163464 ggaren 2012-09-11 16:07:53 -0700 Comment on attachment 163464 Patch r=me 717732 3 163464 webkit.review.bot 2012-09-11 16:53:24 -0700 Comment on attachment 163464 Patch Clearing flags on attachment: 163464 Committed r128244: <http://trac.webkit.org/changeset/128244> 717733 4 webkit.review.bot 2012-09-11 16:53:27 -0700 All reviewed patches have been landed. Closing bug. 717753 5 msaboff 2012-09-11 17:26:07 -0700 Additional commit of r128247: <http://trac.webkit.org/changeset/128247> 163464 2012-09-11 15:58:56 -0700 2012-09-11 16:53:24 -0700 Patch 96439.patch text/plain 2071 msaboff SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODIzMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTExICBNaWNoYWVs IFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIGpzU3RyaW5nV2l0aENhY2hl IHNob3VsZG4ndCBjYWxsIFN0cmluZ0ltcGw6OmNoYXJhY3RlcnMoKSBmb3Igc2luZ2xlIGNoYXJh Y3RlciBzdHJpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NjQzOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFJlcGxhY2VkIFN0cmluZ0ltcGwtPmNoYXJhY3RlcnMoKVswXSB3aXRoIG9wZXJhdG9yW10g YWNjZXNzIHdoaWNoIGlzIGNoYXJhY3RlciBzaXplIGF3YXJlLgorICAgICAgICBBbHNvIGZpeGVk IHRoZSBvdGhlciBGSVhNRSBzbyB3ZSBub3cgdXNlIFNtYWxsU3RyaW5ncyB0byByZXR1bnIgdGhl IHNpbmdsZSBjaGFyYWN0ZXIgc3RyaW5nLgorCisgICAgICAgIE5vIGZ1bmN0aW9uYWwgY2hhbmdl LCBzbyBubyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcu aDoKKyAgICAgICAgKFdlYkNvcmU6OmpzU3RyaW5nV2l0aENhY2hlKToKKwogMjAxMi0wOS0xMSAg QXJuYXVkIFJlbmV2aWVyICA8YS5yZW5ldmllckBzaXNhLnNhbXN1bmcuY29tPgogCiAgICAgICAg IFtHdGtdIGFsbG93IGJ1aWxkaW5nIHdpdGggY3NzLXNoYWRlcnMKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL2pzL0pTRE9NQmluZGluZy5oCShyZXZpc2lvbiAxMjc5NzUpCisrKyBTb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTUJpbmRpbmcuaAkod29ya2luZyBjb3B5KQpAQCAt NDEyLDEwICs0MTIsMTMgQEAgZW51bSBQYXJhbWV0ZXJEZWZhdWx0UG9saWN5IHsKICAgICAgICAg aWYgKCFzdHJpbmdJbXBsIHx8ICFzdHJpbmdJbXBsLT5sZW5ndGgoKSkKICAgICAgICAgICAgIHJl dHVybiBqc0VtcHR5U3RyaW5nKGV4ZWMpOwogCi0gICAgICAgIC8vIEZJWE1FOiB3ZSBzaG91bGRu J3QgaW52b2tlIFN0cmluZ0ltcGw6OmNoYXJhY3RlcnMoKS4KLSAgICAgICAgLy8gRklYTUU6IHdo eSBub3QganVzdCByZXR1cm4gYSBTbWFsbFN0cmluZ3Mgd2hlbiBwb3NzaWJsZT8KLSAgICAgICAg aWYgKHN0cmluZ0ltcGwtPmxlbmd0aCgpID09IDEgJiYgc3RyaW5nSW1wbC0+Y2hhcmFjdGVycygp WzBdIDw9IDB4RkYpCi0gICAgICAgICAgICByZXR1cm4gSlNDOjpqc1N0cmluZyhleGVjLCBzKTsK KyAgICAgICAgaWYgKHN0cmluZ0ltcGwtPmxlbmd0aCgpID09IDEpIHsKKyAgICAgICAgICAgIFVD aGFyIHNpbmdsZUNoYXJhY3RlciA9ICgqc3RyaW5nSW1wbClbMF07CisgICAgICAgICAgICBpZiAo c2luZ2xlQ2hhcmFjdGVyIDw9IEpTQzo6bWF4U2luZ2xlQ2hhcmFjdGVyU3RyaW5nKSB7CisgICAg ICAgICAgICAgICAgSlNDOjpKU0dsb2JhbERhdGEqIGdsb2JhbERhdGEgPSAmZXhlYy0+Z2xvYmFs RGF0YSgpOworICAgICAgICAgICAgICAgIHJldHVybiBnbG9iYWxEYXRhLT5zbWFsbFN0cmluZ3Mu c2luZ2xlQ2hhcmFjdGVyU3RyaW5nKGdsb2JhbERhdGEsIHN0YXRpY19jYXN0PHVuc2lnbmVkIGNo YXI+KHNpbmdsZUNoYXJhY3RlcikpOworICAgICAgICAgICAgfQorICAgICAgICB9CiAKICAgICAg ICAgSlNTdHJpbmdDYWNoZSYgc3RyaW5nQ2FjaGUgPSBjdXJyZW50V29ybGQoZXhlYyktPm1fc3Ry aW5nQ2FjaGU7CiAgICAgICAgIGlmIChKU0M6OkpTU3RyaW5nKiBzdHJpbmcgPSBzdHJpbmdDYWNo ZS5nZXQoc3RyaW5nSW1wbCkpCg==